Noel Grandin
c2ac8569de
convert SBSTRM constants to scoped enum
...
Change-Id: I478a9c7eca6509baf3e9a3dd3ce3dd8f3060f842
2015-07-29 12:10:18 +02:00
Noel Grandin
b1c25a0d8f
inline "old" SbERR constants
...
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
2015-07-28 08:35:34 +02:00
Noel Grandin
01075a7274
inline the "old" SbxErr constants
...
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855
convert SbxFlagsBits to scoped enum
...
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-28 08:35:34 +02:00
Noel Grandin
b4ee16da65
com::sun::star->css in basic
...
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 09:39:36 +00:00
Miklos Vajna
2e7fe50874
error: 'pGen' was not declared in this scope
...
Change-Id: I6ebf100be3a90b315491e2735da9c82e5901fc59
2015-07-02 10:24:59 +02:00
Arnaud Versini
fabe329412
BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr.
...
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a
Reviewed-on: https://gerrit.libreoffice.org/16551
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-07-02 07:43:03 +00:00
Andrea Gelmini
5d5dc059cb
Fix typos
...
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:35:58 +00:00
Andrea Gelmini
69c88a32aa
Fix typos
...
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:28:31 +00:00
Stephan Bergmann
687ab37853
loplugin:stringconstant: Flag more inefficiencies
...
Change-Id: Ie6ca3065ee60fb2ad75f3bab53059046a981da8d
2015-06-25 12:38:33 +02:00
Andrea Gelmini
ca9de688c2
Fix typos
...
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:10:51 +00:00
Arnaud Versini
0766db041e
BASIC: Don't use SbiStringPool to pass SbiParser.
...
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9
Reviewed-on: https://gerrit.libreoffice.org/16137
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-06-13 11:53:03 +00:00
Stephan Bergmann
761e0ae0a7
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-06-08 16:23:17 +02:00
Noel Grandin
623445aa0e
convert PropertyMode to scoped enum
...
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
2015-06-04 08:30:24 +02:00
Noel Grandin
afcf1ecee1
loplugin:loopvartoosmall
...
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
Arnaud Versini
563a3935b8
BASIC: Remove BasicCharClass::IsLetterTab
...
Change-Id: Ib6a13cb7a5725d451c0f8d64c2c543a8a9ec2ad0
Reviewed-on: https://gerrit.libreoffice.org/15876
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-05-26 08:46:32 +00:00
Noel Grandin
539ba642d7
remove unnecessary header file
...
Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
2015-05-17 10:08:59 +02:00
Arnaud Versini
7ff58e1a89
Basic: Doesn't allow non ASCII characters in numeric literals
...
Change-Id: I8b7755dbea56953a04cd7687181ec246fc680c43
Reviewed-on: https://gerrit.libreoffice.org/14691
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-05-12 09:25:18 +00:00
Julien Nabet
0f79a5ff07
tdf#84435: Mod operator does not deal with decimals as described in help
...
Change-Id: I8dbfdf4bb2eceac0b5afbddd3f35e1dcde2db68b
Reviewed-on: https://gerrit.libreoffice.org/14611
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2015-04-30 14:27:06 +00:00
Stephan Bergmann
ed83ba34a5
loplugin:simplifybool
...
Change-Id: I6e181bc4b144c2559ede99d3bae0496cf546415c
2015-04-24 12:36:18 +02:00
Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Noel Grandin
ee094bd46f
loplugin:staticmethods
...
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-04-13 09:37:12 +02:00
Stephan Bergmann
a52cf476e7
Clean up template-parameter-dependent C-style casts
...
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-03-29 15:13:45 +02:00
Stephan Bergmann
0511c86791
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: If774a3b4e2e993d26dd9b5777a55665a330b2abe
2015-03-26 15:33:28 +01:00
Arnaud Versini
8414d8434b
Basic: scanner should'nt use 0xFF mask on characters
...
Change-Id: I2fd3f70c3d8e411430f84c7383da7ab8700513bd
Reviewed-on: https://gerrit.libreoffice.org/14682
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-03-25 13:41:25 +00:00
Michaël Lefèvre
c3cd100556
CppCheck cleanlyness : reduce variable's scope
...
Change-Id: I5bd18b1a93f7197121eb42f6b82d2d8d87e7671f
Reviewed-on: https://gerrit.libreoffice.org/14843
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-03-12 22:28:38 +00:00
Julien Nabet
5f6fcb4e7c
Typos
...
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-08 16:45:30 +01:00
Noel Grandin
e9beb26470
convert SBI_ constants to enum class
...
Change-Id: I65e706f4e1adfe242808293d9514c9db8d22cc12
2015-03-02 08:59:18 +02:00
Arnaud Versini
78f25d565e
Basic : Partially rewrite hex and octal constant reading.
...
Change-Id: I42f72e7b1ca897aba71950841f90b501cf3b6dc2
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2015-02-09 13:18:31 +01:00
Arnaud Versini
96520ae764
Basic : Small OString usage simplification
...
Change-Id: I6d6032b3075e98abb38859207e4a25e1a2e13e98
Reviewed-on: https://gerrit.libreoffice.org/14351
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-02-08 06:54:45 +00:00
Arnaud Versini
4b9a9ce8a0
Use rtl/character.hxx in basic module when possible
...
Change-Id: I1296541ac1a6a65a613818a1264c2b7482915e64
Reviewed-on: https://gerrit.libreoffice.org/14170
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-01-31 09:48:27 +00:00
Caolán McNamara
818c2021d1
coverity#1266457 Identical code for different branches
...
Change-Id: I809ad43ad4541e4dcd5c245b469d30605f9f0d27
2015-01-25 20:46:39 +00:00
Stephan Bergmann
4130c64355
Some more loplugin:cstylecast: basic
...
Change-Id: Ib22bc7408d333a7080fa44c9c3ac9535ccf00752
2015-01-20 09:06:45 +01:00
Stephan Bergmann
2e3655bb51
loplugin:cstylecast
...
Change-Id: I86aaad9f38ad63121805fa3dc05b3a8a33428ef7
2015-01-09 10:54:45 +01:00
Tsutomu Uchino
a272f5b7b3
Resolves: #i63614# fix strange type mismatch when Iif function is used
...
Second or later compilation uses value type returned by previous execution of code.
Use the defined type as return value of the runtime function of Basic always.
(cherry picked from commit 7470c682e136a4a89c1e9474bbc79b2d61f31048)
Conflicts:
basic/inc/basic/sbxmeth.hxx
basic/inc/basic/sbxobj.hxx
basic/source/runtime/stdobj.cxx
basic/source/sbx/sbxobj.cxx
Change-Id: I3064e8403286a9c1401ef658bf139bedeae11f17
2015-01-09 09:24:44 +00:00
Noel Grandin
7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
Stephan Bergmann
39ddeb53c0
basic: Use appropriate OUString functions on string constants
...
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
2014-12-18 14:12:23 +01:00
Michael Weghorn
93124f7710
reduce scope of local variables
...
This eliminates some of the warnings from Cppcheck report of
2014-11-29.
Change-Id: Ic4bf3bd8f5982d2ea2f25a28c0dd61084c59af11
Reviewed-on: https://gerrit.libreoffice.org/13331
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-12-06 14:12:31 +00:00
Caolán McNamara
6b709b27b3
coverity#735399 Logically dead code
...
we can only enter the bAssumeExprLParenMode controlled block once
because the block sets bAssumeExprLParenMode to false
bAssumeExprLParenMode is only true if the first token read in the
method is LPAREN
so we can only enter this block if the current token is LPAREN and
its the first token processed, so the token can't be BYVAL
Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d
2014-11-17 14:53:24 +00:00
Michael Stahl
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Caolán McNamara
9dacd849b6
this is for detecting the type of a variable based on its name
...
which means legal input is any character which a variable can
start with
Change-Id: I0c2d13a92ba374f8020e86e90e8e5f18ce8a9c90
2014-11-14 14:31:24 +00:00
Andrea Gelmini
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
Caolán McNamara
bec2803362
coverity#704558 Dereference after null check
...
Change-Id: I6fe44d8926acd185bb6bc671fb7df8ae935998c1
2014-10-24 09:24:53 +01:00
Eike Rathke
f84dac9b1f
back out even more wrong tools::Time changes, geez..
...
Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
2014-10-08 14:35:36 +02:00
Eike Rathke
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336
used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
Noel Grandin
059f5a95b2
loplugin: cstylecast
...
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
2014-10-02 07:37:19 +02:00
Luboš Luňák
dc7ca91a04
avoid calling OUString::copy() with length being -1
...
Which asserts in dbgutil build.
Change-Id: I0f8205ae98c5a57c430b7d8a574e4c0019855841
2014-10-01 11:45:01 +02:00
Noel Grandin
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
Matthew J. Francis
764e3016b6
fdo#84086 Fix assorted use-after-free bugs
...
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65
Reviewed-on: https://gerrit.libreoffice.org/11553
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-22 05:15:53 +00:00
Noel Grandin
37b9ea92ba
convert SBX flag bits to type-safe enum
...
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-08-26 04:30:03 -05:00