Noel Grandin
d11ed5a57e
convert dbaccess module from String to OUString
...
Change-Id: I110c925f8d955dfd841cdd1092c13df4d8205393
2013-10-01 10:08:43 +02:00
Andras Timar
7f436c1fd3
typo fixes in comments
...
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
Caolán McNamara
8e30689680
drop worthless _VECTOR_/_MAP_ header guards
...
Change-Id: I54be19847b8fb609f0b08a528cc06dbae9f579d5
2013-09-25 19:24:24 +02:00
Caolán McNamara
98de5b40c8
Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii
...
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-25 19:24:23 +02:00
Noel Grandin
ffc782c23c
remove dead definitions
...
Change-Id: I69d2df6cb0a7f994339972a23a913938307e5791
2013-09-19 10:14:15 +02:00
Andrzej J.R. Hunt
7a6fd503b1
Remove sal_char* from dbexception and some cleanup.
...
Change-Id: I81909e4542bd5e8d1f8ae182c3c17f9bbea9745d
Reviewed-on: https://gerrit.libreoffice.org/5881
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-09-12 17:33:02 +00:00
Andrzej J.R. Hunt
4216518982
Update implementations of ColumnLocate::findColumn to throw on invalid column.
...
Change-Id: I7a9354ecd35a70a005c6c50e38d27de9b33332bd
Reviewed-on: https://gerrit.libreoffice.org/5922
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-09-12 17:26:12 +00:00
Caolán McNamara
1c4f72748d
CID#736168 help coverity out a bit
...
coverity thinks theres an overrun here, I think its wrong, but its
needlessly complicated code, simplify
Change-Id: I9db4886b4e60d49c25de514081953cb380d4146f
2013-09-12 13:09:05 +01:00
Thomas Arnhold
fa1b2554d5
use replaceFirst
...
Change-Id: Ia20eec6e868579ed31e478514b7f2722a0972094
Reviewed-on: https://gerrit.libreoffice.org/5828
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-09-05 16:49:33 +00:00
Julien Nabet
fd636fe722
Remove unused writeDBLoaderInfo
...
See http://nabble.documentfoundation.org/About-writeDBLoaderInfo-function-in-dbloader-cxx-dbaccess-module-td4072511.html
Change-Id: I11b8ff569eaaa8ddcaf105e45ef4ee189e71c183
2013-09-02 22:50:17 +02:00
Caolán McNamara
ed0f0fa730
XubString->OUString
...
Change-Id: I5424a148c7173409e6e56f9483fcc769696707bc
2013-09-02 12:22:34 +01:00
Philipp Riemer
7bd0adc64b
fix indentation
...
Change-Id: Iea68e50e9f91c3fa2467201247bd1aaf4e943cf0
2013-08-31 22:41:13 +02:00
Philipp Riemer
fe8e41928d
fdo#39468: Translate German comments
...
Change-Id: I9ccb6453fbebf03d44d3f5b385fa5a49579da873
2013-08-31 22:41:12 +02:00
Philipp Riemer
f212aa9f84
fix existing comments
...
Change-Id: I06dca63053dae5d3dceb49bf67adb0c100b56e8b
2013-08-31 22:41:12 +02:00
Philipp Riemer
8d6da3b8ae
fdo#62475 - remove visual noise
...
Change-Id: I7409f7a58796c9bf7542b6a7904ad40581637eeb
2013-08-31 22:41:12 +02:00
Philipp Riemer
5f68458112
delete more code that was commented out
...
Change-Id: I8a37b482ca4abb440691b2490e43ecd93a8dbbc5
2013-08-31 22:41:11 +02:00
Philipp Riemer
bf42b6f9f5
fdo#62475 - remove visual noise
...
This is a follow up commit to
- 22d1beb78a
- 1c7af455ab
Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-31 22:41:10 +02:00
Lionel Elie Mamane
6d4c69ff84
that comment is patently wrong
...
categories presence used to be hardcoded to sal_True,
but now it is tested a few lines below.
Change-Id: I413bbac3069e49a56c74637b75b8d8990f6111b4
2013-08-30 18:36:48 +02:00
Andrzej J.R. Hunt
c656482c5a
fdo#68588 Move embeddeddbList into OGeneralPageWizard.
...
embeddeddbList is only present in generalpagewizard.ui but not in
generalpagedialog.ui, hence it should be controlled by
OGeneralPageWizard and not OGeneralPage.
Change-Id: I7c52493e12b40d9043d80fb023cfc9eb9c9e42ec
Reviewed-on: https://gerrit.libreoffice.org/5654
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2013-08-28 14:00:39 +00:00
Jelle van der Waa
2ec606730b
fdo#62475 removed pointless comments
...
Conflicts:
dbaccess/source/filter/xml/xmlfilter.cxx
dbaccess/source/ui/dlg/ConnectionPage.cxx
dbaccess/source/ui/dlg/detailpages.cxx
dbaccess/source/ui/dlg/odbcconfig.cxx
dbaccess/source/ui/querydesign/querycontroller.cxx
Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz >
Tested-by: Petr Mladek <pmladek@suse.cz >
2013-08-27 16:11:09 +00:00
Caolán McNamara
81e0c2c38c
WaE: OUString::valueOf in higher debug levels
...
Change-Id: I2aed7907c79905158714dc1b26ae1aefc1fcccc6
2013-08-26 12:36:36 +01:00
Noel Grandin
a7f84fc431
convert include/svtools/QueryFolderName.hxx from String to OUString
...
Change-Id: Iec274c35c3ce4f1f9d5f17bd5562b52b788595d4
2013-08-22 10:49:27 +02:00
Luboš Luňák
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Stephan Bergmann
67876ed105
SAL_INFO output contains the current thread ID anyway
...
Change-Id: Ie51865e57a33e31c2aa115b68eed0fc0a1972c40
2013-08-21 11:42:13 +02:00
Michael Meeks
1c7af455ab
Re-work 8bit characters in source code, or remove them.
...
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@suse.com >
Tested-by: Michael Meeks <michael.meeks@suse.com >
2013-08-20 19:30:59 +00:00
Caolán McNamara
c3164e42dc
Resolves: rhbz#998046 store last size/position of the table/query/form
...
Change-Id: I3623d5e133b8d7b2e7920824b05c46ade7b10d7c
2013-08-20 20:26:41 +01:00
Tor Lillqvist
08452f1208
Rename SOLAR_JAVA to ENABLE_JAVA and HAVE_FEATURE_JAVA
...
Change-Id: Ib451bdb3c1c2ca42347abfde44651d5cf5eef4f3
2013-08-19 10:29:04 +03:00
Jelle van der Waa
9a1aca007f
fdo#57950: Remove some chained appends in dbaccess
...
Change-Id: If93b4a11ac15ede2b08ef42bb2fa4670f0d4cd24
Reviewed-on: https://gerrit.libreoffice.org/5481
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-19 06:04:40 +00:00
Tor Lillqvist
c6a7300974
Use subfolder names from <config_folders.h>
...
Change all instances of hardcoded "program", "share" etc subfolder names to
use those from <config_folders.h> instead. In normal builds, the end result
will not change.
Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-18 21:11:16 +03:00
Caolán McNamara
91da177229
remove various unused dialogs
...
Change-Id: If639745db976671a3b6e3405253dfb3bc5783363
2013-08-17 13:09:23 +01:00
Stephan Bergmann
c9db5e6f08
Do not use this ptr in ctor
...
...offload to init() instead and wrap ctor in create(). That removes the need
for refcount fiddling and additional OContainerListener class. Which in turn
removes code using dynamic_cast on UNO interface classes, which my claim at
<http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130812/
086127.html> "ubsan: check type_info equality via strcmp" that "there should not
be uses of dynamic_cast involving [UNO] classes in the LibreOffice code base"
made me wonder about...
Change-Id: I5d72650f6bf081f971f7bd6bb65f4e58a342f791
2013-08-16 15:02:30 +02:00
Noel Grandin
00f5fde6c4
convert include/svtools/roadmapwizard.hxx from String to OUString
...
Change-Id: I1b5a0c3f5946aac9d353550091616cf5a31e6f82
2013-08-15 09:11:35 +02:00
Noel Grandin
33eeb70011
convert include/svtools/svparser.hxx from String to OUString
...
Change-Id: I4d6196a9a96ad1dd236f8622a523b4702e92d76f
2013-08-15 09:11:33 +02:00
Julien Nabet
1d6ef2446e
Reduce scope + use SAL_N_ELEMENTS
...
Change-Id: I33fd212f6ab82f802fa85af804980c2e8c4c9ec7
2013-08-15 00:04:55 +02:00
Lionel Elie Mamane
76b5ac2193
doing it once is sufficient
...
Change-Id: If31845aa575b3f9459507deefb1b469ac3715e35
2013-08-14 17:39:58 +02:00
Caolán McNamara
6b2cc1eb6c
XubString->OUString
...
Change-Id: I1db6254b23c5203c20c168989656d320f86a3bb9
2013-08-13 09:22:29 +01:00
Caolán McNamara
bfafc8c3a1
callcatcher: update unused code
...
mostly ResId using ctors left stranded post .ui conversion
Change-Id: I06689eea30ee9146ba05294f52056c0d263695f5
2013-08-10 12:25:10 +01:00
Michael Stahl
03eb15938e
vcl, sw: fix the inheritance of SwComboBox from ComboBox a bit
...
Remove the silly overloading, and introduce virtual methods.
Change-Id: If54a6a3fb7464283f80d3387ae23db234690f8a3
2013-08-08 23:25:28 +02:00
Michael Stahl
91f3d77b98
tweak comment translations
...
ede5f05c
fb3a1bb9
5e04331f
fd6089b9
66a1d406
Change-Id: I5077ce5f6182f9193cebaaf63190450d375679dd
2013-08-08 23:25:25 +02:00
Takeshi Abe
e2e15148fc
Mark as const/static
...
Change-Id: I54a7daee7345e7c0c5c3f866d5c365722b567eff
2013-08-04 00:54:12 +09:00
Tor Lillqvist
e22e166a5d
WaE: unknown log area 'dbaui.OGeneralPage' [loplugin]
...
Change-Id: I669bd637a8f4c9880eaceed2c67b9ddedd6eff3e
2013-08-02 16:55:28 +03:00
Tor Lillqvist
c590bf1050
WaE: unknown log area 'dbaaccess' [loplugin]
...
Change-Id: I327192e60ed75f2c24331f38f89bcfeb085725ba
2013-08-02 16:52:39 +03:00
Andrzej J.R. Hunt
c5fb2644c9
Check that xKeys exists before using.
...
Currently base segfaults here when using a database driver that doesn't
support sdbcx, the internal sdbcx wrapper doesn't implement getKeys()
either.
Change-Id: I195dfa891b4e38e6e0f5a9286bcbfa66ca818e28
Reviewed-on: https://gerrit.libreoffice.org/5243
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-08-02 13:41:06 +00:00
Andrzej J.R. Hunt
04d1e80ac7
Add embedded database selector to db setup dialog.
...
This allows for choosing between the HSQLDB driver (currently default)
and the firebird driver for embedded databases.
Change-Id: I3734440fedf9f07b28f9cfd806dafbe6610393f7
Reviewed-on: https://gerrit.libreoffice.org/5199
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-08-02 13:38:46 +00:00
Lionel Elie Mamane
3d5a27bf5a
for later...
...
Change-Id: I266d2992bcd212a6539e4b50c9daf2c53ff98904
2013-08-02 13:57:51 +02:00
Lionel Elie Mamane
a8f327a9fc
make comment actually describe the code
...
Change-Id: If4dda13ff8018d7fd855457a76db2acf8077a477
2013-08-02 13:57:49 +02:00
Lionel Elie Mamane
0fafb92e97
janitorial: more const where possible
...
Change-Id: If579b2b2990c3cdd4785077aa1b34c33bcc241b6
2013-08-02 13:57:48 +02:00
Lionel Elie Mamane
6fc71eea1d
SingleSelectQueryComposer: the name of a non-SELECT column is its "real" name
...
That is, the name in the table.
Change-Id: I95326915f381ec0cf72c66f13352ce76d82e9517
2013-08-02 13:57:47 +02:00
Caolán McNamara
ab29ad8cd5
set some initial sizes for the direct sql dialog textedits
...
and we can use existing GtkTextView<->VclMultiLineEdit mapping rather than the
svtools MultiLineEdit
Change-Id: I6d20a9ba8731dda1ec9579fc2877b817fea0632f
2013-07-30 14:51:47 +01:00
Csikós Tamás
471e5c1ed1
modern .ui widgetlayout for directsql
...
Change-Id: I51140fe6abd2d321c5784b923f920ab9183f417e
Reviewed-on: https://gerrit.libreoffice.org/5171
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2013-07-30 13:48:40 +00:00