Commit Graph

914 Commits

Author SHA1 Message Date
Andras Timar
6ea6a422fb s/wiki.services.openoffice.org/wiki.openoffice.org/g
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
Tor Lillqvist
f1dd6b8d62 WaE: 'BufferNode::notifyAncestor': recursive call has no side effects
Interesting function that just traverses a chain of objects using
recursion, but does nothing at all otherwise. Kill it. But at least it
had an Enterprise Ready block comment in front.

Change-Id: If2296d2534cb9451d4ceadaf966b8c70f0a17557
2013-09-04 01:57:54 +03:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Jelle van der Waa
b5e5ce956b fdo#57950: Remove some chained appends in xmlsecurity
Change-Id: I35ac622abb995a9259f0774f463ec2816b3668b6
Reviewed-on: https://gerrit.libreoffice.org/5477
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-18 13:53:54 +00:00
Andrzej J.R. Hunt
182bf2a63a Revert "fdo#57950: Remove some chained appends in xmlsecurity"
This reverts commit 4f20c9f6f9

Change-Id: I4d8cef801d570b0c20e580144e79a5940b100271
Reviewed-on: https://gerrit.libreoffice.org/5476
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-17 15:28:01 +00:00
Jelle van der Waa
4f20c9f6f9 fdo#57950: Remove some chained appends in xmlsecurity
Change-Id: If70fa38ad4836b6dacdd0c5577c66b78be6826a6
Reviewed-on: https://gerrit.libreoffice.org/5465
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-17 07:48:21 +00:00
Tor Lillqvist
9499df9f8c Ifdef out code which had been accidentally un-commented-out
The code snippet had been commented out since its introduction in
2004. In 1452e56597 it was accidentally
un-commented-out, but it causes compilation errors. So ifdef it out
instead, with a comment. Note that I have no idea what the code does
and whether it actually is useful to keep for future reference or not.

Change-Id: Ie60ca065b2c65f86a7b382e246c1b650424daa1d
2013-08-12 09:28:57 +03:00
Jelle van der Waa
1452e56597 fdo#62475 removed pointless comments
Change-Id: I02b264a9661bcefaea96d6c5743352914154427d
Reviewed-on: https://gerrit.libreoffice.org/5345
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-11 19:37:59 +00:00
Jelle van der Waa
ec52a20edb fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
Change-Id: Ie959aa5a6874aae3c60273355a959c344e82699e
Reviewed-on: https://gerrit.libreoffice.org/5083
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-24 20:18:36 +00:00
Takeshi Abe
bddd4d4598 Mark as const
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
Caolán McNamara
52bce8fadd convert versions of dialog to .ui
Change-Id: I1be2211b5c936e6e00f2fe81883b8fb1e67ef550
2013-07-16 12:45:56 +01:00
Caolán McNamara
9eeacd2751 XmlReadOnlyImage is now unused post .ui conversions
Change-Id: Ib90966ed6e791371dacd8d9cdf8234fa66b02858
2013-07-02 11:59:52 +01:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Thomas Arnhold
b6d97514cd reduce some spacing
Change-Id: I72d494b1c0ff5ed3c52ae6a078815f497e4dd647
2013-06-29 18:38:14 +02:00
Jürgen Schmidt
647ad63f9f Resolves: #i122564# correct typo, save -> safe
(cherry picked from commit 1aedcb86f08affb4265539418d4cde377c4de80c)

Change-Id: I6af85ddfafa1fe1577fd43431a08d62e9c2a5a52
2013-06-20 12:15:28 +01:00
Jelle van der Waa
b5f3f55ce5 fdo#43460 unoxml,writerfilter,xmlsecurity: use isEmpty()
Change-Id: Iba3b39086212803bc41384f5c8f51e42712a5249
Reviewed-on: https://gerrit.libreoffice.org/4349
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-19 10:11:34 +00:00
Noel Grandin
670e2329df fdo#46808, Convert xml::crypto services to new style
Also remove the unnecessary XInitialization implementations.

Change-Id: I81f32b2cdcf69b84fe4b15382f9294073a7f2f20
2013-06-10 10:20:44 +02:00
Fridrich Štrba
9eb4e4dc51 Some more modules at least building with mingw64
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-06 19:49:56 +02:00
Stephan Bergmann
287bc2bb76 Drop unused XInitialization from implementation
...now that it has been dropped from the service declaration with
75a87d9bc2 "fdo#46808, Convert
xml::crypto::XMLEncryptionTemplate to new style"---appears to be nonsense that
had been in there "since the beginning."

Change-Id: I75826b7eb0a4d5538204394a8f0e9c9e9f1393da
2013-06-05 18:17:35 +02:00
Stephan Bergmann
496a2c2e46 Drop unused XInitialization from implementation
...now that it has been dropped from the service declaration with
6a12e13870 "fdo#46808, Convert
XMLSignatureTemplate service to new style"---appears to be nonsense that had
been in there "since the beginning."

Change-Id: I4e4d3649f1aa0dacebdc8bdcee0348cee294ab89
2013-06-05 17:29:14 +02:00
Noel Grandin
d11e59088f fix superclass-constructor call.
Was introduced in commit
   a4196fc3cf
   "fdo#46808, Convert XMultiServiceFactory in xmlsecurity module"

Change-Id: Ie06a3c89e3a8b4cf43e68afd575a0e86b48d6bc2
2013-06-05 15:22:49 +02:00
Noel Grandin
75a87d9bc2 fdo#46808, Convert xml::crypto::XMLEncryptionTemplate to new style
Change-Id: I45bcb3f0f4b9998105d361dbf6a98d8f5310da52
2013-06-05 14:48:20 +02:00
Noel Grandin
6a12e13870 fdo#46808, Convert XMLSignatureTemplate service to new style
Change-Id: I80530f84ad5a86eccc794f9ddd14f939d093a20d
2013-06-05 14:48:20 +02:00
Noel Grandin
a4196fc3cf fdo#46808, Convert XMultiServiceFactory in xmlsecurity module
Change-Id: Ia134170d07f33c2649b2a2620f40bc7b45ec7e16
2013-06-05 14:48:19 +02:00
Noel Grandin
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
Jian Fang Zhang
3d8a7a435c Resolves: #i120675# the certificate store handles need to be closed
after closing the document

Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit 33d9584bb6d285de1d935bf23adbb2c7666656f4)

Change-Id: I131a17276f33059eb944fc34272c50f838b6973f
2013-05-16 16:26:34 +01:00
Philipp Riemer
e8eab43eeb cleanup whitespaces due to RTL_CONSTASCII_USTRINGPARAM removal
In e2e2cc6114 the method was removed
automatically leaving several line breaks etc. as visual noise.
2013-05-06 19:21:07 +02:00
Luboš Luňák
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
Miklos Vajna
3155a8e60f xmlsecurity: drop no longer needed RTL_ASCII_USTRINGPARAM macro
Change-Id: Ia08688ef3c262ba4379213231032c73404ae748b
2013-05-06 09:24:01 +02:00
Thomas Arnhold
1e83da9aed some more namespace cleanup
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
2013-04-26 18:01:51 +02:00
Marcos Paulo de Souza
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
Lionel Elie Mamane
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
Tor Lillqvist
e79b387e03 It is very wrong to #undef _DEBUG in some source files of a library
Nowadays in a dbgutil build with MSVC, the debugging runtime (C++
library) is used. Just like with the GNU libstdc++, it is not binary
compatible with the non-debugging variant.

All sources that go into one DLL or EXE must be compiled with the same
_DEBUG settings (unless one is extremely careful and knows exactly
what one is doing, which presumably is not the case with this code).

With previous compilers this has gone undetected, but with MSVC2012 at
least, you get link-time errors, which is a good thing:

nssinitializer.o : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in biginteger.o

nssinitializer.o : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in biginteger.o

Whether this actually has caused run-time erroneous behaviour or
not in a dbgutil build is another thing...

Change-Id: I0c42161f00a0e37b438e3b911e3c0058edadd800
2013-04-17 13:23:35 +03:00
Luboš Luňák
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Thomas Arnhold
049ce78144 remove local css definitions
follow-up of 66a175834c

Change-Id: I1c495041ccc4db4dd9554d49b6324e989fa46c60
2013-03-30 00:56:42 +01:00
Stephan Bergmann
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
Stephan Bergmann
a9e6e5bf4d The [_]DEBUG_WAS_DEFINED macros are not used here
...but only in connectivity/source/drivers/mozab/{pre,post}_include_mozilla.h,
which is never included from here, so this smells like cargo-cult.

Change-Id: Iac0d7d60caad7c090445d551b7adb50424130e2a
2013-03-25 08:52:56 +01:00
Stephan Bergmann
ec52e5e5a2 Consolidate XMLSEC_NO_SIZE_T setting in xmlsecurity/xmlsec-wrapper.h
...so all xmlsec/*.h includes are bundled there now (except, for pragmatic
reasons, the xmlsec/mscrypto/*.h ones that unconditionally include windows.h and
only work on Windows).

Change-Id: I33e642f4f6a2e40edd6950af7f209c8b76c6e5fe
2013-03-25 08:52:55 +01:00
Stephan Bergmann
3b006a10b7 stricmp macro is unused
...since f3eb77586e "further removing of dead
code."

Change-Id: I6805c5adafcf19782f352cdacd0d99a9e7681eb6
2013-03-25 08:52:55 +01:00
Peter Foley
9cac657749 add cui to Library_merged
Change-Id: I485426c0a0792e17bae5ef125d69f52827b469b2
2013-03-24 08:55:55 -04:00
Thomas Arnhold
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
Luboš Luňák
1af22c05c6 fix other problems found by Wundef
Change-Id: Ib4aba95436f82d2a20b07a092f0fd07e0620fdcf
2013-03-18 17:15:57 +01:00
Borim
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
Thomas Arnhold
4bf95c4c31 make use of startsWith()
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679
Reviewed-on: https://gerrit.libreoffice.org/2599
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-08 13:16:49 +00:00
Caolán McNamara
5ecb308bd3 rename setInitialLayoutSize to setOptimalLayoutSize
and add a mechanism to know that we're in true
initial layout mode

Change-Id: I4ff61160ae67a7ccf1cb8b25c41870c195d32b94
2013-03-07 14:06:17 +00:00
Thomas Arnhold
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
Caolán McNamara
ecda52f6b3 callcatcher: unused code
Change-Id: I7dcaa6f57815321e108cd7ce284fe145dc0506f2
2013-03-04 11:23:59 +00:00
Jean-Noël Rouvignac
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00