mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
489,370 Commits 1 Branch 0 Tags
d724b51c7da391c9afe5e47476d432aecf1c4c67
Commit Graph

349 Commits

Author SHA1 Message Date
Stephan Bergmann
a2166dfd41 Avoid MSVC error C2039 
At least with VS 2022 Preview 17.6.0 Preview 3.0 and (if that makes a difference
here) --with-latest-c++, the build started to fail now for me with

> cli_ure/source/climaker/climaker_app.cxx(603): error C2039: '{dtor}': is not a member of 'System::IDisposable'

Originally, in 4c937bbdbb "#107130# new",
TypeEmitter in cli_ure/source/climaker/climaker_share.h had been defined as

> __gc class TypeEmitter : public ::System::IDisposable

with an overriding Dispose member function (and no user-declared dtor), and the
code in cli_ure/source/climaker/climaker_app.cxx had called

>         type_emitter->Dispose();

when done.  Then, in 6fa1a74ec4 "convert climaker
to new syntax", the definition of TypeEmitter had been changed to

> ref class TypeEmitter : public ::System::IDisposable

with a dtor instead of the overriding Dispose member function, and the code in
cli_ure/source/climaker/climaker_app.cxx had been changed to call

>         type_emitter->~TypeEmitter();

instead.

I have no deep understanding of the Managed C++/CLI stuff at play here, but it
looks reasonable to avoid all this by not deriving from IDisposable (and relying
on GC to clean up all instances) and introducing some explicit finish()
protocol.

Change-Id: I8ebfba9d9f9c32b65a50104d200306e06dc69f73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150387
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-04-17 15:07:57 +02:00
Gabor Kelemen
ed989d6b79 Drop 'using namespace ::std' in Windows-specific files 
Change-Id: Id66d42f2139fbcac0fed56fe534107f65d198f02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147877
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2023-02-28 11:17:57 +00:00
Stephan Bergmann
345d461128 Just use Any ctor instead of makeAny in cli_ure 
Change-Id: Iae41d9c4b600635bd5e2e61b65ea3859a14e6a1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133840
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-04 22:43:37 +02:00
Julien Nabet
961ebbe9eb drop 'using namespace std' in cli_ure 
Change-Id: Ib439d74284d52e32162164d14ab06e4f40df884a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123193
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2021-10-07 13:38:06 +02:00
Stephan Bergmann
2ea32dcffd Fix MSVC 2019 16.8.3 --with-latest-c++ error C2102: '&' requires l-value 
Change-Id: Iff1db722239c32822bbc23ddd13e2df105a993e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108837
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-01-06 14:14:59 +01:00
Stephan Bergmann
72d9fb1e5d Fix various MSVC 2019 16.8.3 --with-latest-c++ issues 
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(863): error C2440: 'type cast': cannot convert from '_typelib_TypeClass' to 'com::sun:⭐:uno::TypeClass'
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(863): note: Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast)
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(863): error C2046: illegal case

etc. and

> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): error C2668: 'System::Array::GetValue': ambiguous call to overloaded function
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): note: could be 'System::Object ^System::Array::GetValue(__int64)'
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): note: or       'System::Object ^System::Array::GetValue(int)'
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): note: while trying to match the argument list '(sal_Int32)'

etc. (the latter hit at least with a 32-bit --host=i686-pc-cygwin build)

Change-Id: Iac372204ee86c8bd590f3b940ed2382dd7f8d2d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108838
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-01-06 12:15:21 +01:00
Philipp Hofer
7ebd82e885 tdf#123936 Formatting files in module cli_ure with clang-format 
Change-Id: I721878c8c7a56f311d1a087618895a2ddb3b6d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105651
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-11-13 15:14:18 +01:00
Andrea Gelmini
9762353cf7 Fix typos 
Change-Id: I49d7dc8a2cbcba5413d05d97559321e672ed413a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92655
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-04-22 15:48:11 +02:00
Andrea Gelmini
de6422b5f3 Fix typos 
Change-Id: I207333e9bafc5d6c38ffa53a303046e437b7a815
Reviewed-on: https://gerrit.libreoffice.org/77607
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-16 22:19:34 +02:00
Andrea Gelmini
4a9ac82cab Fix typos 
Change-Id: I94bfbfef24be46583c5c2877e468ed65c2bd5eb0
Reviewed-on: https://gerrit.libreoffice.org/76513
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-07-29 10:08:01 +02:00
Noel Grandin
a361231b13 fix wrong SET/QUERY flags passed to uno::Reference 
By creating deleted methods for the wrong calls.

Avoids the compiler needing to construct a temporary

Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a
Reviewed-on: https://gerrit.libreoffice.org/72103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-05-13 08:15:27 +02:00
Caolán McNamara
fbc038cc4f an uno -> a uno 
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 14:50:59 +02:00
Andrea Gelmini
d408080d7c Fix typo 
Change-Id: Ie7578a8f1693d69ef5208659375968e43cb15aec
Reviewed-on: https://gerrit.libreoffice.org/70750
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2019-04-15 05:19:20 +02:00
Andrea Gelmini
9ad15c082c Fix typo 
Change-Id: I90a02374666929aed5ae00b08af3faa187f09a5b
Reviewed-on: https://gerrit.libreoffice.org/70749
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2019-04-15 04:48:51 +02:00
Andrea Gelmini
0811add46b Fix typo 
Change-Id: I23e3617274c1c17b9c3792f95eaf28d9554dc2b3
Reviewed-on: https://gerrit.libreoffice.org/70740
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-04-14 19:43:05 +02:00
Andrea Gelmini
62f0218148 Fix typo 
Change-Id: I3f4a60a977c20b2e5d380fe9dd26d80a20099c05
Reviewed-on: https://gerrit.libreoffice.org/70741
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-04-14 19:42:21 +02:00
Mike Kaganski
85456fae54 tdf#120703 PVS: Silence V522 warnings 
V522 There might be dereferencing of a potential null pointer.

Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48
Reviewed-on: https://gerrit.libreoffice.org/70017
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-04-01 00:49:12 +02:00
Arkadiy Illarionov
95a538180f Simplify containers iterations in chart2, cli_ure, comphelper, configmgr 
Use range-based loop or replace with STL functions

Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76
Reviewed-on: https://gerrit.libreoffice.org/69010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-03-12 16:10:01 +01:00
Caolán McNamara
dbd3be9063 createInstanceWithContextAndArguments->createInstanceWithArgumentsAndContext 
Change-Id: Ie22398eb42f61e50177f88672a1407d9dda58f8a
Reviewed-on: https://gerrit.libreoffice.org/68106
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-02-20 22:11:06 +01:00
Stephan Bergmann
5206992e6e Some uses of C++17 class template argument deduction 
Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686
Reviewed-on: https://gerrit.libreoffice.org/68020
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-02-19 17:39:16 +01:00
Andrea Gelmini
47a5f90d42 Fix typo 
Change-Id: If5772a609d7333f3fc07ade887e9a25762ebb75a
Reviewed-on: https://gerrit.libreoffice.org/67340
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-02-04 07:07:07 +01:00
Noel Grandin
8467d76418 fix signatures of deleted copy/assign operators 
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129
Reviewed-on: https://gerrit.libreoffice.org/62718
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-02 07:03:08 +01:00
Mike Kaganski
dc1858783e tdf#120703 (PVS): V519 The variable is assigned values twice successively 
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27
Reviewed-on: https://gerrit.libreoffice.org/62406
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-10-27 09:23:52 +02:00
Caolán McNamara
d1771e8de2 pvs-studio: Potentially uninitialized pointer 'ret_type' used. 
Change-Id: I2f6faf1264a62012724d9fe34352a76ea5491717
Reviewed-on: https://gerrit.libreoffice.org/62096
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-10-21 18:18:26 +02:00
Noel Grandin
37f9fdc11c replace rtl_allocateMemory with std::malloc 
where used directly, since rtl_allocateMemory now just calls into std::malloc

Change-Id: I59f85bdb7efdf6baa30e8fcd2370c0f8e9c999ad
Reviewed-on: https://gerrit.libreoffice.org/59685
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-29 09:05:39 +02:00
Arkadiy Illarionov
0787ce8814 Simplify containers iterations, tdf#96099 follow-up 
Use range-based loop or replace with std::any_of, std::find and
std::find_if where applicable.

Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6
Reviewed-on: https://gerrit.libreoffice.org/59143
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-20 17:12:11 +02:00
Andrea Gelmini
7d071f35be Fix typos 
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2
Reviewed-on: https://gerrit.libreoffice.org/57810
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-07-23 11:44:59 +02:00
Gabor Kelemen
7af90cc93b Add missing sal/log.hxx headers 
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade
to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from a* to configmgr

Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a
Reviewed-on: https://gerrit.libreoffice.org/57170
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-07-09 10:49:06 +02:00
Arkadiy Illarionov
3bd8759f5e tdf#96099 Remove some trivial std::vector typedefs 
Change-Id: I0e60ec7a3edae42b25ff0917828d0a893ed39a38
Reviewed-on: https://gerrit.libreoffice.org/55245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-06-11 08:57:06 +02:00
Mike Kaganski
b9d709e847 tdf#94265: use install directory on delay load failure 
This partially reverts commit 827430c8c0

Change-Id: Ia5d609040a3b355659e780e0606ce4bff0d22509
Reviewed-on: https://gerrit.libreoffice.org/52572
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-04-09 09:06:46 +02:00
Mike Kaganski
acb3eeb6c2 cli_ure: MSVC: pragma warning: make more specific, remove obsolete 
Change-Id: I63e12a22a46de27a8bd010e4d21bf36d3a7e9178
Reviewed-on: https://gerrit.libreoffice.org/48967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-02-01 06:45:58 +01:00
Andrea Gelmini
624f84c07e Fix typos 
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a
Reviewed-on: https://gerrit.libreoffice.org/47855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-16 12:40:51 +01:00
Andrea Gelmini
7bcb66baec Fix typos 
Change-Id: Id2f90d4798ded8f10ef559f434977870e2eab07a
Reviewed-on: https://gerrit.libreoffice.org/44709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-11-14 20:26:54 +01:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Mike Kaganski
eef4c133e9 Windows: avoid dependence on UNICODE define; prefer W functions 
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1
Reviewed-on: https://gerrit.libreoffice.org/42560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-09-22 20:53:30 +02:00
Mike Kaganski
aaa26a58ba Some more WIN32_LEAN_AND_MEAN 
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874
Reviewed-on: https://gerrit.libreoffice.org/42419
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-09-18 19:24:31 +02:00
Michael Stahl
e0487a1129 cli_ure,unoil: always increment all CLI assembly version numbers 
There is a increment_version.pl, which uses the incversions.txt
to increment the CLI version numbers.

But it first checks that there are new published UNO types,
and exits if there are none. Not sure where the input for that
is supposed to come from.

But the OOo docs claim that all version numbers have to be
incresed for every release to work around some MSI issue,
so change the script to do that and add an incversion.txt
in unoil too.

http://www.openoffice.org/udk/common/man/spec/assemblyversioning.html
https://support.microsoft.com/en-us/help/905238/an-assembly-in-the-global-assembly-cache-or-sxs-is-missing-after-you-p

Change-Id: I6190b53d1a3ff00b9fe014f86f7ec8cddef9904e
 2017-08-16 15:35:09 +02:00
Noel Grandin
5e028ad5dc simplify some string handling in tracing calls 
Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3
Reviewed-on: https://gerrit.libreoffice.org/39159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 14:38:14 +02:00
Jochen Nitschke
a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Noel Grandin
68e213319f remove empty comments 
found with:
   git ls-files | xargs grep -Pzl '/\*\*
(\*|\s|
)*\*/'

Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597
Reviewed-on: https://gerrit.libreoffice.org/37159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-03 09:07:36 +02:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Stephan Bergmann
de82b32c4a Clean up uses of SAL_U/SAL_W: cli_ure 
Change-Id: I198be4023710206d66135c33fe01e1d9bb859272
 2017-04-10 10:14:11 +02:00
Stephan Bergmann
9ac98e6e34 Finally switch MSVC to sal_Unicode = char16_t, too 
There is lots of (Windows-only) code that relied on sal_Unicode being the same
as wchar_t, and the best change may be different in each case (and doing the
changes may be somewhat error prone).  So for now add SAL_U/SAL_W scaffolding
functions to sal/types.h, remove their uses one by one again, and finally drop
those functions again.

Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea
Reviewed-on: https://gerrit.libreoffice.org/36077
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-04-04 16:12:11 +00:00
Michael Stahl
cfaba15c58 cli_ure: fix another bad _WIN64 check (related tdf#94265) 
Same problem as commit 2aa20cfb7a

Change-Id: I02160c53870a021c742babf358e0d6172557ef21
 2017-03-29 12:56:59 +02:00
ComputingDwarf
3b2863596f tdf#94265: Correct the error 
Always _WIN32 is defined, even in Win64. So the check must be to _WIN64 and then to _WIN32.
Hope no more lines like this in code.
Can you test programs with SDK 64 Bit?
 2017-03-22 11:20:24 +01:00
Andrea Gelmini
6fab286b2a Fix typos 
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524
Reviewed-on: https://gerrit.libreoffice.org/34808
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-03 07:42:39 +00:00
Tor Lillqvist
6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Stephan Bergmann
22f96dad08 Some simplifications, using UNO_QUERY_THROW 
Change-Id: I3d29240b7a3aa1d8941ca97f3c3e941e884cbf8b
Reviewed-on: https://gerrit.libreoffice.org/34272
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-02-15 14:19:23 +00:00
Jochen Nitschke
a29bd2dabb cleanup tailing backslashes 
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-30 18:48:24 +00:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox 
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:12:00 +00:00