Commit Graph

822 Commits

Author SHA1 Message Date
Noel Grandin
1d1825db86 fdo#46808, Convert awt::UnoControlDialog to new style
Change-Id: I9a5256c8dbacda60167403b4e26900588943a9b2
2013-05-28 08:10:22 +02:00
Stephan Bergmann
e36f83d81c Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"
This reverts commit 6c61b20a8d.  As discussed at
<http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re:
fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd
change in 2e2a4827ce "scripting: get
CreateUnoDialog() work again" appears to fix things again:

  The problem is that the implementation of the css.awt.UnoControlDialogModel
  involves UNO aggregation
  (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in
  toolkit/soruce/helper/registerservices.cxx creating a
  OGeometryControlModel<UnoControlDialogModel> instance that aggregates a
  UnoControlDialogModel instance).  That means that queryInterface can return a
  reference to something that is technically a different object, and that's
  what's happening here, and explains why calling setPropertyValue in two
  different ways on what logically appears to be a single object can end up
  calling two different implementations (of two different physical objects).
  (UNO aggregation is known to be broken and should not be used.  Nevertheless,
  there's still code that does---code that is a horrible mess and hard to clean
  up.)

  That all this worked as intended in the past is just sheer luck, but any
  way of substantially touching it is asking for trouble.  I'm going to
  revert 6c61b20a8d again.

I wasn't able to revert without also reverting
be50ad28f5 "fdo#46808, Convert
awt::XUnoControlDialog to new style," as the two were tightly dependant.  Also
reverts all the follow-up fixes cb4b6dde8f
"-Werror,-Wuninitialized" (sans the const-ness fix in
UpdateHandler::insertControlModel), 697a007c61
"Fix exception specifications," 2ce6828bbb "fix
awt::UnoControlModelDialog crash," and 2e2a4827ce
"scripting: get CreateUnoDialog() work again."

Conflicts:
	basctl/source/dlged/dlged.cxx
	filter/source/t602/t602filter.cxx
	xmlscript/test/imexp.cxx

Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-25 11:45:47 +02:00
Pedro Giffuni
7a6cc8bb59 Resolves: #i55055# Simplify pythonscript.py code
author:	hanya
(cherry picked from commit e945b49105bab50700274f797e41d1446a70641d)

Conflicts:
	scripting/source/pyprov/pythonscript.py

Change-Id: Ia019a737c5f80d3af9fc50aefcda6f5b00987513
2013-05-24 12:16:48 +01:00
Miklos Vajna
2e2a4827ce scripting: get CreateUnoDialog() work again
Trivial reproducer:

Dim Dlg As Object
DialogLibraries.LoadLibrary("Standard")
Dlg = CreateUnoDialog(DialogLibraries.Standard.Dialog1)
Dlg.Execute()
Dlg.dispose()

Regression from 6c61b20a8d.

Change-Id: Ia62778c6d94f54e6097a307701e5c81be847665d
Reviewed-on: https://gerrit.libreoffice.org/4023
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-24 11:06:40 +00:00
Noel Grandin
2ce6828bbb fix awt::UnoControlModelDialog crash
...in commit 6c61b20a8d,
    "Convert awt::UnoControlDialogModel to new style"
I added an attribute "ResourceResolver" because some of the client
code was setting it using the property interface.

It turns out that this was a bad idea because the "ResourceResolver"
property is doing some very interesting stuff, so revert that part
of the change.

Change-Id: I62b890e60164e005867ced49c3e407a49ed09441
Reviewed-on: https://gerrit.libreoffice.org/4013
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-23 15:10:56 +00:00
Noel Grandin
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
Noel Grandin
be50ad28f5 fdo#46808, Convert awt::XUnoControlDialog to new style
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
2013-05-21 08:23:59 +02:00
Noel Grandin
6c61b20a8d fdo#46808, Convert awt::UnoControlDialogModel to new style
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-21 08:23:58 +02:00
Ariel Constenla-Haile
b0c59c3146 Resolves: #ii118478# Implement getInvocationContext in PyUNO ScriptContext
Original author: Tsutomu Uchino <hanya.runo at gmail.com>

(cherry picked from commit 5de5fd495d7cdad852d1631941ae03ec213f93b7)

Change-Id: Iaa0aa8b1dd6a326cd738f2e296a1b5ecdc379c65
2013-05-11 12:21:27 +01:00
Noel Power
2f3359dbe8 fix memory leak with orphaned controls created on the fly 2013-05-09 14:11:20 +01:00
Noel Power
04eb03cc0b handle various ReturnXXXX types for forms
Change-Id: Idcbfbebafb02c734b42428c5b1d6df8d0d4a23d6
2013-05-09 14:11:14 +01:00
Philipp Riemer
e8eab43eeb cleanup whitespaces due to RTL_CONSTASCII_USTRINGPARAM removal
In e2e2cc6114 the method was removed
automatically leaving several line breaks etc. as visual noise.
2013-05-06 19:21:07 +02:00
Luboš Luňák
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
Michael Meeks
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
Stephan Bergmann
e8ff469da5 Remove any remaining remnants of unused component_canUnload feature
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
Lionel Elie Mamane
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
Stephan Bergmann
617e7c6231 Missing include
Change-Id: I1be082b7db5592ad5090cf3ffaafe708bb1d9be4
2013-04-16 19:07:36 +02:00
Luboš Luňák
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
Thomas Arnhold
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
Stephan Bergmann
4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
Noel Grandin
a3bb733ec6 fdo#46808, Convert singleton theMasterScriptProviderFactory
Change-Id: I647a02e552acdd354463fc46c13c5a73b1c90d09
2013-03-07 08:23:39 +02:00
Thomas Arnhold
33d6a7b2d7 doubled namespaces
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-04 13:58:40 +01:00
Thomas Arnhold
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
Thomas Arnhold
ecf0040337 loplugin: improve indentation
Change-Id: If0ddaa8fd7cfaf4df8589422cb50ce37f1be2ad1
2013-03-03 17:14:15 +01:00
Thomas Arnhold
89003e9bd8 loplugin: unused variables
Change-Id: I63553a09eec81e5ae28aa79ee1d3281053b23d06
2013-02-25 03:14:01 +01:00
Caolán McNamara
df37f7d8e8 move loop variables into least scope pos
Change-Id: I8e69e92bbfee2bf20918d041ecc6b7a3f7729fbd
2013-02-24 23:24:26 +00:00
Julien Nabet
3901964b6d coverity#704434 Non-array delete for scalars
Change-Id: Ie92de56ead7988d951fe44cf63b4e72214b1e22f
Reviewed-on: https://gerrit.libreoffice.org/2358
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-24 23:22:55 +00:00
Thomas Arnhold
d5caf6898b loplugin: unused variables
Change-Id: I7fc203900256839e679bf73b717d121fedc42087
2013-02-24 17:44:31 +01:00
Tor Lillqvist
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
Miklos Vajna
d1dc850cbb scripting: s/pathes/paths and s/Pathes/Paths
Change-Id: I58d8e8dc9c6a6864206d923165d075114368c866
2013-02-22 08:47:34 +01:00
Radu Ioan
ef1d096ddc fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
- replaced osl_trace with sal_info
 - added new log areas to log-area.dox

Change-Id: Ib47c4b4c9604bca1f8a635dd01bb89702b47b591
Reviewed-on: https://gerrit.libreoffice.org/2010
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-02-19 16:02:40 +00:00
Noel Grandin
fbd4588afd fdo#46808, convert io::TextOutputStream service to new-style
Change-Id: I12af47afc21c2b646197893a77698f4e0818f94f
2013-02-11 08:02:15 +02:00
Noel Grandin
ff85e8319a fdo#46808, convert io::TextInputStream service to new style
Change-Id: Ida4abdd6587399aa8ade88af672bcb23ab7ea0f1
2013-02-11 08:02:15 +02:00
Noel Grandin
591ef78440 fdo#46808, Use singleton util::theMacroExpander new-style constructor
And deprecate the old-style service util::MacroExpander

Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-11 08:02:13 +02:00
Jean-Noël Rouvignac
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
Caolán McNamara
c25bee9ca3 make emailmerge work with python3 and python2 at the same time
Change-Id: I6289b522513a2fc86e261c85a04ca9c89fd55b63
2013-01-15 17:17:45 +00:00
Caolán McNamara
932e916a9c tidy mailmerge debuging messages
Change-Id: Ibca2af0efa448ed4c2c5b7ad73febf16cbf03480
2013-01-15 16:32:22 +00:00
Caolán McNamara
e48a060eb8 make emailmerge work for me with python3
Change-Id: I4f79aa69b39d2be8fcceacc90b858f116f875385
2013-01-15 14:58:06 +00:00
Ariel Constenla-Haile
8a324a3ba5 i118814 - Allow set connection timeout in Mail API
Conflicts:
	scripting/source/pyprov/mailmerge.py

Change-Id: I7a3eb3b29f41eed154abd45e1aa5be824983f5de
2013-01-15 14:58:05 +00:00
Ariel Constenla-Haile
a5cefd4007 i118791 - Encode ReadableName in UTF-8 only when necessary
Conflicts:
	scripting/source/pyprov/mailmerge.py

Change-Id: I5275bdbbc21f422248a32b824ea6de965c23abd0
2013-01-15 14:58:05 +00:00
Ariel Constenla-Haile
3f2f92b753 i118736 - i118787 : fix XMailMessage implementation in mailmerge.py
(cherry picked from commit 4166969f3b8ed05e91c10a724ce7bd39074012a1)

Conflicts:
	scripting/source/pyprov/mailmerge.py

Change-Id: I794735f02db1efe04b323fed9db5458242e5c16a
2013-01-15 14:58:04 +00:00
Michael Stahl
907b63a0f3 mailmerge.py: fix the debug strings again
Change-Id: Iceac0952b6fc9765cb12f6694260070c1c17296b
2013-01-14 20:06:08 +01:00
Michael Stahl
1a5b3d8e4d fdo#59249: mailmerge.py: adapt to changes in smtplib:
Apparently the login() method in Python 3.3 expects str arguments for
user and password, since it calls encode on them, but for Python 2.6 the
"encode" calls were explicitly added in the caller since login() does
not encode itself; add an ugly version check for that.

Change-Id: Iebfce44073a837e9cb845855ba448d5b6a2ebd11
2013-01-14 12:40:40 +01:00
Michael Stahl
b08dc0b777 Revert "fdo#59249: mailmerge.py: some more bytes vs. str mangling"
This reverts commit 9dec0c7901.

Was nonsense because login method actually expects "str" arguments.
2013-01-14 12:40:40 +01:00
Michael Stahl
9dec0c7901 fdo#59249: mailmerge.py: some more bytes vs. str mangling
Obvious problems are in debug code only.

Change-Id: I45aafb4f194a5a020bb95bd96c2d92ca7ee578f8
2013-01-11 19:08:24 +01:00
Stephan Bergmann
ac56d9373a Can't convert 'Enum' resp. 'bytes' object to str implicitly
...when you set dbg = True

Change-Id: Ifc170e9336a662dce2ae59227baf3bea692eedac
2013-01-11 18:32:04 +01:00