mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
393,295 Commits 1 Branch 0 Tags
dc6bf6c8ae94fd89f30e39d63dfe02fdb042e98d
Commit Graph

5341 Commits

Author SHA1 Message Date
Caolán McNamara
d6665da4ea Resolves: tdf#96251 address wizard crash when run from start center 
Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281
 2016-06-17 09:16:58 +01:00
krishna keshav
46e372a601 tdf#43157 Clean up DBG_ASSERT 
Change-Id: I2a7d5d507a875e555441a9d30d54e638e5dea026
Reviewed-on: https://gerrit.libreoffice.org/26099
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-06-13 11:57:03 +00:00
Noel Grandin
9f4e283fc8 loplugin:sallogareas 
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
 2016-06-13 10:25:40 +02:00
Caolán McNamara
7c98344565 Resolves: tdf#92478 avoid crash on using scanner on windows x64 
which appears to correspond to backtrace
http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d

Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0
Reviewed-on: https://gerrit.libreoffice.org/26197
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2016-06-12 13:48:56 +00:00
Noel Grandin
ab10f9fc11 convert DBG_ASSERT(false, to SAL_WARN( 
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c
Reviewed-on: https://gerrit.libreoffice.org/26187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-12 09:04:15 +00:00
Stephan Bergmann
177afb1ec3 Clean up uses of Any::getValue() in extensions 
Change-Id: I67b9127d8aa67a702086ef5bc61372ae54c2142e
 2016-06-10 18:55:25 +02:00
Michael Stahl
62d270116b tools: rename SvStream::Read/Write to ReadBytes/WriteBytes 
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a
Reviewed-on: https://gerrit.libreoffice.org/25972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-06-06 18:09:11 +00:00
Noel Grandin
9f138ffe9d remove unused constants in HRC files 
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1
Reviewed-on: https://gerrit.libreoffice.org/25817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:01:43 +00:00
Noel Grandin
0323253a7c remove some manual ref-counting 
triggered when I noticed a class doing acquire() in the
constructor and then release() in the destructor.

found mostly by
    git grep -n -B5 -e '->release()'

Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f
Reviewed-on: https://gerrit.libreoffice.org/25806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:01:34 +00:00
Caolán McNamara
ede8229983 DataAccess.xcs says xs:short not xs:int for this type 
noticed when examing tdf#96251

Change-Id: Iec8748ad323bcb59e8e1f6b4135b4a3b313a6e44
 2016-06-02 14:06:49 +01:00
Muhammet Kara
3498fd9fe9 Remove SetAccessibleRelationLabeledBy calls tdf#87026 
And make proper changes in the related .ui files

Change-Id: Iea998b6de25831c08950a8afa725713288113bfa
Reviewed-on: https://gerrit.libreoffice.org/25807
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-06-02 10:36:59 +00:00
Noel Grandin
b860b73f2b Convert VCL_MESSAGE to scoped enum 
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933
Reviewed-on: https://gerrit.libreoffice.org/25720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-01 06:46:29 +00:00
Michael Stahl
c11e60f11f tdf#99643 OLE automation bridge: fix 64-bit pointer conversions 
XBridgeSupplier2::createBridge() is always called in-process and should
therefore expect and create Anys with native-sized encoded pointers,
so use sal_uIntPtr.

Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63
Note: Currently all calls in LO code are with source=UNO, target=OLE.
 2016-06-01 00:11:10 +02:00
Noel Grandin
0b23eec200 teach refcounting clang plugin about uno::Reference 
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-31 06:25:45 +00:00
Stephan Bergmann
8fec9e7e4c Some clean up of uses of css::uno::Any::setValue 
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
 2016-05-30 15:14:03 +02:00
Noel Grandin
c47b170c71 Convert SelectionMode to scoped enum 
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1
Reviewed-on: https://gerrit.libreoffice.org/25611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-30 06:41:28 +00:00
Noel Grandin
06cb2df4db Convert VclAlign to scoped enum 
Change-Id: I03718cc63ec5c1260ebd599bddb1a787ca8f5788
Reviewed-on: https://gerrit.libreoffice.org/25603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-30 06:36:21 +00:00
Noel Grandin
9eb2e683ab tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16) 
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.

Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-27 07:21:45 +00:00
Noel Grandin
74713b34a3 loplugin:unusedmethods 
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda
Reviewed-on: https://gerrit.libreoffice.org/25431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-26 07:50:33 +00:00
Caolán McNamara
07f1a39509 (nearly) nothing uses GetUniqueId anymore, so remove it. 
The odd one out is the usage in Formula, which attempts
to restore focus to a particular window identified by
an unique id. In this case restore focus by keeping a VclPtr
to the desired window.

Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
 2016-05-25 14:24:20 +01:00
Andrea Gelmini
2af018e4dd Fix typos 
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266
Reviewed-on: https://gerrit.libreoffice.org/25420
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-25 09:50:55 +00:00
Noel Grandin
95d20a3799 Revert "remove some manual ref-counting" 
until I have a better understanding of the UNO reference
counting.

This reverts commit 111de438ea.
 2016-05-24 11:02:42 +02:00
Noel Grandin
111de438ea remove some manual ref-counting 
triggered when I noticed a class doing acquire() in the constructor and
then release() in the destructor.

found mostly by
   git grep -n -B5 -e '->release()'

Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f
Reviewed-on: https://gerrit.libreoffice.org/25363
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-24 06:54:06 +00:00
Stanislav Horacek
fcec7522c1 tdf#97221 restore original message for failed check of update 
the message is not specific for server errors

Change-Id: If282acfaefa4fc5843757dff730dd84ece528210
Reviewed-on: https://gerrit.libreoffice.org/25217
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2016-05-21 06:52:36 +00:00
Noel Grandin
2383d557e5 clang-tidy misc-unused-alias-decls 
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124
Reviewed-on: https://gerrit.libreoffice.org/25075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 13:07:28 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Noel Grandin
d96c114171 clang-tidy modernize-make-shared 
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 06:58:44 +00:00
Andrea Gelmini
a9ff36a1e9 Fix typos 
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595
Reviewed-on: https://gerrit.libreoffice.org/25025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-05-16 06:18:47 +00:00
Noel Grandin
1342818790 convert SFXWB file dialog flags to scoped enum 
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b
Reviewed-on: https://gerrit.libreoffice.org/24881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 06:57:19 +00:00
Michael Stahl
eca8497238 sd: remove pointless micro-optimization 
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
 2016-05-11 14:10:51 +02:00
Stephan Bergmann
14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro 
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
 2016-05-10 16:42:16 +02:00
Noel Grandin
50ac0f503b convert FONT_EMPHASIS_MARK to scoped enum 
Change-Id: I137c78b337e57d3442db08334128e79d186b278f
Reviewed-on: https://gerrit.libreoffice.org/24753
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-09 09:41:34 +00:00
Stephan Bergmann
b57184b2fb Better fix for Windows-only code 
Change-Id: I8437ec66b615754d71c726f715a6beeb4a0f7dda
 2016-05-04 15:47:48 +02:00
Stephan Bergmann
cbc68e2787 Fix Windows-only code, part 3 
Change-Id: I1a87cb1b8c5b5603c4043cd2d5de37a336ad88b6
 2016-05-04 13:24:32 +02:00
Stephan Bergmann
6d1c52c5f7 Fix Windows-only code, part 2 
Change-Id: I5e860cd88e851b7bce5fa503108ffe61a36c0817
 2016-05-04 13:16:36 +02:00
Stephan Bergmann
f7b2782e24 Fix Windows-only code 
Change-Id: Iaf6d668f65e31c60dba8140d789f6578ef461264
 2016-05-04 13:06:12 +02:00
Stephan Bergmann
6e70103da0 While at it, delete Any functions on sal_Bool* 
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of
sal_Bool across the code base

Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
 2016-05-04 11:59:23 +02:00
Stephan Bergmann
69a62d4dc1 NULL -> nullptr 
Change-Id: I94d0df867b6ef59cf6485e4cee7ac655155f9b87
 2016-05-03 15:56:18 +02:00
Stephan Bergmann
a6960391ac NULL -> nullptr 
Change-Id: I0bd2dc2e2ed1f699133e3e7753359b969fbee322
 2016-05-03 15:45:13 +02:00
Stephan Bergmann
0b1e4a3067 Prevent Any::setValue from reinterpreting bool* as sal_Bool* 
...which only happens ot work in environments where sizeof (bool) == 1.  The
simpler alternative is to use the operator <<= template without passing explicit
UNO type information, anyway.

The std::nullptr_t overloads are needed to disambiguate calls with a nullptr
argument.  (Which can at least be meaningful for VOID, but for other types what
it happens to do is store a default value of the given type.)  As std::nullptr_t
is only C++11, this all needs to be LIBO_INTERNAL_ONLY.

Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
 2016-05-03 15:26:01 +02:00
Noel Grandin
82e9cfc991 use Any constructor for bool values, instead of temporary vars 
mostly found with:
   git grep -n 'setValue.*cppu.*UnoType.*bool.*get'

Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5
Reviewed-on: https://gerrit.libreoffice.org/24464
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-03 07:26:26 +00:00
Julien Nabet
998adf0b8b Typo: OAddessBookSourcePilot->OAddressBookSourcePilot 
Change-Id: I26587b761c91433fe80b9439e7e7c5e420db6192
Reviewed-on: https://gerrit.libreoffice.org/24552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-05-01 12:29:41 +00:00
Andrea Gelmini
fc2590cfa1 Fix typos 
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-30 15:06:45 +00:00
Muhammet Kara
376c337d46 tdf#97087 Give comprehensible, unique names to idles 
Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-04-28 09:34:30 +00:00
Stephan Bergmann
81105d9534 -Werror,-Wvarargs 
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"

just drop the variadic overload and use the one taking a WizardPath (i.e., a vector)

Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
 2016-04-27 13:47:30 +02:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Noel Grandin
17c4f7f0bc clang-tidy modernize-loop-convert in e* 
Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de
Reviewed-on: https://gerrit.libreoffice.org/24384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 07:43:58 +00:00
Stephan Bergmann
c21bc9e5aa Some more sal_Bool -> bool 
Change-Id: I2dcc7bb0c8d5a6e205d627330735237f85fd9f9f
 2016-04-25 16:41:02 +02:00
Stephan Bergmann
64d4e2a4c9 Avoid reserved identifiers 
Change-Id: I5a68cac4f923218a000c79a01c436bf1dc897971
 2016-04-22 10:18:32 +02:00
Andrea Gelmini
20f23c1a28 Fix typos 
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4
Reviewed-on: https://gerrit.libreoffice.org/24257
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2016-04-21 20:36:29 +00:00