mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
393,295 Commits 1 Branch 0 Tags
dc6bf6c8ae94fd89f30e39d63dfe02fdb042e98d
Commit Graph

175 Commits

Author SHA1 Message Date
Caolán McNamara
a7415828b8 Revert "tdf#88206 Change use of cppu::WeakImplHelper*" 
this doesn't build, I think mysqlc is considered !LIBO_INTERNAL_ONLY
seeing as its an extension

This reverts commit 2d2a33934e.

Change-Id: I600b986632b90e482475628e09256ca5c2b0a6cf
 2016-06-09 10:25:49 +01:00
krishna keshav
2d2a33934e tdf#88206 Change use of cppu::WeakImplHelper* 
removed <cppuhelper/implbase1.hxx>

Change-Id: I2888e42eec480f0940c3e4f9bcc000c150d1161b
Reviewed-on: https://gerrit.libreoffice.org/26076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-06-09 07:10:15 +00:00
Stephan Bergmann
336b62080b Missing include 
Change-Id: Id61e2de27ec307fa7773d3f0d5a0810005f1c364
 2016-05-30 13:33:37 +02:00
Stephan Bergmann
fcbd824f1b Use BOOST_FALLTHROUGH in external code 
...in preparation of enabling Clang's -Wimplicit-fallthrough

Change-Id: If64f9b18591b3cd2528adc6c2d6011d509d4afcd
 2016-05-10 15:25:12 +02:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Stephan Bergmann
235b1f3dfd Avoid reserved identifiers 
Change-Id: Id2ef8fb53207be64d0f7342734f0d9fab832b674
 2016-04-22 16:34:33 +02:00
Stephan Bergmann
227f6998d5 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Ie511eeb586e8c592bc255a09eff1bcf673a29ea9
 2016-04-20 17:25:45 +02:00
Jochen Nitschke
150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Stephan Bergmann
553f7e515d Revert "tdf#88206: use variadic variants for cppu helper" 
This reverts commit cf1ecad26d. Library_mysqlc is
external_code, so cannot use these LIBO_INTERNAL_ONLY features.
 2016-04-12 09:29:59 +02:00
Stefan Weiberg
cf1ecad26d tdf#88206: use variadic variants for cppu helper 
Change-Id: I58a00f721cbb37f97fdbc599d57c26b1e89f4c73
Reviewed-on: https://gerrit.libreoffice.org/23998
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-04-11 16:25:08 +00:00
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes 
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-02 19:01:24 +00:00
Noel Grandin
d298cfd986 loplugin:unuseddefaultparams in mysqlc 
Change-Id: I83e27ed242b6ec1fbd19e473a4d8c0f4588e6f86
 2016-03-03 08:13:14 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
a7f6efc68b loplugin: unused return values 
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af
Reviewed-on: https://gerrit.libreoffice.org/21571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-18 12:50:09 +00:00
Caolán McNamara
0aa5414015 cppcheck: noExplicitConstructor 
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2
Reviewed-on: https://gerrit.libreoffice.org/21245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-01-08 17:15:04 +00:00
Noel Grandin
33fac48280 loplugin:unnecessaryvirtual 
and unwind some apparently now unused VCL OpenGL and GlyphCachePeer
stuff.

Change-Id: Ic85302d4e1ad4056dabc49c97a608891052e3167
Reviewed-on: https://gerrit.libreoffice.org/20920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-12-24 20:57:35 +00:00
Noel Grandin
1b80ad7246 loplugin:unusedfields in lingu,lotuswordpro,mysqlc 
Change-Id: I5866c8d95e04714e81a45e73bf00a430859a4327
 2015-12-22 10:16:36 +02:00
Noel Grandin
e18b08363a loplugin:unusedmethods 
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
 2015-12-21 10:20:31 +02:00
Stephan Bergmann
fb8a3fac5d loplugin:nullptr: More NULL -> nullptr automatic rewrite 
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
 2015-12-10 08:06:06 +01:00
Noel Grandin
ec3f724158 loplugin:unusedfields 
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
 2015-11-30 10:34:38 +02:00
Noel Grandin
1f86864e97 loplugin:unusedfields various 
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
 2015-11-25 13:57:29 +02:00
Noel Grandin
773a07a94e fix mysqlc build 
after my commit 96c26b0d9d
"use initialiser for Sequence<OUString>"

the mysqlc module is compiled as external code, so it
cannot see the initialiser syntax constructor for Sequence

Change-Id: I072e6271ec33637e28dd8225724296e90967329d
 2015-11-16 08:34:54 +02:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Stephan Bergmann
1ddbbfdda8 loplugin:nullptr (automatic rewrite) 
Change-Id: Ie77375d781164232ea0cd94c3d2a5d027c49669e
 2015-11-10 10:31:32 +01:00
Michael Stahl
8e2852428d mysqlc: -Werror=unused-function 
Change-Id: I8b1f4b7c78a10ce604a63aff47d2df2d1d10dc26
Reviewed-on: https://gerrit.libreoffice.org/19800
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-11-05 13:25:32 +00:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Noel Grandin
c733be973e com::sun::star->css in lotuswordpro,mysqlc,oox 
Change-Id: Id99ff87c4eb3f1b36702261ce63d5d2793ea35d7
 2015-10-23 14:37:31 +02:00
Noel Grandin
2f3ea8dfbc refactor out some com::sun::star typedefs 
which mostly serve to make the code harder to read

Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
 2015-10-21 14:17:56 +02:00
Noel Grandin
56e6f0da83 new loplugin: badvectorinit 
look for places calling the 1-argument vector fill constructor and then
immediately called push_back, which is generally a sign that its
leaving empty slots.

Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517
Reviewed-on: https://gerrit.libreoffice.org/17525
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2015-10-20 11:35:31 +00:00
Caolán McNamara
eaf2c27888 boost->std 
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
 2015-09-17 11:00:51 +01:00
Stephan Bergmann
112286d2ef Revert "mysqlc: tdf#88206 replace cppu::WeakImplHelper* etc." 
This reverts commit 7fa5f876fd,
which uses LIBO_INTERNAL_ONLY features in external code.
 2015-08-24 08:28:57 +02:00
Takeshi Abe
7fa5f876fd mysqlc: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: If0eccdcb56f8196db5eea539eb54dd145ac57a8d
Reviewed-on: https://gerrit.libreoffice.org/17918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-22 15:53:18 +00:00
Stephan Bergmann
e2462a3897 loplugin:simplifybool 
Change-Id: I2520ff8ca5f9c0dd68cc4c5cdc377d455c87898d
 2015-07-16 14:00:18 +02:00
Caolán McNamara
8a3120ced5 cppcheck: noExplicitConstructor 
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
 2015-06-11 14:56:14 +01:00
Stephan Bergmann
948a3ece9a loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I18ea5378c165912e988d0c951aab3d83754cf6ca
 2015-06-08 16:26:34 +02:00
Stephan Bergmann
ecad097109 Remove dead code 
Change-Id: Id2b755c500c32392cdb5cc84ee901f0737347350
 2015-05-08 14:37:28 +02:00
Stephan Bergmann
c215ca9197 css.sdbc.XResultSetMetaData.isNullable return type is long (oddly enough) 
Change-Id: I6ca98540a623f921f8d05e71dc67b64948467f52
 2015-05-08 09:49:03 +02:00
Michael Meeks
af48ad2120 fix erroneous disposeOnce calls. 
Change-Id: I4ce39e6d6534d1481f7e6b759d61040606da839c
 2015-04-28 15:34:54 +01:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Stephan Bergmann
2339a5bd50 More loplugin:simplifybool 
Change-Id: Ic26c9e044b0e2225db8e218f39409338a69e7047
 2015-04-27 15:30:59 +02:00
Stephan Bergmann
39950c5b7c loplugin:simplifybool 
Change-Id: Icbd2ce16467c574243d223ae68e79ca043a2ca45
 2015-04-24 12:36:24 +02:00
Stephan Bergmann
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs. 
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
 2015-04-23 18:39:07 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
373a9b9bb6 loplugin:redundantcast: redundant const_cast followed by implicit upcast 
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
 2015-04-13 12:36:36 +02:00
Noel Grandin
d7a84ce840 vclwidget: only call dispose() once 
by using a new utility method in vcl::Window
This means that we don't have to make all our dispose
methods safe to call more than once.

Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
 2015-04-10 10:55:36 +01:00
Stephan Bergmann
caebe97223 Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: I5ce90c5eec46e490f7d38a4f603285d2753ce0d1
 2015-04-01 08:40:06 +02:00
Stephan Bergmann
693002e16c Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I161e6b396e6577dfc4b3c38bf89ed5ecd1dd5f42
 2015-03-31 13:15:04 +02:00
Stephan Bergmann
a52cf476e7 Clean up template-parameter-dependent C-style casts 
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
 2015-03-29 15:13:45 +02:00
Stephan Bergmann
d081dda43f loplugin:constantfunction 
Change-Id: I368de78b99369982cd17a8e7ac8c36b4e7e60b41
 2015-03-25 12:46:55 +01:00