If the paragraph itself inherits BiDi from the environment,
this just means that it gets the value of the paragraph style.
If paraStyle is defined, then we don't need to spam the bidi
property, since it ought to naturally inherit it.
I can only see two possible problems. Either my logic is wrong,
or else import might not always take the paragraph style
into account (for determining the meaning of justify for example).
I want to start spamming justify in the case where the BiDi is not
specified but is inherited from the environment (page style
or AppLanguage). Separating this into multiple patches
will help for debugging in case of any regressive tendencies.
related to tdf#98620.
Change-Id: I36bc63e6659a4b491b5c6f2c99c72ba5bb715a07
Reviewed-on: https://gerrit.libreoffice.org/66921
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
The context in the mxContext member does not seem to be usable for
what we need it for here. Using what
comphelper::getProcessComponentContext() returns works better. Let's
hope it has no unintended side-effects.
This likely makes the mxContext member unused, but I did not bother
removing it yet, to keep this commit minimal.
Change-Id: Ic048683b066af7952e2e84b03ea306e7daaba259
Reviewed-on: https://gerrit.libreoffice.org/68592
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Instead of showing the tracked deletion as tracked
insertion, losing the original and actual text contents,
now w:del within w:ins is imported as tracked deletion
correctly.
Change-Id: I40694a3a73ad4cd443254167462520c17b1bd484
Reviewed-on: https://gerrit.libreoffice.org/68478
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Move XNameAccess Java tests to C++ for ScDataPilotItemsObj.
Change-Id: Id8e83bb68408600f471148df7527467a371590fb
Reviewed-on: https://gerrit.libreoffice.org/68611
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XIndexAccess Java tests to C++ for ScDataPilotItemsObj.
Change-Id: I66888c4515e84cf0e8f051378616c0ecbf60c0e8
Reviewed-on: https://gerrit.libreoffice.org/68610
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XEnumerationAccess Java test to C++ for ScDataPilotItemsObj.
Change-Id: I6123692aee130f4c5bf326676ace2a6e7ac09405
Reviewed-on: https://gerrit.libreoffice.org/68609
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XElementAccess Java tests to C++ for ScDataPilotItemsObj.
Change-Id: Ideb56b3f24d9b6045f68d7e5e84ee9858b6df7bf
Reviewed-on: https://gerrit.libreoffice.org/68608
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
This patch improves the new background tab page use for setting Writer
table cell, row, and table backgrounds. Now cell, row, and table
backgrounds fill tab page according to the fill style of each and can
all be set in the same opening of a Table Properties dialog. This patch
also makes the Reset reset background settings to initial settings of
dialog opening.
Change-Id: I567ef9229232f02d98b45a81309e920dca854bed
Reviewed-on: https://gerrit.libreoffice.org/66844
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...at least some of which have presumably been missing from
ce43d0ae92 "use consistent #define checks for the
Windows platform" by accident (and some just clean up comments)
Change-Id: I5532685c7df96ae3c8a25b73d8064d7433964a9b
Reviewed-on: https://gerrit.libreoffice.org/68580
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
They had been added back in the day with
0c0c6f2727 "INTEGRATION: CWS swwarnings"
(adressing "#i69287# warning-free code"), but don't seem to actually silence any
warnings, at least nowadays. Better to keep such narrowing casts implicit, so
that tools like Clang's -fsanitize=implicit-integer-truncation can detect cases
at runtime where a too-large value erroneously gets truncated by such a cast.
Change-Id: I3bba6fff034e544cd935c0c4dbc98989052add5e
Reviewed-on: https://gerrit.libreoffice.org/68541
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
At least when CppunitTest_sw_filters_test tries to load
sw/qa/core/data/ww6/pass/crash-2.doc, Clang's
-fsanitize=implicit-signed-integer-truncation flags an "implicit conversion from
type 'unsigned int' of value 49197 (32-bit, unsigned) to type 'short' changed
the value to -16339 (16-bit, signed)" when multiplying nFSize by 10. That
document is obviously broken, LO emits lots of SAL_WARN like
"sw/source/filter/ww8/ww8scan.cxx:802: Unknown ww7- sprm, dangerous, report to
development", and at least MS Word for Mac Version 16.21 refuses to open it at
all. But even if the value of nFSize computed here is obviously way too large,
that variable is only passed into SvxFontHeightItem's sal_uLong nSz parameter,
so it can just as well be of type sal_uLong too.
Change-Id: I2e3b9152adce9c928df2276ebb2e9d526553e541
Reviewed-on: https://gerrit.libreoffice.org/68538
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
ScDocument dtor calls ClearLookupCaches(), which calls GetNonThreadedContext().
But ScDocument instances used for copy&paste GetFormatTable() fails
on null mxPoolHelper, because ScDocument ctor doesn't set it in such a case.
So set up the pointer in ScInterpreterContext on demand only if actually
needed.
Change-Id: If3811da5bb00a2d7d404c089ee1bf46037a2cddb
Reviewed-on: https://gerrit.libreoffice.org/68350
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Move XNamed Java tests to C++ for ScDataPilotFieldGroupItemObj.
Change-Id: I1070f99e2e1655f72c1a6ffaf3f61618b083140e
Reviewed-on: https://gerrit.libreoffice.org/68525
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
which is supposed to make the dialog resizable, but was silently ignored.
Change-Id: Ifa2d2ea70c769f7785ac044ab2b681802c54bc17
Reviewed-on: https://gerrit.libreoffice.org/68515
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Correct class name to mirror the name of object we are testing against.
Change-Id: Id89f29843045182bc01d48e7368648ede886d963
Reviewed-on: https://gerrit.libreoffice.org/68524
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
This patch replaces SwFEShell::SetTableStyle use to resolve tdf#108227
with SwTable::SetTableStyleName. The gain in insert speed is a result of
eliminating SwFEShell::SetTableStyle call to the time consuming
SwFEShell::UpdateTableStyleFormatting function which is somewhat
redundant when inserting a table.
Change-Id: Ide1e003d9709a6758e021b52fcf9e40a7b0fcba0
Reviewed-on: https://gerrit.libreoffice.org/68372
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Add test XNameContainer::testRemoveByNameNoneExistingElement to get the
same coverage as before when these case where split with commit
4b98337699.
Change-Id: I45ba5af4e2b3137d9379623556ce4129a860e696
Reviewed-on: https://gerrit.libreoffice.org/68477
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Unintentionally formatted these files with commit
4b98337699 with my Vim set up (better keep
them formatted then revert everything).
Change-Id: Ie017fae2bdf952a5d0313d8b5654813ff8d402ad
Reviewed-on: https://gerrit.libreoffice.org/68476
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
