395194 Commits

Author SHA1 Message Date
Giuseppe Castagno
e0eb85785b tdf#101094 (14) OPTIONS: Options cache removal: PUT
Change-Id: I251bbb101b4be851deaab66cbe4e10ff1fa3376e
Reviewed-on: https://gerrit.libreoffice.org/27691
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 16:39:04 +00:00
Giuseppe Castagno
dfb714183f tdf#101094 (13) OPTIONS: Options cache removal: LOCK, UNLOCK
Change-Id: Ib5e52973252b3af7b0fbe440806eb1e669670299
Reviewed-on: https://gerrit.libreoffice.org/27686
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 16:38:08 +00:00
Eike Rathke
5cf5975cef limit SelectionFillDOOM to 24117248 cells, tdf#60021 tdf#60056 related
Change-Id: Idabf5e51b7f423d7d58094ad1caef166728c3bed
2016-07-29 18:25:28 +02:00
Caolán McNamara
1203bf57de Related: tdf#99324 get backingwindow to honour auto mnemonic on mod key change
Change-Id: I533232729db4a6ad5812d18bb63c36f7401066c0
2016-07-29 17:19:20 +01:00
Caolán McNamara
f305b88286 unhook the alt handling thing from SystemWindow
so it could be used from things that aren't dialogs

Change-Id: I649c5a05ad9c0634be9cef2bbe16a4643e58fc12
2016-07-29 16:36:36 +01:00
Giuseppe Castagno
37ada6f457 tdf#101094 (12) OPTIONS: Add options cache ctrl in getResourceOptions
Change-Id: If4f53e8efc51e5ec33747dfcbe8f4294bbd6160b
Reviewed-on: https://gerrit.libreoffice.org/27685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 15:07:21 +00:00
Rishabh Kumar
7f262a4101 [GSoC] Fix recent colors in color popup widget
Save recent colors in user configuration.

Change-Id: I1637e9fe3150bd1892f72ff9df06dc2a7c3e1e9e
Reviewed-on: https://gerrit.libreoffice.org/27688
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 14:52:56 +00:00
Caolán McNamara
bb01247f71 Related: tdf#99324 accel underlines don't appear in hyperlink dialog
Change-Id: Ib16b239c88b1d1157fc18bc62b5f01c52e896a48
2016-07-29 15:28:34 +01:00
Caolán McNamara
a32c0828f6 Related: tdf#99324 accel underlines don't appear in options dialog
Change-Id: I47cb6df2118ea86dea7225842dcdc4c1dafc439f
2016-07-29 15:26:01 +01:00
Caolán McNamara
6da9e55fb6 this NOCOMMAND is never defined
Change-Id: I6a2ae90182eaeb534176dd0a2591bfe0c2242a5c
2016-07-29 15:18:42 +01:00
Caolán McNamara
94165d249e assert from unsorted sid array
Change-Id: I9f4d6274581bc800c8404fcbbe2369aa42d05302
2016-07-29 14:52:13 +01:00
Giuseppe Castagno
2c0b4ff238 tdf#101094 (11): Add WebDAV options cache configuration param.
Added in officecfg five new properties to be able to set
cache lifetime if needed.

The new properties are available in advanced, expert configuration only,
in org.openoffice.Inet.Settings.

Default values are as follows (value is in seconds):
    OptsCacheLifeImplWeb = 300
        when the web resource is Web only, implementing OPTIONS.
        Min. 0 sec (no caching) max. 3600 sec (1h).

    OptsCacheLifeDAV = 60
        when the web resource is WebDAV.
        Min. 0 sec (no caching) max. 3600 sec (1h).

    OptsCacheLifeDAVLocked = 600
        when the web resource is WebDAV and it's locked by
	this LO instance (e.g. lock store has a lock to it).
        Min. 0 sec (no caching) max. 3600 sec (1h).

    OptsCacheLifeNotImpl = 3600
        when the web resource does not implement OPTIONS method.
        Min. 0 sec (no caching) max. 43200 sec (12h).

    OptsCacheLifeNotFound = 15
        when the requested web resource is not found on server.
        Min. 0 sec (no caching) max. 30 sec.

Change-Id: I719b97645e1d91a29134820b77678fd88fcb9ac2
Reviewed-on: https://gerrit.libreoffice.org/27684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 13:36:30 +00:00
Caolán McNamara
ee79a2dd7e Resolves: tdf#101169 crash using column menu in base
Change-Id: Ia4ce895d3562b29db648a7b568121a2867088493
2016-07-29 14:33:22 +01:00
Caolán McNamara
fa293f7d67 use div() instead of /0 to content ubsan
for the same reason as...

commit fb2c146752074b132d665e40343a08dcb2e6672e
Author: Eike Rathke <erack@redhat.com>
Date:   Mon Jul 25 13:32:17 2016 +0200

    use div() instead of /0 to content ubsan

    While we do handle double floating point division by 0 at least on
    IEEE754 systems, ubsan builds mock about.

Change-Id: I2c96b63a4af3cb2e8483a1d0f2da91ea82da227c
2016-07-29 14:30:36 +01:00
Eike Rathke
77327759c9 disallow Random Number when entire sheet is selected, tdf#60056 related
Change-Id: Ie9e229c3d3e5a5a7e3f3e90ebd181471927bd452
2016-07-29 15:19:44 +02:00
Eike Rathke
c729ee7622 Resolves: tdf#60056 disallow Fill when entire sheet is selected
Change-Id: I866f84d72c27be962dbad8f8e4dcb345aa336bff
2016-07-29 15:10:43 +02:00
Miklos Vajna
410382a423 connectivity: fix loplugin:cppunitassertequals warnings
Change-Id: Iad115345c061074da89746de8a9d2af2eb78802c
Reviewed-on: https://gerrit.libreoffice.org/27679
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 12:59:39 +00:00
Miklos Vajna
7494466e43 svl: add SfxUndoAction::GetViewShellId()
In preparation of a Writer version that overrides this and remembers
which view shell introduced which action.

Change-Id: I4970f8ce9c56f1b57ab1ae92f3ea8be804ca27bf
Reviewed-on: https://gerrit.libreoffice.org/27682
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 12:49:34 +00:00
Caolán McNamara
a840b2526b only map GDK_SUPER_MASK to KEY_MOD3 and not GDK_META_MASK
on wayland I'm getting a GDK_MOD1_MASK and a GDK_META_MASK
on pressing the left alt. The check for KEY_MOD2 in
Window::KeyInput trips up with the extra KEY_MOD3 bit set
so the auto mnemonic underlines don't appear on pressing
left alt under wayland

Lets map only GDK_SUPER_MASK to KEY_MOD3

Change-Id: I1e9cc9fc095f5edfa7ad7c71440232c6de1ecf04
2016-07-29 12:47:00 +01:00
Giuseppe Castagno
b641d83bb9 tdf#101094 (10) OPTIONS: Add a simple options cache class
Added behavioral unit tests as well.

Change-Id: I30f84c8f814d3460a421428ebe0d2fbc32c5c433
Reviewed-on: https://gerrit.libreoffice.org/27668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 11:45:01 +00:00
Miklos Vajna
389d4d4142 sfx2: introduce SfxViewShell::GetViewShellId()
This is quite similar to SwFrame::GetFrameId(), i.e. it assigns a
numeric identifier to each instance to help debugging, as those
identifiers are stable accross runs.

Change-Id: I9cc57e316435f0284a1d481a956a703be859d67e
Reviewed-on: https://gerrit.libreoffice.org/27669
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 11:39:22 +00:00
Eike Rathke
4b90c9dc83 move range detection to ScViewData::SelectionFillDOOM()
Change-Id: Ic5205428136fc323affed8d956d6ee0434d43988
2016-07-29 13:34:35 +02:00
Caolán McNamara
9a40590d0c this 0x4000 means KEY_MOD2
Change-Id: Id260c776241cfa5af35c51ccee7ba6942a353f8d
2016-07-29 12:20:49 +01:00
Giuseppe Castagno
be47f60b51 tdf#101094 (9) OPTIONS: Add options check in Content::getProperties
Change-Id: I1937d51158f67055ed4bbeb60dafbf8ffee090ae
Reviewed-on: https://gerrit.libreoffice.org/27667
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 11:13:14 +00:00
Caolán McNamara
1d81d868d2 strangely misplaced modeline
Change-Id: I4c8dabbd2eeac2e3edb72a426687af8692c77497
2016-07-29 11:24:31 +01:00
Michael Stahl
a2095b1514 comphelper,vcl: let DeInitVCL() join some AsyncEventNotifier threads
comphelper::AsyncEventNotifier is an amazing class that dispatches
events in separate threads, no doubt implemented during times of
exuberant optimism about the tractability of shared-state
multi-threading.

Unfortunately the authors forgot to think about how all those awesome
threads will be joined, so if they are somehow blocked, then it may well
happen that the events are dispatched when the main thread is already in
DeInitVCL, and the objects required for the dispatching already smell
somewhat funny.

This happens quite reproducibly when changing dbaccess' ModelMethodGuard
to lock the SolarMutex too, then CppunitTest_dbaccess_RowSetClones
crashes in DeInitVCL() because one AsyncEventNotifier thread was blocked
until then by SolarMutexGuard, and this test never Yields once its
document is loaded.

Try to fix this by joining the "DocumentEventNotifier" threads from
DeInitVCL() itself.

Since there's no rtl::WeakReference to go with rtl::Reference, refactor
the AsyncEventNotifier and create a new AsyncEventNotifierAutoJoin
that has to be used with std::shared_ptr and std::weak_ptr.

Change-Id: I50a0749795acb04b0776e543f7125767b697ea35
Reviewed-on: https://gerrit.libreoffice.org/27581
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-29 10:05:47 +00:00
Caolán McNamara
b3b7669e7f Resolves: tdf#96677 effects page didn't link labels to what they labelled
Change-Id: I29503324f221c42208267f4f0d36922e89119fdd
2016-07-29 10:58:17 +01:00
Caolán McNamara
3a0aad2f5d Related: tdf#90450 don't overwrite text in size/pos statusbar item
there still isn't enough space for it in writer, but at least
what is there can be read.

I'd love to get this info out of the status bar and into some
overlay shown in the selection when moving the object.

Change-Id: I688690a57253d3774c06f5edcb0931503c6d2ac6
2016-07-29 10:49:30 +01:00
Caolán McNamara
4b73aff7d2 VclPtr: password prompts never dispose
Change-Id: I917e5457be6de152b39e91ad41b6ed196dfe3e45
2016-07-29 10:08:25 +01:00
Caolán McNamara
2a66c02553 Resolves: tdf#84121 wrong password passed to xpdfimport
regression from...

commit eb276d11a652601f743d69ada7a38016bd97d73e
Author: Fridrich Štrba <fridrich.strba@bluewin.ch>
Date:   Mon Jul 8 14:01:17 2013 +0200

    fdo#38878: Upgrading internal xpdf -> poppler

before this the hashed _OOO_pdfi_Credentials_ was used
in the removed OOoImportSecurityhandler::authorize

but after this the hashed password continued to be
passed through stdin, while the unhashed password
was the required data.

Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
2016-07-29 10:00:59 +01:00
Noel Grandin
9da4c9bc71 loplugin:staticmethods
Change-Id: If32319c1d93756d633f07a21c76e0107181704b0
2016-07-29 10:32:41 +02:00
Noel Grandin
8ff6ba3da8 loplugin:cstylecast
Change-Id: I3adb510be10b12953e2889d0d3b74402479194ee
2016-07-29 10:32:41 +02:00
Caolán McNamara
f9ae1b31f7 fftester: another null DestinationText
Change-Id: I84bf3788ac092c491d7c5a9f86421f1cf9f3e814
2016-07-29 09:20:32 +01:00
Caolán McNamara
0dd2216534 fftester: null DestinationText
Change-Id: Icdd71733c4e9f4b36e6e957e4dea772087890faa
2016-07-29 08:50:31 +01:00
Giuseppe Castagno
6ab2cabeae tdf#101094 (8) OPTIONS: Add options check in Content::resourceTypeForLocks
Change-Id: Ia1bcc1be9e61626da2d60ea679d4b6e7e114ac9f
Reviewed-on: https://gerrit.libreoffice.org/27661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 07:10:23 +00:00
Miklos Vajna
73cd9c480c xmlsec: xmlsec1-keyinfo-revert.patch.1 is not needed on WNT
Change-Id: I1dbb6bf57dc78f321e6e6d69b7e573309aff8f48
Reviewed-on: https://gerrit.libreoffice.org/27658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-29 07:09:26 +00:00
Miklos Vajna
73c8bc849c sw layout xml dump: mention SfxViewShell addresses
Change-Id: I2e5c8102684494fd3d7c1c70971a09d0c940a124
Reviewed-on: https://gerrit.libreoffice.org/27637
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 07:08:00 +00:00
Noel Grandin
27319418ed loplugin:countusersofdefaultparams in store..svtools
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6
Reviewed-on: https://gerrit.libreoffice.org/27580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29 07:07:13 +00:00
Giuseppe Castagno
fd586445a4 tdf#101094 (7) OPTIONS: Remove resourceTypeForLocks before unlock
Not needed, unlock() checks if a lock is present first.
If present, it means that LOCK is available, inferring the presence of
UNLOCK availability.

Change-Id: I007c4b02b27e8a40f15721c0308c894ad6f482fd
Reviewed-on: https://gerrit.libreoffice.org/27660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29 06:37:42 +00:00
Zdeněk Crhonek
f9a56767c6 add SUBTOTAL test case
Change-Id: I68a46cfad2cdc09c1963576275033ff40c678c04
Reviewed-on: https://gerrit.libreoffice.org/27655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-29 06:26:09 +00:00
Zdeněk Crhonek
dc2cf46e61 add sQRTPI test cae
Change-Id: I77ffd10e94ecebb045e0a9e7c756180790645885
Reviewed-on: https://gerrit.libreoffice.org/27651
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-29 06:25:53 +00:00
Zdeněk Crhonek
a6de813d71 add SIGN test case
Change-Id: Ica56ab0821718c75c902f97cad3d278cd568f157
Reviewed-on: https://gerrit.libreoffice.org/27644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-29 06:25:36 +00:00
Zdeněk Crhonek
eaa2dd78f6 add SUM test case
Change-Id: I0c322cb157b102faa8d5cfdeb696f7912d5aa720
Reviewed-on: https://gerrit.libreoffice.org/27656
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-29 06:25:13 +00:00
Zdeněk Crhonek
aea52b1cd3 add SIN test case
Change-Id: I439ded1581bcbe623abbcd2a1e51402689c56057
Reviewed-on: https://gerrit.libreoffice.org/27645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-29 06:24:23 +00:00
Caolán McNamara
f5fd2c66f6 set antialias once when context is created
Change-Id: Id36e716253768321e1ddfb977a22470c6b694147
Reviewed-on: https://gerrit.libreoffice.org/27510
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-29 01:55:53 +00:00
Takeshi Abe
b4e3c29f8a Fix typo: completelly -> completely
Change-Id: I566c5554bf32ea18121c5a186365b97c91667c5d
2016-07-29 10:07:33 +09:00
Zdeněk Crhonek
4bd54da674 add SINH test case
Change-Id: Ic82520cc0ff41ce9630460ffe6320f8f278f2bf8
Reviewed-on: https://gerrit.libreoffice.org/27646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-28 21:24:52 +00:00
Markus Mohrhard
776544f5e9 write the customWidth property also to XLS
Change-Id: I3d12e141e1cf6c70c3fbae7b6fb25a2fabeed77b
2016-07-28 23:23:49 +02:00
Bartosz Kosiorek
40d892a2db tdf#100946 Fix width calculation and add customWidth support (.xlsx)
On some MS Excel version (OS X), the column "width" is
not applied, if "customWidth" key (in "col") is not set to "true".
It means that in case of .xlsx files, exported by LibreOffice,
all columns have default width. To resolve that "customWidth"
key was added during export into .xlsx file format.
During development it appears that Default Column Width is wrongly
calculated, and it was done not according to MS documentation.
This issue was also fixed. After fix default column width is
properly set.
MS documentation:
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.column.aspx

Change-Id: I0d1944081a5ea445d1e4284db62e9b4d504bf1c0
2016-07-28 23:23:49 +02:00
Akshay Deep
72e6f08c69 GSoC Emoji Control
Tab Window
Add emoji.json to installation directory
Read the JSON data from code
Filter emojis according to categories
Insert Emoji at cursor position
Toolbar control

Change-Id: Ia5a577ce41398132872914ebfa499e4d4077d57e
Reviewed-on: https://gerrit.libreoffice.org/26700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-28 20:54:44 +00:00