Noel Grandin
e18b08363a
loplugin:unusedmethods
...
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-12-21 10:20:31 +02:00
Stephan Bergmann
fb8a3fac5d
loplugin:nullptr: More NULL -> nullptr automatic rewrite
...
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00
Noel Grandin
ec3f724158
loplugin:unusedfields
...
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-30 10:34:38 +02:00
Noel Grandin
1f86864e97
loplugin:unusedfields various
...
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
2015-11-25 13:57:29 +02:00
Noel Grandin
773a07a94e
fix mysqlc build
...
after my commit 96c26b0d9d10fa9bac3695222980d7145f0342d7
"use initialiser for Sequence<OUString>"
the mysqlc module is compiled as external code, so it
cannot see the initialiser syntax constructor for Sequence
Change-Id: I072e6271ec33637e28dd8225724296e90967329d
2015-11-16 08:34:54 +02:00
Noel Grandin
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Stephan Bergmann
1ddbbfdda8
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ie77375d781164232ea0cd94c3d2a5d027c49669e
2015-11-10 10:31:32 +01:00
Michael Stahl
8e2852428d
mysqlc: -Werror=unused-function
...
Change-Id: I8b1f4b7c78a10ce604a63aff47d2df2d1d10dc26
Reviewed-on: https://gerrit.libreoffice.org/19800
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-05 13:25:32 +00:00
Noel Grandin
3bc5df7f32
UNO: no need to use OUString constructor when calling createInstance
...
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30 08:59:59 +00:00
Noel Grandin
c733be973e
com::sun::star->css in lotuswordpro,mysqlc,oox
...
Change-Id: Id99ff87c4eb3f1b36702261ce63d5d2793ea35d7
2015-10-23 14:37:31 +02:00
Noel Grandin
2f3ea8dfbc
refactor out some com::sun::star typedefs
...
which mostly serve to make the code harder to read
Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-21 14:17:56 +02:00
Noel Grandin
56e6f0da83
new loplugin: badvectorinit
...
look for places calling the 1-argument vector fill constructor and then
immediately called push_back, which is generally a sign that its
leaving empty slots.
Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517
Reviewed-on: https://gerrit.libreoffice.org/17525
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-10-20 11:35:31 +00:00
Caolán McNamara
eaf2c27888
boost->std
...
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
2015-09-17 11:00:51 +01:00
Stephan Bergmann
112286d2ef
Revert "mysqlc: tdf#88206 replace cppu::WeakImplHelper* etc."
...
This reverts commit 7fa5f876fddfd4baeff01d74d26cbf1dc4607d18,
which uses LIBO_INTERNAL_ONLY features in external code.
2015-08-24 08:28:57 +02:00
Takeshi Abe
7fa5f876fd
mysqlc: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: If0eccdcb56f8196db5eea539eb54dd145ac57a8d
Reviewed-on: https://gerrit.libreoffice.org/17918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-22 15:53:18 +00:00
Stephan Bergmann
e2462a3897
loplugin:simplifybool
...
Change-Id: I2520ff8ca5f9c0dd68cc4c5cdc377d455c87898d
2015-07-16 14:00:18 +02:00
Caolán McNamara
8a3120ced5
cppcheck: noExplicitConstructor
...
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-06-11 14:56:14 +01:00
Stephan Bergmann
948a3ece9a
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I18ea5378c165912e988d0c951aab3d83754cf6ca
2015-06-08 16:26:34 +02:00
Stephan Bergmann
ecad097109
Remove dead code
...
Change-Id: Id2b755c500c32392cdb5cc84ee901f0737347350
2015-05-08 14:37:28 +02:00
Stephan Bergmann
c215ca9197
css.sdbc.XResultSetMetaData.isNullable return type is long (oddly enough)
...
Change-Id: I6ca98540a623f921f8d05e71dc67b64948467f52
2015-05-08 09:49:03 +02:00
Michael Meeks
af48ad2120
fix erroneous disposeOnce calls.
...
Change-Id: I4ce39e6d6534d1481f7e6b759d61040606da839c
2015-04-28 15:34:54 +01:00
Michael Meeks
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
Stephan Bergmann
2339a5bd50
More loplugin:simplifybool
...
Change-Id: Ic26c9e044b0e2225db8e218f39409338a69e7047
2015-04-27 15:30:59 +02:00
Stephan Bergmann
39950c5b7c
loplugin:simplifybool
...
Change-Id: Icbd2ce16467c574243d223ae68e79ca043a2ca45
2015-04-24 12:36:24 +02:00
Stephan Bergmann
2240118177
Improved loplugin:literaltoboolconversion looking into cond. exprs.
...
...automatic rewriter fixes
Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Stephan Bergmann
373a9b9bb6
loplugin:redundantcast: redundant const_cast followed by implicit upcast
...
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-13 12:36:36 +02:00
Noel Grandin
d7a84ce840
vclwidget: only call dispose() once
...
by using a new utility method in vcl::Window
This means that we don't have to make all our dispose
methods safe to call more than once.
Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
2015-04-10 10:55:36 +01:00
Stephan Bergmann
caebe97223
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: I5ce90c5eec46e490f7d38a4f603285d2753ce0d1
2015-04-01 08:40:06 +02:00
Stephan Bergmann
693002e16c
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I161e6b396e6577dfc4b3c38bf89ed5ecd1dd5f42
2015-03-31 13:15:04 +02:00
Stephan Bergmann
a52cf476e7
Clean up template-parameter-dependent C-style casts
...
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-03-29 15:13:45 +02:00
Stephan Bergmann
d081dda43f
loplugin:constantfunction
...
Change-Id: I368de78b99369982cd17a8e7ac8c36b4e7e60b41
2015-03-25 12:46:55 +01:00
Noel Grandin
ba233e87ef
remove unnecessary parenthesis in return statements
...
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Stephan Bergmann
35ce36b713
Some more loplugin:cstylecast: mysqlc
...
Change-Id: I7849658606931b231c2bde0c8143bc1f325c80d4
2015-01-20 09:06:49 +01:00
Noel Grandin
45ec1d9b56
brute-force find-and-remove of unused #define constants.
...
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
Stephan Bergmann
d5c86be04e
No need for RTL_USING in addition to LIBO_INTERNAL_ONLY
...
Change-Id: Iaa65658aed6bb4abb20a4d95dc9c6caf7c1c764b
2014-12-19 14:28:13 +01:00
Stephan Bergmann
6bca90dd62
mysqlc: loplugin:cstylecast
...
Change-Id: I293f6fc392f6d081d08d2f53886f534409e38bd5
2014-12-04 09:36:45 +01:00
Michael Stahl
a0eb1be3a9
mysqlc: fix build after cppuhelper header cleanup
...
Change-Id: I8d331914736e17d5aad2ee761fc6d758c2dea1ad
2014-11-18 23:38:33 +01:00
Brij Mohan Lal Srivastava
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Noel Grandin
705c48d32e
fdo#38835 strip out OUString globals
...
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Vinicius Vendramini
5c8ea6d943
fdo#83991 - cleanup whitespace after folding comment removal.
...
Change-Id: I31149484d626013ddcd52356be7d416b435cebcc
2014-10-23 10:39:22 +01:00
Vinicius Vendramini
f73112e229
fdo#83991 - remove redundant function folding comments.
...
Change-Id: I630aeedc31099e11d4bd0e91a05943e926efd61e
2014-10-22 12:03:35 +01:00
Stephan Bergmann
2bb99ca189
mysqlc: These shall be plain "Time" not "tools::Time" apparently
...
Change-Id: Id96a75bb8a07ea3b9701b9fe4692dfc81dbd8295
2014-10-01 10:35:31 +02:00
Noel Grandin
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
Stephan Bergmann
f94fffaf52
mysqlc: std::auto_ptr -> std::unique_ptr
...
Change-Id: I0eb5f9fab5955d1f5790d3f5d269e069aff1c201
2014-09-30 12:28:53 +02:00
Stephan Bergmann
9703cc63ce
Remove o3tl/heap_ptr.hxx, use std::unique_ptr instead
...
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
2014-09-24 14:54:51 +02:00
Michael Meeks
be75acefbc
Translate German comment.
...
Change-Id: I3d452ac218005b40568ec116ede9962cc1e60a18
2014-09-17 14:11:17 +01:00
Stephan Bergmann
dbf99dfb98
mysqlc: sal_Bool -> bool
...
Change-Id: Ie479e1671b03fbb958886d4c01ecff41b2ad1d23
2014-07-02 08:42:58 +02:00
Noel Grandin
6b50e21473
deb#749592 mysql-connector doesn't work with remote connections
...
and also
fdo#77584 mysql-connector doesn't work over SSH tunnel
Not sure exactly how this got broken, I suspect that the UI code
has started unconditionally passing down the properties, just filling
them with empty spaces for the unused ones.
Anyhow, this appears to fix the problem.
Change-Id: I7ac2a0d6bae610f47d2a28daa9beb3ef0e2dbb52
Reviewed-on: https://gerrit.libreoffice.org/9565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-30 08:24:31 -05:00
Noel Grandin
624a116d14
use OUString::startsWith()
...
Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
2014-05-29 09:01:40 +02:00