Commit Graph

355108 Commits

Author SHA1 Message Date
Miklos Vajna
371b80e1a5 loplugin:saloverride
Change-Id: Iff296171e373bae256c7bf182de44e8fc8d7e60d
2014-06-05 22:04:59 +02:00
Michael Stahl
47e907ac91 sw: SAL_DLLPUBLIC breaks windows build
Change-Id: I42934ff9ff2c046c82ac2fbb03c944efaeeb4b95
2014-06-05 22:00:08 +02:00
Miklos Vajna
462303c3f1 loplugin:passstuffbyref
Change-Id: Ia1fb74ec77b34449df49843271e87546ee68a96d
2014-06-05 21:47:38 +02:00
Caolán McNamara
bf01bb6e80 coverity#736056 Missing break in switch, assuming intentional
Change-Id: I4f729d26bae2f2e371e0f2c7aabd5cabd7bf5a62
2014-06-05 20:42:02 +01:00
Caolán McNamara
dce5aea971 coverity#736075 Missing break in switch, assuming its unintentional
Change-Id: Id00c93eb5b43b8dfb38ecfe4c40076b8b1a18465
2014-06-05 20:42:02 +01:00
Miklos Vajna
c18f300ce8 loplugin:implicitboolconversion
Change-Id: I8fac41d74ada3e85c09bcbeba4856dfe03966ed4
2014-06-05 21:41:41 +02:00
Caolán McNamara
13268c75b5 C2782: we hate you sal_Int32 as long on 32bit
Change-Id: I2c8d57f36be15fb4410b11f657e7621022eafa67
2014-06-05 20:35:37 +01:00
Caolán McNamara
eb1b6b8f52 they're not copyable, deploy boost::ptr_vector instead
Change-Id: I2e44b9e60622981141eb7af9753898b9f98b238a
2014-06-05 20:31:58 +01:00
Kohei Yoshida
61d958f37e fdo#72727: Revert "-Werror=unused-but-set-variable second try"
This reverts commit ccf7b15c0a.
2014-06-05 15:18:15 -04:00
Kohei Yoshida
91ca3a92c5 fdo#72727: Revert "fdo#68663 don't blindly force categories when there are none"
This reverts commit b090cbdf82.
2014-06-05 15:04:20 -04:00
Stephan Bergmann
ea2537d5ea Fix memory leak
Change-Id: I74001eb033abd7ceb10da60ea707f876d9f22c08
2014-06-05 18:32:31 +02:00
Stephan Bergmann
a1d7ed2357 Avoid undefined mis-aligned memory access
Change-Id: Ie79a0810cf00217fe2b9ffd34e21aeb7b2299c0d
2014-06-05 18:32:31 +02:00
Stephan Bergmann
f3758b71d9 If no bounds can be determined, assume some reasonable defaults
(instead of the twisted huge values with which aBound got initialized)

Change-Id: Ic6fe08639287eb7b5a0520aef8d2a0d43d61c035
2014-06-05 18:32:30 +02:00
Tobias Lippert
94b296d541 Unittest link generation for table of contents.
The logic was moved to a separate class and unittested.

Conflicts:
	sw/inc/ToxTextGenerator.hxx

Change-Id: I0e4475f5e2950cdfdfb07b89128c4ce1d6af3f22
Reviewed-on: https://gerrit.libreoffice.org/9609
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-05 16:26:39 +00:00
Tobias Lippert
e5345f62bf Unittest the whitespace stripping logic for tox text generation
The separate class allows to unittest this functionality in isoloation.

Change-Id: I1e5eddfb455ca85a662ea38c03302883decc5d58
Reviewed-on: https://gerrit.libreoffice.org/9608
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-05 16:26:06 +00:00
Miklos Vajna
60272bb37d CppunitTest_sw_ooxmlimport: remaining textbox porting
These are the remaining changes: with these, if we import "drawingML
shape with text in DOCX" as "shape with textbox", no testcase in this
suite fails.

Change-Id: Ic39cc204e3cfb662f14db1810f7138df0829eb27
2014-06-05 18:23:14 +02:00
Oliver-Rainer Wittmann
136cd0f3a5 Resolves: #i125050# correct text range for comment/annotation...
at a table cell selection

(cherry picked from commit ec7fc735e031f643e324b0924a1f2ca753cb314d)

Change-Id: I51fa9ab0a77ab06e295452216865d0fae44bc263
2014-06-05 16:49:27 +01:00
Caolán McNamara
2d86d82aa2 drop comment about removed step 4 now
Change-Id: I955a716621d4d566797ca39c008ff183d0656b4f
2014-06-05 16:42:34 +01:00
Caolán McNamara
b0a9f33a9b Resolves: fdo#79021 cannot delete ListBox from inside its own Select handler
Change-Id: I884e617b112397697a702216b62d0c1e17aae536
2014-06-05 16:41:02 +01:00
Caolán McNamara
1268a6f875 WaE: -Werror,-Wmismatched-tags
Change-Id: Ie0ca0c8c8e404642bbe9a918a1cb125b596ef4fc
2014-06-05 16:39:30 +01:00
Oliver-Rainer Wittmann
690c6787b4 Resolves: #i125024# remove code regarding table selection...
as it is not used any more.

(cherry picked from commit 65f39887f41e701b699fd2e51da803d116766eb8)

Conflicts:
	sw/source/core/crsr/viscrs.cxx
	sw/source/core/inc/rootfrm.hxx
	sw/source/core/layout/trvlfrm.cxx

Change-Id: Ia37e73a515a8f5d0218e4e4144e75f18449599c9
2014-06-05 16:39:29 +01:00
Stephan Bergmann
90f0af7a9c WMF record size < 3 is clearly broken
...so we should not attempt to (mis-)interpret such broken input.

Change-Id: I97f4f46fdfc0dfe6f9aff42917d23634b844c7f0
2014-06-05 17:36:52 +02:00
Miklos Vajna
c7aed931dd CppunitTest_sw_ooxmlimport's testFdo69636: use getShape()
getShape() doesn't case if the object is on a drawinglayer one or a
Writer TextFrame, and that's exactly what we want. (Currently is a
TextFrame, but will be a drawinglayer object when shape with text will
be imported as shape with textbox.)

Change-Id: I6ae981700d214447f326e6a0fb550b98380bc10c
2014-06-05 17:30:00 +02:00
Caolán McNamara
94ec76a106 update to openssl 1.0.1h
Change-Id: Ie20c190e36e89a1b3b2ac9a0efaa50af2df77523
2014-06-05 15:46:00 +01:00
Eike Rathke
14ce27cc04 unify the handling of string position arguments, fdo#75971 related
Only two text functions had the full set of checks as introduced by the
fix for fdo#75971. Let all text functions check their arguments in the
same way. Additionally this will ease a transition to accept string
lengths >64k in spreadsheet functions as now we have only one place that
checks for SAL_MAX_UINT16 instead of having that scattered all over the
place.

Change-Id: I454e617a59d0b3c2ca725047e7f8c7370bc0bb1f
2014-06-05 16:41:41 +02:00
Miklos Vajna
199eb08be9 SwAnchoredDrawObject::GetObjBoundRect: avoid SwDoc::SetModified()
This is a const method, but it does a const_cast to still resize an
object... if that's so, then we should ensure that the "is modified"
flag of SwDoc is untouched.

CppunitTest_sw_ooxmlimport's testChartSize is a reproducer for this,
when shape text is imported as textbox.

Change-Id: I6dedb31520a14127ca91782874c285f6e0f93c65
2014-06-05 16:39:36 +02:00
Miklos Vajna
383cc9deee SwDoc::dumpAsXml: show mbModified
Change-Id: I491d4af104453bb5ff3b55b28e3e1775d8aab8f7
2014-06-05 16:39:35 +02:00
Tobias Lippert
4ed0c3dd4e Extract TOX text generation to its own source file
The separate source file will make it easier to unit test the functionality

Also: move some constants to tox.hxx to have them available in the new source file

Conflicts:
	sw/source/core/doc/doctxm.cxx

Change-Id: Ib0369cc4875043829f55d30a549997560a38cc35
Reviewed-on: https://gerrit.libreoffice.org/9607
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-05 14:25:52 +00:00
Caolán McNamara
655377e90c Resolves: rhbz#1096747 crash/hang on format-page on html document
Change-Id: I9a989620375eb210e553b84b7a642a0360c8f03f
2014-06-05 13:49:14 +01:00
Caolán McNamara
231ae9c77c coverity#1158175 Missing break in switch, assuming its intentional
Change-Id: Ia0f1951f1e3edcd858a37ea091550feb2b9fd451
2014-06-05 13:35:54 +01:00
Caolán McNamara
32c37a7ae0 coverity#1103693 Missing break in switch, assuming its intentional
Change-Id: Ie61305f367e2a07a61599433bd83e1ea13bffd71
2014-06-05 13:35:54 +01:00
Caolán McNamara
c2ddb22da9 coverity#1103692 Missing break in switch, assuming its intentional
Change-Id: I32450546541b15a974f28a78604a136cebb71c3c
2014-06-05 13:35:53 +01:00
Caolán McNamara
a2d2c6d6bd coverity#1103688 Missing break in switch, assuming its intentional
Change-Id: I9b619e4896d811c2fbb20e229f65bfa01bd05731
2014-06-05 13:35:53 +01:00
Caolán McNamara
2484cda486 coverity#1000658 Missing break in switch, assuming its intentional
Change-Id: Id208942e98c8b8fc685aa77c3c11468ed2af832d
2014-06-05 13:35:53 +01:00
Caolán McNamara
abf842e4b1 coverity#705323 Missing break in switch, assuming its intentional
Change-Id: Ibb8fe4e1d13a24f810fbdf4978606c35890a9cfd
2014-06-05 13:35:53 +01:00
Caolán McNamara
91eeea0cdf coverity#705261 Missing break in switch, assuming its intentional
Change-Id: Ia19f7790871dec7022c5d1f57f082638b70403fb
2014-06-05 13:35:53 +01:00
Caolán McNamara
a4d416a7c8 coverity#705182 Missing break in switch, assuming its intentional
Change-Id: Ib8d2bc5a5772f6611f9d977376f6fef9505c6a59
2014-06-05 13:35:52 +01:00
Caolán McNamara
402c55e510 coverity#705181 Missing break in switch, assuming its intentional
Change-Id: I2b83f3e5a4fb65819244b88fdad7e48fe918b4bd
2014-06-05 13:35:52 +01:00
Caolán McNamara
ef6e89155b coverity#705178 Missing break in switch, assuming its intentional
Change-Id: I3f0b7796b4ea28c55255327ccf5b2d523ecca053
2014-06-05 13:35:52 +01:00
Caolán McNamara
699c171755 coverity#705169 Missing break in switch, assuming its intentional
Change-Id: Ib1d237591bd9cac1d4b81a04b753b2cf2c9759dd
2014-06-05 13:35:52 +01:00
Caolán McNamara
18c7731bad coverity#705164 Missing break in switch, assuming its intentional
Change-Id: I5cc112d7eb367f5dfe17fc39e3ef47784ae67e9b
2014-06-05 13:35:51 +01:00
Caolán McNamara
9e9c75cc2e coverity#705162 Missing break in switch, assuming its intentional
Change-Id: I3e0658ec26392abf5ad8de53d282b9cc35205025
2014-06-05 13:35:51 +01:00
Caolán McNamara
8d1063ce1e coverity#705147 Missing break in switch, assuming its intentional
Change-Id: I9041f18eb4aae73b795245c589b28a3d02d8397e
2014-06-05 13:35:51 +01:00
Caolán McNamara
65f1fcce56 coverity#705146 Missing break in switch, assuming its intentional
Change-Id: I09a2cacc3aa18796c06a1f1cc9315b3628865621
2014-06-05 13:35:51 +01:00
Caolán McNamara
b370077f77 coverity#736046 Missing break in switch
Change-Id: I1680d21b8f123ec1d937d699edee62b8ff0d6058
2014-06-05 13:35:50 +01:00
Caolán McNamara
1e9ce046a3 coverity#705215 Missing break in switch
Change-Id: I52cf32e9349e547e3445fbb266a74495d69aaa3f
2014-06-05 13:35:50 +01:00
Caolán McNamara
fd31c815b9 coverity#705211 Missing break in switch
Change-Id: I5adc00ba2f711a312c42b54014c465682a54e174
2014-06-05 13:35:50 +01:00
Caolán McNamara
4d7827cf69 coverity#705209 Missing break in switch
Change-Id: Ie9ecc13553e089197de24c8a151eb811e40bd56e
2014-06-05 13:35:50 +01:00
Caolán McNamara
d6efbc4b74 coverity#705207 Missing break in switch
Change-Id: Iac1085e4dc7c68d69fafe76bd6d22470ebaf84ad
2014-06-05 13:35:50 +01:00
Michael Stahl
5cf2205387 ucb: move APR dependencies to gb_LinkTarget__use_apr
Change-Id: I6768e5f2400f3020d85c48b80d58e13a3f6f07e9
2014-06-05 13:35:14 +02:00