mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
391,538 Commits 1 Branch 0 Tags
e9514bcc28caa83d39b40137ca09ebe83dc97e0c
Commit Graph

144 Commits

Author SHA1 Message Date
Andrea Gelmini
fc2590cfa1 Fix typos 
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-30 15:06:45 +00:00
Stephan Bergmann
4225092a35 cid#1326861,1326862: Eq: Problems with implementation of equals() 
Cloneable, odd additional equals overloads, odd hasCode implementation---all
smells like clueless cargo cult.  And I see no place where it would get used.

Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9
 2016-03-04 15:51:04 +01:00
Stephan Bergmann
305453d2c7 This ScriptEntry ctor is always called with empty languagedepprops 
Change-Id: Ia8ddfecf2f809e9f0132ba59812446973532476c
 2016-03-04 15:37:15 +01:00
Stephan Bergmann
8a4e256d67 Scripting.location is unused 
Change-Id: Ia534b5aa579a678f8b0273e6c8c12a6ad335c67a
 2016-03-04 15:34:45 +01:00
Stephan Bergmann
90033c542b ScriptEntry fields can be final 
Change-Id: I7616641584b7ea8192cf3724d8b7d5b88af39da6
 2016-03-04 15:31:38 +01:00
Stephan Bergmann
8e4c33799f Turn forwarding among ScriptEntry ctors around, dropping one 
Change-Id: If3c86c7e5c4acaf4a3e48194e24c3c73e4e99499
 2016-03-04 15:30:46 +01:00
Stephan Bergmann
9b70fdf5ed Remove unusd ScriptEntry ctor 
Change-Id: I7109877e789659b87cbc16e9c5da39dcc8249e09
 2016-03-04 15:29:19 +01:00
Stephan Bergmann
05dba6868e Forwarding-only ctor, can be private 
Change-Id: I9ed2aa9c2bf2e17705dc711560154a9596c8264a
 2016-03-04 15:26:03 +01:00
Stephan Bergmann
04b5ae6221 This ScriptEntry ctor is only needed by ctor of derived class ScriptMetaData 
Change-Id: If3e6aae326aa53825edca9d5dc207d185d288cce
 2016-03-04 15:23:38 +01:00
Stephan Bergmann
2e96766428 Remove unused ScriptEntry.setLogicalName 
Change-Id: Iad58e4227433b766bbdce92a53c95aed48320f88
 2016-03-04 15:20:45 +01:00
Stephan Bergmann
cf6e5f5b6d Parcel.getByName apparently wants to return ScriptMetaData 
Change-Id: I4a710384ec3a0d719f2ad1fbbe7b43b0be1fa1d9
 2016-03-04 15:09:14 +01:00
Noel Grandin
b73db446ac java: combine nested if statements 
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
 2015-11-05 14:55:15 +02:00
Caolán McNamara
d6a3c5786b coverity#1326446 Dereference null return value 
Change-Id: I18b3e0cc30e05e9a53a0f7ae9997b9f190f192f4
 2015-10-25 15:41:01 +00:00
Caolán McNamara
337661a989 coverity#1326446 Dereference null return value 
Change-Id: Ief00b565147bd4a08c4fd6de9df71d9126dc1f75
 2015-10-22 16:45:09 +01:00
Caolán McNamara
86d275366a coverity#1326553 Dereference before null check 
Change-Id: I1fe2e0477f136f31b854672878d0544d9492d51b
 2015-10-20 21:18:35 +01:00
Caolán McNamara
5d5e14e97e coverity#1326899 HE: Equal objects must have equal hashcodes 
and...

coverity#1326898 HE: Equal objects must have equal hashcodes
coverity#1326897 HE: Equal objects must have equal hashcodes
coverity#1326896 HE: Equal objects must have equal hashcodes
coverity#1326895 HE: Equal objects must have equal hashcodes

Change-Id: Ic9cb7542c1bf0608a97e5b4756b737cdf1bb4bd8
 2015-10-15 09:12:36 +01:00
Caolán McNamara
d9bb701494 coverity#1326568 Unused value 
Change-Id: Idf1efef484d3a89bd56ba9a6807d4191ef95cb41
 2015-10-14 15:02:41 +01:00
Noel Grandin
43cbaac5b9 cid#1326361 Data race condition 
Change-Id: Ia61737232d816bb05f3aedbe76e7905262906a79
 2015-10-14 12:30:57 +02:00
Andrea Gelmini
5d5dc059cb Fix typos 
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:35:58 +00:00
Noel Grandin
efd4bfa818 java:regulatize the order of 'final' and public/private 
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-11 09:34:00 +00:00
Julien Nabet
1101ae6772 Typo: deleteing->deleting 
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
 2015-02-21 10:56:21 +01:00
Andras Timar
b55ef81671 typo: langugage -> language 
Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
 2015-01-23 15:01:37 +01:00
Noel Grandin
08ece8d873 java: revert part of commit, scripting/ is public API 
revert part of my commit
7557f23b31
"java: reduce visibility of fields and methods"

Change-Id: I2049a154b60b165d4d2217495935442d6da66e97
 2014-12-11 15:20:09 +02:00
Noel Grandin
7557f23b31 java: reduce visibility of fields and methods 
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-11 06:09:03 +00:00
Noel Grandin
c199b76d88 java: remove some unused local variables 
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
 2014-12-05 11:15:57 +02:00
Noel Grandin
db203e59d6 java: remove some unused fields 
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
 2014-12-05 11:15:56 +02:00
Noel Grandin
58eab57648 java: final fields that can be static 
found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-25 06:06:48 +00:00
Noel Grandin
0063cf2856 java: make fields final where possible 
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
 2014-11-18 12:44:28 +02:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible 
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:03:29 +00:00
Noel Grandin
36ff1527c9 java: reduce excessive code indentation levels 
by using early return in some methods

Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7
Reviewed-on: https://gerrit.libreoffice.org/12374
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 08:01:55 +00:00
Noel Grandin
b2f69f6264 java: when rethrowing, store the original exception 
Change-Id: I14666493e72da177fcfff1895ef3206f0e13cc01
 2014-10-16 12:27:14 +02:00
Noel Grandin
fa22664be2 java: always use braces for while loops 
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
 2014-10-16 08:15:52 +02:00
Robert Antoni Buj i Gelonch
0fdba36ab6 scripting: replace '.size() == 0' with '.isEmpty()' (collections) 
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Map.html#isEmpty()
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty()

Change-Id: I76d8d8be2794655cb27ab121759494d7084b4744
Reviewed-on: https://gerrit.libreoffice.org/11967
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-14 12:29:02 +00:00
Robert Antoni Buj i Gelonch
791ed2c654 scripting: use new exception constructors 
Change-Id: I7eeece85d4e462bf2df010ee29c062941a677759
Reviewed-on: https://gerrit.libreoffice.org/11966
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-14 12:28:37 +00:00
Noel Grandin
68fa141097 java: use isEmpty() instead of "size() == 0" 
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
 2014-10-07 13:20:03 +02:00
Robert Antoni Buj i Gelonch
e41597eade scripting: line break (code formatting) 
Change-Id: Ib1a8d7e4bdaad2f4eae822d9af280fd5b6f9dd7b
Reviewed-on: https://gerrit.libreoffice.org/11794
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-06 14:10:27 +00:00
Robert Antoni Buj i Gelonch
4a0fc2fb02 scripting: organize imports 
Change-Id: I26a1164d44f464a44ed7deb93ac39465feb0541c
Reviewed-on: https://gerrit.libreoffice.org/11768
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-03 05:25:06 +00:00
Robert Antoni Buj i Gelonch
6f42a71439 scripting: Format_java_code.sh initial run 
Conflicts:
	scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java

Change-Id: I09b94d8c96dfbaf498bd93a0088feb80a9e4afb6
 2014-10-02 15:25:29 +02:00
Noel Grandin
83636d2c09 java: when rethrowing exceptions, store the original cause 
so that we get a nice complete stacktrace when it hits the final
handler

Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
 2014-09-25 13:47:25 +02:00
Stephan Bergmann
27d5b5c6dd BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layout 
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
 2014-09-17 11:45:14 +02:00
rbuj
f93ce4f7eb scripting: decode(String) in URLDecoder has been deprecated 
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLDecoder.html#decode(java.lang.String)

Change-Id: I71ecb498c93d5e8d6959bdc3ab263a5ff48c1c21
Reviewed-on: https://gerrit.libreoffice.org/11453
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-09-16 06:16:49 +00:00
rbuj
44304a8147 scripting: replace StringBuffer with StringBuilder method 
In JDK 1.3, StringBuffer makes the String concatenations faster.

public String concat(String s1, String s2) {
  StringBuffer sb = new StringBuffer();
  sb.append(s1);
  sb.append(s2);
  return sb.toString();
}

JDK 1.5 comes with StringBuilder (which is faster than StringBuffer) and the method:

public String concat(String s1, String s2) {
  return s1 + s2;
}

is translated to:

public String concat(String s1, String s2) {
  return new StringBuilder().append(s1).append(s2).toString();
}

Change-Id: I2924fcdf23d7ffbb567d9e924d02edcab4d21be6
NOTE: StringBuffer is synchronized, StringBuilder is not.
Reviewed-on: https://gerrit.libreoffice.org/11436
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-09-14 06:33:05 +00:00
rbuj
fafb0db5d2 scripting: use String.length()==0 instead of String.equals(empty string) 
Change-Id: Icff6a5d19aaf7ac7ebb0cd54140bd388cba0f24d
Reviewed-on: https://gerrit.libreoffice.org/11431
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-09-13 15:09:44 +00:00
rbuj
8171113420 scripting: use a character literal 
Change-Id: Iabd3514f3c64ff851463cb9b2c1c425164285eb5
Reviewed-on: https://gerrit.libreoffice.org/11430
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-09-13 15:05:45 +00:00
rbuj
e41cc6898a scripting: Enhanced For-Loops 
Change-Id: Ib5e59a8c153e7d788c14153fa3b94c8b2d0a068c
Reviewed-on: https://gerrit.libreoffice.org/11292
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-09-13 15:03:32 +00:00
rbuj
4d6bd06c33 scripting: there isn't any benefit by reducing the scope here. 
Change-Id: I73ebfac7b44d3fba7da70788784492fa3c53c572
Reviewed-on: https://gerrit.libreoffice.org/11312
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-09-07 13:01:56 -05:00
rbuj
c562a0b58d scripting: remove import from the same package 
Change-Id: If3a07e81f5d738395d6718302512c0172b90d977
Reviewed-on: https://gerrit.libreoffice.org/11285
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-09-05 02:30:53 -05:00
rbuj
015d65c7ea scripting: use contains to check if a string contains a substring 
Change-Id: I7cbd32310e362f43f0a456e45b58930eb5453f0c
Reviewed-on: https://gerrit.libreoffice.org/11289
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-09-04 20:36:09 -05:00
rbuj
a795c3660b scripting: the if statement is redundant 
Change-Id: I7e61d740d6f58afbcdad630deb0de0ef548efcfb
Reviewed-on: https://gerrit.libreoffice.org/11288
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-09-04 20:34:16 -05:00
rbuj
652b807658 scripting: the assigned value is never used 
Change-Id: I430da93e985291300ac5fdaccc7f907535771a07
Reviewed-on: https://gerrit.libreoffice.org/11287
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-09-04 20:31:50 -05:00