mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
318,046 Commits 1 Branch 0 Tags
eaecc7971f7024a0f5aa7df1d933bd60a9f1357c
Commit Graph

216 Commits

Author SHA1 Message Date
Markus Mohrhard
eaecc7971f simplify cond format copy&paste code, fdo#58677 
This should also help with fdo#57896 and some other problems I found

Change-Id: I8cb3eb69a7ec1413cb57ce81c5f4d806250474e5
 2012-12-25 21:07:09 +01:00
Michael Meeks
16155fdc39 re-base on ALv2 code. Includes: 
Patches contributed by Herbert Duerr
    i#118735 prevent endless loop if vlookup/hlookup doesn't find anything
    http://svn.apache.org/viewvc?view=revision&revision=1239673

    Patches contributed by Andre Fischer
    remove lp_solver
    http://svn.apache.org/viewvc?view=revision&revision=1199180
    i#118160: Added external CoinMP library.
    http://svn.apache.org/viewvc?view=revision&revision=1233909

    Patches contributed by Armin Le-Grand
    i#118485 - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    i#118524: apply patch, followup fixes to 118485
    http://svn.apache.org/viewvc?view=revision&revision=1186077

    Patches contributed by lihuiibm
    i#108860 - Fix range validation.
    http://svn.apache.org/viewvc?view=revision&revision=1242846
    i#118954 Chart data will lost after copy to different file
    http://svn.apache.org/viewvc?view=revision&revision=1301345

    Patches contributed by Ariel Constenla-Haile
    Fix Linux build breaker: extra qualification on member
    http://svn.apache.org/viewvc?view=revision&revision=1301591
    i#118696 - i#118697 - Fix some Sheet Tab Color API issues
    http://svn.apache.org/viewvc?view=revision&revision=1225428
    i#118697 - Fix uninitialized variable
    http://svn.apache.org/viewvc?view=revision&revision=1225859
    i#118771 - ScUndoImportTab should preserve tab background color
    http://svn.apache.org/viewvc?view=revision&revision=1230356
    i#118921 - Repaint linked sheet tab background color after updating link
    http://svn.apache.org/viewvc?view=revision&revision=1245177
    i#118927 - Undo/Redo "Update Link" does not reset sheet tab color
    http://svn.apache.org/viewvc?view=revision&revision=1245241
    i#118747 - Copy tab color when transferring sheets across documents
    http://svn.apache.org/viewvc?view=revision&revision=1230355

    Patch contributed by Oliver Rainer-Wittman
    i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and
    <ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container
    iteration in order to avoid destroyed iterators during iteration.
    http://svn.apache.org/viewvc?view=revision&revision=1297916

    Patches contributed by Mathias Bauer
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    http://svn.apache.org/viewvc?view=revision&revision=1396797
    http://svn.apache.org/viewvc?view=revision&revision=1397315

    Patch contributed by Daniel Rentz
    calc69: #i116936# fix VBA symbol Cells
    http://svn.apache.org/viewvc?view=revision&revision=1172135

    Patches contributed by leiw:
    i#118546 CPU 100% on switched off AutoCalculate with Conditional
    Formatting on date values
    http://svn.apache.org/viewvc?view=revision&revision=1301380

Re-add new function documentation. Many various cleanups.
Add missing calc66: #o11817313# also look at formula result
number format, remove redundant binaries.
 2012-12-04 07:17:12 +00:00
Niklas Nebel
ff132d6764 calc66: #i117315# round-down single row height values in GetScaledRowHeight 2012-12-04 07:17:08 +00:00
Markus Mohrhard
a9b7b4ab6b use the correct flag to remove notes 
Change-Id: Ib7713cace98c732e9fbcc4e9689ca223544d5e4c
 2012-11-28 15:14:35 +01:00
Markus Mohrhard
f8eed7ad9d support undoing conditional formats correctly 
Change-Id: Ice698827b3bc559a1e5ad0ea929145fa8c0dfffe
 2012-11-23 17:27:48 +01:00
Markus Mohrhard
ac5b0cd66a this should be IDF_NOTE 
Change-Id: Id460ed774b4ccedd5e72ba41756fc7c78f8c2313
 2012-11-23 17:27:48 +01:00
Markus Mohrhard
f44928cbd5 delete also note caption, fdo#56548 
Change-Id: I1d792082e79d6bb68004a84c172cc3bb5c194826
 2012-11-17 18:56:25 +01:00
Kohei Yoshida
d3344dd85e Correctly handle cell note shifting when immediate row/column is deleted. 
Currently, having a note e.g. at D5, and deleting cell D4 and shifting
the cells below upward will remove the note at D5.  But the correct behavior
is to shift that note up to D4.  This change fixes it.

Change-Id: Ia37f1ce67a003deab424f2b805a2ce333fc10ed4
 2012-11-02 13:42:12 -04:00
Kohei Yoshida
e8487c8a3f Fix incorrect shifting of cell notes upon cell insertion / deletion. 
Steps to reproduce:

1) Insert a comment at D5.
2) Move cursor to C4.
3) Right-click and select Insert.
4) Choose shift cells down.
5) The comment gets shifted down but it shouldn't.

The same thing happens when deleting a cell and shifting content.

Change-Id: I5a71845cca6abde6b7c940e152e155da26343cef
 2012-11-02 11:04:18 -04:00
Kohei Yoshida
b10833d4db No more "increase / decrease of recalc level" for drawing objects. 
That scheme made it extremely hard to determine when the object's
positions get recalculated.  It's better to figure out when to recalc
drawing objects' positions, and call SetDrawPageSize() manually at
that point (and only once!)

Change-Id: I05d9b693cfc9310f5472ed8287c7a2e36646f4d7
 2012-11-01 16:30:04 -04:00
Markus Mohrhard
f8dada570b fix memory leak in note handling 
Change-Id: I55a7673aff8e23f59ccb99ea73a102df215ba599
 2012-10-15 04:52:52 +02:00
Markus Mohrhard
262079b2df fix the problem in the right method 
Change-Id: Ifedd563ad430cff957e148d81367139455d71686
 2012-10-15 04:52:41 +02:00
Markus Mohrhard
9ffba6a8da need to set the row/col relative to the start row/col 
Change-Id: Ic423924dc12cc8aef1a45d494c6a623ddc45cff0
 2012-10-13 07:07:18 +02:00
Markus Mohrhard
2ec03fc221 don't insert notes from deleted cells, fdo#55885 
Change-Id: I036f0531dc2290c5eb480258bc70ec13b810e6bc
 2012-10-13 04:33:33 +02:00
Markus Mohrhard
fa02cce680 also support removing of conditional formats 
Change-Id: I47ba632ccf752611a41b29c0da8e5d0f28a88565
 2012-10-06 00:26:42 +02:00
Markus Mohrhard
3cb337fdcf adpat ScTable methods to overlapping conditional formats 
Change-Id: I2f63ac7884f0897aa47fd4ee35b8af06553c311c
 2012-10-06 00:26:41 +02:00
Markus Mohrhard
d2b49b5b9b support overlapping conditional formats 
Still missing:

*Removing conditional formats
*Handling of Manage Names dialog
*UNO
*Undo/Redo
*Import/export
*Adjusting the dialogs to support this

Change-Id: I72481cfb807fee2c3a1546222fe7e786d515ab44
 2012-10-06 00:26:40 +02:00
Markus Mohrhard
78e35a68b2 only delete cond formats when attributes are deleted, fdo#54748 
Change-Id: I41829e8464fb2fb5e7bbc435f9aa5ed72e7d5cbc
 2012-09-16 04:09:36 +02:00
Markus Mohrhard
24712398aa handle protection in conditional formats correctly, fdo#51636 
Change-Id: I81d7369218ae8e361f15d811952a8f690a32df96
 2012-09-06 18:55:25 +02:00
Markus Mohrhard
10efe1bced handle missing cond format entries more gracefully, related fdo#52340 
Change-Id: Id1cf7d99a13c04541e87ad00c5418dd4f766d268
 2012-08-31 15:50:15 +02:00
Markus Mohrhard
a3c4ee1653 update cond formats for deleting, moving and cut&paste 
Change-Id: I52987e957918853bcd1abd1460c6166b52454d62
 2012-08-31 15:50:14 +02:00
Markus Mohrhard
26a1aed24c make more ScTable methods const 
Change-Id: I9965a5ee383c4380dc1e75abc6a8df17ed69f6fc
 2012-08-10 19:51:08 +02:00
Markus Mohrhard
07616ec2bd make more methods const in ScTable 
Change-Id: Ib61ab9ea33ea94d6175a2110105849279d1ad440
 2012-08-10 19:51:08 +02:00
Markus Mohrhard
669784c665 use correct source table for cond format paste, fdo#52340 
Change-Id: I7c4cb1a5f31ba9e37a280af2243a13c57914cb2f
 2012-07-22 21:17:14 +02:00
Markus Mohrhard
4c462b24ab correctly copy the cond formats, fdo#50679 
Change-Id: I52d645a8a7662016ced8c1eb6b320c4a14807353
 2012-06-11 08:01:26 +02:00
Markus Mohrhard
caad0f6c79 adjust import/export code to merged conditional formats 
Change-Id: Ib9cd4e09e55ff2413db8e1daf45624d695e3113d
 2012-06-11 08:01:24 +02:00
Markus Mohrhard
08ed74c89f integrate color formats into conditional formats 
Change-Id: I3c235f6dd0b69d3fc560910fcc890d2c80c995c0
 2012-06-11 08:01:24 +02:00
Markus Mohrhard
13ed8001c9 prepare cond format code for merge with color formats 
Change-Id: Id49eb1da20b75a9ab83d20c29ad8e976d46b9423
 2012-06-11 08:01:24 +02:00
Thomas Arnhold
d8afc8e5e9 Remove superfluous include comments 
Change-Id: Ie5792855761b9be209bf3fa2cba9e6998523c982
 2012-06-09 04:39:01 +02:00
Markus Mohrhard
655d61042f make color formats and conditional formats a sheet property 
TODO:
- UNO needs some love to accept this change
  - we need a new uno interface for conditional formats in 4.0
- copy/paste
- undo/redo

Change-Id: I2c8a233888a95c7298dfb151d1c12b6a6a58520d
 2012-05-24 12:38:11 +02:00
Markus Mohrhard
eb3d3a0a7d restructure colorscale code a bit to allow adding databars 
This is just a first step. In a second step we need another layer to
allow color scales and databars applied to the same range and finally
merge them with normal conditional formatting.

Change-Id: I0452ed12dd9b2d5395cf005d75a902fbb7a984ad
 2012-05-18 10:51:20 +02:00
Markus Mohrhard
5a5d80ce54 copy color scales correctly 
Change-Id: I I I0f3ce313928ffa85f563e4162398816bf3ab2fdc
 2012-05-14 07:51:23 +02:00
Markus Mohrhard
63bfed7bce create real copies for conditional formats 
This fixes problems with unique value/ duplicate value entries. The old
falt copy process did not respect that the copy needs to point to its
own range and therefore the copy was totally useless.

This is also necessary for several future new conditional formats like:
top n%, top n elements, above average, ...

Change-Id: I51b868968812a4e00dca9af2aa51d50b5ef8b855
 2012-05-14 07:51:23 +02:00
Markus Mohrhard
130b2a3949 use correct indentation 
Change-Id: I60cb1f1ed4a0068bc39ada14ac629bf20af709f9
 2012-05-14 07:51:22 +02:00
Markus Mohrhard
7db060e12f reduce scope of this variable 
Change-Id: I I98b7d83aee9f74574a4884f6066e769930e1803a
 2012-05-12 07:03:50 +02:00
Markus Mohrhard
f61cbce529 make ScTable::FillSeries work correctly with hidden rows/columns 2012-04-11 22:03:25 +02:00
Markus Mohrhard
80c233cddf search for hidden rows/columns and not filtered areas, fdo#48449 2012-04-10 16:05:21 +02:00
Markus Mohrhard
8efa446a36 use the target document not the source document 2012-03-09 19:10:27 +01:00
Markus Mohrhard
c0e58cdcac and two more errors of the same kind 
It is alarming that the Notes unit test did not fail for any of these
errors
 2012-03-05 02:28:17 +01:00
Markus Mohrhard
d3ebd8340f well one copy/paste error is not enough 2012-03-05 02:12:58 +01:00
Markus Mohrhard
569e8b8a9e fix copy/paste error 
I can't express how dumb I feel after searching for hours for a bug in
the note handling and then it is just such a small copy/paste error
 2012-03-05 01:53:43 +01:00
Markus Mohrhard
50506b3840 readd note handling to CopyUpdated 2012-03-05 01:39:23 +01:00
Markus Mohrhard
d59b9c07c8 remove table.hxx from document.hxx 2012-03-02 03:39:26 +01:00
Markus Mohrhard
921fb226d2 fix crashs in undo/redo realted to note captions 2012-03-02 02:00:28 +01:00
Markus Mohrhard
1d1141cd06 remove unnecessary parameter 2012-03-02 02:00:28 +01:00
Markus Mohrhard
956c9d1775 there is no need any more for CloneWith[out]Note 2012-03-01 15:38:01 +01:00
Markus Mohrhard
58272b9831 fix some iterator misuse in the new notes handling 2012-03-01 11:13:16 +01:00
Markus Mohrhard
373394c887 only delete notes if correct flag is passed 2012-03-01 11:13:16 +01:00
Markus Mohrhard
979cc1c009 some more fixes to get note handling back 
there are still some issues that will be addressed in later commits
 2012-02-29 23:37:52 +01:00
Markus Mohrhard
33849f3fca remove mpNote: fix copy/paste 2012-02-29 23:37:52 +01:00