Commit Graph

34 Commits

Author SHA1 Message Date
Noel Grandin
91adb929d7 clang-tidy modernize-loop-convert in h-l/*
Change-Id: I843528327b25d18476f8959cabba16371213a48a
Reviewed-on: https://gerrit.libreoffice.org/24460
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28 09:31:29 +00:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17 11:33:57 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Jan Holesovsky
4c4999d944 tdf#96042: 'std::string::find("something") == 0' means "startsWith()".
This should fix a regression from 3bdd176731,
apparently the cppcheck's advice is misleading.

Change-Id: I427ecaa1eb3c9841cb6112997b9b51feda4583d0
2015-12-08 12:12:53 +01:00
Noel Grandin
ec3f724158 loplugin:unusedfields
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-30 10:34:38 +02:00
Noel Grandin
275ccca3d2 loplugin:unusedfields helpcompiler
Change-Id: I8a4feaea642cf781fde54e4afc5cd98e326f8db3
2015-11-20 15:07:05 +02:00
Noel Grandin
3bdd176731 cppcheck:stlIfStrFind
"Inefficient usage of string::find() in condition; string::compare() would be faster."

Change-Id: I90403b1d05eff6499c10be33068e5fd4fed30b62
Reviewed-on: https://gerrit.libreoffice.org/19966
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 06:46:07 +00:00
Stephan Bergmann
2df257e95e loplugin:nullptr (automatic rewrite)
Change-Id: I6e34abccb0bda1c76e30ab973b8fd827d6c99c72
2015-11-10 10:31:27 +01:00
Caolán McNamara
78f042b9ab coverity#1338235 Uncaught exception
Change-Id: I66bd63a75e9d75cb5d87be5e4573aec891994588
2015-11-06 09:21:59 +00:00
Andrea Gelmini
a50539e2aa Fix typos
Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8
Reviewed-on: https://gerrit.libreoffice.org/18953
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 12:41:09 +00:00
Caolán McNamara
f7ef1cbb83 boost->std
Change-Id: I5079e03f70370ed83a1158b2e278f48642108f08
Reviewed-on: https://gerrit.libreoffice.org/18692
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19 08:02:51 +00:00
Caolán McNamara
7ed80b1969 coverity#1308500 Uncaught exception
Change-Id: I38d6c03ee380ba6b3055e000f905a4cc568d5ab6
2015-06-28 13:23:00 +01:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]>
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17 15:50:45 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
Stephan Bergmann
9a1909a5d0 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: Idca144969e2b978fee8cd5b0868fcf418b193967
2015-06-08 16:25:33 +02:00
Stephan Bergmann
b7c27fef4e Some more loplugin:cstylecast: helpcompiler
Change-Id: I9e094356601cf156537f75d0629fd214710d80e8
2015-01-20 09:06:48 +01:00
Łukasz Hryniuk
9fd89a5952 fdo#39440 reduce scope of local variables
Beside scope changes, it fixes lack of initialization in a few places.

Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2
Reviewed-on: https://gerrit.libreoffice.org/13755
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-07 06:47:04 +00:00
Stephan Bergmann
9720e8e5ef Some loplugin:revisibility clean-up
Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.

However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.

Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05 13:10:48 +01:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Michael Weghorn
28d9983e2c indent try-block, remove obsolete comment
indent block one level deeper than block in
which it is contained

Change-Id: Ibefd1a87c25100001f842f42f053d9e68feba8a6
Reviewed-on: https://gerrit.libreoffice.org/13498
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-17 07:32:11 +00:00
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Caolán McNamara
04a4671b2d coverity#1223090 Uncaught exception
Change-Id: Iec100b86e2952a5efe4fa52bd85fbc00b51f78c3
2014-06-17 10:57:58 +01:00
Takeshi Abe
6a964dcf0f Avoid possible memory leaks in case of exceptions
Change-Id: Ibadadacbe09a93e7d7a7210868c52a8fa582d427
2014-04-17 10:57:00 +09:00
Thomas Arnhold
8d202fa72f typo: paramter -> parameter 2014-04-14 12:32:54 +02:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
Michael Stahl
0bb8c03253 helpcompiler: remove Package_inc
Change-Id: Iddafa9068edcc20135c08ed205b8fb7fb5382eba
2013-05-07 01:41:23 +02:00
Michael Stahl
18af827875 HelpLinker: add comment for mysterious XML parsing
Change-Id: I9aa5fd2cb0cb4eae0a94f8d3d6b6185a1fcffdc4
2013-04-08 13:40:59 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
David Tardon
cfe0fbb039 do not create index for shared help module
Change-Id: I83f9b99abcc952dfea924662a0db8d98efc56307
2013-02-28 12:30:50 +01:00
David Tardon
f094641d3a add opt -nolangroot needed for gbuild
Change-Id: Id76dfc5698619f8095e0c682ae4ce5e181c9a599
2013-02-26 15:24:53 +01:00
Andras Timar
a775aa57f7 compact help xml files with xslt which removes the cruft
Change-Id: Iee923174169d6ba9961a9cee14115c9a4bf7ba09
2013-02-13 16:37:35 +01:00
Dávid Vastag
d06c698b79 Basic code syntaxhighlighting added to LibreOffice help
Change-Id: Id47172d0386e7aa28d82178f04b5f626f0c441fe
2013-02-13 10:19:14 +01:00
Michael Meeks
b9d1006ebb re-base on ALv2 code. Includes:
#i118662# remove berkeleyDB from module l10tools
    Patch contributed by Oliver-Rainer Wittmann
    http://svn.apache.org/viewvc?view=revision&revision=1213189

    reportdesign: remove extra items from Help menu
    Patch contributed by Ariel Constenla-Haile
    http://svn.apache.org/viewvc?view=revision&revision=1201215
2012-10-02 12:15:41 +01:00
Andras Timar
eaa81cc2f0 move help compiler/linker/indexer to a new module
we may want to use syntax highlighter class from svtools later,
which is not available for l10ntools

Change-Id: I5a06b77cb6935e3ef68015fb608aa26ac7c53fac
2012-09-16 20:41:26 +02:00