1) Do not dispose m_xComposer, might still be used by our m_pCache
2) Do not create a new m_xComposer if the previous one will do, so
that we do not gratiously use a different one than our m_pCache.
Change-Id: I6540c035c9159017c694b36e676721ec3e42db51
Trying to set a name that is already in use will throw an exception (and
set a different, generated name); if there is actually no name in the
file then there's no point trying to set anything.
(regression from b69d152cfa)
Change-Id: Ie54d4a830cc23e2853a6efeb81f77dcc788192ea
7a3b8b1a5a switched formula parsing from
API FormulaParser::importFormula() / ApiParserWrapper::parseFormula() to
ScCompiler, which means that also FormulaFinalizer::finalizeTokenArray()
is not executed anymore and processTokens() and processParameters() that
among others handled appending Calc-only and required parameters.
At least implement that parameter part at ScCompiler now.
Change-Id: Iaa2804c82ec43dd51f781485b0e2afab8c613638
This can be used later for the VML or binary export of shapes imported
from drawingML. Note that without this, drawingML shapes won't be
exported to VML, as e.g. for a triangle it expects a
'isosceles-triangle' type, while the shype's type is 'ooxml-triangle'.
Change-Id: I59abc27febdd026c181a7ff38b16c93567058cb9
76c549eb01 "Integrate branch of IAccessible2" had
changed it to return a string, but that neither matched the documentation of
css.accessibility.XAccessibleValue nor did it satisfy JunitTest_sw_unoapi. This
needs further clarification apparently.
Change-Id: Ib09f7549db7ba5155798d5917908c7ce50e7a592
Mirror what the VML import's ShapeBase::convertShapeProperties() already
does, fixes CppunitTest_sw_ooxmlexport's testFdo66688 when wps import is
enabled by default.
Change-Id: Iabed3a5fa1353aefe3055232ad0b7770067a7a58
This only works partially: the ClassObjects are only registered on the
main thread; CoCreateInstance on other threads still fails.
This reverts commit 29c6216af8c502f220bb84857d3dda901ddfd234.
The ImplHandleGetObject() function modifies the Application Settings and
must take the SolarMutex for this; otherwise we get crashes when another
thread calls StyleSettings::GetPersonaHeader() during some unoapi test.
Also fix another HWND to long cast; use LRESULT which is Win32 for intptr_t.
Change-Id: I5580f88ed0a8e9955697655ace94584e2307982d
tvhlp1 just have 2 files, and this lib is used always with ucpchelp1. By
these reasons, we can merge these 2 libs.
Change-Id: I515f9c12893c986279ffac91b83879c467b091c7
Reviewed-on: https://gerrit.libreoffice.org/6820
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
When the drawingML shape import is enabled by default, testFdo66929
(from CppunitTest_sw_ooxmlexport) fails without this.
Change-Id: I38fc64201aaf28ae2e07e57c498a64391ac56f07
This commit includes the following changes:
1) Remove boxes from PNG files, and draw them ourselves.
This will ensure that the color rec will always fit the box.
Also it will make all color pickers look the same, and greatly
simplify the code. (a part of the code was not reachable anyway.)
2) Fix color preview for toolbar large icons. (a regression of
commit f59c47fc1e79050d3342924e6173b0f4b6ddaf02.)
3) Fix sidebar paragraph color picker initial drawing. reset should
be called *after* the icon assignment.
Change-Id: I13ae02bc3dd68dd14877ccc949784072c58bf211
Reviewed-on: https://gerrit.libreoffice.org/6882
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
