mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
412,096 Commits 1 Branch 0 Tags
f192302a57a7c49f711c87eef548f93a3364d9b9
Commit Graph

412096 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Stephan Bergmann
78960ad06f Missing include 
Change-Id: Ic0ab1cc72005f99d7558b06c9a4ec9c94f2f0460
 2017-08-30 08:29:15 +02:00
Stephan Bergmann
f86552ea15 This check for GDIObj subtypes is exhaustive 
For one, catches issues like d5ed3cd6db "Make
WinMtfFontStyle's base class EMFIO_DLLPUBLIC, too" earlier.  For another, uses
if/else to avoid unnecessary, expensive dynamic casts.

Change-Id: I695b1e8673d5af22060b05b982789ad0ddcd39c3
 2017-08-30 08:25:33 +02:00
Olivier Hallot
7f4e02e380 Updated core 
Project: help  ba1b065b296a1fce482bb3ebfa2fc8b765b45456

Uppercase Xor operator for consistency

Change-Id: Iabc0599c1d921597b35601d5766a8f8afe2b17b8
Reviewed-on: https://gerrit.libreoffice.org/41637
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-30 00:47:35 +02:00
Olivier Hallot
1b57fe0edc Updated core 
Project: help  79b1d6e796d6d689ef200d4531b0b2734b344392

Some tweaks in online XSLT transform

* move lang attribute from <body> to <html>
* remove role attribute in <label> (not W3C compliant)
* Fix license of help contents in page footer

Change-Id: Ia8e116588ff3a3ce41d146eea06385a420a5b0f7
Reviewed-on: https://gerrit.libreoffice.org/41716
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
 2017-08-30 00:06:52 +02:00
Tamás Zolnai
b90bdb1c0d tdf#108352: Structure of pivot table coming from XLS is altered in LO 
Change-Id: I001daeaa12cd41cc36033a26457f960d8b8a5c0e
Reviewed-on: https://gerrit.libreoffice.org/41713
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
 2017-08-30 00:06:29 +02:00
Kiyotaka Nishibori
a9cd75c150 Fix 'make translations' run again 
Some translatable strings without context attribute was fixed at recent commit. However 'make
translations' fails still now:

[POT] pot.done
Traceback (most recent call last):
  File "/home/kiyotaka/Sources/libreoffice-testing/solenv/bin/uiex", line 30, in <module>
    keyid = entry.msgctxt + '|' + entry.msgid
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

Two translatable strings in 'sc/uiconfig/scalc/ui/dataprovider.ui' have had no context attribute.

Change-Id: Id832ef62904b8000b58348bdc380d58eff305001
Reviewed-on: https://gerrit.libreoffice.org/41598
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-29 22:11:58 +02:00
Caolán McNamara
79cfd48dae Resolves: tdf#112017 crash on particular odt 
Change-Id: I6ba2e73562a16afecb6abdfe4f1a40b1e316379e
Reviewed-on: https://gerrit.libreoffice.org/41685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-29 21:57:10 +02:00
Julien Nabet
c82e5db962 tdf#112027: avoid leaks in FillTreeBox (sfx2) 
Next step could be using std::unique_ptr<StyleTree_Impl>
instead of StyleTree_Impl*

Change-Id: Ifbf5313fedf1fc0310073918f91edd6fe75d0afc
Reviewed-on: https://gerrit.libreoffice.org/41710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 21:41:08 +02:00
Julien Nabet
864f89e92e Related tdf#111892: use unique_ptr 
Change-Id: I8de0704cae36805737033c38950ac45be13198da
Reviewed-on: https://gerrit.libreoffice.org/41650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 21:39:14 +02:00
Gautam Prajapati
c6df07f905 nss: Upgrade to release 3.31.1 and update patches 
This commit updates the NSS to release 3.31.1 and NSPR
to 4.15. It also updates the external/nss/nss.patch and
external/nss/nss-android.patch to incorporate the
NSS source changes.

Change-Id: Icdd933b67e717f8d91622cd5f6001e34e261b746
Reviewed-on: https://gerrit.libreoffice.org/41636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-08-29 21:32:19 +02:00
Andrea Gelmini
8c21ecc8f5 Removed ancient comment 
Change-Id: I3607551397e131990f37eea4ee70e92e19d9c538
Reviewed-on: https://gerrit.libreoffice.org/41657
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
 2017-08-29 20:06:27 +02:00
Andrea Gelmini
68178e226b Fix typo in code 
Change-Id: I9aadb4f3f7f71715e886666f11a91c4392395860
Reviewed-on: https://gerrit.libreoffice.org/41704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
 2017-08-29 20:05:05 +02:00
Jens Carl
22b54751a8 Remove unused header 
Change-Id: Idf069da8098ffdfc5174c161302228076a80b080
Reviewed-on: https://gerrit.libreoffice.org/41673
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
 2017-08-29 20:03:20 +02:00
Noel Grandin
f8a900e81e loplugin:constparam in sc part9 
Change-Id: If5bd37c48ee99210eb8f8a432b87a5e5235865bd
Reviewed-on: https://gerrit.libreoffice.org/41702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 19:51:19 +02:00
Noel Grandin
4e70d0b6bf rename SBX errorcodes to BASIC 
Change-Id: Ia6c2d2379a2f6e9b1109e2c04edd5cdd9dcf242f
Reviewed-on: https://gerrit.libreoffice.org/41706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 19:50:11 +02:00
Stephan Bergmann
ddc4c0edeb Strength-reduce XViewSplitable::testSplit 
At least my macOS build had failed CppunitTest_sc_tabviewob now, as there
getSplitRow() returns 2 instead of 3.  Before
0bd57d62d0 "tdf#45904 Move Java _XViewSplitable
tests to C++" the original Java code only checked for non-zero, so keep it at
that for now.

Change-Id: Ia777bb27d0296507c73df170fff623d45cd55dca
 2017-08-29 19:41:18 +02:00
Gabor Kelemen
e44ec17e7b tdf#112062 Spelling: Grey -> Gray in color palettes 
Change-Id: I724c7ad0327a577032b8aeaa5b6dffe81d34e15f
Reviewed-on: https://gerrit.libreoffice.org/41662
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-29 19:11:37 +02:00
andreas kainz
bdedadfcc0 add 32px to tango icon set from adwaita 
Change-Id: If5dbf0fcb4dcce2e89f00521d6c9317844293b25
Reviewed-on: https://gerrit.libreoffice.org/34708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-29 19:08:33 +02:00
andreas kainz
ce72954d2c add setoutline icon to tango 
Change-Id: I800906806d98720317f725d7c0a496e84f016f47
Reviewed-on: https://gerrit.libreoffice.org/41691
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-29 18:47:22 +02:00
andreas kainz
1367d0a42d add setoutline icon to sifr 
Change-Id: Idab8d4bbee01fbc69932055f267a5518b69a538c
Reviewed-on: https://gerrit.libreoffice.org/41693
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-29 18:46:35 +02:00
andreas kainz
72c8044fa1 tdf#107741 breeze-icon update for border style 
Change-Id: Iae63cf9df6b78757db0b55dcbac9c90c4f844777
Reviewed-on: https://gerrit.libreoffice.org/41703
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-29 18:43:55 +02:00
Noel Grandin
5c088880c8 tdf#112008 Assert when starting an empty slideshow 
Init() is called via at least two different code patchs,
from BasicViewFactory::CreateView and
PresentationViewShell::FinishInitialization.

But we only call EndListening() once in the destructor, so lets just
check before calling StartListening()

Change-Id: Ia6757a17934cc2665c635e21ee0305a810c624c1
Reviewed-on: https://gerrit.libreoffice.org/41701
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 18:39:29 +02:00
Stephan Bergmann
9b3813cdbf Avoid "ThreadSanitizer: lock-order-inversion (potential deadlock)" 
...during CppunitTest_drawinglayer_border:

> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=3780)
>   Cycle in lock order graph: M1066643978230284960 (0x000000000000) => M1071992002787787328 (0x000000000000) => M1066643978230284960
>
>   Mutex M1071992002787787328 acquired here while holding mutex M1066643978230284960 in main thread:
>     #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7)
>     #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a)
>     #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78)
>     #3 ClearableGuard include/osl/mutex.hxx:163 (libsvllo.so+0x10409f)
>     #4 ResettableGuard include/osl/mutex.hxx:208 (libsvllo.so+0xfe61c)
>     #5 ItemHolder2::impl_addItem(EItem) svl/source/config/itemholder2.cxx:80 (libsvllo.so+0xfd5ae)
>     #6 ItemHolder2::holdConfigItem(EItem) svl/source/config/itemholder2.cxx:70 (libsvllo.so+0xfd4bf)
>     #7 SvtCTLOptions svl/source/config/ctloptions.cxx:357 (libsvllo.so+0xf9308)
>     #8 drawinglayer::detail::getDigitLanguage() drawinglayer/source/processor2d/getdigitlanguage.cxx:20 (libdrawinglayerlo.so+0x20882b)
>     #9 VclProcessor2D drawinglayer/source/processor2d/vclprocessor2d.cxx:1434 (libdrawinglayerlo.so+0x248ed3)
>     #10 VclPixelProcessor2D drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:77 (libdrawinglayerlo.so+0x239f5c)
>     #11 drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(OutputDevice&, drawinglayer::geometry::ViewInformation2D const&) drawinglayer/source/processor2d/processorfromoutputdevice.cxx:51 (libdrawinglayerlo.so+0x20f366)
>     #12 (anonymous namespace)::DrawinglayerBorderTest::testDoublePixelProcessing() drawinglayer/qa/unit/border.cxx:98 (libtest_drawinglayer_border.so+0x9a05)
>     #13 void std::__invoke_impl<void, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(std::__invoke_memfun_deref, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:227 (libtest_drawinglayer_border.so+0xc01e)
>     #14 std::result_of<void ((anonymous namespace)::DrawinglayerBorderTest::* const&((anonymous namespace)::DrawinglayerBorderTest*&))()>::type std::__invoke<void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:250 (libtest_drawinglayer_border.so+0xbf0d)
>     #15 _ZNKSt12_Mem_fn_baseIMN12_GLOBAL__N_122DrawinglayerBorderTestEFvvELb1EEclIJRPS1_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS8_ /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:604 (libtest_drawinglayer_border.so+0xbdeb)
>     #16 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933 (libtest_drawinglayer_border.so+0xbd5b)
>     #17 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991 (libtest_drawinglayer_border.so+0xbc66)
>     #18 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:1731 (libtest_drawinglayer_border.so+0xb62a)
>     #19 std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:2127 (libtest_drawinglayer_border.so+0x12efe)
>     #20 CppUnit::TestCaller<(anonymous namespace)::DrawinglayerBorderTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175 (libtest_drawinglayer_border.so+0xadcc)
>     #21 CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32 (libcppunit-1.14.so.0+0xd61d2)
>     #22 (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39 (libvclbootstrapprotector.so+0x1114)
>     #23 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #24 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 (unobootstrapprotector.so+0x2204)
>     #25 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #26 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 (unoexceptionprotector.so+0x23e9)
>     #27 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #28 CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 (libcppunit-1.14.so.0+0xa57ad)
>     #29 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #30 CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 (libcppunit-1.14.so.0+0xc4a96)
>     #31 CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 (libcppunit-1.14.so.0+0xf4714)
>     #32 CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 (libcppunit-1.14.so.0+0xd5750)
>     #33 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a)
>     #34 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e)
>     #35 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a)
>     #36 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e)
>     #37 CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 (libcppunit-1.14.so.0+0x10282c)
>     #38 CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 (libcppunit-1.14.so.0+0xf4223)
>     #39 CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 (libcppunit-1.14.so.0+0x102c76)
>     #40 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316 (cppunittester+0x4bd1e8)
>     #41 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e)
>     #42 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695)
>
>   Mutex M1066643978230284960 previously acquired by the same thread here:
>     #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7)
>     #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a)
>     #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78)
>     #3 Guard include/osl/mutex.hxx:129 (libsvllo.so+0xf38ef)
>     #4 SvtCTLOptions svl/source/config/ctloptions.cxx:350 (libsvllo.so+0xf9224)
>     #5 drawinglayer::detail::getDigitLanguage() drawinglayer/source/processor2d/getdigitlanguage.cxx:20 (libdrawinglayerlo.so+0x20882b)
>     #6 VclProcessor2D drawinglayer/source/processor2d/vclprocessor2d.cxx:1434 (libdrawinglayerlo.so+0x248ed3)
>     #7 VclPixelProcessor2D drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:77 (libdrawinglayerlo.so+0x239f5c)
>     #8 drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(OutputDevice&, drawinglayer::geometry::ViewInformation2D const&) drawinglayer/source/processor2d/processorfromoutputdevice.cxx:51 (libdrawinglayerlo.so+0x20f366)
>     #9 (anonymous namespace)::DrawinglayerBorderTest::testDoublePixelProcessing() drawinglayer/qa/unit/border.cxx:98 (libtest_drawinglayer_border.so+0x9a05)
>     #10 void std::__invoke_impl<void, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(std::__invoke_memfun_deref, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:227 (libtest_drawinglayer_border.so+0xc01e)
>     #11 std::result_of<void ((anonymous namespace)::DrawinglayerBorderTest::* const&((anonymous namespace)::DrawinglayerBorderTest*&))()>::type std::__invoke<void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:250 (libtest_drawinglayer_border.so+0xbf0d)
>     #12 _ZNKSt12_Mem_fn_baseIMN12_GLOBAL__N_122DrawinglayerBorderTestEFvvELb1EEclIJRPS1_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS8_ /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:604 (libtest_drawinglayer_border.so+0xbdeb)
>     #13 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933 (libtest_drawinglayer_border.so+0xbd5b)
>     #14 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991 (libtest_drawinglayer_border.so+0xbc66)
>     #15 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:1731 (libtest_drawinglayer_border.so+0xb62a)
>     #16 std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:2127 (libtest_drawinglayer_border.so+0x12efe)
>     #17 CppUnit::TestCaller<(anonymous namespace)::DrawinglayerBorderTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175 (libtest_drawinglayer_border.so+0xadcc)
>     #18 CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32 (libcppunit-1.14.so.0+0xd61d2)
>     #19 (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39 (libvclbootstrapprotector.so+0x1114)
>     #20 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #21 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 (unobootstrapprotector.so+0x2204)
>     #22 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #23 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 (unoexceptionprotector.so+0x23e9)
>     #24 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #25 CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 (libcppunit-1.14.so.0+0xa57ad)
>     #26 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #27 CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 (libcppunit-1.14.so.0+0xc4a96)
>     #28 CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 (libcppunit-1.14.so.0+0xf4714)
>     #29 CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 (libcppunit-1.14.so.0+0xd5750)
>     #30 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a)
>     #31 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e)
>     #32 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a)
>     #33 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e)
>     #34 CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 (libcppunit-1.14.so.0+0x10282c)
>     #35 CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 (libcppunit-1.14.so.0+0xf4223)
>     #36 CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 (libcppunit-1.14.so.0+0x102c76)
>     #37 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316 (cppunittester+0x4bd1e8)
>     #38 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e)
>     #39 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695)
>
>   Mutex M1066643978230284960 acquired here while holding mutex M1071992002787787328 in main thread:
>     #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7)
>     #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a)
>     #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78)
>     #3 Guard include/osl/mutex.hxx:129 (libsvllo.so+0xf38ef)
>     #4 ~SvtCTLOptions svl/source/config/ctloptions.cxx:370 (libsvllo.so+0xf95df)
>     #5 ~SvtCTLOptions svl/source/config/ctloptions.cxx:368 (libsvllo.so+0xf971c)
>     #6 ItemHolder2::impl_deleteItem(TItemInfo&) svl/source/config/itemholder2.cxx:136 (libsvllo.so+0xfdb69)
>     #7 ItemHolder2::impl_releaseAllItems() svl/source/config/itemholder2.cxx:109 (libsvllo.so+0xfd2b9)
>     #8 ItemHolder2::disposing(com::sun:⭐:lang::EventObject const&) svl/source/config/itemholder2.cxx:75 (libsvllo.so+0xfd834)
>     #9 non-virtual thunk to ItemHolder2::disposing(com::sun:⭐:lang::EventObject const&) :? (libsvllo.so+0xfd89c)
>     #10 cppu::OInterfaceContainerHelper::disposeAndClear(com::sun:⭐:lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:300 (libuno_cppuhelpergcc3.so.3+0xba149)
>     #11 cppu::OMultiTypeInterfaceContainerHelper::disposeAndClear(com::sun:⭐:lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:472 (libuno_cppuhelpergcc3.so.3+0xbb6a5)
>     #12 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:101 (libuno_cppuhelpergcc3.so.3+0xb0de8)
>     #13 cppu::PartialWeakComponentImplHelper<com::sun:⭐:lang::XServiceInfo, com::sun:⭐:lang::XMultiServiceFactory, com::sun:⭐:util::XRefreshable, com::sun:⭐:util::XFlushable, com::sun:⭐:lang::XLocalizable>::dispose() include/cppuhelper/compbase.hxx:93 (libconfigmgrlo.so+0x116708)
>     #14 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun:⭐:lang::XServiceInfo, com::sun:⭐:lang::XMultiServiceFactory, com::sun:⭐:util::XRefreshable, com::sun:⭐:util::XFlushable, com::sun:⭐:lang::XLocalizable>::dispose() include/cppuhelper/compbase.hxx:? (libconfigmgrlo.so+0x116a0c)
>     #15 cppu::ComponentContext::disposing() cppuhelper/source/component_context.cxx:451 (libuno_cppuhelpergcc3.so.3+0x5cdc0)
>     #16 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:102 (libuno_cppuhelpergcc3.so.3+0xb0e09)
>     #17 cppu::PartialWeakComponentImplHelper<com::sun:⭐:uno::XComponentContext, com::sun:⭐:container::XNameContainer>::dispose() include/cppuhelper/compbase.hxx:93 (libuno_cppuhelpergcc3.so.3+0x65a88)
>     #18 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun:⭐:uno::XComponentContext, com::sun:⭐:container::XNameContainer>::dispose() include/cppuhelper/compbase.hxx:? (libuno_cppuhelpergcc3.so.3+0x65d8c)
>     #19 (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) test/source/setupvcl.cxx:53 (libtest-setupvcl.so+0x2aa0)
>     #20 (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) test/source/setupvcl.cxx:37 (libtest-setupvcl.so+0x27f8)
>     #21 Link<LinkParamNone*, void>::Call(LinkParamNone*) const include/tools/link.hxx:84 (libvcllo.so+0x983870)
>     #22 DeInitVCL() vcl/source/app/svmain.cxx:519 (libvcllo.so+0x10db246)
>     #23 ~Protector test/source/vclbootstrapprotector.cxx:31 (libvclbootstrapprotector.so+0x100a)
>     #24 ~Protector test/source/vclbootstrapprotector.cxx:30 (libvclbootstrapprotector.so+0x109c)
>     #25 CppUnit::ProtectorChain::pop() workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:56 (libcppunit-1.14.so.0+0xc46cb)
>     #26 CppUnit::TestResult::popProtector() workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:196 (libcppunit-1.14.so.0+0xf4873)
>     #27 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:325 (cppunittester+0x4bd3df)
>     #28 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e)
>     #29 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695)
>
>   Mutex M1071992002787787328 previously acquired by the same thread here:
>     #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7)
>     #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a)
>     #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78)
>     #3 ClearableGuard include/osl/mutex.hxx:163 (libsvllo.so+0x10409f)
>     #4 ResettableGuard include/osl/mutex.hxx:208 (libsvllo.so+0xfe61c)
>     #5 ItemHolder2::impl_releaseAllItems() svl/source/config/itemholder2.cxx:101 (libsvllo.so+0xfd20c)
>     #6 ItemHolder2::disposing(com::sun:⭐:lang::EventObject const&) svl/source/config/itemholder2.cxx:75 (libsvllo.so+0xfd834)
>     #7 non-virtual thunk to ItemHolder2::disposing(com::sun:⭐:lang::EventObject const&) :? (libsvllo.so+0xfd89c)
>     #8 cppu::OInterfaceContainerHelper::disposeAndClear(com::sun:⭐:lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:300 (libuno_cppuhelpergcc3.so.3+0xba149)
>     #9 cppu::OMultiTypeInterfaceContainerHelper::disposeAndClear(com::sun:⭐:lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:472 (libuno_cppuhelpergcc3.so.3+0xbb6a5)
>     #10 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:101 (libuno_cppuhelpergcc3.so.3+0xb0de8)
>     #11 cppu::PartialWeakComponentImplHelper<com::sun:⭐:lang::XServiceInfo, com::sun:⭐:lang::XMultiServiceFactory, com::sun:⭐:util::XRefreshable, com::sun:⭐:util::XFlushable, com::sun:⭐:lang::XLocalizable>::dispose() include/cppuhelper/compbase.hxx:93 (libconfigmgrlo.so+0x116708)
>     #12 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun:⭐:lang::XServiceInfo, com::sun:⭐:lang::XMultiServiceFactory, com::sun:⭐:util::XRefreshable, com::sun:⭐:util::XFlushable, com::sun:⭐:lang::XLocalizable>::dispose() :? (libconfigmgrlo.so+0x116a0c)
>     #13 cppu::ComponentContext::disposing() cppuhelper/source/component_context.cxx:451 (libuno_cppuhelpergcc3.so.3+0x5cdc0)
>     #14 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:102 (libuno_cppuhelpergcc3.so.3+0xb0e09)
>     #15 cppu::PartialWeakComponentImplHelper<com::sun:⭐:uno::XComponentContext, com::sun:⭐:container::XNameContainer>::dispose() include/cppuhelper/compbase.hxx:93 (libuno_cppuhelpergcc3.so.3+0x65a88)
>     #16 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun:⭐:uno::XComponentContext, com::sun:⭐:container::XNameContainer>::dispose() :? (libuno_cppuhelpergcc3.so.3+0x65d8c)
>     #17 (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) test/source/setupvcl.cxx:53 (libtest-setupvcl.so+0x2aa0)
>     #18 (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) test/source/setupvcl.cxx:37 (libtest-setupvcl.so+0x27f8)
>     #19 Link<LinkParamNone*, void>::Call(LinkParamNone*) const include/tools/link.hxx:84 (libvcllo.so+0x983870)
>     #20 DeInitVCL() vcl/source/app/svmain.cxx:519 (libvcllo.so+0x10db246)
>     #21 ~Protector test/source/vclbootstrapprotector.cxx:31 (libvclbootstrapprotector.so+0x100a)
>     #22 ~Protector test/source/vclbootstrapprotector.cxx:30 (libvclbootstrapprotector.so+0x109c)
>     #23 CppUnit::ProtectorChain::pop() workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:56 (libcppunit-1.14.so.0+0xc46cb)
>     #24 CppUnit::TestResult::popProtector() workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:196 (libcppunit-1.14.so.0+0xf4873)
>     #25 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:325 (cppunittester+0x4bd3df)
>     #26 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e)
>     #27 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695)

Change-Id: I9564fc918438a265629ef227bdd97e42ca1756f2
 2017-08-29 18:31:54 +02:00
Stephan Bergmann
0ae7909c89 Avoid "ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)" 
...during CppunitTest_vcl_timer:

> WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=3753)
>   Write of size 8 at 0x7ffa5fa31348 by main thread:
>     #0 ~Thread include/osl/thread.hxx:66 (libtest_vcl_timer.so+0xcbae)
>     #1 ~WatchDog vcl/qa/cppunit/timer.cxx:32 (libtest_vcl_timer.so+0xaa08)
>     #2 at_exit_wrapper(void*) compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:361 (cppunittester+0x44c823)
>
>   Previous read of size 8 at 0x7ffa5fa31348 by thread T2:
>     #0 threadFunc include/osl/thread.hxx:185 (libtest_vcl_timer.so+0xcc54)
>     #1 osl_thread_start_Impl(void*) sal/osl/unx/thread.cxx:237 (libuno_sal.so.3+0xeb5c5)
>
>   As if synchronized via sleep:
>     #0 nanosleep compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:343 (cppunittester+0x474d47)
>     #1 osl_waitThread sal/osl/unx/thread.cxx:520 (libuno_sal.so.3+0xea531)
>     #2 osl::Thread::wait(TimeValue const&) include/osl/thread.hxx:143 (libtest_vcl_timer.so+0xcd68)
>     #3 SlowCallbackTimer::Invoke() vcl/qa/cppunit/timer.cxx:372 (libtest_vcl_timer.so+0xdb0a)
>     #4 Scheduler::ProcessTaskScheduling() vcl/source/app/scheduler.cxx:381 (libvcllo.so+0x1074fff)
>     #5 Scheduler::CallbackTaskScheduling() vcl/source/app/scheduler.cxx:204 (libvcllo.so+0x1073ba5)
>     #6 SalTimer::CallCallback() vcl/inc/saltimer.hxx:54 (libvcllo.so+0x138548f)
>     #7 SvpSalInstance::CheckTimeout(bool) vcl/headless/svpinst.cxx:242 (libvcllo.so+0x1382742)
>     #8 SvpSalInstance::DoYield(bool, bool, unsigned long) vcl/headless/svpinst.cxx:349 (libvcllo.so+0x1383403)
>     #9 ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:470 (libvcllo.so+0x10c344e)
>     #10 Application::Yield() vcl/source/app/svapp.cxx:540 (libvcllo.so+0x10bad80)
>     #11 TimerTest::testSlowTimerCallback() vcl/qa/cppunit/timer.cxx:385 (libtest_vcl_timer.so+0x8506)
>     #12 void std::__invoke_impl<void, void (TimerTest::* const&)(), TimerTest*&>(std::__invoke_memfun_deref, void (TimerTest::* const&)(), TimerTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:227 (libtest_vcl_timer.so+0x15e2e)
>     #13 std::result_of<void (TimerTest::* const&(TimerTest*&))()>::type std::__invoke<void (TimerTest::* const&)(), TimerTest*&>(void (TimerTest::* const&)(), TimerTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:250 (libtest_vcl_timer.so+0x15d1d)
>     #14 _ZNKSt12_Mem_fn_baseIM9TimerTestFvvELb1EEclIJRPS0_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS7_ /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:604 (libtest_vcl_timer.so+0x15bfb)
>     #15 void std::_Bind<std::_Mem_fn<void (TimerTest::*)()> (TimerTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933 (libtest_vcl_timer.so+0x15b5b)
>     #16 void std::_Bind<std::_Mem_fn<void (TimerTest::*)()> (TimerTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991 (libtest_vcl_timer.so+0x15a26)
>     #17 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (TimerTest::*)()> (TimerTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:1731 (libtest_vcl_timer.so+0x1530a)
>     #18 std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:2127 (libtest_vcl_timer.so+0x1616e)
>     #19 CppUnit::TestCaller<TimerTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175 (libtest_vcl_timer.so+0x14a5c)
>     #20 CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32 (libcppunit-1.14.so.0+0xd61d2)
>     #21 (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39 (libvclbootstrapprotector.so+0x1114)
>     #22 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #23 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 (unobootstrapprotector.so+0x2204)
>     #24 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #25 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 (unoexceptionprotector.so+0x23e9)
>     #26 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #27 CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 (libcppunit-1.14.so.0+0xa57ad)
>     #28 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614)
>     #29 CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 (libcppunit-1.14.so.0+0xc4a96)
>     #30 CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 (libcppunit-1.14.so.0+0xf4714)
>     #31 CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 (libcppunit-1.14.so.0+0xd5750)
>     #32 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a)
>     #33 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e)
>     #34 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a)
>     #35 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e)
>     #36 CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 (libcppunit-1.14.so.0+0x10282c)
>     #37 CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 (libcppunit-1.14.so.0+0xf4223)
>     #38 CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 (libcppunit-1.14.so.0+0x102c76)
>     #39 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316 (cppunittester+0x4bd1e8)
>     #40 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e)
>     #41 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695)
>
>   Location is global '<null>' at 0x000000000000 (libtest_vcl_timer.so+0x00000021d348)
>
>   Thread T2 (tid=3925, running) created by main thread at:
>     #0 pthread_create compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:887 (cppunittester+0x451186)
>     #1 osl_thread_create_Impl(void (*)(void*), void*, short) sal/osl/unx/thread.cxx:286 (libuno_sal.so.3+0xe93ee)
>     #2 osl_createSuspendedThread sal/osl/unx/thread.cxx:337 (libuno_sal.so.3+0xe974d)
>     #3 osl::Thread::create() include/osl/thread.hxx:73 (libtest_vcl_timer.so+0xc349)
>     #4 WatchDog vcl/qa/cppunit/timer.cxx:40 (libtest_vcl_timer.so+0xa99f)
>     #5 __cxx_global_var_init.1 vcl/qa/cppunit/timer.cxx:51 (libtest_vcl_timer.so+0x6fd1)
>     #6 _GLOBAL__sub_I_timer.cxx vcl/qa/cppunit/timer.cxx:? (libtest_vcl_timer.so+0x70af)
>     #7 call_init /usr/src/debug/glibc-2.24-61-g605e6f9/elf/dl-init.c:72 (ld-linux-x86-64.so.2+0x10d99)
>     #8 CppUnit::DynamicLibraryManager::doLoadLibrary(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/UnixDynamicLibraryManager.cpp:16 (libcppunit-1.14.so.0+0x10ee31)
>     #9 CppUnit::DynamicLibraryManager::loadLibrary(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/DynamicLibraryManager.cpp:49 (libcppunit-1.14.so.0+0xa5f6d)
>     #10 DynamicLibraryManager workdir/UnpackedTarball/cppunit/src/cppunit/DynamicLibraryManager.cpp:13 (libcppunit-1.14.so.0+0xa5eb9)
>     #11 CppUnit::PlugInManager::load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CppUnit::PlugInParameters const&) workdir/UnpackedTarball/cppunit/src/cppunit/PlugInManager.cpp:34 (libcppunit-1.14.so.0+0xba57c)
>     #12 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:259 (cppunittester+0x4bc55b)
>     #13 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e)
>     #14 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695)

Change-Id: I80f83d2e54f3bae61c1a896a5f9be9f0b5bce582
 2017-08-29 18:22:15 +02:00
Chris Sherlock
a486a379ba osl: partial cleanup of socket_decl.hxx doxygen comments 
Change-Id: Ie7de4fb82a6e5162bb1732baaa742f1943559ce6
 2017-08-30 02:09:11 +10:00
Stephan Bergmann
d5ed3cd6db Make WinMtfFontStyle's base class EMFIO_DLLPUBLIC, too 
...otherwise the dynamic_cast<WinMtfFontStyle*> in MtfTools::SelectObject
(emfio/source/reader/mtftools.cxx) would not work on macOS in
CppunitTest_emfio_wmf

Change-Id: I5c361544fd273bdb65a4b83c7d694bae714815f5
 2017-08-29 17:44:36 +02:00
Miklos Vajna
2a55916a92 EPUB export: initial character properties as direct formatting 
Handle the case when the formatting comes from an autostyle on the text
span.

Change-Id: I12f9a752c4f2934a3e155a4442ad3db68a43d395
Reviewed-on: https://gerrit.libreoffice.org/41694
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-08-29 16:56:43 +02:00
Caolán McNamara
507247697d make custom properties tab page some reasonable starting width 
Change-Id: I50f1a552a39b2fb70e6c0c340f27834381eaa92e
 2017-08-29 15:00:59 +01:00
Chris Sherlock
9806359e65 revert "convert all sal_Bool to bool in start.c" 
Didn't realise this was introduced in a version of C that was later than our
minimum version...

Reverts 59a25f6f82

Change-Id: I6b6656f510251e4f3f70e499ff8a7729ee6fcc90
 2017-08-29 23:54:05 +10:00
Chris Sherlock
06c3fd26fb revert 36e31c6a6f 
Change-Id: If5039ab54df40f263a947c83fceba4d844467a88
 2017-08-29 23:49:41 +10:00
Chris Sherlock
59a25f6f82 desktop: convert all sal_Bool to bool in start.c 
Change-Id: I27480e0ee5e247730e5368f57d57c8dea439d3d5
 2017-08-29 23:37:29 +10:00
Chris Sherlock
36e31c6a6f desktop: change NULL to nullptr in start.c 
Change-Id: I943d33470a4cd61d78d8d465dfebe9df9cba444f
 2017-08-29 23:37:29 +10:00
Chris Sherlock
d368258e25 desktop: start.c cleanup 
Change-Id: I3b18abc8f01ddca70203fbae96efe09329a2d4fb
 2017-08-29 23:37:29 +10:00
Markus Mohrhard
856ff88131 move ListControl to vcl 
Change-Id: I022bba9a9a4d3d0bdb25ca8fa43aef2544decddb
Reviewed-on: https://gerrit.libreoffice.org/41682
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-08-29 15:34:54 +02:00
Markus Mohrhard
b2e229ea40 ListControl: append new entries by default 
Change-Id: Ibd11b59526f95be054c4c1599bf45bc9e757dada
Reviewed-on: https://gerrit.libreoffice.org/41681
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-08-29 15:33:50 +02:00
Markus Mohrhard
492462a3e7 handle scroll wheel scrolling in new ListControl 
Change-Id: I8dc68b674aabf446c4b949770ae066d41204efc3
Reviewed-on: https://gerrit.libreoffice.org/41680
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-08-29 15:32:58 +02:00
Noel Grandin
45acf26775 remove some unused macro definitions 
Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0
Reviewed-on: https://gerrit.libreoffice.org/41672
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 15:19:17 +02:00
Caolán McNamara
57d3e8b35d Resolves: rhbz#1400287 resizing properties dialog hides widgets 
Change-Id: I5d066f53c5bdfb4dd50d60c5cb4b66e425c0293c
Reviewed-on: https://gerrit.libreoffice.org/41696
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-29 15:13:38 +02:00
Caolán McNamara
3415764d00 Resolves: tdf#112018 number-columns-repeated has the data type positiveInteger 
Change-Id: I534885fe7a36a8e3ad891a3f5ed50b589f36e3b9
Reviewed-on: https://gerrit.libreoffice.org/41692
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-29 15:10:19 +02:00
Caolán McNamara
384abc0615 Related: tdf#112018 limit to min of 1 before conversion from signed int 
Change-Id: I1a27f9ebfbe70891d64afa9553f37f565f2d49bf
Reviewed-on: https://gerrit.libreoffice.org/41689
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-29 15:04:39 +02:00
Markus Mohrhard
663b0a92dc update the gtk updater icon with the new updater icon 
Change-Id: I658a1ec54e74fe57efcaec873991d66be7ba31c1
 2017-08-29 14:58:48 +02:00
Markus Mohrhard
4b1f1d6aef disable unstable UNO API tests 
Change-Id: I2a2ea122c1e95fca0e14884e8194f5c75c591bdf
 2017-08-29 14:55:00 +02:00
Noel Grandin
bcc372d15e loplugin:constparam in sc part8 
Change-Id: I6cf9c5e662b20de9c9698a8c1fab56a09950c522
Reviewed-on: https://gerrit.libreoffice.org/41683
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 14:15:16 +02:00
Tor Lillqvist
3878c4725f Use 1-based numbers in the ScAddress debugging output operator << 
Change-Id: If9f685bc504d9da8011c1788dfb90dc29b86e9ea
 2017-08-29 15:14:34 +03:00
Caolán McNamara
4b44a42b6a Resolves: tdf#111865 ensure draw after SetProgressValue uses new value 
and always erase the background so we can go backwards as well as forwards

Change-Id: Ibdf215320d0eeb3392cd21d3e1fd5c0535e6cd31
Reviewed-on: https://gerrit.libreoffice.org/41675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-29 13:40:53 +02:00
Caolán McNamara
6748074004 Resolves: tdf#111760 cancel file dialog on terminate 
schedule cancel dialog in query termination, take ownership of the desktop and
re-schedule terminate to be re-attempted after the dialog is cancelled

Change-Id: I5c061b47959baba138c6c23aaae365f28e9cf167
Reviewed-on: https://gerrit.libreoffice.org/41181
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-29 12:50:08 +02:00
Tor Lillqvist
e6abf10fa2 Add cautionary comment 
Change-Id: I6003e8193bf58ba21cd8d5abe42959b489b2f39d
 2017-08-29 13:44:38 +03:00
Eike Rathke
8c0c897c8c Export to PNG: init DPI with screen resolution, tdf#108317 
This whole concept of "use a JPG dialog for PNG export" is nonsense anyway,
but.. as long as there isn't anything better at least have sensible defaults.

Change-Id: I0c074f7bb2989122aed039c739fd1813f371cbca
 2017-08-29 12:42:52 +02:00
Eike Rathke
d34fa1fc64 Export to PNG: export selected cell range only, not as page, tdf#108317 
Change-Id: If662f4ed360c702e572fc5d7b473eb53b9cb14d2
 2017-08-29 12:42:52 +02:00
Eike Rathke
408b260c4f Add keeper for FmFormView* pDrawView 
So later we can bail out at any point without having to manually keep track of it.

Change-Id: I4414456b870d4a82b4baf8209bdabcc5a8b63c35
 2017-08-29 12:42:52 +02:00