Commit Graph

405411 Commits

Author SHA1 Message Date
Matteo Casalin
7a2f07c4bd Use just geParameter instead of hasParameter + getParameter
getParameter returns and empty string if the key is not found,
so we can just avoid searching twice for the same key.

Change-Id: Ic48debce05fe94d8e087b64bde5a589e54bfb616
2017-03-19 17:12:26 +01:00
Matteo Casalin
e256519a62 OUString-related simplifications
Change-Id: I2f4099410bcdb9e04583cd37bf63ef86ce81f7e5
2017-03-19 17:12:25 +01:00
Matteo Casalin
4a268ebc3f Can return const OUString&, here
Thanks to Noel Grandin for his suggestion.

Change-Id: Ia0d9c46c03928e5551e766572c814f4e9ba6f278
2017-03-19 17:12:25 +01:00
Matteo Casalin
3563fef956 SfxViewFrame::ExecReload_Impl - remove written-only variable aURL
Its only user was commented-out by commit 6c1be80980
(2004) and then removed by commit 40fe03745f (2010)

Change-Id: I821a97275b79230e9e389a9b57c82110fa16aa8e
2017-03-19 17:12:24 +01:00
jan Iversen
03feb95030 ios LibreOfficeLight
start project with sidemenu and navigation

the aim of the project is to provide an IOS prototype
based on work from the online repo and added up with
native swift work.

The project aims at having a simple editor, where the user
can correct typos etc. in complex documents. Sharing will
be done using the iCloud drive.

The project is a proof of concept, to replace the current
android/ios viewers.

The document will be presented using the webkit (available
in both IOS and Android) and reusing the Javascripts from online.
Thereby having one set of files to handle user interface for online,
android and ios.

The sidebar is intented to be used similar to MUFFIN (notebook bar),
while the action is for save/print etc.

Change-Id: I307a70b87e6367de2d22c1360a3e9cfa53d373a9
Reviewed-on: https://gerrit.libreoffice.org/35376
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
2017-03-19 15:49:17 +00:00
Andrea Gelmini
34ccc9c486 Fix filename reference
Change-Id: I0110d61bc9505a880e5e6e70d430eae1fab9aeff
Reviewed-on: https://gerrit.libreoffice.org/35428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 15:30:14 +00:00
Khaled Hosny
12490e743f This can move out of the header as well
Change-Id: I995ad7fb040e11363a70ee2b5cd88e068f06771c
2017-03-19 17:01:02 +02:00
Khaled Hosny
550c6ed03a Typo
Change-Id: Icdcf060b8e6d5ecbb08a1915261687026d674c0b
2017-03-19 16:55:17 +02:00
Szymon Kłos
2cfc214c6b Notebookbar: transparent icon for breeze_dark
Change-Id: I01827e4064ed7b43a9d517cdd14716eeef4d054e
2017-03-19 15:42:29 +01:00
Caolán McNamara
d433bb874a sync with final upstream commit
Change-Id: I7ebe6096a63f1da29523295b8065c998809e125a
2017-03-19 13:39:39 +00:00
Stephan Bergmann
cffc082ec7 loplugin:loopvartoosmall
Change-Id: Ie83c881db64a857bb542ffc8e298f585f3880d73
2017-03-19 13:21:59 +01:00
Julien Nabet
b3be89a02c cppcheck: alloca (vcl/printerjob)
Remove it since useless
Add an assert to pBuffer
Remove an useless variable

Change-Id: Icac2bc6582ca6f2bebe628e9454b9212206b269d
Reviewed-on: https://gerrit.libreoffice.org/35408
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19 10:51:04 +00:00
andreas kainz
fd69755082 update page breeze icons
Change-Id: I0a2d92b8c5bdf1ab37f4ac4c4fe6ffa3ad066f2f
Reviewed-on: https://gerrit.libreoffice.org/35416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-19 10:35:45 +00:00
Caolán McNamara
cd3e18c2cf ofz#907 divide by zero
Change-Id: I663761239efe195b2051cf4410eca2a3362e5de8
2017-03-19 10:23:49 +00:00
Andrea Gelmini
47a9523f3f Fix typos + some German translations
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253
Reviewed-on: https://gerrit.libreoffice.org/35406
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 10:05:45 +00:00
andreas kainz
6b9498c65b add titlepagedialog breeze icon
Change-Id: Ic7d30eb0c5ab85cdd62fb7d07e3d22c8352af47d
Reviewed-on: https://gerrit.libreoffice.org/35417
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-19 09:32:43 +00:00
andreas kainz
b0ced89524 add tablenumberformatdialog icon for 32px Breeze size
Change-Id: I0f93f3478b8320215ebf8ad4a6ea69182f62c51f
Reviewed-on: https://gerrit.libreoffice.org/35399
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-19 09:31:03 +00:00
andreas kainz
53bfc6de0d add entirecell for 32px
Change-Id: I0b2e2cc3cad9835d4fb3e13c43eab626079d7d23
Reviewed-on: https://gerrit.libreoffice.org/35397
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-19 09:29:36 +00:00
andreas kainz
e6341a9485 update showtrackedchanges icon with addwatch
Change-Id: Icbde59ec6f2b99560dc110a5f5d28a08d05fe71f
Reviewed-on: https://gerrit.libreoffice.org/35378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-19 09:29:09 +00:00
andreas kainz
e1b9714aa8 add savemodified_extralarge icon to breeze
Change-Id: I3ef5d0ef0d2d65478a281aca406ca14ecc075b90
Reviewed-on: https://gerrit.libreoffice.org/35327
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-19 09:27:26 +00:00
Takeshi Abe
70f034497b starmath: Make DoTerm() return the top of the stack
without pushing it. Client code do it instead, so no logic changes.

Change-Id: I7ea95b4bddc4e1ef7270cfe02d4f8ad3dc1f19d0
Reviewed-on: https://gerrit.libreoffice.org/35400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-19 06:52:48 +00:00
Andrea Gelmini
d948d66509 Fix typos
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085
Reviewed-on: https://gerrit.libreoffice.org/35413
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19 05:49:15 +00:00
dennisroczek
7e24cedb9e fix typo/grammar: "the the" --> the
* also removing pointless ASCII art (tdf#62475)
* truncate ending whitespace in Doxyfile

Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5
Reviewed-on: https://gerrit.libreoffice.org/35151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19 05:43:51 +00:00
dennisroczek
de084e09cf fix grammar/typo: defunctional --> nonfunctional
Change-Id: I672ac5d22c79e63cafc6f9f9f31f69e82dedf342
Reviewed-on: https://gerrit.libreoffice.org/35405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19 05:40:40 +00:00
Mark Hung
4cd1cd396a Remove GetVerticalOrientation declaration from header.
Change-Id: Icedd82e7a0092c18e1ff5b4ad4be22f2a30c33e2
Reviewed-on: https://gerrit.libreoffice.org/35384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19 05:38:40 +00:00
Chris Sherlock
2667435ea5 vcl: have AcquaSalInstance use osl::Condition instead of oslCondition
Condition is deprecated already, but there is no need for the
AcquaSalInstance class to use the low-level C-API, when in fact there
is a C++ fascade that calls on this via the C++ abstraction,
osl::Condition.

This will make it much easier to switch to using std::condition_variable
in the future.

Change-Id: Ic495c4120a59480bf50a8c5b73608874fc4228ea
Reviewed-on: https://gerrit.libreoffice.org/35392
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-19 05:26:50 +00:00
Julien Nabet
96a9b38db5 Typo: sucess->success + "adminsitrator" fix
Change-Id: I42fdb0a60b987af92e0433e7ff0e5754bc1da748
Reviewed-on: https://gerrit.libreoffice.org/35412
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18 22:18:09 +00:00
Tamás Zolnai
d1f3219e77 tdf#104722: Align text correctly also during editing
Change-Id: Icd21aa5be70adf6637bc20f7f511ff26d2955fc2
Reviewed-on: https://gerrit.libreoffice.org/35415
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-18 21:54:30 +00:00
Caolán McNamara
4154b710ae use SAL_NO_FONT_LOOPUP for consistent results
Change-Id: Ibdc0df66325b49fb24c8e59c86beb2875b0e200e
2017-03-18 21:41:30 +00:00
Caolán McNamara
cfd7493704 noone cares about the return value
Change-Id: I1f5e0ea481c39b92726812722d3f6f782f3cec9d
2017-03-18 21:41:29 +00:00
Caolán McNamara
6889fa826e rework jpeg error handling to throw rather than setjmp to avoid leaks
Change-Id: I00e5041db7dcfb71d646438f7fda538d90ce6223
Reviewed-on: https://gerrit.libreoffice.org/35414
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-18 21:07:40 +00:00
Adolfo Jayme Barrientos
78d3af7260 Updated core
Project: help  42188315ed1aef6b50e73b968da52739fdc9a76e

We’ve recently stopped abusing the product logo for a UI element…

… so its appearance-based description has gone stale.

While I’m here, I’m fixing a preposition, word spacing and quotation marks.
String changes are painful for translations, so this saves time.

Change-Id: I56b2a9830e02f166af048a9900c26bdc59f79223
2017-03-18 19:48:00 +00:00
Julien Nabet
4c2b298afc Use char instead of unsigned char
to avoid some reinterpret_cast
+ prepare to replace some alloca calls
+ replace C cast by using plain char assignment

Change-Id: Iff65b9a324ca1cc936c9effd2b3b71596d6e9b0f
Reviewed-on: https://gerrit.libreoffice.org/35398
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18 19:12:14 +00:00
Julien Nabet
68722bd4ba Typo: BimapPainter->BitmapPainter
Change-Id: I2176e0050ca92de0f2effb7257dd7ebba2a4f439
Reviewed-on: https://gerrit.libreoffice.org/35411
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18 18:22:32 +00:00
Caolán McNamara
7ceeae3823 ofz: floating point exception in values close to zero
Change-Id: Idd8c7d4dd42c63f4f4a67ba61b9f3760ec04f2f1
2017-03-18 17:10:25 +00:00
Zdeněk Crhonek
1e02750ef2 VBA tests - add CVDATE,CVERR,DATEADD test case
Change-Id: Ib6b79eb3a3daf22dd4f15427a3e8547300f8b8f9
Reviewed-on: https://gerrit.libreoffice.org/35403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-03-18 16:26:09 +00:00
Caolán McNamara
7cf3f4d1d7 ofz#891 an exception is an acceptable outcome
Change-Id: Ia5939b81f6bc2d44a4966266a91ed14d4fafad2f
2017-03-18 16:15:54 +00:00
Jean-Pierre Ledure
4436bef02b Access2Base - Get and set On... properties on dialog events
The technique used on form, subform and control events
is not applicable on dialog events
Workaround now implemented

Change-Id: Ie729e47e6f87f156536fd43ab4bfa36cb6ae35f6
2017-03-18 16:46:41 +01:00
Caolán McNamara
23a7498fdd valgrind: uninitialized value
and can use a simple vector here

Change-Id: If27e881c4ae7a1a068fdbb1c0a689ecc78804095
2017-03-18 12:38:05 +00:00
Rosemary Sebastian
109210e5b7 Revert "Revert "Implement export and import of author field in fixed format""
This reverts commit cae16645e1.

Change-Id: If5b85beb53a0925909d537023879a7d86fa011cf
Reviewed-on: https://gerrit.libreoffice.org/35391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-18 11:54:54 +00:00
Michael Stahl
198b6c16e7 Fix MSVC hang in ThreadPool::shutdown()
This is the vclbootstrapprotector.cxx part of
9899ffd244, which unblocks
hanging unit tests on a number of VS2015 tinderbox hosts

Change-Id: I6dcfd5a85c078953f0dc6fba0311d9e750f8ce5e
Reviewed-on: https://gerrit.libreoffice.org/35393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-18 11:27:04 +00:00
Julien Nabet
415059bddf cppcheck: workaround nullpointer false positive with an assert
Change-Id: Ib94d64ed5076b5603e99fa9632d25e85395b6ff1
Reviewed-on: https://gerrit.libreoffice.org/35395
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18 11:10:17 +00:00
Julien Nabet
468d2964e9 cppcheck: nullPointer
Avoid to forget E_POINTER return value

Change-Id: I1887d20c7d73dcd3c6ddc1287b6c1ad6c13dd69f
Reviewed-on: https://gerrit.libreoffice.org/35394
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18 11:07:43 +00:00
Chris Sherlock
c154f9a082 vcl: change opengl gpWatchdogExt from oslCondition to osl::Condition
Condition is deprecated already, but there is no need for the
us to use the low-level C-API, when in fact there is a C++ fascade
that calls on this via the C++ abstraction, osl::Condition.

This will make it much easier to switch to using std::condition_variable
in the future.

Change-Id: I0d7fda22ad00a79767b68cd06f00decfc0555371
Reviewed-on: https://gerrit.libreoffice.org/35390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18 11:01:24 +00:00
Chris Sherlock
5198b4b8c7 vcl: make GtkData use osl::Condition instead of oslCondition
Condition is deprecated already, but there is no need for the
GtkData class to use the low-level C-API, when in fact there is a C++
fascade that calls on this via the C++ abstraction, osl::Condition.

This will make it much easier to switch to using std::condition_variable
in the future.

Change-Id: Iddd2cad0e1137c0b458ebe25b506d463847a6dc0
Reviewed-on: https://gerrit.libreoffice.org/35389
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18 10:57:27 +00:00
Chris Sherlock
3961387192 salhelper: change oslCondition to osl::Condition
Condition is deprecated already, but there is no need for the
us to use the low-level C-API, when in fact there is a C++ fascade
that calls on this via the C++ abstraction, osl::Condition.

This will make it much easier to switch to using std::condition_variable

Change-Id: Ia362666ff241293e143de0fa1dc0bc3a990bef82
Reviewed-on: https://gerrit.libreoffice.org/35388
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18 08:24:25 +00:00
Chris Sherlock
5ec1713ae5 vcl: have SolarThreadExecutor use osl::Condition, not oslCondition
Condition is deprecated already, but there is no need for the
SolarThreadExecutor class to use the low-level C-API, when in fact there
is a C++ fascade that calls on this via the C++ abstraction,
osl::Condition.

This will make it much easier to switch to using std::condition_variable
in the future.

Change-Id: I81e8530d42fe1451c4ca5bce998b13de0576bc4e
Reviewed-on: https://gerrit.libreoffice.org/35386
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18 08:02:26 +00:00
Adolfo Jayme Barrientos
1e7d1f2721 Updated core
Project: help  d0bd7a8b5d81eac901ad1b9840d4d83d1f1c85da

I renamed this button a while ago…

Change-Id: I18453f5bf0d9418a60733eaef01ac979ac89a937
2017-03-18 06:20:04 +00:00
Khaled Hosny
6c0525ff45 Move the check to start, clearer this way
Change-Id: I6c7626161d7f8ab8ee2a8a87eea470338861d80e
2017-03-18 08:00:04 +02:00
dennisroczek
a87f678e7b fix typo: amd --> and
Change-Id: I2905e8bbc659ab8a6344b172980d20455a67e87e
Reviewed-on: https://gerrit.libreoffice.org/35319
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18 05:35:13 +00:00