mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
391,105 Commits 1 Branch 0 Tags
f41257dc9913cd6020a3a37bf425c20b51e18ece
Commit Graph

2511 Commits

Author SHA1 Message Date
Caolán McNamara
4f92eb777a Resolves: tdf#99425 crash when closing dialog editor 
with undocked "Object Catalog" toolbar

Change-Id: I70d51cec699333c5cfc1461d61734c1bbb5323da
 2016-04-21 16:10:23 +01:00
Noel Grandin
8762aa986d clang-tidy modernize-loop-convert in b* 
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
 2016-04-21 10:27:17 +02:00
Noel Grandin
789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Jochen Nitschke
150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Ryan McCoskrie
a6af1b545a Remove the hardly used SyntaxLineSet typedef 
Change-Id: Ib38bbbdcc65620329d1471d0d61ede65c4f834e6
Reviewed-on: https://gerrit.libreoffice.org/24176
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:17:02 +00:00
Julien Nabet
60b61b7859 tdf#97380: don't destroy completely window when replace dialog 
0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210
210	        inline  bool    isApplication() const   { return m_bValid && m_bIsApplication; }
(gdb) bt
0  0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210
1  0x00002aaaf64fa12e in basctl::ScriptDocument::isApplication (this=0x576b458) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:1311
2  0x00002aaaf648f6d7 in basctl::MarkDocumentModified (rDocument=...) at /home/julien/lo/libreoffice/basctl/source/basicide/basobj3.cxx:256
3  0x00002aaaf645e2a9 in basctl::implImportDialog (pWin=0x576b210, rCurPath=<error reading variable: Cannot access memory at address 0x999999999999999d>, rDocument=...,
    aLibName="Standard") at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1154
4  0x00002aaaf645eda9 in basctl::DialogWindow::ImportDialog (this=0x576b210) at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1213

Change-Id: I7365b2cacc8a3783fdc8e573bbc10ff574d9c4ed
Reviewed-on: https://gerrit.libreoffice.org/24139
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-04-16 22:27:16 +00:00
Julien Nabet
5b72c4ce7f basctl: prefix some members 
Change-Id: I59660153a33e83dc9457fbee082e8da444b04b58
Reviewed-on: https://gerrit.libreoffice.org/24126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-04-16 14:17:11 +00:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Stephan Bergmann
58ecaf1f47 Get rid of _SVX_NOIDERESIDS 
Change-Id: Iab728d51c24ccbedad5fa181850a673129d489ae
 2016-04-12 15:50:23 +02:00
Noel Grandin
48b8898bd7 clang-tidy performance-unnecessary-value-param in basctl 
Change-Id: Ie48eb08edd1335661d1ef57ae652713143951317
 2016-04-12 12:05:01 +02:00
Jochen Nitschke
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes 
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-12 06:38:26 +00:00
Jochen Nitschke
b4ddacbc55 fix copy assignment signatures 
get value by reference

introduced in
commit 8c2f2e1dd7 and
commit f9b200ce54

Change-Id: Iba84dd752f4cbdde9f3676c434d107efabe63a38
Reviewed-on: https://gerrit.libreoffice.org/23974
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-11 07:05:40 +00:00
Noel Grandin
db43ef00c1 sequence->vector in xmlscript 
Change-Id: I4f99cd9dc659f54bd4818559dd3e0dbce1e8f5d4
Reviewed-on: https://gerrit.libreoffice.org/23795
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-05 06:25:39 +00:00
Caolán McNamara
03d3506286 cppcheck: noExplicitConstructor 
Change-Id: I9510a16bf4ac5dd2c3da16c618841918daea8cfb
 2016-04-04 10:41:01 +01:00
Jochen Nitschke
8c2f2e1dd7 tdf#94306 replace boost::noncopyable in .. 
.. accessibility, avmedia, basctl, basic and bridges
remove boost from module if not needed anymore

Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2
Reviewed-on: https://gerrit.libreoffice.org/23744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-04 06:54:36 +00:00
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes 
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-02 19:01:24 +00:00
Wastack
0b8e5ca5a2 tdf#97966 Drop 'static' keywords 
Including no keywords from extern "C" blocks

Change-Id: Id0304994a692f1004993dda2ffd7fb819ab8e8d0
Reviewed-on: https://gerrit.libreoffice.org/23670
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-01 06:44:05 +00:00
Michael Stahl
51d7f466df sfx2: make SfxDispatcher::Execute() less variadic ... 
... and less overloaded; C++11 initializer_list should make undefined
behavior as fixed in ba0a866b83 less
likely.

Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865
Reviewed-on: https://gerrit.libreoffice.org/23666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-03-31 11:19:23 +00:00
Noel Grandin
1aa4df615f use SAL_N_ELEMENTS in for loops 
for with
  git grep -n 'for.*sizeof'

Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f
Reviewed-on: https://gerrit.libreoffice.org/23569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-31 08:00:13 +00:00
Michael Stahl
ba0a866b83 tdf#96505: fix wrong SfxDispatcher::Execute calls ... 
... that are now busted on all 64-bit platforms since commit
57d0caacee but were already busted only
on 64-bit WNT before.

SfxDispatcher::Execute(sal_uInt16 nSlot, SfxCallMode eCall,
    const SfxPoolItem*  pArg1, ...)
assigns the varargs to a "const SfxPoolItem *", so passing in
"0L" is only correct if long is 64-bit, but on WNT 64-bit long is
32-bit, so use "nullptr" already.

Change-Id: I50448d8ad121c4881be549623d44c44b00e56d98
 2016-03-30 14:42:47 +02:00
Noel Grandin
c92d8866af loplugin:constantparam in basctl 
Change-Id: I08ab924a9bb69bede4247cfe8c50921520a4f4a7
 2016-03-23 11:22:34 +02:00
Noel Grandin
c91b103930 convert SvButtonState to scoped enum 
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
 2016-03-18 12:46:35 +02:00
Noel Grandin
0008c67004 drop unused params from SvLBoxItem and all it's subclasses 
looks like this is fallout from commit
ac7acb0a "Merged SvTreeListBox and SvLBox."
(in year 2012)

Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
 2016-03-18 11:03:00 +02:00
Noel Grandin
db93b92d78 loplugin:constantparam in sfx2 
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd
Reviewed-on: https://gerrit.libreoffice.org/23321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-17 11:02:18 +00:00
Noel Grandin
8ca50d20c1 loplugin:constantparam in tools 
Change-Id: I3774661799c074561c694515baba42a375d0a077
Reviewed-on: https://gerrit.libreoffice.org/23301
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-17 06:09:42 +00:00
Noel Grandin
b47cb646ff loplugin:constantparam 
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
 2016-03-15 08:27:25 +02:00
Rohan Kumar
eda2459251 tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals 
I removed the OSL_DEBUG_LEVEL > 1 conditional and replaced it
to OSL_DEBUG_LEVEL > 0 as suggested in easy hack.

Change-Id: If5f086f280d01e7a80be59f3c992dc2d0a7663cf
Reviewed-on: https://gerrit.libreoffice.org/23062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-03-12 14:20:11 +00:00
Caolán McNamara
5b3f84cec4 Resolves: tdf#95428 backspace in readonly macro editor hangs 
Change-Id: I16568b00e92d18f32818188ba3ab8df92bbd13aa
 2016-03-09 15:32:07 +00:00
Noel Grandin
5c1c8f53d7 loplugin:constantparam in basctl 
Change-Id: I07d22585e768335f61d70bf18807479a2675804a
 2016-03-09 10:07:46 +02:00
Caolán McNamara
5ea0d6b10d these ResIds are used solely for their number by now 
so cut out the middle-man ResId

Change-Id: Ic83db355cc1a0c7dc70958bca79b466baadaedd0
 2016-03-07 15:26:42 +00:00
Aleksas Pantechovskis
57d0caacee tdf#96505 Remove long integer literal specifier when not needed 
Remove L from integer literals if it does not produce warnings
and does not change semantics

Change-Id: I9573a47d3e3401993a1f0fbcf7df4be20f9e6eba
Reviewed-on: https://gerrit.libreoffice.org/22867
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-04 06:40:33 +00:00
Noel Grandin
5adde1bf69 loplugin:unuseddefaultparams various 
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546
Reviewed-on: https://gerrit.libreoffice.org/22852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-03 11:39:56 +00:00
Noel Grandin
f163745cca convert HighlighterLanguage to scoped enum 
Change-Id: Ibf0871601e52ea4fa49e9622176431943c55abdd
 2016-02-24 11:48:39 +02:00
Noel Grandin
a5e53f9ffd convert TokenTypes to scoped enum 
Change-Id: I17c0a616dd6cf48a22896b6cd6b0df157d1f9a9f
 2016-02-24 11:48:39 +02:00
Maxim Monastirsky
144546b622 tdf#93837 Convert RID_POPUP_DLGED to xml 
Change-Id: I0588063aef397ee95923ad5acd332bc6052fafc7
 2016-02-21 16:41:31 +02:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform 
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 11:33:57 +00:00
danielt998
2b31daf74e tdf#95857 Sort out German plurals ... 
Made a start in removing the incorrect 'Infos' German plural

Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60
Reviewed-on: https://gerrit.libreoffice.org/22301
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-02-12 15:29:25 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Andrea Gelmini
534b2a4b58 Fix typos 
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-02-05 06:48:38 +00:00
Chris Sherlock
697d445ed0 vcl: take into account the font width is the average font width 
I'm changing the Font class function names:

- SetSize       -> SetFontSize
- GetSize       -> GetFontSize
- SetHeight     -> SetFontHeight
- GetHeight     -> GetFontHeight
- SetWidth      -> SetAverageFontWidth
- GetWidth      -> GetAverageFontWidth

That's because it really makes no sense to say that there is a
single constant font width because obviously proportional fonts
don't have one - the best we can do is an average font width,
which is what folks like Microsoft sort of do already. On a fixed
font, the average is still accurate, for obvious reasons :-)

I'm also not a fan of GetSize/SetSize as I find it a might too
generic.

Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70
Reviewed-on: https://gerrit.libreoffice.org/22069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-04 03:17:26 +00:00
Noel Grandin
83b9c51803 sequence->vector in PrinterOptionsHelper 
Change-Id: I643519397a4e714e3407ec0c3a10d329654b9f7d
Reviewed-on: https://gerrit.libreoffice.org/21887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-31 07:09:41 +00:00
Chris Sherlock
d1a49df683 vcl: add text alignment functions to ImplFont and FontAttributes 
ImplFont and FontAttributes now have GetAlignment and SetAlignment,
and I have renamed Font::GetAlign to Font::GetAlignment, and
Font::SetAlign to Font::SetAlignment.

See commit description in 8bfccd3a71 ("vcl: Create accessor
and mutator for font scaling in FontMetric") for reasoning behind
patch.

Unit test added to vcl/qa/cppunit/font.cxx to test text alignment.

Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba
Reviewed-on: https://gerrit.libreoffice.org/21876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-29 01:59:55 +00:00
Stephan Bergmann
cd5431c071 Unwind trivial AccessibleExtendedComponentHelper_BASE typedefs 
Change-Id: I74b30cba1359045873a3d7a3f0e72f857ffa0ed0
 2016-01-27 10:23:48 +01:00
Samuel Mehrbrodt
867af25bd8 tdf#96683 Move tabs in Basic IDE to an own row 
So that the tab height does not depend on the scrollbar height (which is subject to the desktop theme)

Change-Id: Ie2d787528152aed92c9943fe76955bf499d7d2a9
Reviewed-on: https://gerrit.libreoffice.org/21707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-01-22 17:18:28 +00:00
Noel Grandin
a7f6efc68b loplugin: unused return values 
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af
Reviewed-on: https://gerrit.libreoffice.org/21571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-18 12:50:09 +00:00
Chris Sherlock
28c96fc255 vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-17 23:35:37 +00:00
Norbert Thiebaud
45654a1d4d revert vcl patch series that brok Mac and Windows 
revert:
9bc2f3de86
 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105b
 vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b43173
 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ea
 vcl: tabify font.hxx
f99550dae5
 vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb
 vcl: rename Font::GetName to Font::GetFamilyName

Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
 2016-01-16 12:20:45 -06:00
Arnaud Versini
1ae5ceccb8 BASIC : Remove useless methods in StarBasic 
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d
Reviewed-on: https://gerrit.libreoffice.org/21498
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-16 17:06:26 +00:00
Chris Sherlock
2b297116cb vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:11:28 +00:00
Stephan Bergmann
9ff5abf2e1 loplugin:privatebase: Make derivation from noncopyable explicitly private 
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
 2016-01-11 13:17:07 +01:00