mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
391,105 Commits 1 Branch 0 Tags
f41257dc9913cd6020a3a37bf425c20b51e18ece
Commit Graph

535 Commits

Author SHA1 Message Date
Stephan Bergmann
b5758dfd02 Avoid reserved identifiers 
Change-Id: I8ee75a8ba2ca579cf945a7ef2a9746a2eb13611a
 2016-04-18 15:30:08 +02:00
Stephan Bergmann
555619ddf7 Avoid reserved identifiers 
Change-Id: Ia3a9d2edb9ce7bcf9450dd10589d823383210269
 2016-04-12 20:03:45 +02:00
Noel Grandin
6a8873c874 clang-tidy performance-unnecessary-value-param in filter 
Change-Id: I6818f6c9593bfe7105cc194fcf6f69131046e4f3
 2016-04-12 11:25:18 +02:00
Noel Grandin
7f1d68a798 these don't need to be fields on the class 
Change-Id: I6f8bab0b9c286270f1e896629379762e38d448c5
Reviewed-on: https://gerrit.libreoffice.org/23120
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-11 12:38:07 +00:00
Noel Grandin
bc9aa454ff loplugin:commaoperator in filter/ 
Change-Id: I88697862bfb160d4d7d257bf425507567deae837
 2016-02-22 16:41:20 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
7a65837349 loplugin:unusedmethods unused return value in filter 
Change-Id: I42b24bed84ab9b745041166610732d9a074b5f72
 2016-01-11 13:14:08 +02:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Stephan Bergmann
3cdda9af2c loplugin:nullptr (automatic rewrite) 
Change-Id: I61e494952df8cc40fff3ccad0936adf06035dbeb
 2015-11-10 10:31:25 +01:00
Caolán McNamara
e1d1154d09 coverity#1338246 Uncaught exception 
Change-Id: I149f41989575b19eb113cdeca217839b4a0a7d18
 2015-11-06 12:15:50 +00:00
Stephan Bergmann
cc6e40d5a7 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I90ec231ed163b9bd501993b64188deab10823e14
 2015-11-06 09:35:56 +01:00
Noel Grandin
1b41208608 use uno::Reference::set method instead of assignment 
Change-Id: I3d94c94a9829161663a7ed18421ace38ce95a659
Reviewed-on: https://gerrit.libreoffice.org/19733
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-02 06:17:21 +00:00
Noel Grandin
0e6544903b no need to be so verbose in constructing uno::Reference 
Change-Id: I187a26e200e9ecaff2adaf53a2ba3f6e87346030
Reviewed-on: https://gerrit.libreoffice.org/19724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:26:10 +00:00
Stephan Bergmann
e07d58cd65 loplugin:defaultparams 
Change-Id: If7a81c87ebc2e7f72498fbee025b0e98bc84ce60
 2015-10-20 11:45:30 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Caolán McNamara
56a5734b06 cppcheck: noExplicitConstructor 
Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
 2015-10-05 20:30:59 +01:00
Noel Grandin
bd8a4ae223 com::sun::star->css in filter/ 
Change-Id: I3a5e6a349c903259698118542b0000b0f119859e
 2015-10-01 12:20:41 +02:00
Stefan Heinemann
c50eb68af3 Renamed wrongly prefixed boolean variables 
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-09-29 18:33:40 +00:00
Noel Grandin
cf0c04a428 convert Link<> to typed 
Change-Id: I85658fa35b9b85106a3b9c8ef303584cad6f39b0
 2015-09-11 08:48:54 +02:00
Noel Grandin
61623d5b90 convert Link<> to typed 
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
 2015-09-08 08:16:46 +02:00
Noel Grandin
5beffcf3f1 convert Link<> to typed 
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83
Reviewed-on: https://gerrit.libreoffice.org/18258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-03 07:20:27 +00:00
Noel Grandin
68ddda0f3f convert Link<> to typed 
Change-Id: I53b0a7a9875a3ebcca915c8f2d8c53face6f9509
 2015-08-31 09:50:10 +02:00
Stephan Bergmann
a6050c32f3 Clean up aEmpty 
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
 2015-08-27 08:00:32 +02:00
Noel Grandin
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void> 
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
 2015-08-26 11:15:35 +02:00
Stephan Bergmann
5da0dce19c Consolidate isFileUrl checks 
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
 2015-08-19 12:24:37 +02:00
Takeshi Abe
678bb5135b tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, for filter.

Change-Id: I30dcd7cfb3e484034f6cceceb1ff7cd9d3f4b7a6
Reviewed-on: https://gerrit.libreoffice.org/17585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-11 07:06:51 +00:00
Noel Grandin
a90c6eb99c loplugin:unusedmethods filter 
Change-Id: Ie33a5ebda9337cf123b39ae18a8d7b4ef12b6991
Reviewed-on: https://gerrit.libreoffice.org/17131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 06:50:58 +00:00
Stephan Bergmann
db081acb01 loplugin:stringconstant: Flag more inefficiencies 
Change-Id: I7d8b0ab33980726ffb4887b1f19797702d224191
 2015-06-25 12:38:36 +02:00
Stephan Bergmann
b5a062bd1c loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I2976a8e6a3c9abf70e153a71bf0374d24d92968d
 2015-06-08 16:25:08 +02:00
Noel Grandin
24600dcf31 loplugin:constantfunction 
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
 2015-05-22 09:59:46 +02:00
Tomaž Vajngerl
e1b653b173 cleanup XMLFilterSettingsDialog 
Change-Id: I5e42afe348004daa99c0d3b331bb1fe0f84bd309
 2015-05-18 15:55:00 +09:00
Stephan Bergmann
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK... 
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
 2015-05-10 11:25:47 +02:00
Michael Meeks
266ce1cd53 tdf#91052 - more macros for 'make' constructors. 
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
 2015-05-09 21:39:57 +01:00
Stephan Bergmann
5eb6bd4db7 lopluign:staticmethods: Handle DECL_LINK 
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
 2015-05-08 19:15:32 +02:00
Noel Grandin
39078c247d cleanup DIALOG_NO_PARENT, follow on to tdf#91090 
remove the DIALOG_NO_PARENT abomination and replace it with a flags
parameter

Change-Id: I71b7dc46c619f2db56af6d4dc2c17daf0a2c8534
Reviewed-on: https://gerrit.libreoffice.org/15645
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-06 12:12:26 +00:00
Noel Grandin
0a442d3815 loplugin:staticmethods 
Change-Id: I4d19f868a618cb135aa7a949222972dc35b47d2a
 2015-05-05 14:05:20 +02:00
Noel Grandin
7d426e6fd6 loplugin:staticmethods 
Change-Id: I97160fc51dc16ff92b06d44570298eeec637e132
 2015-05-05 14:05:20 +02:00
Noel Grandin
d3b5038cbb loplugin:staticmethods 
Change-Id: Iea68c4e466dd8e1cb7164959a680e5e52542166b
 2015-05-05 09:30:39 +02:00
Stephan Bergmann
b95427196e Use typed TabControl::SetDeactivatePageHdl Link 
Change-Id: I487aad5217cb685ece971717445a68b4fb3d2b3a
 2015-05-04 17:54:51 +02:00
Stephan Bergmann
0dccc59702 Use typed MaybeFile Link 
Change-Id: Ic9eebca9d8fe3e9173b1873bdc7800e5161f9999
 2015-04-30 10:53:10 +02:00
Stephan Bergmann
3ead3ad52f Gradually typed Link 
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
 2015-04-30 10:20:00 +02:00
Tomaž Vajngerl
9905a8b953 replace Paint calls to Invalidate + fix compilation 
Change-Id: Id716c47d56922ab6ce0c3adb3d426ea814980674
 2015-04-29 09:24:20 +09:00
Tomaž Vajngerl
f50fd9692e mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&) 
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
 2015-04-29 09:19:47 +09:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Noel Grandin
321d924f15 convert HIB_ constants to scoped enum 
Change-Id: I6fa3ecde4a1c5f9c7e6e1dcd22250cba065933e3
 2015-04-22 10:28:40 +02:00
Michael Meeks
9e43761446 filter: convert new to ::Create. 
Change-Id: I6cea3011ff3c89c95fa19cc4264b43779aa0e0a9
 2015-04-17 12:26:44 +01:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Michael Meeks
8a65284fe3 Automated conversion of VclPtr construction to use Instance template. 
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
 2015-04-10 13:40:25 +01:00
Noel Grandin
61b224f392 vclwidget: fixup locally allocated vcl::Window objects 
They need to be wrapped in ScopedVclPtr in order to be disposed properly.

Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
 2015-04-10 12:37:44 +01:00
Noel Grandin
d7a84ce840 vclwidget: only call dispose() once 
by using a new utility method in vcl::Window
This means that we don't have to make all our dispose
methods safe to call more than once.

Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
 2015-04-10 10:55:36 +01:00