mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
391,105 Commits 1 Branch 0 Tags
f41257dc9913cd6020a3a37bf425c20b51e18ece
Commit Graph

797 Commits

Author SHA1 Message Date
Noel Grandin
789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Noel Grandin
62633dfe02 clang-tidy performance-unnecessary-value-param in various 
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-14 11:37:19 +00:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Noel Grandin
a31840be01 reduce unnecessary reallocing 
Change-Id: I01880cfecdab4addb358c74cbcdc02c98c0d6224
Reviewed-on: https://gerrit.libreoffice.org/23764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-04 09:19:15 +00:00
Noel Grandin
b4fda7b3f9 new loplugin:constantparam 
finds parameters that are only ever being called with a single value

Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
 2016-03-08 09:04:47 +02:00
Noel Grandin
c45d3badc9 new loplugin: commaoperator 
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
 2016-02-23 08:08:56 +02:00
Noel Grandin
778e9a65bf new loplugin: find write-only fields 
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717
Reviewed-on: https://gerrit.libreoffice.org/22498
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-19 11:23:57 +00:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform 
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 11:33:57 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Andrea Gelmini
64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Stephan Bergmann
e9aa3c99d2 Simplify code 
Change-Id: I28cff254d2cc1e2abe6fc893d918bd84bfc8645c
 2016-01-05 12:25:31 +01:00
Stephan Bergmann
ce3dd82ca8 Clean up configuration access 
Change-Id: I0662e8ddb24f2c6a7197b8a5f23c219484628b78
 2016-01-05 12:25:31 +01:00
Stephan Bergmann
549e900b4b tdf#96855: Put back assignment of xHierAccess 
...that had inadvertently been removed as part of a larger code removal in
6948c546fd "tdf#75637: Resolve help images via a
vnd.libreoffice.image UCP"

Change-Id: Ic2d5e1a5fa5a10b240bb9e511e6dcb8097e58081
 2016-01-04 15:16:44 +01:00
Noel Grandin
4c7ce41582 loplugin:unusedfields in xmlhelp,xmloff 
Change-Id: I4d2f0ff95da5abaa3d0a0a5223616e09e0c476fc
 2015-12-21 12:45:49 +02:00
Noel Grandin
e18b08363a loplugin:unusedmethods 
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
 2015-12-21 10:20:31 +02:00
Stephan Bergmann
e65233abd4 -Werror,-Wunused-private-field 
Change-Id: I4649381a330bc4e9d4f419137f0393f6f35bea17
 2015-11-26 13:47:36 +01:00
Noel Grandin
abc6071b7a loplugin:unusedfields various 
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
 2015-11-26 13:26:25 +02:00
Noel Grandin
fa452b54a5 com::sun::star->css in xmlhelp 
Change-Id: Iaa57a071f8f0e6945d24f019cb4c06e02d066e0a
Reviewed-on: https://gerrit.libreoffice.org/20147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-25 04:47:05 +00:00
Noel Grandin
22c5968314 loplugin:unusedfields in xmlhelp/ 
Change-Id: I1db28ad3670c166201050a4e19a50ec13a82fa76
 2015-11-24 10:09:26 +02:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Noel Grandin
25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Stephan Bergmann
87bae0e188 loplugin:nullptr (automatic rewrite) 
Change-Id: Ibdc68ac3fa6e1424337096c720c8c9605b767480
 2015-11-10 10:32:01 +01:00
Stephan Bergmann
fd80fa38db loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9ee0d12d68cef7bd65d1e119d0272e356e7cf300
 2015-11-06 09:38:40 +01:00
Noel Grandin
9e8ff13eb2 use uno::Reference::set method instead of assignment 
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
 2015-11-05 13:32:17 +02:00
Noel Grandin
59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Noel Grandin
b5db48ada1 no need to use OUString constructor in call to createInstance 
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:25:43 +00:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Michael Stahl
03802af730 xmlhelp: apparently "picture.jar" hasn't existed for a long time 
Change-Id: I9ac46ffcf21e8af2cb3b92d4068981cafb271ebc
 2015-10-27 14:39:56 +01:00
Stephan Bergmann
6948c546fd tdf#75637: Resolve help images via a vnd.libreoffice.image UCP 
...which uses the logic already available in VCL's ImplImageTree to locate the
image zip files and find fallbacks for incomplete themes and for localized
images.

Change-Id: Ic1c15fcacb6596a27a2b051093232902202bf472
 2015-10-26 17:55:14 +01:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code 
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
 2015-10-12 17:52:26 +02:00
Noel Grandin
6b34ac2419 loplugin:mergeclasses 
Change-Id: Ic02d59708670949c3342566753882eebd086438f
 2015-10-12 09:13:34 +02:00
Andrea Gelmini
79797f8e59 Fix typos 
Change-Id: If2e4adb2ce93c02ee14d831eedf4ef31da04b92d
Reviewed-on: https://gerrit.libreoffice.org/18996
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
 2015-09-29 22:14:58 +00:00
Takeshi Abe
ee7da352b8 Resolves: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a
Reviewed-on: https://gerrit.libreoffice.org/18580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-15 06:19:28 +00:00
David Ostrovsky
28ebbf16ad xmlhelp: Add missing include 
Change-Id: Ie369f00a745dba82c8966f51886d74a8a9a7c1ff
Reviewed-on: https://gerrit.libreoffice.org/18523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
 2015-09-13 05:36:01 +00:00
Stephan Bergmann
6afc1202ae loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: I816d2205dcd01d4566054da33439e943a3c6348b
 2015-08-31 08:00:15 +02:00
Stephan Bergmann
5da0dce19c Consolidate isFileUrl checks 
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
 2015-08-19 12:24:37 +02:00
Noel Grandin
a45827b230 loplugin:unusedmethods 
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-30 06:23:00 +00:00
Noel Grandin
38ecca9b30 inline a bunch of use-once macros 
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
 2015-07-27 08:18:16 +02:00
Stephan Bergmann
760e7c269b Remove unused XmlSearchExceptions.hxx 
Change-Id: Iff364452d72c49f6484bed1520b5d2a17c342ddf
 2015-07-07 09:18:54 +02:00
Stephan Bergmann
e1b30d6881 -Werror,-Wunused-private-field 
Change-Id: I80da554ab15450ff6aa13575784ee8f64ca506db
 2015-07-07 09:14:33 +02:00
Noel Grandin
fc0079ee90 loplugin:unusedmethods xmlhelp 
Change-Id: Iaaeb6e6f928c6e40112b6c852a6868e1f4abdc47
Reviewed-on: https://gerrit.libreoffice.org/16793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-07 06:52:29 +00:00
Andrea Gelmini
1c5f07e60c Fix typos 
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 09:14:23 +00:00
Stephan Bergmann
6390d2c52b Get rid of comphelper::string::is*Ascii functions 
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
 2015-06-24 15:27:28 +02:00
Noel Grandin
dcf6abfcdf cppcheck:unreadVariable 
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
 2015-06-15 14:06:31 +02:00
Caolán McNamara
cc0e9a37de cppcheck: variableScope 
Change-Id: If0c56c89e2722d47a401363f3854331229856490
 2015-06-09 10:33:59 +01:00
Caolán McNamara
f8da549db1 Decompressor rubbish in xmlhelp is luckily unused 
Change-Id: I0d44ef4df250921d24da0d202de96f60c567ded6
 2015-06-08 17:52:24 +01:00
Stephan Bergmann
e7b4225fc8 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I4e24ee646763e758a404bf0832e31e5cebc9d71d
 2015-06-08 16:29:59 +02:00
Noel Grandin
6ef9f7e202 loplugin:loopvartoosmall 
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
 2015-06-02 12:09:56 +02:00