395378 Commits

Author SHA1 Message Date
Eike Rathke
569825ea2b comment about using GRAM_ENGLISH_XL_R1C1
... found when looking for GRAM_PODF_A1.

Change-Id: I175f92f297c8720c2d0736d3a30815217e334276
2016-08-03 15:16:51 +02:00
Eike Rathke
4afd35f691 use GRAM_API instead of GRAM_PODF_A1 in API context
... which right now is identical but may get corrections in future.

Change-Id: Id4e1707afb32a3d8e073705072e5e65105f2a14a
2016-08-03 15:16:50 +02:00
Eike Rathke
f21a73bc5b InitSymbolsAPI() for FormulaLanguage::API
Change-Id: I203557ed50d0d54fe9977e3d51e7f979551b472b
2016-08-03 15:16:50 +02:00
Eike Rathke
41eb7eef76 introduce formula::FormulaGrammar::Grammar::GRAM_API
Change-Id: Iceaf114847129f0b014ffd61d547e131baf1f07b
2016-08-03 15:16:50 +02:00
Eike Rathke
f85991efc2 introduce css::sheet::FormulaLanguage::API
Change-Id: I70624ded4060f50ad820a9590cb461fe58abceb9
2016-08-03 15:16:49 +02:00
Jochen Nitschke
fcd222d8cc remove dead code in drawinglayer
static bools were probably used for debugging proposes
and should not be in master
introduced in commits:
 9f6018ec1472d7e4f2f26b300d8c00b09fda1fe8
 ddcf9b9ff2caaffcc59d250b2d7f50ca3ab20330
 d45ddb6d03846b0c576eeee062342962aa131bc0
 7a652a2b2ab5e0d37e32185c8c5fac3af482bb76 and
 70e3eb2c1762fb1ca097cf671e3c7ce3d0dfd1b7

Change-Id: Ided2bf923696cd9fc537f1cb4fedd1a7d4b7c5cd
Reviewed-on: https://gerrit.libreoffice.org/26880
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-03 12:17:58 +00:00
Jochen Nitschke
700bcdbd46 sc: replace REGISTER_..._EVENT macros with lambdas
Change-Id: Ie4aef0c2e5cb89626e3549599b055a1d3ce4054b
Reviewed-on: https://gerrit.libreoffice.org/27506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-03 12:15:04 +00:00
Jochen Nitschke
219a4707ee sc: remove unused code
which was used for import of old BIFF formats

commit e73c4d5013d7a0bf7d72db1773d7125ab91cf269
removed use of readUniString which lead to a cascade
-> readUniStringBody
  -> readUniStringHeader
    -> readUniStringChars
      -> jumpToNextStringContinue

skipRecordBlock got unused with commit
45e4f9e99b75ef8a125228bc42df7fb98af9d7bc

LinkSheetRange getSheetRange(sal_Int32, sal_Int16, sal_Int16 ) const;
is obsolete since commit
c4cb83504faa1d241a116001fd27f7148de300ba

Change-Id: I14c49280ca6f5087852d4c5a26e23a4a12fd9338
Reviewed-on: https://gerrit.libreoffice.org/27254
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-03 12:14:19 +00:00
Caolán McNamara
61062608a2 Resolves: tdf#96873 include template image to make it available in help
alternatively move it into the helpimg dir and change the usage
in helpcontent2, but do it this way to keep it together with the others

Change-Id: I84c6b10aed948a5fea835dc86bade5a4390c716b
2016-08-03 12:59:57 +01:00
Michael Stahl
403eefe81b tdf#101136 dbaccess: use SolarMutex in ModelMethodGuard
There is a deadlock here when storing a ODatabaseDocument on a
non-main-thread while the main thread dispatches some event that calls
into ODatabaseDocument, while holding SolarMutex.

The storing of the document also stores BASIC libraries, and since
commit fca62934f492125ea6728fd6d09f0c66c9e4fa69 the SfxLibraryContainer
uses SolarMutex for locking.

Now we could re-investigate that problem, but it seems unrealistic to
expect ODatabaseDocument's implementation will never call anything
that acquires SolarMutex.

Resistance is futile.  Your locking scheme will be assimilated.

Change-Id: I337d286f3e96c6b2e0dde8682b31faab3f508d20
Reviewed-on: https://gerrit.libreoffice.org/27590
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-03 11:27:44 +00:00
Miklos Vajna
4acac00df5 svx: track view shell id in SdrUndoAction
This is used in Impress e.g. when resizing a picture.

Change-Id: I2e0a9228ed0ff9ecfd72696ef84e56f88e4c0f70
Reviewed-on: https://gerrit.libreoffice.org/27822
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-03 11:06:42 +00:00
Caolán McNamara
405db7afbd Resolves: tdf#100123 prefer notation priority in detecting range/address
i.e. try and parse whether something is a range or an address in order of
document address convention, Calc A1, Excel A1 and Excel R1C1, rather than
check if something is a range in any of those conventions before checking if it
might be an address in any of those conventions.

Change-Id: Ibb744c3eda78a80f33bdbfa5f5ddf0aa5b6361af
Reviewed-on: https://gerrit.libreoffice.org/27821
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-08-03 10:05:27 +00:00
Jakub Trzebiatowski
8c80a56ea9 GSoC Writer Table Styles; Table styles panel; Delete table style
+ Enabled delete from context menu of Table style tab in Styles and Formatting panel

Change-Id: I23523169e0427eb14571102e30fa693b5777af76
Reviewed-on: https://gerrit.libreoffice.org/27797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03 08:43:29 +00:00
Miklos Vajna
e5359520dd sw: use std::move() in RtfAttributeOutput
Change-Id: Ie410d6d34a663fd438d4e4e966578acc74865c55
Reviewed-on: https://gerrit.libreoffice.org/27819
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-03 08:20:30 +00:00
Caolán McNamara
6968be5e27 unused slot argument
Change-Id: Ifdc94afa1af8b573ad9652b7f62ca9beee5df340
2016-08-03 09:15:32 +01:00
Szymon Kłos
89df751d47 GSoC notebookbar: avoid crash while opening menu
Change-Id: I9fb4d329e13d8bfc429adc40c7663645b811a8b8
Reviewed-on: https://gerrit.libreoffice.org/27790
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-08-03 08:09:58 +00:00
Takeshi Abe
9f8f6e032a starmath: SmRootSymbolNode must have type NROOTSYMBOL
Change-Id: I1ce875fba10e0e84fc015cecdb5a36e48ee8ea0e
2016-08-03 16:57:34 +09:00
Zdeněk Crhonek
1b52171752 add YIELD test case
Change-Id: I88bcd9433da6edb5aa59ff01f2590ca74c39219c
Reviewed-on: https://gerrit.libreoffice.org/27805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 22:58:23 +00:00
Zdeněk Crhonek
4ff14e446d add MDETERM test case
Change-Id: Id69ce2d5c19d0b55921dc21143aac7d7bdd0fef1
Reviewed-on: https://gerrit.libreoffice.org/27810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 22:52:15 +00:00
Zdeněk Crhonek
e08e906afa add YIELDDISC testcase
Change-Id: Ie39e922fcf4b56c0aa4c659472683653ceda4482
Reviewed-on: https://gerrit.libreoffice.org/27806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 22:51:48 +00:00
Eike Rathke
88134dcba6 break the Excel rule for YMD and DMY, tdf#101147 follow-up
Clearly in {HH YYYY-MM-DD} the MM should not be minute. Also not in
{HH DD.MM.YY}. Don't follow every bullshit. Period.

It is debatable how to treat MDY, {HH:MM DD/YY} should be different from
{HH MM/DD/YY}, Excel ironically takes both as minute, even in an en-US locale.

Change-Id: I13d39a36294e3c40cc0e9bf72026804b299bb264
2016-08-02 23:52:18 +02:00
Caolán McNamara
4e8bc5462a Related: tdf#101196 prompt to restart after OpenGL config changes
Change-Id: If0ade12ed4cf360bdac8cfbec7bb09c9a640fc6d
2016-08-02 21:04:44 +01:00
Caolán McNamara
40c889105f Related: tdf#101196 shorten description, move info into tooltip
Change-Id: Id3e083dc45135c8af724c64530b6eb4e36c7f6d2
2016-08-02 20:53:57 +01:00
Caolán McNamara
1c33b3f5f6 Resolves: tdf#101196 line wrap very long checkbox content
Change-Id: Ie451b88240f755a0d64dd3db14d7981b8ed2a2a2
2016-08-02 20:49:49 +01:00
Miklos Vajna
c86e89c5bb editeng: track view shells in SfxListUndoActions
This is needed for e.g. tracking deletions by backspace in Writer shape
text.

Change-Id: I6f873872566313096c2c57f4a13ac2f1db67e77d
Reviewed-on: https://gerrit.libreoffice.org/27807
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02 18:57:57 +00:00
Eike Rathke
c82a81bbda Resolves: tdf#100582 SetMatColsRows() when constructing matrix ScFormulaCell
... from an ScFormulaCellGroup token array, because ScFormulaResult that holds
the matrix dimensions is not cloned in that case as we don't clone from an
ScFormulaCell.

Change-Id: I13ab1b29db71ae1618580de995fe12ec423d4dc7
2016-08-02 20:05:28 +02:00
Miklos Vajna
b567278c4a editeng: implement SfxUndoAction::GetViewShellId() interface in EditUndo
With this, e.g. inserting a character in a Writer shape text remembers
its view shell.

Change-Id: Ic82a3f45a66cf622496e3131390d365440dffb3b
Reviewed-on: https://gerrit.libreoffice.org/27796
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02 17:33:17 +00:00
Caolán McNamara
db686815b4 fftester: guard against no drawing object property set
Change-Id: I51736459f9f098d9d793bff3b9a1a403962e099d
2016-08-02 16:08:46 +01:00
Markus Mohrhard
dadd4abdad add missing nullptr check
See
http://crashreport.libreoffice.org/stats/crash_details/173c2c82-7241-44b4-8394-2b5635f7f938

Change-Id: I2a03c6d6a77e3c872b8507c72b47a05db20fd564
Reviewed-on: https://gerrit.libreoffice.org/27791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 15:04:47 +00:00
Caolán McNamara
bb9c9fdd3d gtk2: toggle menubar mnemonics on if any keyinput on it or submenus
this is closer to how I seem to see the gtk menubars work

(gtk3 is native now so this doesn't affect that)

Change-Id: Ie5225d2ccda698946f26408aae95d2a50cbb928b
2016-08-02 14:56:42 +01:00
Zdeněk Crhonek
4e9bd1bc07 add SUMIF (wildcards) test case
Change-Id: Ic07f45043bd3536fe00d3f6440165cd69792a33d
Reviewed-on: https://gerrit.libreoffice.org/27783
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 12:41:10 +00:00
Zdeněk Crhonek
b796090525 add SUMIF test case
Change-Id: I836acc35137a3edd0d73c2c5372230c7968a536d
Reviewed-on: https://gerrit.libreoffice.org/27718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 12:40:22 +00:00
Zdeněk Crhonek
6ae6016a6a add XIRR test xase
Change-Id: I5df06aa71c0b23fa07009f46aa3d1555951f3245
Reviewed-on: https://gerrit.libreoffice.org/27780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 12:33:36 +00:00
Zdeněk Crhonek
e601533855 add GROWTH test case
Change-Id: Ic874210a621923f053725a652f2a67d2ef242dae
Reviewed-on: https://gerrit.libreoffice.org/27741
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-02 12:33:01 +00:00
Caolán McNamara
f6d0d92a5e Related: tdf#92516 make menu accelerators always work even if...
keyboard not used yet.

The gtk2/3 menus appear to work this way. (And when not in gtk2/3
it shouldn't disable the accelerators for other platforms anyway)

Change-Id: Ib7a99bd9039cd07120b3b77380f810b5b028fd57
2016-08-02 13:17:05 +01:00
Miklos Vajna
0762a119fc editeng: make SfxUndoAction::GetViewShellId() interface available
Extend the existing OutlinerViewCallable interface to be able to obtain
the view shell ID of a view shell, even from editeng.

Change-Id: I13708b0e4f58ee86643b913c7d21de022a685223
Reviewed-on: https://gerrit.libreoffice.org/27788
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02 11:13:48 +00:00
Szymon Kłos
9162c483bc GSoC notebookbar: Calc, Impress placeholder icons
Change-Id: I2a18c4d610ab1dac2627284c008207a3dbaab406
2016-08-02 13:03:40 +02:00
Tor Lillqvist
78cdd1b224 Remove some presumably unnecessary leftovers from ancient times
I could not find that SHORTSTDC3 or SHORTSTDCPP3 would have any
meaning. They only occur here (and in our history).

Change-Id: I45141e60c144207fbf3fc0c5e59340b80951b212
2016-08-02 13:22:06 +03:00
Caolán McNamara
772191616a Resolves: tdf#101241 Revert "fix paint table border in DOUBLE_THIN style"
because of the never-ending invalidate and paint of tdf#101241

there was no bug or route to reproduce the original problem so can't
try to solve it a different way.

This reverts commit 9a95520948de1d92c55252aa5f90606b01d6ac9e.
2016-08-02 11:18:25 +01:00
Caolán McNamara
0321dbb9be Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with alt
this returns things to passing the alt to the thing with the focus
and depends on ::Command handlers passing the alt-press/release back
up through the Command hierarchy to get to the default top-level
handler eventually

Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
2016-08-02 10:22:33 +01:00
Miklos Vajna
6d40c515fd libxmlsec: drop xmlsec1-keyinfo-revert.patch.1 completely
And instead attempt to set up the test environment correctly.

Change-Id: I06c10b96749c0464da8d2dd9a59b48f16baeead5
Reviewed-on: https://gerrit.libreoffice.org/27785
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02 08:40:05 +00:00
Jan Holesovsky
010a2a8ed3 Don't use spaces in the product names when packaging.
Change-Id: I55f332117cc7530eb6d562846db379d95e628a22
2016-08-02 10:20:51 +02:00
Noel Grandin
cc252e1641 loplugin:simplifybool
Change-Id: I2e1f288bf71cd5598bccf12322f74c096386b3c9
2016-08-02 08:59:49 +02:00
Noel Grandin
d961af95cd loplugin:countusersofdefaultparams in sfx2
Change-Id: I0a21e2f8069bc698700e97e7c5e4ae508240ff98
Reviewed-on: https://gerrit.libreoffice.org/27761
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02 06:58:37 +00:00
Muhammet Kara
52f377c259 tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor
in AnimationNode

Change-Id: I2612286632dddbf96cbf918ffbeb09ac0c99d398
Reviewed-on: https://gerrit.libreoffice.org/27774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02 05:44:57 +00:00
Noel Grandin
6c87b02840 loplugin:countusersofdefaultparams in sd
Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5
Reviewed-on: https://gerrit.libreoffice.org/27765
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02 05:34:49 +00:00
Takeshi Abe
389b081900 starmath: SmVerticalBraceNode always has a triple of nodes
Moreover the middle ("Brace") node is a SmMathSymbolNode.

Change-Id: Ia0e4f798b69a9a205269bbd3f6c63d2059e8c766
Reviewed-on: https://gerrit.libreoffice.org/27769
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-02 01:44:12 +00:00
Eike Rathke
a859c37ee0 introduce mxSymbolsAPI and InitSymbolsAPI()
Change-Id: I1c4673a25bb0f686e0705f87318a04166e6688bb
2016-08-02 00:25:35 +02:00
Eike Rathke
fc5342fb30 InitSymbolsPODF() from RID_STRLIST_FUNCTION_NAMES_ENGLISH_PODF
Change-Id: I03f8d183303b869a4cfaa76ea4170da95574e5d5
2016-08-02 00:25:35 +02:00
Eike Rathke
e128d2afa3 prepare to disentangle RID_STRLIST_FUNCTION_NAMES_ENGLISH
RID_STRLIST_FUNCTION_NAMES_ENGLISH grew to a conglomerate of English UI names,
names used in PODF (ODF 1.0/1.1) and XFunctionAccess API names. Copy it to
independent resources so we can start to correct names in English UI, keep PODF
oddnesses and cater for API compatibility needs.

Change-Id: I7c2053d7627c4da220d8fc991158e8e7a81f0b37
2016-08-02 00:25:34 +02:00