Commit Graph

11 Commits

Author SHA1 Message Date
Stephan Bergmann
a246830d3f This is fixed now on Clang trunk
...since <https://github.com/llvm/llvm-project/commit/
dc3957ec215dd17b8d293461f18696566637a6cd> "Include leading attributes in
DeclStmt's SourceRange"

Change-Id: I21859dfdcb454a9dd4444ce299548bf75043b1ab
Reviewed-on: https://gerrit.libreoffice.org/81424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-24 11:50:01 +02:00
Stephan Bergmann
bfaf25f593 Silence -Werror,-Wunused-variable (clang-cl)
Required a workaround for loplugin:indentation, until
<https://reviews.llvm.org/D68581> "Include leading attributes in DeclStmt's
SourceRange" lands in Clang.

Change-Id: I7192969d40fa4c50bbd603d059532b9344865248
Reviewed-on: https://gerrit.libreoffice.org/80596
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-10 13:02:40 +02:00
Noel Grandin
476fb5d26e Revert "simplify sharedplugin PostTraverse calls"
This reverts commit ff55ad1ace,
Lubos prefers it the way it was.

Change-Id: I68edc21c438b6aa2fc819245dd9a3d590af3a278
Reviewed-on: https://gerrit.libreoffice.org/75790
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins
2019-07-17 20:40:01 +02:00
Noel Grandin
dd969ad6e0 make some plugins used the shared framework
Change-Id: Ie283a4774564f25e0fde8ca35212f92be786d671
Reviewed-on: https://gerrit.libreoffice.org/75785
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17 19:32:43 +02:00
Stephan Bergmann
0626e66d76 Avoid loplugin:indentation after preproc conditional inclusion lines
...to not trigger (for --disable-dbgutil) at

>                         rContentAtPos.eContentAtPos = IsAttrAtPos::TableBoxFml;
> #ifdef DBG_UTIL
>                         if( RES_BOXATR_VALUE == pItem->Which() )
>                             rContentAtPos.eContentAtPos = IsAttrAtPos::TableBoxValue;
>                         else
> #endif
>                             const_cast<SwTableBoxFormula*>(static_cast<const SwTableBoxFormula*>(pItem))->PtrToBoxNm( &pTableNd->GetTable() );

(sw/source/core/crsr/crstrvl.cxx:1710)

Change-Id: I8fd5c8a1cd40450bdd8cc97057e5233a0134f044
Reviewed-on: https://gerrit.libreoffice.org/68030
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-20 11:14:55 +01:00
Stephan Bergmann
177747c445 SourceManager::getExpansionRange already returns CharSourceRange since Clang 7
Change-Id: Ic7c6c648c71203116ca074bd7392a48ff850cd51
Reviewed-on: https://gerrit.libreoffice.org/67864
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-02-15 12:19:34 +01:00
Andrea Gelmini
6d52cd1c0b Fix typo
Change-Id: I036a41bd4d46973a8b6fb51a90c6506cf3f9b8f0
Reviewed-on: https://gerrit.libreoffice.org/67748
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-13 05:07:43 +01:00
Stephan Bergmann
a072b15e96 More loplugin:indentation Qt "emit" hackery
Change-Id: I6f71546a5f6ab07bb4df6fc89213962e74984c84
2019-02-12 08:54:19 +01:00
Noel Grandin
c04eb27aff remove debugging code
Change-Id: Ibb6f3a1c711959cb4f32541dba96f005e51c9040
2019-02-11 11:37:07 +02:00
Noel Grandin
8c0bb7692a loplugin:indentation workaround qt macros
Change-Id: I17bb0b462bb4ce7e8128c9ad33491aa8b691e566
2019-02-11 10:59:35 +02:00
Noel Grandin
f76bf262a6 new loplugin indentation
look for mixed indentation in compound statements, which makes them hard
to read, and sometimes makes it look like a statement is associated with
a nearby if/for

Change-Id: Ic8429cee1f9a86d938097a4a8769a2bce97b3361
Reviewed-on: https://gerrit.libreoffice.org/63283
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11 08:24:19 +01:00