mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
438,694 Commits 1 Branch 0 Tags
Commit Graph

1947 Commits

Author SHA1 Message Date
Noel Grandin
ad74c032ce drop ComplListAppendHandl enum 
we only use one value all the time, so it is unnecessary

Change-Id: I37b596f9c9330ad5f35d6b112dcca14851626995
Reviewed-on: https://gerrit.libreoffice.org/63936
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 16:49:59 +01:00
Noel Grandin
8a629c1f9b remove unused DocTreeNode::NodeType::Invalid 
Change-Id: I68dde9c81ac73875382cd09bf342340b6c144ee8
Reviewed-on: https://gerrit.libreoffice.org/63935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 16:49:45 +01:00
Noel Grandin
9afa992b34 remove unused FontChangeMask::HorAlign 
Change-Id: I9e38cf1d749aa78e5b3c32575b76a372ca25c7c8
Reviewed-on: https://gerrit.libreoffice.org/63933
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 16:49:32 +01:00
Noel Grandin
d21b290be2 remove unused FileViewFlags::SHOW_ONLYTITLE 
and correct the constant in is_typed_flags

Change-Id: If8aa57be2c64ab8e4fc82d0dae670cb68e3a8926
Reviewed-on: https://gerrit.libreoffice.org/63932
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 13:55:50 +01:00
Noel Grandin
5a291af996 remove unused GalleryItemFlags::ThemeName 
Change-Id: Iaf1c82ee454139553dbc9fd1b0cf38b9e7971fdd
Reviewed-on: https://gerrit.libreoffice.org/63931
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 13:23:12 +01:00
Noel Grandin
969d96b3a8 remove unused RedlineFlags::IgnoreDeleteRedlines 
Change-Id: Ic7c1b752c4511a0f55aa8be6b835763715c7738a
Reviewed-on: https://gerrit.libreoffice.org/63930
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 13:23:01 +01:00
Noel Grandin
dcda5569c4 remove unused TableChgWidthHeightType::InsertDeleteMode 
looks like as a consequence of
    commit 2d5ce0e1b233c83f91481cd6b9306ac8de7f5ff8
	Date:   Mon Mar 26 13:08:54 2018 +0200
    tdf#116452 Remove "3 seconds to add/delete col/row" functions

Change-Id: Iae3e2876ed0a0bc916bb4a53f3050d9baa45b0e7
Reviewed-on: https://gerrit.libreoffice.org/63923
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 12:38:31 +01:00
Noel Grandin
32e3238a37 remove unused PROT values 
Change-Id: I2a0962c68e23722370ce36ce35e8cb86a3b7a7fb
Reviewed-on: https://gerrit.libreoffice.org/63922
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 12:38:21 +01:00
Noel Grandin
0742d5d3ec remove unused VarHeight from Css1FrameSize 
Change-Id: I3ac901a6eaa733a0a8b85a9e8ed8b71ff6ff8f96
Reviewed-on: https://gerrit.libreoffice.org/63921
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 11:19:10 +01:00
Noel Grandin
6b8cd04144 remove unused SwInsertNumTypes 
Change-Id: Iede167882414e77f54218e8458f5315c1e16f245
Reviewed-on: https://gerrit.libreoffice.org/63912
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 11:19:04 +01:00
Noel Grandin
9fe4d2225c remove unused LoginFlags values 
Change-Id: I378bd70afea58ef64186c0aeb8f9da51f155494d
Reviewed-on: https://gerrit.libreoffice.org/63911
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 11:18:53 +01:00
Noel Grandin
8f4ffbecee remove unused PropertyIds values 
Change-Id: Id73a21bbf897af77057fb8e8c58b1e9e247584d8
Reviewed-on: https://gerrit.libreoffice.org/63910
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 11:18:45 +01:00
Noel Grandin
82cc30a832 BoolAttrFlags::DefaultMask is unnecessary 
Change-Id: Iaae876e180cef95cb45e4c0df63e146aaf5320be
Reviewed-on: https://gerrit.libreoffice.org/63909
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:06:31 +01:00
Noel Grandin
c756f32851 drop unused ColorType in canvas 
Change-Id: I319cc18db1b068bdfe1e7a9b6fbabb74ab7be04b
Reviewed-on: https://gerrit.libreoffice.org/63908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:06:20 +01:00
Noel Grandin
0e585562d7 convert EPathType to scoped enum 
and drop unused values

Change-Id: I0ba498d66702fb4bb4ff23fb4c42783fc1c83f75
Reviewed-on: https://gerrit.libreoffice.org/63907
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:06:11 +01:00
Noel Grandin
c9d4adb3cf convert AGGREGATE_ACTION to scoped enum 
and rename, and drop unused values

Change-Id: I71eebed1c766d1f0044f6f263e3584fc263a8b1e
Reviewed-on: https://gerrit.libreoffice.org/63906
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:05:49 +01:00
Noel Grandin
f359f87d5f remove some unused enums in filter 
Change-Id: I25c3d6718e9a2e9767a16777b88a0f96afb77b89
Reviewed-on: https://gerrit.libreoffice.org/63905
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:05:39 +01:00
Noel Grandin
cfb09a460d remove unused SpriteChangeRecord::ChangeType::none 
Change-Id: I66d6a8824df0430a560e4aabed0f829e51399467
Reviewed-on: https://gerrit.libreoffice.org/63904
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:05:29 +01:00
Noel Grandin
a78118a94e remove unused EXITHELPER_SECOND_OFFICE 
Change-Id: If6595b9893be5ffacf0810bcd7f1ba51d42ddd0b
Reviewed-on: https://gerrit.libreoffice.org/63903
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:05:03 +01:00
Noel Grandin
3ff1f462ea remove unused EESpellState::LanguageNotInstalled 
Change-Id: I8467f2807d77dad4290b0eff1336eaab40cfb20a
Reviewed-on: https://gerrit.libreoffice.org/63902
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-24 07:04:53 +01:00
Noel Grandin
9c0c5bc5ba convert FormulaDlgMode to scoped enum 
and drop unused ARGS value

Change-Id: I9b9d0c9ea64a2174759dcf6406bdf6cd5be5862a
Reviewed-on: https://gerrit.libreoffice.org/63892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-23 20:31:42 +01:00
Noel Grandin
49b1107b6e remove unused enums in reportdesign,linguistic,l10ntools,vcl,svx 
Change-Id: I3ae854f9fed485be915ded5bc4d7e93f5db23dc6
Reviewed-on: https://gerrit.libreoffice.org/63891
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-23 20:31:22 +01:00
Noel Grandin
c110bfc810 convert CallbackType to scoped enum 
and drop unused INVALID constant

Change-Id: Ifbfaeb209ed75af99f8e531105b9f23541034648
Reviewed-on: https://gerrit.libreoffice.org/63890
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-23 19:52:13 +01:00
Noel Grandin
baf08f569f enum ScMatrix::Op is unnecessary 
Change-Id: If4ae97b43f012f1770213d99407ffaadac05f9de
Reviewed-on: https://gerrit.libreoffice.org/63756
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-23 17:53:55 +01:00
Stephan Bergmann
d20d442087 Improve wording of loplugin:unoany warnings 
...which apparently caused confusion occasionally, cf.
<https://gerrit.libreoffice.org/#/c/58687/5> "Unit test for
0853b05b1fabb231a7d57d811c5a06ee542d3295".

Change-Id: I32f1137bcbb86ffa04bc1a6a58fc93ef69cb3022
Reviewed-on: https://gerrit.libreoffice.org/63874
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-11-23 14:39:44 +01:00
Noel Grandin
981a98af30 remove some unused enums in sc/ 
Change-Id: I841f64a8b4f7f9a9e09df3b7877843616129dee1
Reviewed-on: https://gerrit.libreoffice.org/63755
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-23 13:44:17 +01:00
Noel Grandin
6c19de4713 remove some dead enums in sd/ 
Change-Id: I72bfaf2be6939798cd3db21df959b07500751fab
Reviewed-on: https://gerrit.libreoffice.org/63754
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-23 10:28:32 +01:00
Stephan Bergmann
f23aa1a51c Bump compiler plugins Clang baseline to 5.0.2 
...as discussed at
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html>
"minutes of ESC call ..."

Change-Id: Ia053da171d59747984546f38e19da808825b4f79
Reviewed-on: https://gerrit.libreoffice.org/63832
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-11-23 08:20:53 +01:00
Noel Grandin
d05dbf61d2 remove unused enums DocumentTextDirection and RendererPaneStyle::Side 
Change-Id: I5409a1b1ea3e7619bd1dc4a430c65987269f6204
Reviewed-on: https://gerrit.libreoffice.org/63753
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 17:21:42 +01:00
Noel Grandin
7f91d6ccee remove unused enum RedlineFunc 
Change-Id: Ibbe870680e22cf91d6c421df98cf7b8a098d6e3f
Reviewed-on: https://gerrit.libreoffice.org/63752
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 13:07:33 +01:00
Noel Grandin
4c19552052 remove some unused enum values and defines in soltools 
which led to a whole bunch of dead code

Change-Id: If138a05cf7f09b3020e27489b90c32776b859bcf
Reviewed-on: https://gerrit.libreoffice.org/63751
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 10:15:40 +01:00
Noel Grandin
9decbd5998 convert SwTableAutoFormat::UpdateFlags to scoped enum 
and remove unused UPDATE_ALL

Change-Id: Ib8f21dcddec66947fff8e9cda63f10711da02883
Reviewed-on: https://gerrit.libreoffice.org/63748
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:40:55 +01:00
Noel Grandin
507dc611bd remove unused PAGESIDE enum 
Change-Id: I45185865ec0645040b129885beb97bebafefe70a
Reviewed-on: https://gerrit.libreoffice.org/63747
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:39:35 +01:00
Noel Grandin
ecd6b4f373 remove unused enum AutoFormatLine 
Change-Id: I8e39be5a5f2306121358eaaf07bb026c2f577bf3
Reviewed-on: https://gerrit.libreoffice.org/63744
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:38:17 +01:00
Noel Grandin
4d60a038c9 convert JumpToMarks to scoped enum 
and remove unused JUMPTO_FRAME

Change-Id: Ic12350c66612a7be5f930d1cddd0481b397f3c53
Reviewed-on: https://gerrit.libreoffice.org/63746
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:37:12 +01:00
Noel Grandin
2a78a49508 remove unused SmTokenType values 
Change-Id: Ie15425758f17bba3d088f3cd6925aec9fbf63c91
Reviewed-on: https://gerrit.libreoffice.org/63749
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:36:54 +01:00
Noel Grandin
49d074451c convert FieldDialogPressedButton to scoped enum 
and removed unused EDIT

Change-Id: I1bd4ac135f280e19ffbf51364f406f8068130874
Reviewed-on: https://gerrit.libreoffice.org/63743
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:36:10 +01:00
Noel Grandin
54addc81de remove unused broadcast_type enum 
Change-Id: I2939928e393ef2e306e840488053ca50957c10ce
Reviewed-on: https://gerrit.libreoffice.org/63742
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:35:57 +01:00
Noel Grandin
542ad7cb20 convert INetURLObject::PrefixInfo::Kind to scoped enum 
and drop unused ALIAS

Change-Id: Ifc0c6aba681bb166c515380ebb1b0f45d232d2d2
Reviewed-on: https://gerrit.libreoffice.org/63741
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:35:26 +01:00
Noel Grandin
58bc1cba20 convert LineType to scoped enum 
and remove unused LINE_HORIZONTAL

Change-Id: I39ee05b444b4da46758ff30176e041a02bee54e8
Reviewed-on: https://gerrit.libreoffice.org/63740
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:34:59 +01:00
Noel Grandin
fe39cd0df3 convert SalRGB to scoped enum 
and remove unused values

Change-Id: Id10c18e832d54a6e530c3fe197b230d2d511d79c
Reviewed-on: https://gerrit.libreoffice.org/63739
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:34:34 +01:00
Noel Grandin
bab2753312 loplugin:unusedenumconstants in EEControlBits 
(*) remove effectivly unused enum constants

(*) tweak the plugins heuristics some more to remove false+ in this enum

(*) twweak the python post-processing step to avoid a KeyError

Change-Id: I2943ec94c00f71dcd049f5c9ef33db259c005ba3
Reviewed-on: https://gerrit.libreoffice.org/63709
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-22 07:34:15 +01:00
Caolán McNamara
47897fdd93 weld SwCondCollPage 
and put back original SvTreeListBox a11y factory use

Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79
Reviewed-on: https://gerrit.libreoffice.org/63501
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-11-21 22:08:04 +01:00
Stephan Bergmann
7fb708ed9f Linkage::ModuleLinkage was only introduced in Clang 5 
Change-Id: Ib27908cba00ca120b3bd2ea1dc291c29120a27a4
Reviewed-on: https://gerrit.libreoffice.org/63705
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-11-21 13:58:12 +01:00
Noel Grandin
2dbd02b576 loplugin:redundantfcast improvements 
check for calls to constructors, and extend the list of types we check
for unnecessary temporary creation

Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec
Reviewed-on: https://gerrit.libreoffice.org/63472
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-21 12:44:55 +01:00
Noel Grandin
0acbfd466a loplugin, remove unnecessary filtering in post-processing 
removing things that point to the same source location is only really
necessary for the method-based analyses, the other's dont need it, and
it can hide stuff we are interested in

Change-Id: Ib5c3b4c2ed4011c158a199fcd08096285976b831
 2018-11-21 12:14:35 +02:00
Noel Grandin
5e2322ec84 loplugin:unusedenumconstants improvements 
add some unit tests, and improve the heuristics

Change-Id: I95aa97a87e178ce8d506bd245710d0ae66ad08a4
Reviewed-on: https://gerrit.libreoffice.org/63647
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-20 14:48:27 +01:00
Stephan Bergmann
b0e819bbc0 Fix loplugin:staticconstfield 
...(ExprWithCleanups around the CXXConstructExpr in initializers for members of
O[U]String type, with older Clang, as used in
compilerplugins/clang/test/staticconstfield.cxx), and thus revert
e3e8d52625c2dc7a277a955d4ae2ad10c60c5f1b "Temporarily disable
compilerplugins/clang/test/staticconstfield" again.

Change-Id: Ic5fcdd1a26e4a6810369e4f9d909200d25feb12e
Reviewed-on: https://gerrit.libreoffice.org/63628
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-11-20 11:18:45 +01:00
Stephan Bergmann
50e644253f Take array-to-pointer decay into account in loplugin:redundantcast 
Change-Id: I3c5bace180605d1a72a74feb1bf9f9b184a16d83
Reviewed-on: https://gerrit.libreoffice.org/63545
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-11-19 09:25:35 +01:00
Noel Grandin
67408174f8 loplugin:constantparam 
Change-Id: Ifc2a8db82bd8bb508bce7f226e2cb499d1e6f6f8
Reviewed-on: https://gerrit.libreoffice.org/63492
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-19 07:43:51 +01:00