We should reduce the amount of callbacks from the core in the first place, so
that we don't have to deduplicate this much here, but this already helps a
lot.
Change-Id: Idf4a3681ac0f47536e00c1d97152f3f8bb99894b
This was for the moment removed from the online.git, so let's disable the API
bits too before it shows this is really necessary. Reverts also:
Revert "Lok: unittest batch API"
Change-Id: I7bf3fe62d1e73b6f233992d51f587868a78f4bec
so the sidebar is listening to the old controller which has been disposed[1] so
when print preview exits and yet another controller replaces the print preview
one then the sidebar still doesn't listen to the current one.
framework broadcasts COMPONENT_DETACHING/COMPONENT_REATTACHED around these
changes, so if we listen to them we can keep attached to whatever is the
current component
[1] note that ContextChangeEventMultipler doesn't inform clients that the
controller has been disposed, this remains unchanged here
Change-Id: I141509d4a262307afd7dcfc3d77de6cdd6dbfa5f
Reviewed-on: https://gerrit.libreoffice.org/33758
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit fixes commit aa799f64723933bbb46544f835a970cfcbb90384,
and partially reverts commits bd505fdb9f669f365ff39b0ef46f0742c638e333
and 9104d5e8905c2ec2b576b5ca452d3e23d5555e49 that seem unnecessary
now. Unit test included, the existing unit tests of partially
reverted commits are kept.
Change-Id: I2a02cda546f5d484553c3b9467993fca36dae140
Reviewed-on: https://gerrit.libreoffice.org/33722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Eliminating 11 unused IDs that occupied empty elements in the string
table. Also moved STR_ERR_NAME_INVALID_CELL_REF to the proper position.
Change-Id: I2534476895edb438c7404d781781e6088adf0385
This reverts commit d69bc9c939b94718ac9e17a62f62ae7ae87776e5, which isn't needed
any more now that 01aa52b5e91bac740ad21c31968c834c1530831e "Work around
-Werror,-Wunknown-pragmas" makes the whole pragma block conditional on
__GNUC__ >= 7
(which Clang does not fulfill).
Moved LOKitThread back to LibreOfficeMainActivity, so that it could
use the context in the constructor. Once the Context became available
in LOKitThread, it was simply a matter of replacing static references
with the one passed in the constructor.
Also changed access levels of some methods in LOKitThread.
Change-Id: I0cc2c846c67b90907cbf3dce363666f9ab02d887
Reviewed-on: https://gerrit.libreoffice.org/33546
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Removed static context, and edited the access levels of some methods
in the classes, along with some general code style fixes.
Change-Id: I89c71fa38eaafb5cda721602cfc8dad10ba7d26a
Reviewed-on: https://gerrit.libreoffice.org/33557
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Removed references to static context, replaced them with the context
object already available in the class, and changed access levels on
some methods in LOKitTileProvider.
Change-Id: Ib52d325650377b77ec166ddbfb760f74c19067ff
Reviewed-on: https://gerrit.libreoffice.org/33554
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
...can happen when 'unopkg add' is called before soffice had ever been run, so
UserInstallation isn't populated yet
Change-Id: I0c6b9444f196da5ad5a32cc90f2e1e2a5dbd0f58
this patch writes the .filters file, it creates 2 filters:
-headers: place, for each module, the header files contained in gbuilparser.modules[<module>][headers]
-sources: place, for each module, the cxx files contained in gbuildparser.modules[<module>][<target>]['CXXOBJECTS']
Change-Id: Iba98d788b72992624fb8aa09315a5647e275ffcc
Reviewed-on: https://gerrit.libreoffice.org/33721
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
seeing as we seek from previous position + bytecount on each loop
we can only be sure we go forward the min (+1/+2) for each iteration
Change-Id: I4f1a29d96c43ee8aa858c97405d196b89994669b
Regression from commit 9e7eb63989ef1cf4b9a0e0404b84ef890db3d8e3 (DOCX
import: parse <w:spacing>'s w:before/afterLines attribute, 2014-10-17),
the problem is that OOXML has 3 different attributes for the paragraph
bottom margin (and other 3 for the top one), while in Writer we just
have a top margin.
Now the import filter tries to work out which one of these should have
priority and ignore the rest, but this is way more complicated when
style inheritance has to be taken into account as well.
To avoid the regression just restrict w:before/afterLines handling for
the case when it's used as direct formatting, that's why this was
introduced after all.
Change-Id: Ie8642c7a9771596def6b8899e098b26c4f8be0b4
Reviewed-on: https://gerrit.libreoffice.org/33738
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
This is in !LIBO_INTERNAL_ONLY code, so cannot use SAL_FALLTHROUGH. And even on
current <https://github.com/boostorg/config> master, BOOST_FALLTHROUGH does not
yet support [[fallthrough]] for GCC 7.
Change-Id: I5306c3949b13c517fe8ef643cf98c2021147617e
Copied gbuild-to-ide.py from d575e3a14beef8bdd3517c024b9aab8a17b3ef7b
to gbuild-to-ideNS.py
Changed Makefile.in to use gbuild-to-ideNS.py for non-actively
supported platforms.
That way these platform are stable, and not affected of new features.
For now all platforms are still present in gbuild-to-ide and will
have a "does not break" test for all new features.
Change-Id: I8bb069d93c954a80de540a32b8a01889035c840d
Reviewed-on: https://gerrit.libreoffice.org/33710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
Foo(OUString("xxx"), 1)
Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Project: help 57c058399077a50156e8f2d26f7b483f49fc3700
Fix ahelp for the Section tab page
Was set for the title instead of the description here
Change-Id: I108ea751c79f9dff0d8ab24205a7e06ca43a9ac3
Reviewed-on: https://gerrit.libreoffice.org/33727
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Project: help 8ecc94f4f628fc151aabd6d4f3ba5dfe9ff72198
Fix ahelps for Wrap tab page and related UNO commands
These are on the Drawing Object Properties toolbar
and on the drawing objects Properties window - Wrap tab
also some simple drawing objects have an own Wrap window
Change-Id: I18471f402eb109af5936feacb3fdd8e1d1033087
Reviewed-on: https://gerrit.libreoffice.org/33729
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
