403477 Commits

Author SHA1 Message Date
Caolán McNamara
ac33904d05 move these into the member init list
Change-Id: I94a1ea4cb81e2b7383c3e7c56314d08eea754434
2017-01-27 15:33:08 +00:00
Caolán McNamara
011bae55cd Resolves: tdf#104153 lookup what listbox an entry is dragged from
so we can find where its been dragged from in order to remove it from that
source, rather than relying that it comes from the previously focused listbox

Change-Id: Ie6aa1a311b46e5e9ee96cab05e0705b794b5eb0b
Reviewed-on: https://gerrit.libreoffice.org/33575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-01-27 15:32:42 +00:00
Stephan Bergmann
53eb2fae38 -Werror=int-in-bool-context (GCC 7)
Change-Id: Ide131a586d0d282993dfbf53a783f02d48860647
2017-01-27 16:23:52 +01:00
Pranav Kant
1eef075ad5 Fix android build
Change-Id: I3a39b7adc44a61f1bd4379c2a46e559ad12e7184
2017-01-27 20:44:22 +05:30
Caolán McNamara
1ddf5b0ecb ImplClear sets mbSwapOut false, so mbSwapOut is actually always false here
i.e. failure to swap in does not mean that mbSwapOut is true afterwards, and
mpSwapFile is discarded. It means the whole thing is thrown away.

Change-Id: I73704866d77078c73d053047a7d2ef6499a3e69d
2017-01-27 15:01:21 +00:00
Stephan Bergmann
4d092cba79 Remove dynamic exception specifications from some TDE-only code
Change-Id: I55cfacfd66ed31c8ec209d8deed7746ce917f8ba
2017-01-27 15:54:56 +01:00
Stephan Bergmann
c65d6e9e5d -Werror=int-in-bool-context (GCC 7)
Change-Id: I69f31a94f3e57b3488c576f8d8e0569f459a2117
2017-01-27 15:46:47 +01:00
Stephan Bergmann
85ccbb6f2e Don't worry, Kai, it's still in the git repo
57558f61e9aa1a45f12a2f72d7a0359303d00be2 "#i108938# - commented out unused
member fuction."

Change-Id: I4972d0ff98f8fa21de4fa6506bc1bcbc7088f6d3
2017-01-27 15:41:22 +01:00
Caolán McNamara
3ae2158d43 getColorWindow calling itself, so undisposed windows lying around
Change-Id: I5902c7a677b8b0d3d2891a5f793e5f8e457f25fa
2017-01-27 14:34:24 +00:00
Stephan Bergmann
9c62e04bd5 Remove unused sw/source/ui/vba/vbacheckbox.cxx
...which was listed as explicitly not copiled with
24a129b9f559f79df1d88e159760f907f4fdd37c "make it obvious some files are
intentionally not compiled ( temporarily )" but not removed completely with
09abd826a0e26517ea722659491e8eb525a9b8bc "remove uncompiled source files" (which
removed the other files from the first commit's list)

Change-Id: I232fa73680a2fbc64c6b57b85a626695b86d5f7a
2017-01-27 15:28:28 +01:00
Eike Rathke
9a283e44ca Resolves: tdf#105558 accept numeric BASIC return types as numeric
... not only SbxINTEGER, SbxLONG, SbxSINGLE and SbxDOUBLE.

Change-Id: I75d892f5ae60ef1b18bd86e64777dea746e35a1f
2017-01-27 14:58:38 +01:00
Stephan Bergmann
cb3c2eaba6 loplugin:unnecessaryoverride
Change-Id: I5bed51a3c03e2d55b9b7508d854cd486a35ea90e
2017-01-27 14:18:32 +01:00
Pranav Kant
d83deb9d50 lok: Allow to delete comment by post it id
Change-Id: I61971dfe3a2630ba33c029ce7865bd7077e235cc
Reviewed-on: https://gerrit.libreoffice.org/33613
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 13:01:33 +00:00
Pranav Kant
6e463381b4 lok: Allow to reply to comments using postit id
Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c
Reviewed-on: https://gerrit.libreoffice.org/33612
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 12:54:27 +00:00
Pranav Kant
73875b39e0 Indentation
Change-Id: Ic5b636d5c77b3afff96fc6e4486041153dea9b2a
2017-01-27 17:23:30 +05:30
Pranav Kant
4b8e711ead lok: Calculate and return parent comment id
... instead of just checking if its a root comment or reply one.

Change-Id: I2539e6893ee69bfe12911807504df49edf422be2
Reviewed-on: https://gerrit.libreoffice.org/33470
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 11:52:22 +00:00
Pranav Kant
5f5073a845 lok: Implement new callbacks for comment notifications
Change-Id: I298183b295c68c4a39cb1f6fffe4b89b4eaee0f3
Reviewed-on: https://gerrit.libreoffice.org/33469
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 11:50:02 +00:00
Pranav Kant
a623b3a449 lok: New commandvalues command - .uno:ViewAnnotations
Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c
Reviewed-on: https://gerrit.libreoffice.org/33468
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 11:49:01 +00:00
Olivier
6b977d5a24 Updated core
Project: help  3e23a5bbb9a0de726b6739f0d60f187648c1dbf4

Fix text box in help page since box redesign

The search options are now under the "replace" box.

Change-Id: I65e704703501715c1e9417686fb2d1c9dcb074c8
Reviewed-on: https://gerrit.libreoffice.org/33579
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-01-27 11:37:12 +00:00
Samuel Mehrbrodt
ab28f1291a SafeMode: Add Backup config to installation
has been only active in instdir so far

Change-Id: I1028d1acb2186347448a1f86aaa864c3ba88f75d
Reviewed-on: https://gerrit.libreoffice.org/33584
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-27 11:28:38 +00:00
Samuel Mehrbrodt
6fd00998fa Put crash directory config in soffice.ini, instead of own ini file
Change-Id: I3a7aa394792c47c6c5a3a553174d177e66ade617
Reviewed-on: https://gerrit.libreoffice.org/33582
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-27 11:25:39 +00:00
Samuel Mehrbrodt
3aae650d0f User profile backups: Don't backup user galleries
As suggested in
https://lists.freedesktop.org/archives/libreoffice/2017-January/076768.html

Change-Id: I2562064ae906eb8b2d507ec971762625692a4bbf
Reviewed-on: https://gerrit.libreoffice.org/33608
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-27 11:22:14 +00:00
Michael Stahl
dae273da61 stoc: oops, missing closing quote
Change-Id: Ib1acd95a705d2b504718a28a91abd570b57c9de9
2017-01-27 12:14:37 +01:00
Stephan Bergmann
e8613c6eef Remove some '#ifdef AWT_DIALOG' noise
...that sat there ever since 4bda34677755729bd3a10353ea5b7bb9998ccc9b "initial
checkin - frame for dialogs usuable as UNO service"

Change-Id: I3c8f6fe74d05e5d25950251997354475da02832d
2017-01-27 12:11:57 +01:00
Tomaž Vajngerl
aaa0728d88 chart2: too long line
Change-Id: I1ed0b51156ef2d6231908f18be64e49b754789bd
2017-01-27 12:11:12 +01:00
Tomaž Vajngerl
8a8a946c88 chart2: some more for-loop changes in VLegend
Change-Id: I3c0c0b7463a45917c98f8dc766c781acf62da963
2017-01-27 12:11:12 +01:00
Tomaž Vajngerl
7e9d2ccdbb chart2: remove typedef for std::vector, remove commented code
Change-Id: I62c4cbd0f1ed3d7ea0715475d58e0ee130f3ca00
2017-01-27 12:11:11 +01:00
Tomaž Vajngerl
8529550435 chart2: use c++11 for-loop in VLegend
Change-Id: I8f42fa30f49a8c1dc271017dda826279c45460eb
2017-01-27 12:11:11 +01:00
Stephan Bergmann
df60fbc361 Remove dynamic exception specifications from some TDE-only code
Change-Id: Ic5fa5648d0d52bf5a16b5d3c32c549d5fffb2f4f
2017-01-27 12:07:10 +01:00
Stephan Bergmann
12ffd3ecdd Remove dead code
...dead ever since its introduction in d86602573305ac7c8583794a37c4bd0572b41577
"#i17307#: XFunction->XScript etc"

Change-Id: I664ff15ec2e9fda000bae7740ced427a646ddc92
2017-01-27 12:03:48 +01:00
Stephan Bergmann
53a9e834f0 ...and Clang 4 will have it, too
Change-Id: Ia927ed7d1e7815e59ccb67246da6981c65683168
2017-01-27 11:58:18 +01:00
Michael Stahl
845d4eb7bc stoc: try to throw more informative exceptions
... from IdlInterfaceMethodImpl::invoke(), which is somewhere involved
in BASIC calls.

Change-Id: I739f70fec56ec9e4345511eefe41fd0f8df8bf6f
Reviewed-on: https://gerrit.libreoffice.org/33593
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-27 10:57:18 +00:00
Caolán McNamara
94ffb720b8 ofz: tidy up eps preview import
a) check that the remaining stream length is >= the 14 bytes that are
unconditionally skipped
b) make the initial security count the min of the arbitrary 100 and the
remaining stream len less that 14 bytes
c) tweak ImplGetNumber not to reduce nSecurityCount if its already 0

Change-Id: Ifffa6d02d492affd578fb48007704457ad635b39
2017-01-27 10:55:23 +00:00
Michael Stahl
c971cfbe21 offapi: FormulaProperties doc broken link
Change-Id: I45eb0f3259ec514864178b6725107e5ba0ea140e
2017-01-27 11:51:05 +01:00
Pranav Kant
85959fccad lok: Unique annotation Ids to SwPostItFields
Change-Id: I6dd5186eb18ca99a75a5cb73263cc6bfcc7ff345
Reviewed-on: https://gerrit.libreoffice.org/33467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 10:52:49 +00:00
Pranav Kant
c67040c157 lok: Exit early when inserting annotation if tiled annotation off
Change-Id: Ia5705a07166e5c40aface506e8e8e7b727c2e376
Reviewed-on: https://gerrit.libreoffice.org/33466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 10:51:19 +00:00
Stephan Bergmann
f4fac7f341 getExceptionSpecSourceRange is new in Clang 5
Change-Id: Ifa9223fadeeb1fde54afc99874a1b3d855073dce
2017-01-27 11:50:36 +01:00
Pranav Kant
0f0164d647 lokdocview: Turn off annotations rendering here
Change-Id: Ia1ee4f54a05ab3daca62a78fe335e731e4cfc02d
Reviewed-on: https://gerrit.libreoffice.org/33465
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 10:48:56 +00:00
Noel Grandin
2d506f4c3d fix spelling containging->containing
Change-Id: I49f736c049735e89ce9f71740f5c308120378a9a
2017-01-27 12:43:41 +02:00
Caolán McNamara
521723b118 move deref inside (laughable) nSecurityCount check
Change-Id: Idf9a83ffa80137967d8c77d7a9b5133529fc2858
2017-01-27 10:39:20 +00:00
Stephan Bergmann
b593c9c5b8 -Werror=implicit-fallthrough= (GCC 7)
Change-Id: I9d6c7e5a03aea56d8db84c2ba06c63efb0e007fa
2017-01-27 11:36:23 +01:00
Caolán McNamara
cf06348d9d make this a little more readable
Change-Id: I83b6b0bd636b639ce0892f22f216410ce79dee03
2017-01-27 10:35:33 +00:00
Caolán McNamara
5ff2ae5d72 reformat member initialization
Change-Id: I6c86da271d01d63ad426d3ac99068a6ad9663705
2017-01-27 10:35:33 +00:00
Tor Lillqvist
5b2f40d918 Fix comments to match reality
Change-Id: I99b49a3c8472b063316baeebdaa89119832a2a1b
2017-01-27 12:10:27 +02:00
Jochen Nitschke
547ceda8ff remove unused debug code
unused since commit 9585c8b8c8d8724cc1bad4a2060c828c15599929
Date:   Tue Mar 22 10:58:54 2016 +0200
    loplugin:constantparam in sw

Change-Id: I8469619fb70583170ea5cc8d4d03464335af2d28
Reviewed-on: https://gerrit.libreoffice.org/33609
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-27 10:03:16 +00:00
Noel Grandin
4511431fb6 improve "unnecessary user-declared destructor" check
to look for inline&empty destructors, where we can just let
the compiler do it's thing

Change-Id: Ibde8800bdfed6b77649c30ebc19921167c33dec3
Reviewed-on: https://gerrit.libreoffice.org/32999
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27 09:49:04 +00:00
Stephan Bergmann
1a90a23d9f Enable loplugin:dynexcspec rewriting mode
Change-Id: I73404287c387a36e224683f75e967d51d911175b
2017-01-27 10:47:16 +01:00
Stephan Bergmann
38da1ed919 Make plugin rewriting work on Windows too
...in a somewhat hacked-up way for now (see the TODO comment)

Change-Id: Ida89fb8257b876cfca05b3048ce15996091c5703
2017-01-27 10:46:15 +01:00
Stephan Bergmann
b61214c91d Remove dynamic exception specifications from !LIBO_INTERNAL_ONLY
...only odk/examples/ remains to be clean up

Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
2017-01-27 10:40:41 +01:00
Caolán McNamara
d1f3168162 ofz: check if the stream is able to meet the eps len claim before reading
Change-Id: I440c7f38d6588c570a411f2a97c0164e5d7d646f
2017-01-27 09:01:50 +00:00