This asserts because MarkManager::m_vAllMarks is not sorted.
info:sw.core:32273:1:sw/source/core/doc/docbm.cxx:286: 1493,39 1493,39 N2sw4mark8BookmarkE _Source_Device_Configuration
info:sw.core:32273:1:sw/source/core/doc/docbm.cxx:286: 1493,39 1493,39 N2sw4mark8BookmarkE _Deploying_the_Connector
info:sw.core:32273:1:sw/source/core/doc/docbm.cxx:286: 1493,39 1493,39 N2sw4mark8BookmarkE _Setting_up_Connection
info:sw.core:32273:1:sw/source/core/doc/docbm.cxx:286: 1493,39 1493,39 N2sw4mark8BookmarkE _Testing_the_Audit
info:sw.core:32273:1:sw/source/core/doc/docbm.cxx:286: 1493,0 1493,0 N2sw4mark23CrossRefHeadingBookmarkE __RefHeading___Toc270687978
This happens while called from SwRangeRedline::MoveFromSection; the
target paragraph has some normal bookmarks and a CrossRefBookmark
all at index 0 before, but the move messes up the sorting.
The reason is that SwIndexReg::Update() has a special case HACK to avoid
adjusting the content index of CrossRefBookmark away from 0.
Prevent the problem by tweaking the bookmark sort function to always
sort CrossRefBookmark before other marks in the paragraph.
Change-Id: I1373337a9c7e6760fdbe5b634a14c63428a2e73c
This reverts commit 27ca6387b7188d1805dda8906d809025a2d3fb95, at least together
with f7962f59ea0b2a8f7c2d6c015e1c02855e1008fe "sc rowlimit: Make the cursor
better fit the rendering" it makes CppunitTest_desktop_lib fail.
This reverts commit f7962f59ea0b2a8f7c2d6c015e1c02855e1008fe; at least together
with 27ca6387b7188d1805dda8906d809025a2d3fb95 "sc tiled rendering: We keep
increasing the precision here..." it makes CppunitTest_desktop_lib fail.
commit eca5ea9f79181d45cd7fbabe2313617d3025818a
"make the AbstractDialog stuff extend from VclReferenceBase"
introduced this regression.
Fix up the asynchronous delete to work again - necessary because
the delete is triggered from deep inside the object it wants to
delete.
Change-Id: I18d5a899fbb2da772552ebba7fe6a8e810314010
Reviewed-on: https://gerrit.libreoffice.org/33881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
in particular, libgpg-error and libassuan
This only downloads and unpacks the tarball. Building them needs
some work still
Change-Id: I562fd01571929ddfb47a319038f88ea8dbfb4bdd
Reviewed-on: https://gerrit.libreoffice.org/33712
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Change-Id: Iaedabfa4c4242f5a37f818572fddfbcca88d5b9a
Reviewed-on: https://gerrit.libreoffice.org/33849
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
This forces writing a comparision of two variables in the
CPPUNIT_ASSERT_EQUALS(expected, actual) form, rather than
CPPUNIT_ASSERT(actual == expected). The benefit is when the test fail,
it's more clear what are these two values, rather than just seeing that
they are not equal.
In the relatively rare case when the types are not streamable, the
plugin can be silenced using CPPUNIT_ASSERT(bool(it == foo.end())). But
please always first consider making the type streamable instead. See
commit 0e1b831b93048c68735f2e2dbdcee587db4862ef
(CppunitTest_vcl_complextext: fix loplugin:cppunitassertequals warnings,
2016-12-16) for an example.
Change-Id: I564fb0724836b6dbbea9262b53ad646e285a339c
you beat me to it, mmeeks
Change-Id: I3191a506363ebfd9299e9c94857aacdffdb28946
Reviewed-on: https://gerrit.libreoffice.org/33855
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits
Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
By the time DiagramGraphicDataContext::onCreateContext() completes, we
know if there will be a DrawingML fallback for the SmartArt (called
ExtDrawing in the code) or not.
Warn about this case once at the end of the import when in interactive
mode. Headless mode silently ignores the warning as expected.
Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d
Reviewed-on: https://gerrit.libreoffice.org/33866
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Various download-and-open mechanisms save to the system's
$TEMP dir. If so, don't recomment saving in that same
location in the GUI dialog! That's just silly.
Change-Id: Ifa20fdfd81d768bbd893f92a50355f08c3aab356
Reviewed-on: https://gerrit.libreoffice.org/33353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Fix width of labels removed and code added to define it on runtime
Fix height of buttons commented out
Resizable flag unset
Change-Id: I3ffb38b5c9b23447ac914dc8c13fa95072897ced
Reviewed-on: https://gerrit.libreoffice.org/33370
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
A few properties of FillProeprties have the same nWID
but have different nMemberId, such as FillGradient,
FillGradientName,FillHatch,FillHatchName, FillBitmap,
FillBitmapName, and FillBitmapURL.
When putting value of an item, the default item was put
first, despite the value of the item might have already
been put.
Move the part of the code that put default item upfront
so that it will not overwrite actual value accidentally.
Change-Id: I54288420abde333e5b3e4cdd31ca9fae0c3ed7ab
Reviewed-on: https://gerrit.libreoffice.org/33594
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
GetHangingMargin() also returns offset for PostItPortion, assure
there is a hanging portion before using the value.
Change-Id: I750b8078fbd607d49f4bf5f76ea606fc36ea5c23
Reviewed-on: https://gerrit.libreoffice.org/33832
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
LibreOffice has had direct support for Google Drive since (I think) 5.1,
via libcmis.
Change-Id: I7587923b3fd7dd505124b790066cdaa99a858af1
Reviewed-on: https://gerrit.libreoffice.org/33822
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
which is why my sample document creates a .doc which triggers
word's safe mode
this has been wrong since initial impl in
commit 4d5c193b2fd38c6cab049fcb97189462fff0fddb
...
2003/07/17 14:13:17 mmaher 1.64.6.6: #110851# Added support for animated text effects
a mere 13+ years ago
Change-Id: I8c4d95dac8e03f6523a2a036f0100f425f787a13
nVerBuiltInNamesWhenSaved (2 bytes): An unsigned integer that specifies the
version number of the style names as defined by the application that writes the
file. This value SHOULD be 0.
old number is 2: which means...
"Word 97 2"
Specifying a value of 0 is recommended for maximum compatibility, as it will
cause all versions of Word to update the names to whatever set of application
defined style names is current, with little performance penalty.
http://msdn.microsoft.com/en-us/library/0E246123-E907-4AD1-9DFC-558512E2B052
Change-Id: I9a04f62f950c7965d6eb5e6ff23d9c09fe38d99e
When libtool links a library with another libtool-based library, it
replaces -lfoo by path to installed foo, like $foo-libdir/libfoo.la.
harfbuzz would be installed to /usr/local/lib by default, therefore
libtool replaces -lharfbuzz by /usr/local/lib/libharfbuzz.la in
libfreetype.la, which causes a failure (nonexistent file) when building
fontconfig...
Change-Id: Ie2510034e69803af084dd90671fdbc8f6863fcf2
Reportedly gperf 3.1 changes the signature of in_word_set(), where the
len parameter changes from unsigned int to size_t.
It turns out the only forward declaration for this function is currently
unused, so just remove it.
Change-Id: Ifbc582cd31ca37fff9ff95a3706ee902ecfe5223
