mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
406,095 Commits 1 Branch 0 Tags
ff339c89b51ed571d55c762e43aa1a6ee9ada1cb
Commit Graph

3700 Commits

Author SHA1 Message Date
Laurent Godard
0405975042 tdf#75973 : User Defined Types in password encrypted macros 
save/load basic script so that when executing password protected
the user defined types can be rebuilt

supports array and nested types

a unit test in sc macros-test.cxx

Change-Id: Ie127ea7ad9aea3353741048c00f1b3910c5517a4
Reviewed-on: https://gerrit.libreoffice.org/17815
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-18 09:50:53 +00:00
Arnaud Versini
7985e5245a BASIC : SbiParser::pBasic is useless 
Change-Id: I5aa041f78ea5685b996a6baf1d7bc22d5bd957ab
Reviewed-on: https://gerrit.libreoffice.org/17782
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-17 07:20:31 +00:00
Arnaud Versini
0d737f2683 BASIC : SbiRuntime::ClearExprStack should return void 
Change-Id: I704d8920ec44b6d2eb1fc9599dc37e41a28b5e63
Reviewed-on: https://gerrit.libreoffice.org/17779
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-08-16 12:27:49 +00:00
Stephan Bergmann
9d094b9f0a tdf#92446: Revert apparently bogus attempt at fixing a memory leak 
6b4c596b01 "Fix memory leak for BASIC sub (as well
as void function)," from just looking at the few lines of code in isolation, and
their revision history, looked like a plausible and effective approach to fix
the leaks reported by CppunitTest_basci_vba when run under lsan.

However, tdf#92446 indicates that that innocent-looking change had rather dire
consequences.  So revert it and leave a fix for the memory leak to somebody who
actually understands all this code.

Change-Id: Ic81b1c14a1cfb07c6ec4415cc26b2f826adbc8ca
 2015-08-14 13:18:56 +02:00
Noel Grandin
adbc556c91 make Link<> instances typed 
and remove some unused code

Change-Id: I934824401b5c528b07ad76f753f78440c4492885
Reviewed-on: https://gerrit.libreoffice.org/17703
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-14 07:15:01 +00:00
Noel Grandin
4f87e9da41 loplugin: defaultparams 
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
 2015-08-11 09:48:17 +02:00
Noel Grandin
50097a8bb2 basic,basctl: inline some use-once typedefs 
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
 2015-08-04 08:55:56 +02:00
Noel Grandin
2660d24a07 new loplugin: refcounting 
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-03 06:37:16 +00:00
Noel Grandin
c2ac8569de convert SBSTRM constants to scoped enum 
Change-Id: I478a9c7eca6509baf3e9a3dd3ce3dd8f3060f842
 2015-07-29 12:10:18 +02:00
Noel Grandin
b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Noel Grandin
01075a7274 inline the "old" SbxErr constants 
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
 2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Adolfo Jayme Barrientos
3e926736c7 Miscellaneous typos 
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
 2015-07-21 04:53:48 -05:00
Noel Grandin
b4ee16da65 com::sun::star->css in basic 
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 09:39:36 +00:00
Matteo Casalin
40c34e6262 Fix indentation 
Change-Id: I5cff1cda3c6882e751b88a4a4d1aacbec8942578
 2015-07-19 17:12:32 +02:00
Matteo Casalin
f7a2795c88 sal_uIntPtr to sal_uInt32, for consistency 
Change-Id: Ib78dce61e8fb8c8e3bf8c7a2b02966100a4db0e8
 2015-07-19 17:12:32 +02:00
Matteo Casalin
c1edceb2f3 sal_uInt16 to sal_Int32 with some cleanup 
Change-Id: Ib6e42702dd1ce29645215114b26286f05ccc1332
 2015-07-19 17:12:32 +02:00
Matteo Casalin
903baa666b Use more proper integer types 
Change-Id: If86163ddeff91571419a37becbbe75f98e681d7d
 2015-07-19 17:12:30 +02:00
Michael Stahl
15f32b5a1e basic: replace boost::ptr_vector with std::vector<std::unique_ptr>> 
Change-Id: I96ea97c1df7903a28387d8e1171075be55a80ca7
 2015-07-17 20:26:59 +02:00
Stephan Bergmann
5a80e32728 loplugin:simplifybool 
Change-Id: I2dc7883e23c1437c4a8bf9fce19acfd3fe700ec0
 2015-07-16 14:00:16 +02:00
Noel Grandin
536051f886 fix Windows build 
after commit 22b094f5d8
"loplugin:unusedmethods basic"

Change-Id: I7586d2487e47731db93335c3d9969626bf2eb6ab
 2015-07-15 14:04:59 +02:00
Noel Grandin
22b094f5d8 loplugin:unusedmethods basic 
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1
Reviewed-on: https://gerrit.libreoffice.org/17044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-15 09:07:05 +00:00
Stephan Bergmann
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds 
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
 2015-07-13 18:14:11 +02:00
Andrea Gelmini
799cc41b53 Fix typos 
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-07-08 05:48:18 +00:00
Stephan Bergmann
e69fd541ca Replace GetAppData(SHL_IDL) with a static pointer var 
Change-Id: Ia1e22ff95457a958ef26974091aa2092b32505bd
 2015-07-07 07:48:12 +02:00
Takeshi Abe
7640e244db tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, in basic.

Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36
Reviewed-on: https://gerrit.libreoffice.org/16719
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-06 07:28:21 +00:00
Andrea Gelmini
ffa8892c5a Fix typos 
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-04 10:23:17 +00:00
Miklos Vajna
2e7fe50874 error: 'pGen' was not declared in this scope 
Change-Id: I6ebf100be3a90b315491e2735da9c82e5901fc59
 2015-07-02 10:24:59 +02:00
Arnaud Versini
fabe329412 BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr. 
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a
Reviewed-on: https://gerrit.libreoffice.org/16551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2015-07-02 07:43:03 +00:00
Caolán McNamara
50bd0c8573 coverity#1308521 Uncaught exception 
Change-Id: I6a189e0d1c4eb04e727fdf12585d46a1f4121f68
 2015-06-28 17:55:52 +01:00
Andrea Gelmini
5d5dc059cb Fix typos 
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:35:58 +00:00
Andrea Gelmini
69c88a32aa Fix typos 
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:28:31 +00:00
Caolán McNamara
cfbbb3ca5d coverity#1308445 Uncaught exception 
Change-Id: I831637f7f2fb2c552de8c20dc9f5da4e8783b935
 2015-06-27 18:24:57 +01:00
Caolán McNamara
232db3f79c coverity#1308444 Uncaught exception 
Change-Id: I103965dfb3e19964e58b3ca4ef34dcee2141d882
 2015-06-27 18:24:57 +01:00
Caolán McNamara
25b665a2f3 coverity#1308435 Uncaught exception 
Change-Id: I8d4ba326e94565bc1ae8b57e406883f737049aea
 2015-06-27 14:42:20 +01:00
Stephan Bergmann
687ab37853 loplugin:stringconstant: Flag more inefficiencies 
Change-Id: Ie6ca3065ee60fb2ad75f3bab53059046a981da8d
 2015-06-25 12:38:33 +02:00
Stephan Bergmann
892455e72a Simplify uses of comphelper::string::equals with constant argument 
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
 2015-06-24 15:27:28 +02:00
Noel Grandin
07d85c4499 remove SFX_NOTIFY macro 
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects

Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
 2015-06-24 12:06:34 +02:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]> 
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-06-17 15:50:45 +00:00
Andrea Gelmini
f378e723d2 Fix typos 
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56
Reviewed-on: https://gerrit.libreoffice.org/16300
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:14:55 +00:00
Andrea Gelmini
ca9de688c2 Fix typos 
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:10:51 +00:00
Noel Grandin
4ea281a3cc cppcheck:redundantAssignment 
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
 2015-06-15 13:34:14 +02:00
Noel Grandin
5a2e09989a cppcheck:redundantCondition 
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
 2015-06-15 11:56:55 +02:00
Julien Nabet
b226928c6d cppcheck: redundantCondition [part1] 
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
 2015-06-14 12:17:55 +02:00
Arnaud Versini
0766db041e BASIC: Don't use SbiStringPool to pass SbiParser. 
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9
Reviewed-on: https://gerrit.libreoffice.org/16137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-06-13 11:53:03 +00:00
Julien Nabet
3754474cde Typos 
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
 2015-06-13 09:13:52 +02:00
Caolán McNamara
cc0e9a37de cppcheck: variableScope 
Change-Id: If0c56c89e2722d47a401363f3854331229856490
 2015-06-09 10:33:59 +01:00
Stephan Bergmann
761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Noel Grandin
3f72218069 Apply new VclPtr clang plugin to catch potential problems. 
Omit the plugin, and sw's FrameControlsManager for now.

Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-06-06 20:26:54 +00:00
Noel Grandin
623445aa0e convert PropertyMode to scoped enum 
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
 2015-06-04 08:30:24 +02:00