mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
406,095 Commits 1 Branch 0 Tags
Commit Graph

525 Commits

Author SHA1 Message Date
Stephan Bergmann
e4651e2003 loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I5bb3c63790cb153c0d6f57a681ec6dda71d482be
 2016-07-07 18:59:55 +02:00
Caolán McNamara
6752590fec don't autocapitalize words that follow a field mark 
Change-Id: Ia8efa88aaf47edba9a590c858d0ea30d7bfe2977
 2016-07-01 14:49:03 +01:00
Noel Grandin
42486dde49 move #includes to top of file 
instead of being randomly embedded somewhere deep inside the CXX code.

Found with:
  git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t :

Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a
Reviewed-on: https://gerrit.libreoffice.org/26764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-06-29 14:49:19 +00:00
Stephan Bergmann
e3e79246cb Simplify some PutProperties calls 
Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
 2016-06-28 14:50:49 +02:00
Gökhan Gurbetoğlu
ea5a5b1dbb tdf#99589 - tolower / toupper - dangerous to Turks ... 
Change-Id: Id3b9abd557f2b8dfc942589362452cbdb0232da9
Reviewed-on: https://gerrit.libreoffice.org/26546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-06-23 10:01:18 +00:00
Stephan Bergmann
fb7b701c18 Clean up uses of Any::getValue() in editeng 
Change-Id: I2bce1aba3e01e5c8d67d47b88cddca1f7ad37a93
 2016-06-13 12:10:27 +02:00
Noel Grandin
b860b73f2b Convert VCL_MESSAGE to scoped enum 
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933
Reviewed-on: https://gerrit.libreoffice.org/25720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-01 06:46:29 +00:00
Noel Grandin
0b23eec200 teach refcounting clang plugin about uno::Reference 
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-31 06:25:45 +00:00
László Németh
785e530e83 fix bad index/assertion failure with line ending autocorrect patterns 
Test case: type "->" and press Enter in a new en-US text document.
Result: crash or missing replacement of the arrow.

Change-Id: I052ae868b6fe0b1e5557c40471d31a20bd1e5ca9
 2016-05-21 02:49:27 +02:00
Andrea Gelmini
3742748699 Fix typos 
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3
Reviewed-on: https://gerrit.libreoffice.org/24760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-05-10 19:13:31 +00:00
Noel Grandin
58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Stephan Bergmann
6e70103da0 While at it, delete Any functions on sal_Bool* 
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of
sal_Bool across the code base

Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
 2016-05-04 11:59:23 +02:00
Stephan Bergmann
0b1e4a3067 Prevent Any::setValue from reinterpreting bool* as sal_Bool* 
...which only happens ot work in environments where sizeof (bool) == 1.  The
simpler alternative is to use the operator <<= template without passing explicit
UNO type information, anyway.

The std::nullptr_t overloads are needed to disambiguate calls with a nullptr
argument.  (Which can at least be meaningful for VOID, but for other types what
it happens to do is store a default value of the given type.)  As std::nullptr_t
is only C++11, this all needs to be LIBO_INTERNAL_ONLY.

Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
 2016-05-03 15:26:01 +02:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Noel Grandin
17c4f7f0bc clang-tidy modernize-loop-convert in e* 
Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de
Reviewed-on: https://gerrit.libreoffice.org/24384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 07:43:58 +00:00
Stephan Bergmann
9ad66e5ae9 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I626b79e1450d78aec96c206db82bf64a47305d08
 2016-04-20 17:25:39 +02:00
Noel Grandin
789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Jochen Nitschke
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes 
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-12 06:38:26 +00:00
Stephan Bergmann
fb411e93ae Avoid reserved identifier 
Change-Id: Ia2af17bbf08cebc9e3c8f772583a61bde194328f
 2016-04-06 13:06:38 +02:00
Stephan Bergmann
81284624d8 Avoid reserved identifier 
Change-Id: I87a6afeffaf7c87c6037a416783f1f22015b2fbf
 2016-04-06 12:31:15 +02:00
Stephan Bergmann
311167193b Avoid reserved identifiers 
Change-Id: I2c83911433a8f89e7366d9f7711ca4879e44bae9
 2016-04-06 12:07:30 +02:00
Stephan Bergmann
9b1307f790 Avoid reserved identifiers 
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4
Reviewed-on: https://gerrit.libreoffice.org/23587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-29 07:11:31 +00:00
Noel Grandin
9391688f61 loplugin:constantfunction in editeng 
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1
Reviewed-on: https://gerrit.libreoffice.org/23331
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-18 06:02:18 +00:00
Noel Grandin
b76842f63b loplugin:unuseddefaultparams in editeng 
Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
 2016-03-03 09:42:49 +02:00
Noel Grandin
c45d3badc9 new loplugin: commaoperator 
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
 2016-02-23 08:08:56 +02:00
Chris Sherlock
6858d51757 vcl: include vcl headers via triangular brackets instead of quotes 
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
 2016-02-13 00:29:50 +11:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
1ef9f3988e unnecessary use of OUString constructor 
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1
Reviewed-on: https://gerrit.libreoffice.org/21945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-31 12:04:02 +00:00
Chris Sherlock
3187193a61 tools: rename FontUnderline to FontLineStyle 
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca
Reviewed-on: https://gerrit.libreoffice.org/21892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-31 04:31:13 +00:00
Chris Sherlock
5659b68be3 vcl: rename Font::GetFamily to Font::GetFamilyType 
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254
Reviewed-on: https://gerrit.libreoffice.org/21633
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-21 06:22:01 +00:00
Chris Sherlock
cb20f46895 vcl: change Font::SetName() to Font::SetFamilyName() 
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5
Reviewed-on: https://gerrit.libreoffice.org/21560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-18 05:24:46 +00:00
Chris Sherlock
28c96fc255 vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-17 23:35:37 +00:00
Norbert Thiebaud
45654a1d4d revert vcl patch series that brok Mac and Windows 
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
 vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
 vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
 vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
 vcl: rename Font::GetName to Font::GetFamilyName

Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
 2016-01-16 12:20:45 -06:00
Chris Sherlock
f99550dae5 vcl: change Font::SetName() to Font::SetFamilyName() 
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc
Reviewed-on: https://gerrit.libreoffice.org/21510
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:12:14 +00:00
Chris Sherlock
2b297116cb vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:11:28 +00:00
Caolán McNamara
570087e762 coverity#3148472 Unused value 
Change-Id: I9acdfe0edf8468c6efb708ca13109abe2be0b826
 2016-01-15 20:24:47 +00:00
Michael Stahl
228bccb7bc editeng: coverity#1348472 unused value AddNonBrkSpace 
Let's hope that shuts up coverity?

Change-Id: I81f56ce9120c1d9328d5f04b1d1869c01402eca1
 2016-01-15 13:03:11 +01:00
Noel Grandin
1f9a610de1 loplugin:unusedmethods unused return value in include/editeng 
Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970
Reviewed-on: https://gerrit.libreoffice.org/21361
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-12 07:39:42 +00:00
Andrea Gelmini
64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Noel Grandin
1dbe54fd2e loplugin:unusedfields in /include 
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
 2015-12-23 08:13:53 +02:00
Noel Grandin
e78bb6d545 loplugin:unusedfields in include/comphelper,include/editeng 
Change-Id: I619c2cf1765df97159fc52ee84e0e9e8d16a22fe
 2015-11-24 14:20:25 +02:00
Noel Grandin
2e9277c050 use unique_ptr for pImpl in editeng/ 
Change-Id: I43ae9f706db15594b3a0c5cba41436d009588393
 2015-11-18 08:35:34 +02:00
Stephan Bergmann
217f7f236f loplugin:nullptr (automatic rewrite) 
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
 2015-11-10 10:31:24 +01:00
Stephan Bergmann
108ecc45ce loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: Icf08e69ba327225da816bd57648d4242dcbf3280
 2015-11-06 09:35:37 +01:00
Benjamin Ni
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b" 
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2015-11-02 23:40:57 +01:00
Noel Grandin
3c971162b5 use uno::Reference::set method instead of assignment 
Change-Id: I150f213ab033f5fc1b50abe4e1529292206c9feb
Reviewed-on: https://gerrit.libreoffice.org/19689
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-31 12:56:38 +00:00
Caolán McNamara
7076cc68fd get rid of erroneous 0x7ff language mask 
Change-Id: I2b3501967fc0088e0bebf6c366e033c61b652921
 2015-10-23 20:36:45 +01:00
Caolán McNamara
97893e56e6 more tdf#76964 fall back to primary language via getLanguage 
Change-Id: I7718ff6f93f704e37e9a046cb07c497b2d533a2a
 2015-10-23 20:27:53 +01:00
Caolán McNamara
a1ff0745cc Resolves: tdf#76964 fall back to primary language via getLanguage 
instead of bittwiddling which ends up trying to resolve the
system language

Change-Id: I545bd5e39f99003ddedf3c90031e8b818edc1de2
 2015-10-23 09:13:09 +01:00
Stephan Bergmann
ad6e444a31 loplugin:defaultparams 
Change-Id: I62e0ec63ff09c200e0b621c8b042a976e8ce630e
 2015-10-19 17:49:51 +02:00