mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
406,095 Commits 1 Branch 0 Tags
ff339c89b51ed571d55c762e43aa1a6ee9ada1cb
Commit Graph

7234 Commits

Author SHA1 Message Date
Caolán McNamara
f1d4c40096 add 602 fuzzer 
Change-Id: I91242d4647922be1c668c6a6518dedf7048801be
 2017-02-25 20:58:07 +00:00
Caolán McNamara
ee619fb344 ofz: don't read data that isn't there 
Change-Id: I7fdcb78bde8f650c1a57d34177d8993a6d8a0a2f
 2017-02-23 11:07:02 +00:00
Caolán McNamara
46b1b5dd2a make this a little clearer 
no logic change intended

Change-Id: Ibfc46d0aba9e220be54270734e0cdfbc123be9a5
 2017-02-23 11:06:59 +00:00
Caolán McNamara
840ad0a880 improve scoping 
Change-Id: Ic79d46da4e322a0f52981c3a3df65f7f0294fdd8
 2017-02-23 11:06:59 +00:00
Caolán McNamara
c5b1a01ddf ofz: don't read data that isn't there 
Change-Id: I9f730c321755cde169d940b49fc93bbe057ead57
 2017-02-22 20:50:11 +00:00
Stephan Bergmann
c5346d4464 loplugin:subtlezeroinit: filter 
Change-Id: I4842b8a82f7fe3a4a5c33da2780ced61d66293ba
 2017-02-21 07:35:07 +01:00
Noel Grandin
c3db252b04 remove unused enumerators from SdrObjKind 
Change-Id: I7b02cb0557d55a7063f8985552bdda54657d803f
Reviewed-on: https://gerrit.libreoffice.org/34472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-20 13:12:07 +00:00
Chr. Rossmanith
1ce132b5b4 tdf#105639: create valid id values in svg export 
Change-Id: I01a011501af317d7a9e90d7c70d50ef84c74b24e
Reviewed-on: https://gerrit.libreoffice.org/34347
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-02-17 10:39:17 +00:00
Fakabbir Amin
9d8c206ee4 tdf#100726 Improved readability of OUString concatenations 
Cleanup in filter, framework and svtools directory.

Change-Id: Icf4f04cff1207e58ce55ea3dc8c21b0635c3b6ec
Reviewed-on: https://gerrit.libreoffice.org/34298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-02-16 08:51:29 +00:00
Caolán McNamara
f18e476308 assume max compression of 255 for ras 
Change-Id: I51dfa45b266b6b9361f48aac58f0a4bca8446bdd
 2017-02-15 14:47:19 +00:00
Caolán McNamara
dfc58d2db7 check data needed to fulfil ras claims before allocating 
Change-Id: Ifdd820e4ea4287f97cc07cb86c0a180d06081449
 2017-02-14 11:34:52 +00:00
Caolán McNamara
5e4fb24278 this is already checked for 
Change-Id: I01af66bfdcbee0a3d63a17c0a19fdd3c02d4acdc
 2017-02-14 11:34:52 +00:00
Caolán McNamara
aea7594bf1 check valid mnDstBitsPerPix before progressing 
Change-Id: I77b8e882b537ab10b26fa021ef633c603bbd6562
 2017-02-14 10:38:29 +00:00
Caolán McNamara
ef4f097d3e check ras seeks 
Change-Id: Id4c55ad57c49f08eff813a3ad5325d7788688c51
 2017-02-14 10:33:24 +00:00
Caolán McNamara
d06646ca28 move allocation of bmp to after reading palette 
Change-Id: Ib54e0b3f3fae2c2e76cf49e03dceab2259b26b92
 2017-02-14 10:28:19 +00:00
Caolán McNamara
2fbc3a4e82 reduce scope of maBmp 
Change-Id: I8605ec535bc8a948cf0dc0dd194e673b73939035
 2017-02-14 10:26:12 +00:00
Caolán McNamara
16f5f716de reduce scope of bPalette 
Change-Id: Icc1fd48e72be6c550b03008a6d7b81bf8a903d44
 2017-02-14 10:19:47 +00:00
Caolán McNamara
7c9c6a4425 ofz: move size check before bitmap allocation 
Change-Id: I09deab103a3bc53277ea3d545b2737438875dfc5
 2017-02-13 14:37:38 +00:00
Andrea Gelmini
417bc89880 Fix typos 
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c
Reviewed-on: https://gerrit.libreoffice.org/34199
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
 2017-02-13 09:37:18 +00:00
Caolán McNamara
fc81a580dd coverity#736181 Out-of-bounds read 
it should be fine, as we rely on there being at least one password
char, this is the same as,

commit 2d3ed7ebb5
Author: Michael Meeks <michael.meeks@collabora.com>
Date:   Tue Feb 25 22:48:48 2014 +0000

    cid#736173 - increase default fill chars buffer size.

which is another impl of this

Change-Id: I5e1e07af37bea0398153ede300beed67d37d5e12
 2017-02-10 11:07:46 +00:00
Caolán McNamara
805784cb85 ofz#579 wrong variable tested for 0 
Change-Id: I721dc9d1c15296b2658421b4c4fe794578f3f1af
 2017-02-10 09:28:01 +00:00
Noel Grandin
76cf4c3656 convert PDFVersion to scoped enum 
Change-Id: I9920f4c9783eb23a41d135e5eacd12805c1b9c2b
Reviewed-on: https://gerrit.libreoffice.org/34060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-09 10:13:58 +00:00
Noel Grandin
b5699cd01b convert BmpConversion to scoped enum 
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators

Also fix a bug in x11::convertBitmapDepth where we were incorrectly
passing BmpConversion enumeratirs to ReduceColors

Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242
Reviewed-on: https://gerrit.libreoffice.org/34062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-09 08:42:06 +00:00
Cor Nouws
ae1b9d55ee tdf#90436 - better wording for selection in case of PDF export from Calc 
improved patch

Change-Id: I6baf39db88d3fe9322c573a288243689d1696d7f
Reviewed-on: https://gerrit.libreoffice.org/33977
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2017-02-07 11:37:24 +00:00
Stephan Bergmann
6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Caolán McNamara
bac4b46e86 Resolves: ofz#547 Floating-point-exception 
Change-Id: I9612bef0198ce8f09d39f5000a31819c175027d1
 2017-02-06 09:29:27 +00:00
Julien Nabet
223f1f2b81 Typos 
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52
Reviewed-on: https://gerrit.libreoffice.org/33900
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-02-03 21:09:44 +00:00
Julien Nabet
aea9eeb159 Typo about "property" 
Change-Id: I17bd9ce74d95beaa230276bec40b739b05b81cf2
Reviewed-on: https://gerrit.libreoffice.org/33898
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-02-03 19:29:57 +00:00
Noel Grandin
f4826959c1 new loplugin:unusedenumconstants 
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits

Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:59:39 +00:00
Noel Grandin
4978328534 convert method names in tools::SvRef to be more like our other.. 
reference classes, uno::Reference and rtl::Reference.

Specifically rename Is()->is() and Clear()->clear().

Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae
Reviewed-on: https://gerrit.libreoffice.org/33576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 08:02:54 +00:00
Noel Grandin
52360bf8dd convert BmpCombine to scoped enum and drop unused 
Change-Id: Ic67474683a25a25e5753777f4bbbeded6ceba414
Reviewed-on: https://gerrit.libreoffice.org/33793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 07:45:28 +00:00
Noel Grandin
2489000d3f loplugin:useuniqueptr extend to check local vars 
just the simple and obvious case for now, of a local var being allocated
and deleted inside a single local block, and the delete happening at the
end of the block

Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
Reviewed-on: https://gerrit.libreoffice.org/33749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-01 12:15:22 +00:00
Caolán McNamara
2934b737e9 ofz#506 check len before alloc 
Change-Id: Ia3a30936fadde10275a964d09150a3b6e4f3e16f
 2017-02-01 08:56:31 +00:00
David Tardon
bc4097ed56 upload libmwaw 0.3.10 
Change-Id: I1355f60bdaf66aecef22f1093f57369b9fd91972
Reviewed-on: https://gerrit.libreoffice.org/33745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2017-01-31 20:08:48 +00:00
Caolán McNamara
fbb91632da we don't actually need width amount of data in advance to fill the width 
seeing as we seek from previous position + bytecount on each loop
we can only be sure we go forward the min (+1/+2) for each iteration

Change-Id: I4f1a29d96c43ee8aa858c97405d196b89994669b
 2017-01-31 10:18:29 +00:00
Caolán McNamara
267d6e19e3 ofz: we're going to need at last a len field and a CounterByte on each row 
Change-Id: I5c5c2d67bcba7692e696be6ab96db041b20416a4
 2017-01-30 22:44:46 +00:00
Caolán McNamara
4d009bb402 ofz: div by zero 
Change-Id: Id5174bb9f0d89fc2286c130650ec27c9df13e123
 2017-01-30 09:48:08 +00:00
Caolán McNamara
f15b444966 ofz: defer bitmap initialization until size checks are completed 
Change-Id: I64715b5fe263889d2d62a7a9876d9856842e4a05
 2017-01-30 08:56:32 +00:00
Caolán McNamara
e4f7e197f7 we don't need read access, only write 
Change-Id: If9720a402ce360fd691a4ce83f267e2d19e19652
 2017-01-29 21:23:29 +00:00
Caolán McNamara
5b4d218b35 ofz: cluster of unused variables -> div by zero 
Change-Id: Ic3ca3228b112301217f0eb239899c775de52975e
 2017-01-28 20:40:42 +00:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor.. 
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-28 09:22:55 +00:00
Rohan Kumar
6e901f8651 tdf#51358 Support for SnakeWipe transition animation in SVG support 
ported the class SnakeWipe.

Change-Id: Icb41072bbd276e0edf3ef2ecea6148c81110b53e
Reviewed-on: https://gerrit.libreoffice.org/23285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-01-28 06:16:25 +00:00
Caolán McNamara
94ffb720b8 ofz: tidy up eps preview import 
a) check that the remaining stream length is >= the 14 bytes that are
unconditionally skipped
b) make the initial security count the min of the arbitrary 100 and the
remaining stream len less that 14 bytes
c) tweak ImplGetNumber not to reduce nSecurityCount if its already 0

Change-Id: Ifffa6d02d492affd578fb48007704457ad635b39
 2017-01-27 10:55:23 +00:00
Caolán McNamara
521723b118 move deref inside (laughable) nSecurityCount check 
Change-Id: Idf9a83ffa80137967d8c77d7a9b5133529fc2858
 2017-01-27 10:39:20 +00:00
Caolán McNamara
cf06348d9d make this a little more readable 
Change-Id: I83b6b0bd636b639ce0892f22f216410ce79dee03
 2017-01-27 10:35:33 +00:00
Caolán McNamara
d1f3168162 ofz: check if the stream is able to meet the eps len claim before reading 
Change-Id: I440c7f38d6588c570a411f2a97c0164e5d7d646f
 2017-01-27 09:01:50 +00:00
Gian Domenico Ceccarini
78f5923e7c use . as decimal separator in exported number format 
Change-Id: I951995a028274c93e0c0b7226e6d2dceec5a916d
Reviewed-on: https://gerrit.libreoffice.org/33022
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2017-01-27 07:26:06 +00:00
Caolán McNamara
e17a34e957 ofz: check if the stream is able to meet the eps len claim before reading 
Change-Id: I65407bffb67449e203b8ead23554a4e88387d214
 2017-01-26 21:04:30 +00:00
Caolán McNamara
f85fb724d5 ofz: check eps seeks are sane and succeeded 
Change-Id: I0eb45e1c1ffd91682ed0ce6a6a74eab54666d715
 2017-01-26 16:02:53 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00