mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
406,095 Commits 1 Branch 0 Tags
Commit Graph

190 Commits

Author SHA1 Message Date
Noel Grandin
86a32589e9 Find places where OUString and OString are passed by value. 
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
 2014-03-18 08:32:26 +02:00
Alexander Wilms
bed18b128f Remove visual noise from forms 
Conflicts:
	forms/source/component/DatabaseForm.cxx

Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 14:54:56 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Stephan Bergmann
b7259532d8 Remove unnecessary bool2any 
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
 2014-02-24 08:08:00 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Caolán McNamara
466e8bd416 coverity#738654 Uninitialized scalar field 
Change-Id: I92909b606e06f3d86fc3b66aef1ac52e5d706967
 2014-02-21 12:40:27 +00:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool 
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
 2014-02-17 17:55:19 +01:00
Arnaud Versini
5a73cceee5 FORMS : Remove usage of DBG_CTOR and DBG_DTOR. 
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 16:26:50 +00:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Lionel Elie Mamane
f237f1a616 fdo#66171 ListBox correctly save empty or zero BoundColumn 
Change-Id: I05fa923f962191081ea3318837d3e181c183b466
 2013-06-27 18:53:00 +02:00
Lionel Elie Mamane
e2d9138ce0 make "gcc -Werror" happy 
Change-Id: I6dd1bf6b4535bb956cb7e85908312d52749a6f2b
 2013-06-23 20:52:48 +02:00
Lionel Elie Mamane
f76cedf1d6 Data-aware ListBox: fix case ListSourceType==TableFields 
Change-Id: I9a89374fd1cc56c8185753f5959275a0a2d841ff
 2013-06-23 20:05:55 +02:00
Lionel Elie Mamane
8e824b11b6 Don't second-guess the database 
If it gives us a NULL as bound value,
use it, even if the underlying column
has constraint NOT NULL.

This can happen e.g. in OUTER JOIN,
with UNION, ...

Change-Id: I1fc0d9366764b90e0cdb443cd34c32b52f059e0b
 2013-06-23 18:02:05 +02:00
Lionel Elie Mamane
d8eafdafe0 Data-aware ListBox: use entry for NULL if the *bound* value is NULL 
as opposed to when the display string is empty.

Change-Id: I802955404d2d8d5c91b3fd1633e34be7ef4f0b82
 2013-06-23 17:40:39 +02:00
Lionel Elie Mamane
157a9da934 Use unsigned values in m_a(Converted)BoundValues 
Values that come from the database are always signed
(we inherit that from sdbc that inherits that from jdbc
 that inherits that from Java's type system that does not have unsigned values)
So when using unsigned values, they always operator==-compare false!

Change-Id: I604b04afa23ede835c1f3db1f8c1bdeafbfba7ea
 2013-06-23 17:40:14 +02:00
Lionel Elie Mamane
2d432035a8 enhance comment 
Change-Id: I897a59d10a903bfe303b1ac059f19b6dcc686616
 2013-06-23 17:39:48 +02:00
Lionel Elie Mamane
2a2b900544 avoid initialise-then-reset 
Directly construct as unitialised

Change-Id: I66aa4f5a5f5ed2c1d5bf0cb8083e1968ef776bf7
 2013-06-23 17:39:22 +02:00
Noel Grandin
d209e13319 fdo#46808, Convert comphelper::ComponentContext in forms module 
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
 2013-06-03 10:00:03 +02:00
Noel Grandin
2838b8eb5e fdo#46808, Convert ComponentContext in connectivity,extension.. 
...modules.

Change-Id: Ie61976dc12b514bb85ca42496c0d9173a1c56264
 2013-06-03 10:00:02 +02:00
Radu Ioan
660b67a413 fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO 
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: Id4e90b83a7275bfd30914f7514a609cebbfbf4ac
Reviewed-on: https://gerrit.libreoffice.org/4044
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
 2013-05-31 18:08:02 +00:00
Lionel Elie Mamane
3e5b9865fa fdo#64456 impl_getValues always set m_nConvertedBoundValuesType 
That is, also when returning an ephemeral value constructed from StringItemList

Change-Id: I3f0edcb6cc31926c6b82acbcb88282829314b859
 2013-05-12 05:07:55 +02:00
Miklos Vajna
8ed6f1c2bf forms: FORMS_CONSTASCII_STRING is no longer needed 
Change-Id: I2b666f0e48db4c97cc4c641480a82681f5057ac2
 2013-04-23 11:58:32 +02:00
Lionel Elie Mamane
dfcbc1e1af Data-aware ListBox: declare the newly supported External Binding Types 
Change-Id: I5ab021f99373f24b6be2ca6db00fe8b6e69bc9cb
 2013-04-22 21:54:21 +02:00
Lionel Elie Mamane
567a4fcf02 Data-aware bindable ListBox new feature: bind *value* 
As opposed to index in list or *display* string

Change-Id: I5fa74c80b28db843d45ee68523a4349ba44d229b
 2013-04-22 17:56:00 +02:00
Lionel Elie Mamane
a2c54dc208 ListBox: take care of validation (use binding value when appropriate) 
Change-Id: I7c2ab0e42a82baa39e1b48124cc8cf58bfa126d5
 2013-04-22 17:55:55 +02:00
Lionel Elie Mamane
1e698bb7f1 Use (get|set)ControlValue instead of manipulating the property directly 
Change-Id: Ice58cf4f67fae6a26548bae6569ae0c0993a7e84
 2013-04-22 17:55:49 +02:00
Lionel Elie Mamane
a16bb08013 Data-aware ListBox: add SelectedValue and SelectedValues properties 
Change-Id: Id081e4f6bb765056f17babcfec52a1aedcd7b5d5
 2013-04-22 17:55:34 +02:00
Lionel Elie Mamane
f7be9c71d4 janitorial: typo in variable name 
Change-Id: I0bc68e7a1f589e11f16bc539f49a323e64bd834f
 2013-04-22 17:55:24 +02:00
Lionel Elie Mamane
bfc0bf6a16 Data-aware ListBox: BoundValue==-1 to store index in list 
Change-Id: I248cd5ec62574f47a27f8b37e1e90333b8748af2
 2013-04-22 17:55:14 +02:00
Lionel Elie Mamane
52bc6737cd Data-aware ListBox: getCurrentValue should return *binding* values 
As opposed to display values

Change-Id: I8afb52d69786702776f4e8d24390ba8ede417e92
 2013-04-22 17:51:46 +02:00
Lionel Elie Mamane
3e1a0c9b2f Data-aware ListBox: populate ValueList even without bound field 
Change-Id: I8742285778962b5be10f3aa300236efd525bdeb9
 2013-04-22 17:51:41 +02:00
Lionel Elie Mamane
0202f9b7c4 assert non-nullness of interface before use 
Change-Id: I467830dce80e97db1b20c6d589fb4ca407cfa26c
 2013-04-22 17:51:36 +02:00
Lionel Elie Mamane
64ef3bf0d9 janitorial: typo in comment 
Change-Id: Icba805697caa6675339535b382fc4f24f86a94fb
 2013-04-22 17:51:25 +02:00
Lionel Elie Mamane
24bdda09fb factorise common code 
Change-Id: I53ee3b7c99205046b25f437480d26e484ac2c340
 2013-04-22 17:51:20 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Thomas Arnhold
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations 
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 10:48:30 +00:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings 
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 09:00:26 +00:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling 
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
 2013-03-03 17:14:16 +01:00
Fridrich Štrba
79080b68f3 Include <iterator> 
Change-Id: I8a3db271ed0400decc00b88c75603cc73ffdd1db
 2012-11-30 11:56:58 +01:00
Michael Meeks
0a063f3a36 re-base on ALv2 code. Includes: 
Patch contributed by Christian Lippka
    impress212: #i113063# patch: dubios self assign in svx/source/dialog/framelink.cxx
    http://svn.apache.org/viewvc?view=revision&revision=1167619

    Patches contributed by Mathias Bauer
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117712#: fix several resource errors introduced by
    IAccessible2 implementation
    http://svn.apache.org/viewvc?view=revision&revision=1172343
    cws mba34issues01: #i117719#: use correct resource ID
    http://svn.apache.org/viewvc?view=revision&revision=1172351

    Patch contributed by Andre Fischer
    Do not add targets for junit tests when junit is disabled.
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    Patches contributed by Armin Le-Grand
    #118804# corrected GraphicExporter behaviour on shortcut when pixel graphic is requested
    http://svn.apache.org/viewvc?view=revision&revision=1240195
    fix for #118525#: Using primitives for chart sub-geometry visualisation
    http://svn.apache.org/viewvc?view=revision&revision=1226879
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118524: apply patch, followup fixes to 118485
    http://svn.apache.org/viewvc?view=revision&revision=1186077 13f79535-47bb-0310-9956-ffa450edef68

    Patch contributed by Regina Henschel
    linecap: Reintegrating finished LineCap feature
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    Patch contributed by Wang Lei (leiw)
    #i118760# split the first table cell vertically, then undo&redo,
    the Presentation app will crash
    http://svn.apache.org/viewvc?view=revision&revision=1301361

cleanup globlmn hacks, undo dependent fixmes.
 2012-11-27 12:55:10 +00:00
Jung-uk Kim
ed93117447 fdo#53061: Fix for C++11 #define NULL nullptr 
Change-Id: Ia1805aab4bec7fef02c96ec4e7a7a0ed9991d3c3
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2012-08-14 10:39:13 +02:00
Thomas Arnhold
2beba8f93e reduce ascii noise and useless comments 
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
 2012-08-08 13:53:54 +02:00
Thomas Arnhold
57154616f0 Remove UNO includes comments 
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
 2012-06-29 09:25:09 +02:00
David Tardon
e6c997c962 mingw: avoid weird build error and -Werror 
The error message is:
"'*((void*)& aBoundColumn +2)' may be used uninitialized in this function"

using gcc 4.7.0 in gnu++11 mode and boost 1.48.0 .
 2012-04-16 20:23:23 +02:00
Stephan Bergmann
2eaa1422a0 Adapted AsyncEventNotifier to safer-to-use salhelper::Thread 2012-02-23 10:47:37 +01:00
Lionel Elie Mamane
c55d050400 fdo#46163 convert bound values to bound column's type 2012-02-16 13:33:04 +01:00
Lionel Elie Mamane
fc593ac601 correct indentation 2012-02-16 13:33:04 +01:00
Philipp Weissenbacher
7212cc8081 Translate German comments 2012-02-16 13:12:37 +01:00