Stephan Bergmann
0abfcb735e
Undef RGB where it was defined, not where it gets used
...
Change-Id: I1e122bb7c32850dfdd74de029c8d92a328207a95
Reviewed-on: https://gerrit.libreoffice.org/20430
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-07 12:35:02 +00:00
Stephan Bergmann
a846982f9e
-Werror,-Wunused-private-field
...
Change-Id: Icf15313f5bcacbe9c7efa0b4161929dbb3e39c1e
2015-12-02 08:02:17 +01:00
Stephan Bergmann
6760dc5f16
-Werror,-Wunused-const-variable
...
Change-Id: I4331396f5bbc37306c09f0e9a1c6b2969922f66f
2015-11-28 08:44:48 +01:00
Stephan Bergmann
a649689fac
-Werror,-Wreorder
...
Change-Id: I0988cf701dea563e3990b4179879fbcd3778662d
2015-11-28 08:44:48 +01:00
Stephan Bergmann
adf2c52352
-Werror,-Wunused-const-variable
...
Change-Id: Ie539b4f3e4295a8dcb1126371e5f2c75e9d723ab
2015-11-28 08:44:47 +01:00
Stephan Bergmann
dd706ea26d
-Werror,-Wunused-const-variable
...
Change-Id: Ib725e544d058c735e485db1586743746a5236488
2015-11-28 08:44:47 +01:00
Stephan Bergmann
3493c74970
Avoid ambiguity which OUStringBuffer ctor to select
...
...for size_t (i.e., unsigned long long on Windows 64-bit), chosing among the
int, unsigned int, long, unsigned long overloads. MSVC apparently happily picks
one of them, but clang-cl rightly complains.
Change-Id: Ib245925bdf9e4a34add6ca435a95559f4f07c4d7
2015-11-28 08:44:47 +01:00
Stephan Bergmann
1ef0dd7aef
-Werror,-Wunused-function
...
Change-Id: Id53c00a90f4f2d87e469ae4fe4121a5678dff5a4
2015-11-28 08:44:47 +01:00
Noel Grandin
fafac0d248
loplugin:unusedfields forms,formula,fpicker,framework
...
Change-Id: Ic7af56ac801c1e5b3fcf3c4e8413656e96220279
2015-11-20 15:07:05 +02:00
Noel Grandin
53f16c39f5
remove unused typedefs and inline use-once typedefs
...
and improve the script a little
Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84
Reviewed-on: https://gerrit.libreoffice.org/20033
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-18 10:38:08 +00:00
Noel Grandin
d9e6270392
loplugin:unnecessaryvirtual
...
update the plugin with lessons learned from the mergeclasses plugin and
re-run it
Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17 12:26:32 +00:00
Stephan Bergmann
f199bbafd3
Don't assume sal_Unicode is unsigned short
...
Change-Id: I82bb9471479523d68641fd815da1208f0d45b8a8
2015-11-17 10:37:05 +01:00
Noel Grandin
8569c6d0ad
use initialiser list for Sequence<OUString>
...
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16 08:35:42 +00:00
Noel Grandin
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Noel Grandin
25aec383f9
use initialiser for Sequence<OUString>
...
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"
Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:18:55 +00:00
Noel Grandin
8e234c5b7d
use initialiser syntax for Sequence<OUString>
...
replaced using the script:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi
-e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"
Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 10:13:08 +00:00
Stephan Bergmann
90dba06daf
loplugin:nullptr (automatic rewrite; Mac-specific code)
...
Change-Id: I14ed4aa3cfc52dcb9a75de2364074dec18be3d5d
2015-11-10 16:20:35 +01:00
Stephan Bergmann
88b5e5fd3a
loplugin:nullptr (automatic rewrite)
...
Change-Id: I7f32320f38be2bb4f62b57e856e93cff708d5ee0
2015-11-10 10:31:26 +01:00
Stephan Bergmann
9d3cb71115
Prevent += called on temporary O[U]String instances
...
...found regression e31205f3ec1f941ab5a188bfde6329edf2acc55b
"EditUndoRemoveChars::GetStr must return a reference" and dubious code
0e23f7b0839df68d277186b4df54ba391ac3406a "Lets assume this doesn't want to
update m_pForcedPrefix->GetText() anyway" in addition to the apparent sillies
directly fixed in this commit.
Introduces HAVE_CXX11_REF_QUALIFIER.
Change-Id: I564e98254fd53c1dd9b34193d7057c59721ee24c
2015-11-09 12:22:17 +01:00
Mario J. Rugiero
f045b7cb45
Replace a few for_each and one-liner locals by range-based loops in fpicker.
...
Change-Id: I07cb510b8c8ab195d5d3addb715cfb0af488ab9b
Reviewed-on: https://gerrit.libreoffice.org/19849
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 06:09:56 +00:00
Stephan Bergmann
e9c65d802b
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: Ib9c9daa113fecff495a51dca1bfaace1239b6ebc
2015-11-06 09:36:04 +01:00
Noel Grandin
1b41208608
use uno::Reference::set method instead of assignment
...
Change-Id: I3d94c94a9829161663a7ed18421ace38ce95a659
Reviewed-on: https://gerrit.libreoffice.org/19733
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-02 06:17:21 +00:00
Noel Grandin
0e6544903b
no need to be so verbose in constructing uno::Reference
...
Change-Id: I187a26e200e9ecaff2adaf53a2ba3f6e87346030
Reviewed-on: https://gerrit.libreoffice.org/19724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01 15:26:10 +00:00
Noel Grandin
b5db48ada1
no need to use OUString constructor in call to createInstance
...
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01 15:25:43 +00:00
Noel Grandin
a673713bb3
more removal of com::sun::star typedefs
...
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21 15:10:24 +02:00
Noel Grandin
382eb1a23c
remove untyped Link<>
...
Change-Id: I809f9e10309ceadda0a82c3818277323b34ec61b
Reviewed-on: https://gerrit.libreoffice.org/19491
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-21 07:44:43 +00:00
Stephan Bergmann
2a5b3c0267
loplugin:defaultparams
...
Change-Id: I6372cf755a78772094bf5fdcb076cc6ea395fc89
2015-10-19 17:50:16 +02:00
Noel Grandin
39e63bfac5
convert remaing DBG_WARNING to SAL_INFO
...
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
Noel Grandin
6f1313b3d4
convert Link<> to typed
...
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-16 09:11:29 +00:00
Noel Grandin
99b21cc9f3
convert Link<> to typed
...
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15 09:58:34 +02:00
Noel Grandin
b4da5037e0
convert Link<> to typed
...
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-14 09:30:20 +02:00
Noel Grandin
ba974ccc8c
com::sun::star->css in fpicker/
...
Change-Id: I211687bfeaf456e0f9639567bff401083011cd74
Reviewed-on: https://gerrit.libreoffice.org/19353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-14 06:36:34 +00:00
Stephan Bergmann
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
Noel Grandin
3c99f8500f
convert Link<> to typed
...
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12 10:48:13 +00:00
Oliver Specht
f9157d1a21
tdf#94811: Crash in Open Remote File dialog fixed
...
Edit control needed a disposeAndClear instead of a clear
Change-Id: I24f4ec8c391080cb83574949cc141c883b43cfb9
Reviewed-on: https://gerrit.libreoffice.org/19185
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06 09:17:22 +00:00
Szymon Kłos
45817662f3
Remember password after setting new service
...
Change-Id: I14ba319307f74b24fa474e742504b70c46539a08
2015-10-05 19:24:08 +02:00
Szymon Kłos
3ff764c9f4
Focus for file list after opening folder
...
Change-Id: Ibac322b873315fd8a0ec63c930f4c76562a5e704
2015-10-05 19:24:08 +02:00
Szymon Kłos
227aa18e23
Focus for file name field after using it to open folder
...
Change-Id: Ic3ae0c899c5feea659d22100f98dbeca4df217eb
2015-10-05 19:24:07 +02:00
Szymon Kłos
39a438dec5
tdf#57370 : Open place after pressing 'Enter'
...
Change-Id: Iabcf17b71b3fe06a25bb7b0e7f3aa65ad0663e69
Reviewed-on: https://gerrit.libreoffice.org/19085
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-02 10:44:41 +00:00
Andrea Gelmini
a0649f316e
Fix typos
...
Change-Id: Id94c03249b2752e88499628b3ad12936b361bb2f
Reviewed-on: https://gerrit.libreoffice.org/18950
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-10-01 11:26:35 +00:00
Noel Grandin
e209d115d4
remove old standalone Sun bug numbers
...
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 06:57:19 +00:00
Stefan Heinemann
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
Caolán McNamara
6f70cf8348
don't over-expand built-in file dialog on very long paths/names
...
Change-Id: Ia8167833b54bcfc68f1a306e58a1134a38d64ef6
Reviewed-on: https://gerrit.libreoffice.org/18843
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-25 09:47:58 +00:00
Noel Grandin
e85b2333bc
convert Link<> to typed
...
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-24 16:19:37 +00:00
Caolán McNamara
f36a36b575
boost->std
...
Change-Id: Idac11d3a634ba0a899db605449c894d4c3a61ead
Reviewed-on: https://gerrit.libreoffice.org/18680
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 09:52:37 +00:00
Noel Grandin
95be2bbe0f
remove unused Link<> fields
...
Change-Id: I9898e04da6bebd1e08ab141e43439908fe1860b0
2015-09-16 08:38:54 +02:00
Noel Grandin
e0f617aa58
convert Link<> to typed
...
Change-Id: I8cd997f55f4c7206358cba9edd3d41dbedd4363f
2015-09-15 09:37:31 +02:00
Noel Grandin
55cdab3b8b
convert Link<> to typed
...
Change-Id: I057969beed6402b2125f4dc719570d324c1df4fc
2015-09-15 09:37:31 +02:00
Julien Nabet
5bbff06137
[API CHANGE] XFilePicker2/3 changes for multiselection
...
In order to use GetSelectedFiles (in XFilePicker2) instead of GetFiles (in XFilePicker),
here are some api changes
before:
XFilePicker3 inherits from XFilePicker
XFilePicker2 is not a published interface
after:
XFilePicker3 inherits from XFilePicker2
XFilePicker2 is a published interface
+ adapt Uno Implementations
Change-Id: If44afaa7236f08bc2b814f91eda5bfad333dd799
Reviewed-on: https://gerrit.libreoffice.org/17068
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-15 06:17:47 +00:00