836 Commits

Author SHA1 Message Date
Noel Grandin
1a08ce7078 loplugin:staticfunction
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-27 10:51:08 +02:00
Stephan Bergmann
d3b69645d8 const_cast: convert some C-style casts and remove some redundant ones
Change-Id: I81dc70639a866368b9a6c69afffdfd42464e9138
2015-03-26 15:33:32 +01:00
Caolán McNamara
ab86a53623 V805: Decreased performance
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
2015-03-02 14:21:52 +00:00
Stephan Bergmann
b3934e4afc loplugin:deletedspecial
Change-Id: I6827530316561e600b760a2620f859b28c6c91e6
2015-02-07 12:35:59 +01:00
Stephan Bergmann
9c0cb45562 Some more loplugin:cstylecast: jvmfwk
Change-Id: Iaa1be4b338b75c340555eb4bf0760cadca16713f
2015-01-20 09:06:49 +01:00
Michael Weghorn
bb65b09678 avoid copying of vector
Change-Id: I06ce27f4fa52637bbeaa6d84fdecdf81364e15a7
Reviewed-on: https://gerrit.libreoffice.org/13489
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-08 09:54:05 +00:00
Miklos Vajna
05850304c9 jvmfwk: fix Android build
Change-Id: Ib183158e51f7bebbb6add92e460a33fa132c1c9d
2015-01-07 11:24:02 +01:00
Julien Nabet
5a4c549d32 Some cppcheck cleanings: Prefer prefix ++/-- operators for non-primitive types
Change-Id: I899164412ad90653b4228423283f9fbd4cb5fccc
2014-12-18 21:14:10 +01:00
Stephan Bergmann
39733239d3 jvmfwk: Use appropriate OUString functions on string constants
Change-Id: I5a16fdd9217f0523212842650d74f504f17848fd
2014-12-18 15:00:28 +01:00
Stephan Bergmann
f582ad2c69 jvmfwk: Use appropriate OUString functions on string constants
Change-Id: I3e0b70c61c4e92f2cbd27ce7c45e67ae04dfe14c
2014-12-16 17:29:29 +01:00
Stephan Bergmann
555f024f16 Related fdo#83753: Fix JVM_ONE_PATH_CHECK feature again
Change-Id: I1dc3b0db6295c43a9d29576b81870b4a293a61aa
2014-12-16 09:39:16 +01:00
Stephan Bergmann
72d8747ad9 Remove obsolete comment
Change-Id: I66dcf6284bd1b7afb1c60c838bbbb2052e06072b
2014-12-15 16:51:11 +01:00
Stephan Bergmann
5e9a2e9b0f Check each potential JRE location only once
i.e., after recent "fdo#83753: consider JAVA_HOME and PATH when selecting JRE"
fix, if jfw_findAndSelectJRE found no suitable JRE in
jfw_plugin_getJavaInfoFromJavaHome or jfw_plugin_getJavaInfosFromPath, do not
re-check those locations in jfw_plugin_getAllJavaInfos.

Change-Id: If4e085b4fceff5b2494c7b7b84ac51691dbc78cc
2014-12-15 16:45:51 +01:00
Stephan Bergmann
0136acb836 Rename getJREInfoByPath overload to getAndAddJREInfoByPath
Change-Id: Ib6eac731a4b8193a8d9b9132da78e7961aec22ab
2014-12-15 16:45:51 +01:00
Stephan Bergmann
5d2398a982 getJREInfoFromBinPath return value is unused
Change-Id: I360d7cb7c03e78739883db4b989ba5f31bc8e24b
2014-12-15 16:45:51 +01:00
Michael Weghorn
40138cee6b fdo#83753: consider JAVA_HOME and PATH when selecting JRE
adapted algorithm that selects the Java runtime to be used so that
Java installations associated with the JAVA_HOME and PATH
environment variables are preferred over others

Java installations are now analysed in the following order:
* installation that the JAVA_HOME environment
    variable refers to (if it is set)
* Java installations in PATH
* other Java installation (algorithm that was used before)

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>

Conflicts:
	jvmfwk/source/framework.cxx

Change-Id: I3a3ade25322def0c0432b369848f13a6b82034a1
2014-12-15 16:45:51 +01:00
Stephan Bergmann
8814eb4770 Remove unused cModule leftovers
Change-Id: Id08194460e9a42896591047e36b3a95e5fbc47be
2014-12-15 13:18:56 +01:00
Noel Grandin
7d812b09b5 java: unused imports
Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08
Reviewed-on: https://gerrit.libreoffice.org/13403
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:03:50 +00:00
Caolán McNamara
6d8b06224c callcatcher: update unused code
Change-Id: I3cd65d112339fa9c67ed462fe39acbbef91d4d8d
2014-12-08 10:09:01 +00:00
Noel Grandin
c199b76d88 java: remove some unused local variables
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05 11:15:57 +02:00
Caolán McNamara
f4d03933dc callcatcher: update unused code
Change-Id: Ia25b857738bb7b6c3baf18c68ef0d1bc0b3e142e
2014-12-04 10:44:36 +00:00
Stephan Bergmann
827430c8c0 Fold URE: Windows
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is
no longer necessary and loading of cppuhelper from the program dir cannot fail
regardless in whatever scenario the cli_cppuhelper library itself is loaded.

Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
2014-12-03 15:19:55 +01:00
Stephan Bergmann
982f199a98 Fold URE: Linux ure/share/misc/* -> program/
...and remove now unused ure-link symlink

Change-Id: Ic958432c1dad4fae213982d0af072187f151620b
2014-12-01 15:10:32 +01:00
Stephan Bergmann
45ca1bfc22 Fold URE: Linux ure/lib/* -> program/
The ../../../program/ links in the URE jar Class-Paths are a temporary kludge
(and juh.jar had lacked adaption for Mac OS X).

Change-Id: I2542d8a582866485dd61c05df3fc6b4b39a8403d
2014-11-28 11:57:28 +01:00
Caolán McNamara
0aa25403cb fix higher debug level build
Change-Id: Ie61be2bd009b71bbbb7261865d026faf3af706ce
2014-11-26 13:03:37 +00:00
Michael Weghorn
772a36932e changed type of parameters from rtl_uString to OUString
changed type of several parameters of the functions
jfw_plugin_getAllJavaInfos and jfw_plugin_getJavaInfoByPath
from rtl_uString to OUString

Change-Id: I80feb311542e6ccded9f9924f800c75a7e14a1e7
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-19 09:09:59 +01:00
Stephan Bergmann
8c27c4acee Pass by ref
Change-Id: I88def7e41a31948d1d7205cd5522b63de6be5f80
2014-11-18 14:26:52 +01:00
Michael Weghorn
8c36dc2cbc sunjavaplugin.cxx: extracted function for Java version check
extracted the (duplicate) code which is responsible to check the Java
version requirements in the two functions
"jfw_plugin_getAllJavaInfos" and "jfw_plugin_getJavaInfoByPath"

Change-Id: I8acb198c4b4aaee77dc84bc42ff1fc2e0da2aba7
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-18 14:26:52 +01:00
Michael Weghorn
7bd4d1e918 remove duplicate code line
Change-Id: Ia1e9d2b31698db23029e4dd5f0f7659acff5d30f
Reviewed-on: https://gerrit.libreoffice.org/12951
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-18 13:09:33 +00:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Caolán McNamara
6abcd7fe9b coverity#1247641 Uncaught exception
Change-Id: I35e1eed91a23d2b993398fb39e47e21ca9c0a055
2014-11-14 12:02:46 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method"
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
Caolán McNamara
12bcfec04f markup with event type not checker type
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05 14:58:00 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Andrea Gelmini
0c0e3e7539 Fixed typos. No automatic tools (sed, and so on).
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30 17:16:02 +00:00
Caolán McNamara
c7b0c02ddd coverity#1247641 Uncaught exception
Change-Id: I61e55095b4f74fd619a26cba88dd177d0e318154
2014-10-30 14:34:25 +00:00
Caolán McNamara
9b8f91d348 coverity#1247624 oslModule -> osl::Module
should silence warning, still actually
avoid dlclose on the non-error path

Change-Id: Ibc522bf1067feb04def7d7284eee59878ddc6f47
2014-10-29 10:40:07 +00:00
Stephan Bergmann
f66cbdb948 Work around OpenJDK's os::workaround_expand_exec_shield_cs_limit
Change-Id: Iea1b6354764db0a22976b3de49bf3e22ccb7243e
2014-10-27 18:26:33 +01:00
Stephan Bergmann
564fe4e36a Clean up JNI_CreateJavaVM option code
Change-Id: I1902c73a72f29e948e479a2ae4776f2dff77b2b5
2014-10-27 17:59:06 +01:00
Stephan Bergmann
42a05b4b2a Remove unnecessary jfw_plugin::getVendorNames
Change-Id: I3c134c27db4c1496fcacc519da68af10ab3ce574
2014-10-21 08:52:58 +02:00
Stephan Bergmann
af748c7fff Clean up VendorBase (virtual) member functions further
Change-Id: If6b9355c6992eb6651f71c0944a93af0856ef1c7
2014-10-20 18:07:27 +02:00
Stephan Bergmann
5dcfbe57c8 Clean up VendorBase (virtual) member functions
Change-Id: I1377dfded1246c8e96db3addc28489886c7f2d99
2014-10-20 17:58:44 +02:00
Stephan Bergmann
e3dc8cb177 Missing "
Change-Id: I5d596f85fe11bc9336e1669d571795f3dfc70c6c
2014-10-20 11:02:44 +02:00
Tor Lillqvist
68e0f4d4f2 Clean jvmfwk tracing output
Change-Id: I070fb24e9466d697a6014bd65635f6cda8736819
2014-10-20 11:27:56 +03:00
Tor Lillqvist
247f197cba Skip vendors that are irrelevant
There surely are no Apple JVMs for other OSes than OS X.
Correspondingly, there surely are no IBM, Blackdown, BEA, FSF or
FreeBSD JVMs for OS X. At least not ones that would be relevant today.

Change-Id: I0ee6f904665a2145771802beffe54268718bef50
2014-10-20 11:25:22 +03:00
Caolán McNamara
1156d11ef0 coverity#1066164 Resource leak
Change-Id: I152f22728a8eeea65114fe102511940bccf40478
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-13 17:45:13 +02:00
Stephan Bergmann
04a290b107 vendorplugin.h is jvmfwk-internal (and no need for extern "C")
Change-Id: I954f789d5850e8016f5900812f9aa99be2416ce4
2014-10-09 18:09:41 +02:00