9552 Commits

Author SHA1 Message Date
Noel Grandin
ff339c89b5 loplugin:constantparam part2
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05 06:42:40 +00:00
Bjoern Michaelsen
3ecb9b4bd7 tdf#99352: assert on stray VclPtrs past DeInit
- ignore on Windows for now, as it is acting up

Change-Id: I98dbb887ed556b58188870c3eb3de1327bc58109
Reviewed-on: https://gerrit.libreoffice.org/35816
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-04-04 14:35:16 +00:00
Jens Carl
6b4a149a65 tdf#39468 Translate German comments
Translate German comments and terms in UnoControls/, editeng/, filter/,
odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/,
tools/, writerfilter/, and xmloff/.

Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1
Reviewed-on: https://gerrit.libreoffice.org/35992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03 19:25:49 +00:00
Noel Grandin
5d0e485e82 use actual UNO enums in reportdesign..svtools
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203
Reviewed-on: https://gerrit.libreoffice.org/36043
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 09:40:19 +00:00
Julien Nabet
884499a03e Display unknown token for html key in console
Change-Id: I57740e52a8e76d4f0f68cb2e58ca3f1aab249a0b
Reviewed-on: https://gerrit.libreoffice.org/35989
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-01 07:27:14 +00:00
Miklos Vajna
a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-31 06:27:11 +00:00
Jochen Nitschke
da56de9ac4 remove type decorations on char literals
they are only needed where type deduction fails.
left them in defines for now.

Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30 12:21:40 +00:00
Noel Grandin
90305526ee loplugin:unusedenumconstants
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c
Reviewed-on: https://gerrit.libreoffice.org/35854
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30 06:26:26 +00:00
Noel Grandin
9bfd742d8c loplugin:unusedmethods
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29 11:43:40 +00:00
Markus Mohrhard
f71208f495 uitest: allow to change state of checkbox in treelist
Change-Id: If76ab528dfd835ea7718e153a943d182ecc4ce0a
Reviewed-on: https://gerrit.libreoffice.org/35698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26 02:57:34 +00:00
Markus Mohrhard
3df98c595f uitest: add info whether a tree list box contains check boxes
Change-Id: Id214928de2e74ac7ec707eaf2276e4e808b630a4
Reviewed-on: https://gerrit.libreoffice.org/35697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26 02:56:57 +00:00
Stephan Bergmann
2258f33a5f Make loplugin:loopvartoosmall find more suspicious cases
...where the "controlling expression" of any sort of loop contains a sub-
expression of the form

  var < val

where the type of var is smaller than that of val.  Theoretically, this could
turn up lots of false positives, but practically it didn't run into any.  Most
findings have been cleaned up over the last weeks.  There's just a handful
remaining places that are hard to clean up, so I flagged them here with
(deliberately awkward) sal::static_int_cast for later clean-up.

Change-Id: I0f735d46dda15b9b336150095df65cf247e9d6d3
Reviewed-on: https://gerrit.libreoffice.org/35682
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-25 16:21:34 +00:00
Andrea Gelmini
25e0872da6 Fix typos
Change-Id: I4eda687db6ad8d41e6a28430c76b288510da605d
Reviewed-on: https://gerrit.libreoffice.org/35645
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 12:25:17 +00:00
Stephan Bergmann
6291574d94 Remove unused #include <ctype.h>
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23 17:55:31 +01:00
Noel Grandin
ed76d1d350 loplugins:redundantcast teach it about c-style typedef casts
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23 09:48:10 +00:00
Noel Grandin
7299481834 loplugin:redundantcast find redundant c-style enum casts
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349
Reviewed-on: https://gerrit.libreoffice.org/35467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22 06:47:35 +00:00
Stephan Bergmann
10b8a72903 New loplugin:unicodetochar
Change-Id: I279fe1dec196b6e1e551b4f6aba77f24e3f76ab7
2017-03-21 09:18:15 +01:00
Julien Nabet
b5bef1f7d5 Typos
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c
Reviewed-on: https://gerrit.libreoffice.org/35436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 18:50:33 +00:00
Miklos Vajna
a6209ba6a8 vcl: OutputDevice::GetGlyphBoundRects()'s nIndex and nBase is always the same
So keeping just nIndex is enough.

Change-Id: I5d3a0e6b4a6ce1305a56cf50e7ff181a098f6412
Reviewed-on: https://gerrit.libreoffice.org/35336
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-17 20:18:46 +00:00
Noel Grandin
f5a16eae76 remove unused defines from HRC files in svtools
Change-Id: I5d8a6a4fd232ef10644ae45174a07b30af789205
Reviewed-on: https://gerrit.libreoffice.org/35277
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17 08:21:21 +00:00
Noel Grandin
f2a873cd13 convert SvxBorderStyle to scoped enum
and rename to SvxBorderLineStyle

Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17 06:04:30 +00:00
Eike Rathke
e0d86cff2b tdf#105448 add Xibe [sjo-CN] to language list (and remove Sibe [nco-PG])
... the latter which was a misunderstanding and erroneous.

Change-Id: I4ec8eaf14348aaaed43ea4578d46b5488279c85b
2017-03-15 18:51:40 +01:00
Eike Rathke
b614ceb80c tdf#100462 prefer en-GB-oxendict over en-GB-oed
And make en-GB-oed just an alias of en-GB-oxendict.

Change-Id: I73c1208f85d06360dbd8def0b8d916cddfe59aca
2017-03-14 15:12:49 +01:00
Eike Rathke
bde834ee6b display raw language tags in curly brackets
Place raw language tags in curly brackets {}, so all on-the-fly tags are
grouped together at the top of a listbox (but behind the "[None]"
entry).

Change-Id: I01d388150241a8482a1f39f8eda26cdd5bb1d832
2017-03-14 12:48:22 +01:00
Stephan Bergmann
6e4d3bad80 Clean up integer types representing positions in ToolBox's item vector
(vs. uses of sal_uInt16 representing such items' IDs).  APPEND and ITEM_NOTFOUND
are members of ToolBox now (and have been bumped to the corresponding type's
max).  The payload of VclEventIds

  ToolboxButtonStateChanged
  ToolboxClick
  ToolboxHighlightOff
  ToolboxItemAdded
  ToolboxItemDisabled
  ToolboxItemEnabled
  ToolboxItemRemoved
  ToolboxItemTextChanged
  ToolboxItemUpdated
  ToolboxItemWindowChanged
  ToolboxSelect

has been changed too (note that reading/writing of those payloads isn't very
consistent, though: for some of these, values are written that are never read,
while for some others no values are ever written but the reading code would like
to receive some value if the payload wasn't a nullptr).

Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-13 13:48:23 +01:00
Noel Grandin
7c0e3d0b37 convert GraphicDrawMode to scoped enum
Change-Id: I18eec89c4e1ebb86d64297e7cef4b36bf12df59f
Reviewed-on: https://gerrit.libreoffice.org/35004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13 08:38:33 +00:00
Stephan Bergmann
5b25275002 No need for extra heap allocation
Change-Id: I0844a0a8a3476cdb007ab1d587b15ce26c68783e
2017-03-09 18:26:40 +01:00
Stephan Bergmann
6412b9c5dd loplugin:loopvartoosmall
Change-Id: If76fa042462897735d0d67341a3734b8cfced12c
2017-03-08 11:01:32 +01:00
Noel Grandin
02fd5f04fb convert eHtmlMetas to scoped enum
Change-Id: I4433bb87e74b909fbd8e1144e00d8cc53954bf05
2017-03-06 09:52:04 +02:00
Noel Grandin
b0f13baae8 convert HTMLTableRules to scoped enum
Change-Id: Id8758955565579abd1f4687907d7fe06aaefa749
2017-03-06 09:52:04 +02:00
Noel Grandin
f36846b145 convert HTMLTableFrame to scoped enum
Change-Id: I1353619ca11f867ca37dec3105e50ba9f3d70d54
2017-03-06 09:52:04 +02:00
Noel Grandin
5a099fef6e convert HTMLInputType to scoped enum
Change-Id: I3f6f6aadd813898ccff93154138a2fbf911b9c8f
2017-03-06 09:52:04 +02:00
Noel Grandin
1cbef3eb08 convert HTMLScriptLanguage to scoped enum
Change-Id: If87863b520da704410a6ad261330bbde7ef8008c
2017-03-06 09:52:04 +02:00
Noel Grandin
aadf790bbc remove some unnecessary use of OUString constructor
found with
   git grep -nP '<<= OUString\(\w*[A-Za-z]+'

Change-Id: I43354842f1e0418fb292f2e8e0cb30f1229d1c67
Reviewed-on: https://gerrit.libreoffice.org/34864
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06 05:59:56 +00:00
Noel Grandin
59fbef6cf8 templatize HTMLEnumOption::GetEnum methods
And consequently fix bug in htmlfld.cxx in
the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating
the m_bUpdateDocStat fields by comparing the wrong enum variable.

Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0
Reviewed-on: https://gerrit.libreoffice.org/34857
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06 05:59:16 +00:00
Stephan Bergmann
6cb9e6dad7 Remove redundant 'inline' keyword
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03 20:55:50 +00:00
Andrea Gelmini
3ffc206a4b Fix typos
Change-Id: Ib25dadb25d8c2df1361de194f74cf3ddd459650d
Reviewed-on: https://gerrit.libreoffice.org/34783
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03 06:54:05 +00:00
Noel Grandin
60f6127854 don't need this STL hack anymore
Change-Id: Id0883060acf2ca73af5cce56e1cf9021c2fb121a
2017-03-02 08:39:18 +02:00
Jochen Nitschke
5ee57cabb4 no need to use smart pointers for DataFlavorExVector
DataFlavorExVector is a std::vector<..> typedef.
remove odd void pointer in BrowseBox.
return const references to keep getter const qualified.

Change-Id: Iafd529a46b7511941c1dffc86d2066fdc4f07e28
Reviewed-on: https://gerrit.libreoffice.org/34767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02 06:33:48 +00:00
Noel Grandin
198c41c4fe new loplugin unoany
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28 10:17:47 +00:00
Noel Grandin
6776fdc63b loplugin:unusedmethods
Change-Id: I5a72ee666e71b4c5c8f43d327aa7e8eb62d1e51b
Reviewed-on: https://gerrit.libreoffice.org/34537
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-23 06:19:06 +00:00
Noel Grandin
0649622956 loplugin:unusedmethods
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c
Reviewed-on: https://gerrit.libreoffice.org/34508
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21 10:07:37 +00:00
Stephan Bergmann
b7302c4870 loplugin:subtlezeroinit: svtools
Change-Id: I10383c62060022838b1e63383b2fce9de9bbfd0e
2017-02-21 07:34:58 +01:00
Noel Grandin
c868dc4927 remove unused enumerators from WindowType
Change-Id: I1e100302dd60ebbcdf187cf30befe0c767c6d6b8
Reviewed-on: https://gerrit.libreoffice.org/34474
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21 06:06:47 +00:00
Caolán McNamara
917d5b8b26 Resolves: tdf#97731 allow status bar to adapt to its own preferred size
Change-Id: I4390f61a21eef21371ce7399bf746e60234b8db8
2017-02-20 17:20:02 +00:00
Fakabbir Amin
9d8c206ee4 tdf#100726 Improved readability of OUString concatenations
Cleanup in filter, framework and svtools directory.

Change-Id: Icf4f04cff1207e58ce55ea3dc8c21b0635c3b6ec
Reviewed-on: https://gerrit.libreoffice.org/34298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-16 08:51:29 +00:00
Noel Grandin
e48f0084df remove unused AccessibilityChanged from SfxHintId enum
Change-Id: Ic2d413002466e92d38a7a918b3f7e04d3c9eebf2
2017-02-15 08:33:37 +02:00
Noel Grandin
e1c4dbdbe1 convert SvxIconChoiceCtrlTextMode to scoped enum
and drop unused DontKnow enumerator

Change-Id: Ida06ae702e45d489765f970bbbdab6d762293c6c
2017-02-15 08:33:37 +02:00
Noel Grandin
89c24a380a convert SvxIconChoiceCtrlPositionMode to scoped enum
and drop unused AutoAdjust enumerator

Change-Id: Ie900f89241947cb93a16f0223071846fecfef09c
2017-02-15 08:33:37 +02:00
Noel Grandin
2074acd6e3 remove unused Border from RulerIndentStyle enum
Change-Id: If8d5acdf48278adeb4974c46c8e777e8792ba743
2017-02-14 14:22:24 +02:00