7938 Commits

Author SHA1 Message Date
Tomaž Vajngerl
9009663deb tdf#83257 [API-CHANGE] Pivot chart implementation
This is a squashed commit of the pivot chart implementation.

Some of the changes:
- Add pivot chart specific (pivot table) data provider which
  provides the data from a pivot table to the associated chart.
- When inserting a chart and the cursor is in a pivot table,
  in that case insert a pivot chart
- Modify the pivot chart when the pivot table changes
- Collect and set the number format for the values
- isDataFromSpreadsheet check for the creation wizard
- In ChartView (and VLegend) check if the data provider is a
  pivot chart data provider and get the pivot table field names
  to create the buttons on the UI.
- Adds the functionallity to show a filter pop-up (from calc)
  when clicking on row / column / page field buttons.
- Remove (X)PopupRequest as we won't need it.
- Add ODF import/export for pivot charts:
  + Added loext:data-pilot-source attribute on chart:chart
    which is the internal name of the pivot table with which the
    pivot chart is associated with. If the element is present, then
    the it means the chart is a pivot chart, else it is a normal
    chart
  + Added service to create pivot chart data provider through UNO
  + Add new methods to XPivotChartDataProvider to create value and
    label data sequences separately from the data source, which is
    needed for pivot chart import
  + When importing defer setting the data provider until a later
    time when we know if we are creating a chart od a pivot chart
- Pivot chart ODF round-trip test
- Add table pivot chart supplier API:
  This adds the XTablePivotChartSupplier and related interfaces so
  we can access, create, delete pivot charts from UNO in a sheet
  document. With this we now distinguish between normal charts
  and pivot charts. This was mainly needed because we can't extend
  the "published" interfaces of TableChartSupplier.
- Added an extensive test, which uses the API to create a new
  pivot chart when there was none, and checks that the pivot chart
  updates when the pivot table updates.

Change-Id: Ia9ed96fd6b1d342e61c2f7f9fa33a5e03dda21af
Reviewed-on: https://gerrit.libreoffice.org/36023
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-04 13:39:29 +00:00
Noel Grandin
e63116602b loplugin:unusedmethods
Change-Id: I30f9b6e68a7aa73782c980749e34f8f8d40ae57b
Reviewed-on: https://gerrit.libreoffice.org/36047
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04 06:38:38 +00:00
Jens Carl
6b4a149a65 tdf#39468 Translate German comments
Translate German comments and terms in UnoControls/, editeng/, filter/,
odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/,
tools/, writerfilter/, and xmloff/.

Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1
Reviewed-on: https://gerrit.libreoffice.org/35992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03 19:25:49 +00:00
Caolán McNamara
2f33a8cd23 coverity#1403662 Mixing enum types
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947
Reviewed-on: https://gerrit.libreoffice.org/36020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-02 16:31:48 +00:00
Caolán McNamara
68273aaae4 coverity#1403657 Unchecked return value
and

coverity#1403656 Unchecked return value

Change-Id: I41660df2685b1a07c5ec8f363f6b9c4c581d7c83
2017-04-01 19:51:19 +01:00
Noel Grandin
9a165a8679 use actual UNO enums in xmloff
Change-Id: I585825ad3faf972acde548817187183029856971
Reviewed-on: https://gerrit.libreoffice.org/35914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31 06:59:51 +00:00
Miklos Vajna
a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-31 06:27:11 +00:00
Jochen Nitschke
da56de9ac4 remove type decorations on char literals
they are only needed where type deduction fails.
left them in defines for now.

Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30 12:21:40 +00:00
Thomas Beck
659cb84664 tdf#96505 Get rid of cargo cult "long" integer literals
Removed "long" integer literals where applicable in some files of xmloff module

Change-Id: I96f44c00583a95f8a0ae6acf25f439936433ac08
Reviewed-on: https://gerrit.libreoffice.org/35798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28 11:31:30 +00:00
Andrea Gelmini
74117f9597 Fix typos
Change-Id: I901ff35ad2e0aa43a421f0996865130514a819bc
Reviewed-on: https://gerrit.libreoffice.org/35663
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 13:10:53 +00:00
Noel Grandin
ed76d1d350 loplugins:redundantcast teach it about c-style typedef casts
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23 09:48:10 +00:00
Stephan Bergmann
e6297cf05d Use rtl::isAscii* instead of ctype.h is* with sal_Unicode arg
Change-Id: Ieb4bda18ea6ee8d957bb9b9f584e12eb24091513
2017-03-22 21:28:18 +01:00
Noel Grandin
7299481834 loplugin:redundantcast find redundant c-style enum casts
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349
Reviewed-on: https://gerrit.libreoffice.org/35467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22 06:47:35 +00:00
Mohammed Abdul Azeem
0a0f205775 tdf#105686 - fixed wrongly imported named expressions:
It is necessary to extract and set ODF version for fast
events also.
While debugging I found a couple of tokens which were
not in the list, and added them (not needed for bug fix).

Change-Id: I7aaab99688a067ee2fd2c9814deec1a359a758ab
Reviewed-on: https://gerrit.libreoffice.org/35410
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-21 11:36:06 +00:00
Mohammed Abdul Azeem
9f9e861c6d Old-to-new mapping of attributes is moved into a Module:
This should make it easy to reuse the mapping code wherever
necessary and restores the loading of writerperfect documents.

Change-Id: I505bffa47fe37270b0430d9ae5afec5072762b4c
Reviewed-on: https://gerrit.libreoffice.org/35263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
2017-03-21 09:24:32 +00:00
Andrea Gelmini
47a9523f3f Fix typos + some German translations
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253
Reviewed-on: https://gerrit.libreoffice.org/35406
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 10:05:45 +00:00
Rosemary Sebastian
109210e5b7 Revert "Revert "Implement export and import of author field in fixed format""
This reverts commit cae16645e17df6a1f87443c00b6abfd26dabd27f.

Change-Id: If5b85beb53a0925909d537023879a7d86fa011cf
Reviewed-on: https://gerrit.libreoffice.org/35391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-18 11:54:54 +00:00
Rosemary Sebastian
cae16645e1 Revert "Implement export and import of author field in fixed format"
This reverts commit 5de40734af30a8b897c6c5b7f681759e36a25557.

Change-Id: Ib09fb1dc54066cadcd9503c92140d78e7482ae6c
Reviewed-on: https://gerrit.libreoffice.org/35281
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-16 16:17:40 +00:00
Miklos Vajna
c3e9b8cce7 xmloff: fix Android -Werror=maybe-uninitialized
Change-Id: I2b62b8606ad3652dc6cecfbb201f30b9f15e33da
2017-03-14 17:01:57 +01:00
Noel Grandin
427678b9cf remove noise UUUU tags in comments
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00
Reviewed-on: https://gerrit.libreoffice.org/35161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14 08:23:53 +00:00
Caolán McNamara
e20d9867e2 Werror=maybe-uninitialized on arm toolchain
Change-Id: If728a1da99d9146d60d15b5273a7a89764b82d51
2017-03-13 15:51:18 +00:00
Noel Grandin
93985db341 fix android build
Change-Id: I960768ff98137a50da44348bffeec329295ea95f
2017-03-13 12:16:34 +02:00
Noel Grandin
7e9857c293 templatize SvXMLEnumMapEntry
in preparation for "scoped UNO enums".

This is a little hacky: In order to limit the scope of this change,
the templated SvXMLEnumMapEntry struct actually has a fixed size field,
and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various
places, to avoid carrying the type param around.

Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83
Reviewed-on: https://gerrit.libreoffice.org/34987
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13 09:02:22 +00:00
dennisroczek
8636e2462d fix typo: savety --> safety
Change-Id: I6fab05c05c8f79607b75429f32be0497b54b3cb7
Reviewed-on: https://gerrit.libreoffice.org/35059
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-11 07:49:05 +00:00
Rosemary Sebastian
5de40734af Implement export and import of author field in fixed format
Change-Id: I1975bfcdc8436f2b05e2fab2a4c9c09838330b30
Reviewed-on: https://gerrit.libreoffice.org/33520
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-10 04:47:48 +00:00
Julien Nabet
33ac4636c0 Typo: exportBindingAtributes->exportBindingAttributes
Change-Id: I8211918b90e096e65de2ce8efeac3bede47b42ec
Reviewed-on: https://gerrit.libreoffice.org/34876
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-04 06:25:01 +00:00
Stephan Bergmann
6cb9e6dad7 Remove redundant 'inline' keyword
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03 20:55:50 +00:00
Andrea Gelmini
d0f99b1b39 Fix typos
Change-Id: Ibc81246e615d7c68c93e01b84584e78a79bece16
Reviewed-on: https://gerrit.libreoffice.org/34779
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-02 10:40:27 +00:00
Noel Grandin
4730b23b1d use std::vector::insert when inserting multiple of the same thing
instead of looping

Change-Id: I7b8c1663e303449302e0b96dc5b483367c2a52ba
2017-03-02 11:28:37 +02:00
Julien Nabet
472f92421b xmloff: prefix member nElement of XMLTransformerBase
Change-Id: I83f62ccad47bc10c2a506a6b79a24e3367df5335
Reviewed-on: https://gerrit.libreoffice.org/34769
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-01 22:30:18 +00:00
Julien Nabet
08c49bf075 Typo: decaration->declaration
Change-Id: I743e7f41243ae54b1deece4743b248a002ecfdb8
Reviewed-on: https://gerrit.libreoffice.org/34768
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-01 22:09:10 +00:00
Noel Grandin
d49c0f3b30 expose the SvXMLEnumMapEntry arrays in getAnimationsEnumMap
preparatory change to making SvXMLEnumMapEntry a template class for the
"UNO scoped enum" change.

But I think its an improvement by itself, there is no need to initialise
these arrays on-demand, the compiler will do that at link time.

Change-Id: Ie582fbe628cc9d21a4f31229c85195aa09139516
Reviewed-on: https://gerrit.libreoffice.org/34737
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01 12:16:32 +00:00
Noel Grandin
121525db24 these arrays should be const
Change-Id: I808064abce15c4ec240d61e8168f0430ebf4c86c
Reviewed-on: https://gerrit.libreoffice.org/34722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01 06:31:40 +00:00
Noel Grandin
dd4ed25aae expose the SvXMLEnumMapEntry arrays in OEnumMapper
preparatory change to making SvXMLEnumMapEntry a template class for the
"UNO scoped enum" change.

But I think its an improvement by itself, there is no need to initialise
these arrays on-demand, the compiler will do that at link time.

Change-Id: I842c16b3ef44b9f5e1f0325b637d3f55f8bb5ebc
Reviewed-on: https://gerrit.libreoffice.org/34721
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01 06:31:08 +00:00
Noel Grandin
198c41c4fe new loplugin unoany
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28 10:17:47 +00:00
Stephan Bergmann
d9e1313144 loplugin:loopvartoosmall
Change-Id: If080ee083a7531cc744ac35fc4ebd24d037003dc
2017-02-26 21:51:40 +01:00
Noel Grandin
0649622956 loplugin:unusedmethods
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c
Reviewed-on: https://gerrit.libreoffice.org/34508
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21 10:07:37 +00:00
Stephan Bergmann
c6f21f90e1 loplugin:subtlezeroinit: xmloff
Change-Id: I1308f4ad4584ac7c657ab9fc2b747c4e3715337d
2017-02-21 07:34:55 +01:00
Tor Lillqvist
c72a91512c Use symbolic AUTOLAYOUT_* names
Change-Id: I76a23c99bf92f33ebea1e138ccb3e948dee5ab84
2017-02-21 00:14:14 +02:00
Tor Lillqvist
1b3aa39339 AutoLayout value 33 is "AUTOLAYOUT_4CLIPART" according to comments
Change-Id: I082dd08c1caf6f1585e3e16b441ba3b5a0d137f1
2017-02-21 00:14:14 +02:00
Tor Lillqvist
5afef8d531 s/AUTOLAYOUT_6CLIPART/AUTOLAYOUT_TITLE_6CONTENT/, and sort
Need to sort in this commit so that the AUTOLAYOUT_END keeps being one
more than the highest-valued enumerator.

Change-Id: I0db7c8ba069808e92589d5c4688632440007163b
2017-02-21 00:14:13 +02:00
Tor Lillqvist
1324b7f1ce s/AUTOLAYOUT_TITLE_VERTICAL_OUTLINE_CLIPART/AUTOLAYOUT_TITLE_2VTEXT
Change-Id: Ie20c4539b8b66b1e9b40015e6bc611d5bc12ddb4
2017-02-20 23:07:49 +02:00
Tor Lillqvist
56917ba7ca s/AUTOLAYOUT_TITLE_VERTICAL_OUTLINE/AUTOLAYOUT_TITLE_VCONTENT
Change-Id: I6186a2583dff2b142ceee1c4f2c7f0c972ec6c57
2017-02-20 22:49:48 +02:00
Tor Lillqvist
656af688ec s/AUTOLAYOUT_VERTICAL_TITLE_VERTICAL_OUTLINE/AUTOLAYOUT_VTITLE_VCONTENT
Change-Id: Ic423c5a84c887222e38ab411ed218987075f7ced
2017-02-20 22:44:58 +02:00
Tor Lillqvist
9d90993a28 s/(AUTOLAYOUT)_VERTICAL_TITLE_TEXT_CHART/\1_VTITLE_VCONTENT_OVER_VCONTENT
Change-Id: I996d4a0b01ce9cb78119cba3165b2716f09fd048
2017-02-20 22:39:00 +02:00
Tor Lillqvist
e819494edb s/AUTOLAYOUT_4OBJ/AUTOLAYOUT_TITLE_4CONTENT
Change-Id: I8acd349ec7d9424f817981719320f51ac58b9861
2017-02-20 22:34:09 +02:00
Tor Lillqvist
056bb6f4f0 s/AUTOLAYOUT_OBJOVERTEXT/AUTOLAYOUT_TITLE_CONTENT_OVER_CONTENT
Change-Id: Idf9771d3d58520a1a31cea45a6acca89347237f6
2017-02-20 22:00:30 +02:00
Tor Lillqvist
6c897c63f7 s/AUTOLAYOUT_2OBJOVERTEXT/AUTOLAYOUT_TITLE_2CONTENT_OVER_CONTENT
Change-Id: I9f421104773c8c84828cb0908f0f5e182538eead
2017-02-20 22:00:30 +02:00
Tor Lillqvist
97ee1af455 s/AUTOLAYOUT_2OBJTEXT/AUTOLAYOUT_TITLE_2CONTENT_CONTENT
Change-Id: I8ed1361b2103b35e277107bfda4c174f07d9de08
2017-02-20 22:00:30 +02:00
Tor Lillqvist
7b2c59a97d s/AUTOLAYOUT_TEXT2OBJ/AUTOLAYOUT_TITLE_CONTENT_2CONTENT
Change-Id: I514cf647863e51848ff51c26938e682ffeca7685
2017-02-20 22:00:30 +02:00