406095 Commits

Author SHA1 Message Date
Michael Stahl
ae013f9ce0 oox: -Werror=format
Change-Id: I9036335c812992946e3164e517cbe7296b98759b
2017-04-04 11:41:18 +02:00
Andras Timar
86b17cd32c typo fix
Change-Id: Ic8a62b0e241f740d3f1352fe48c8405570bfc61a
2017-04-04 11:39:22 +02:00
Caolán McNamara
29cf858a97 ofz: check anldPap sprm for valid ANLD payload len
Change-Id: Ie034e3b37e01c29cf19fe8ad78b1121f6eadecb2
Reviewed-on: https://gerrit.libreoffice.org/36053
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04 08:05:51 +00:00
dennisroczek
4f08bd30ec Adding other spec-files to README
Change-Id: If6e28474a234dc1ca01d927a2a6c1f1a51f430c7
Reviewed-on: https://gerrit.libreoffice.org/36044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-04 07:22:27 +00:00
Miklos Vajna
236ae9392f sw: indentation fixes
Nested namespaces were always declared in new lines in these files,
let's keep the consistency.

Change-Id: I1dcfdd2b1f54ec56b3554f3c0095513cec33e49c
2017-04-04 09:11:43 +02:00
Stephan Bergmann
d53398fe04 Fix build
Change-Id: Ic6644d03a7d6dd41422731d0b4015df831752087
2017-04-04 09:01:59 +02:00
Noel Grandin
e63116602b loplugin:unusedmethods
Change-Id: I30f9b6e68a7aa73782c980749e34f8f8d40ae57b
Reviewed-on: https://gerrit.libreoffice.org/36047
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04 06:38:38 +00:00
Noel Grandin
5676ced825 make UNO enums scoped for internal LO code
this modifies codemaker so that, for an UNO enum, we generate code
that effectively looks like:

   #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR
       enum class XXX {
           ONE = 1
       };
       constexpr auto ONE = XXX_ONE;
   #else
      ...the old normal way..
   #endif

which means that for LO internal code, the enums are scoped.

The "constexpr auto" trick acts like an alias so we don't have to
use scoped naming everywhere.

Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4
Reviewed-on: https://gerrit.libreoffice.org/34546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04 06:38:03 +00:00
Takeshi Abe
1a1d1a86e9 starmath: Simplify code parsing nospace
This also comes with its unit test.

Change-Id: I1478bf48c5522691978e3534c9c8a9c0ddfc1e59
Reviewed-on: https://gerrit.libreoffice.org/35985
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-04 01:24:31 +00:00
Jens Carl
646e52adf4 tdf#39468 Translate German comments
Translate German comments and terms in sc/source

Change-Id: I8d1fa7c2d07512376ad186c55a13322b6219237f
Reviewed-on: https://gerrit.libreoffice.org/36015
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-03 19:59:08 +00:00
Caolán McNamara
9aff1789e0 ofz#721 use vector::at to check index
Change-Id: I786b5d6fb10afe3ebb8482f999115fe72ffe2d4c
Reviewed-on: https://gerrit.libreoffice.org/34851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03 19:46:21 +00:00
Caolán McNamara
3feabd87ad ofz: check anlv text bounds
Change-Id: I6288aae2d439cde6a2b95c005a2090f73e21bb7a
2017-04-03 20:41:04 +01:00
Caolán McNamara
aec5912b13 ofz: avoid oom
Change-Id: Icbd4b98e8a0a4aff967bae22f3f59248ed40598a
Reviewed-on: https://gerrit.libreoffice.org/36049
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03 19:34:28 +00:00
Jens Carl
6b4a149a65 tdf#39468 Translate German comments
Translate German comments and terms in UnoControls/, editeng/, filter/,
odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/,
tools/, writerfilter/, and xmloff/.

Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1
Reviewed-on: https://gerrit.libreoffice.org/35992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03 19:25:49 +00:00
Julien Nabet
df039e89c5 Remove DBG_ASSERT since it's always wrong
Indeed EditHTMLParser constructor calls HTMLParser constructor,
the last one calls "SetSrcEncoding(RTL_TEXTENCODING_UTF8);"

Change-Id: If749674c3d4f2b9f9fccbf0b99f1e7d62fd0450d
Reviewed-on: https://gerrit.libreoffice.org/36011
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03 19:19:10 +00:00
Michael Stahl
282b3e8c4d sw: [loplugin:sallogareas]
Change-Id: I94c552e4b2ae95f57b0c667f6072664eab570042
2017-04-03 21:06:59 +02:00
Stephan Bergmann
5793364b83 More integer clean-up
...after dbaab58c1442e7f62ef0732376fe5a49840e9fd6 "loplugin:loopvartoosmall".
Looks like SwLayHelper::nIndex only needs to be initialized to a very large
value (so that 'nIndex < pImpl->size()' will be false), not USHRT_MAX exactly.

Change-Id: I209faa00894783c468db1440f5663ea9e8ad3e19
2017-04-03 17:46:58 +02:00
Miklos Vajna
a8caa0ef1c vcl: avoid divide by zero in PDFExtOutDevData::HasAdequateCompression()
My stub graphic import filter created a graphic with 0 data size, don't
crash on that.

Change-Id: Ie9b93fce1bcae04d555a0610f674603c6945a54a
Reviewed-on: https://gerrit.libreoffice.org/36048
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-04-03 15:36:20 +00:00
Caolán McNamara
8c52dca558 only convert used part of buffer
Change-Id: I133a02ae1cbdb4fb32f81db7214d27c66ccd0a8b
2017-04-03 16:05:20 +01:00
Caolán McNamara
9b3685789b don't check on every loop
Change-Id: I000a887925db63b5717cc0d062d9da623415f7cc
2017-04-03 16:05:20 +01:00
Stephan Bergmann
32dad6983f loplugin:unreffun
Change-Id: I7a4fe7240e43faaae3482a084b466fa87e67b6b8
2017-04-03 17:00:06 +02:00
Caolán McNamara
af16eb5a22 flush writer fontcache after TestImportDOC
to get around leak sanitizer

Change-Id: I45f0caefc14c35476e92887058031dddd92afb81
2017-04-03 15:43:38 +01:00
jan Iversen
605d3a2858 iOS update for Rectangle
Updated Rectangle to tools::Rectangle

Change-Id: I1577dffe8d51ac3a33bbc2e0771b338d5fdd0220
2017-04-03 16:40:48 +02:00
Caolán McNamara
e5b0183bd8 these are file urls, so don't need ucb
Change-Id: I25beaeab002db1de34be3b5f4a774bd15b71f5d3
Reviewed-on: https://gerrit.libreoffice.org/36045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03 13:37:25 +00:00
Stephan Bergmann
dbaab58c14 loplugin:loopvartoosmall
Change-Id: Ief96de6eb6f6276681130a6d16c767ab8ceaa3f1
2017-04-03 15:35:34 +02:00
Stephan Bergmann
cfdc46a4bc loplugin:sallogareas
Change-Id: Idd4f44b66e67d938a1ba2b9c7ff4be0b0009ff53
2017-04-03 15:30:02 +02:00
Michael Stahl
8a5374f2fd tdf#106237 sw: do some basic sanity checking on layout-cache
The bugdoc, with claimed generator AOO4.1.1 on Windows, contains
a bogus layout-cache:

debug:26706:1: nType P nIndex 29 2147483647
debug:26706:1: nType P nIndex 66 2147483647
debug:26706:1: nType P nIndex 105 2147483647
debug:26706:1: nType P nIndex 142 2147483647
debug:26706:1: nType P nIndex 178 2147483647
debug:26706:1: nType P nIndex 205 2147483647
debug:26706:1: nType P nIndex 229 2147483647
debug:26706:1: nType T nIndex 314 65535

Due to a loop-control this causes incorrect pagination if CalcLayout()
is called only once.

It should look like this:

debug:26765:1: nType T nIndex 382 65535
debug:26765:1: nType T nIndex 790 65535

In this case we can easily detect that the indexes and types in
the layout-cache are bogus by checking against the node types, so
do that in SwLayHelper::SwLayHelper().

Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb
2017-04-03 14:46:38 +02:00
Caolán McNamara
fb53319713 ofz: fix leak
Change-Id: I93a7b2f77713db5c51734263b78ffc69c899987b
2017-04-03 12:41:42 +01:00
jan Iversen
11a0863509 iOS update to allow iOS SDK 10.3
added 10.3 SDK to configure.ac

Change-Id: I2bd287cada37e595ee25a5a1bfc535daeeb247a9
2017-04-03 13:16:55 +02:00
Noel Grandin
0fe6f1a196 use actual UNO enums in vcl..xmlsecurity
Change-Id: Id862544f27ebcbe8363f93dc83192d0f0cddb5cc
Reviewed-on: https://gerrit.libreoffice.org/36041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 11:05:13 +00:00
Noel Grandin
d68927c7fd use actual UNO enums in test..vbahelper
Change-Id: I2e38462045efedc31903589a3fa4e6f62d74d8de
Reviewed-on: https://gerrit.libreoffice.org/36042
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 11:04:25 +00:00
Noel Grandin
5d0e485e82 use actual UNO enums in reportdesign..svtools
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203
Reviewed-on: https://gerrit.libreoffice.org/36043
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 09:40:19 +00:00
Caolán McNamara
ed6c5a4908 coverity#440972 Dereference before null check
Change-Id: If4a1da1859dbdf19a7084341003fd6c41700971f
Reviewed-on: https://gerrit.libreoffice.org/36040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03 09:39:48 +00:00
Caolán McNamara
6eabb8fc77 coverity#1403734 Mixing enum types
Change-Id: I46a9a85e7f70502f703ee9fb0f94abd83952d120
2017-04-03 10:39:02 +01:00
Caolán McNamara
aa434253d2 coverity#1403731 Explicit null dereferenced
Change-Id: I6025e6d4307aa8a6e4b6338d62bc597dace0ac9e
2017-04-03 10:18:44 +01:00
Caolán McNamara
f2b52c8597 coverity#1403736 Unintentional integer overflow
Change-Id: I3902dda8f7b420ea3f5e7e8c5d50a47b7e762918
2017-04-03 10:13:18 +01:00
Miklos Vajna
92fbd5a325 sw: prefix members of SwTokenWindow
Change-Id: Iab538d4e4943559dc09dc1e947217b0db697620f
Reviewed-on: https://gerrit.libreoffice.org/36039
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-04-03 07:59:27 +00:00
Oliver Specht
8533e21ecf tdf#106897: preset visited/unvisited character style in ListBox
Change-Id: I9bfa2b8a50340a6b09d8cc50e5313dc45a518472
Reviewed-on: https://gerrit.libreoffice.org/35973
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-03 07:36:17 +00:00
Miklos Vajna
40eca147d1 sw: indentation fixes
Change-Id: I81076414ee335f34bb687f93e89d65343d2f3c57
2017-04-03 09:20:07 +02:00
Jochen Nitschke
b7b2c95fbc remove hack for non DBG_UTIL builds
always use a 8bit enum for StackVar

correct StackVar types for opcode opSep and opClose in unit test
and test them.

Change-Id: I89fac97d791eb12667ce5218ff31e798c8711e10
Reviewed-on: https://gerrit.libreoffice.org/36000
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 06:33:51 +00:00
Arnaud Versini
d7869e5611 Avoid redundant inline warning in swcache
Change-Id: Ia30d9f406769cab219418d4624e8547a036c4f08
Reviewed-on: https://gerrit.libreoffice.org/36022
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 06:29:08 +00:00
Noel Grandin
4809096a1f use actual UNO enums in sw
Change-Id: If0f4a6532cc255f632d88d97e6b1a9e57462f5fc
Reviewed-on: https://gerrit.libreoffice.org/35969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 06:24:33 +00:00
Noel Grandin
fcad02149f use actual UNO enums in sc
Change-Id: I51dbe623178e3c463dc4c941f23edac04fbfe349
Reviewed-on: https://gerrit.libreoffice.org/35968
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03 06:22:40 +00:00
Caolán McNamara
74917d2378 split up doc testing for three major variants
Change-Id: Iac1b5cb1c209ba27d185c8a7ba1e59c663553d77
2017-04-02 22:48:55 +01:00
Caolán McNamara
6fd66ad940 we're either reading or writing, not both
Change-Id: I6b004c7f7957f3843d37063b182cac0cd07e5f44
2017-04-02 22:48:55 +01:00
Caolán McNamara
edf79cacbe SwapOutData url is always a file url
so can just use SvFileStream here and not go through ucb

Change-Id: I1d70a4e39977a178afaf7eeadb552f1bd7d9fd1a
Reviewed-on: https://gerrit.libreoffice.org/36024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-02 21:48:04 +00:00
Gabor Kelemen
d80b0c4d94 Updated core
Project: help  5469ccc6ecc354020edf0b7e7b8c1e4c0f074517

Fix one ahelp to work with multiple bookmarks

Change-Id: Ibfe212d879ad7ebc4d275e2818c8779064235634
Reviewed-on: https://gerrit.libreoffice.org/35952
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-04-02 21:01:54 +00:00
Gabor Kelemen
9c5fac2f2e Updated core
Project: help  cf89d14c283d391bc3441f9a5e4f0c915af76706

tdf#102930 Mail Merge Wizard: Drop obsolete Wizard help pages

The 6th, 7th, 8th pages of the wizard are now gone.
Usable content was moved to the new save/print/email dialogs
and to the toolbars help pages.

Change-Id: I911c86f0ab0e159ed3666e32c8d45582c23b1627
Reviewed-on: https://gerrit.libreoffice.org/35951
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-04-02 21:00:49 +00:00
Gabor Kelemen
02cf765edc Updated core
Project: help  20abdd0a447ec3a330326ccd84257a0af6ce6f95

tdf#102930 Mail Merge Wizard: Drop duplicated page

This is the same as the mm_newaddblo.xhp file

Change-Id: Iafa9297c54042ba10a7bfff41a5ac4de13ada25d
Reviewed-on: https://gerrit.libreoffice.org/35950
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-04-02 20:59:05 +00:00
Gabor Kelemen
ed92b1633f Updated core
Project: help  5bffaa7cecbcb102764ce195be2cb5fd03de4d6b

tdf#102930 Mail Merge Wizard: Standard Filter dialog ahelps

Appears from the Select Address List dialog, Filter button.
ahelps need to be the literal dot to work with multiple bookmarks

Change-Id: Id906881098601f49643e0298949d7bcbbd618d57
Reviewed-on: https://gerrit.libreoffice.org/35949
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-04-02 20:58:52 +00:00