...so recent LLVM 19 trunk libc++ in debug mode complained during CppunitTest_chart2_export2 about > ~/llvm/inst/bin/../include/c++/v1/__debug_utils/strict_weak_ordering_check.h:59: assertion __comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering at > 5 libsystem_c.dylib 0x0000000183279a40 abort + 180 > 6 libc++.1.0.dylib 0x00000001030f9d98 _ZNSt3__123__cxx_atomic_notify_oneEPVKv + 0 > 7 libchartcorelo.dylib 0x00000002f817f0ec _ZNSt3__135__check_strict_weak_ordering_sortedB8de190000INS_11__wrap_iterIPNS_6vectorIdNS_9allocatorIdEEEEEEN5chart12_GLOBAL__N_116lcl_LessXOfPointEEEvT_SB_RT0_ + 960 > 8 libchartcorelo.dylib 0x00000002f817e6cc _ZNSt3__118__stable_sort_implB8de190000INS_17_ClassicAlgPolicyENS_11__wrap_iterIPNS_6vectorIdNS_9allocatorIdEEEEEEN5chart12_GLOBAL__N_116lcl_LessXOfPointEEEvT0_SC_RT1_ + 268 > 9 libchartcorelo.dylib 0x00000002f8172a90 _ZNSt3__111stable_sortB8de190000INS_11__wrap_iterIPNS_6vectorIdNS_9allocatorIdEEEEEEN5chart12_GLOBAL__N_116lcl_LessXOfPointEEEvT_SB_T0_ + 68 > 10 libchartcorelo.dylib 0x00000002f8172820 _ZN5chart11VDataSeries15doSortByXValuesEv + 508 > 11 libchartcorelo.dylib 0x00000002f8064c44 _ZN5chart9AreaChart12createShapesEv + 1528 > 12 libchartcorelo.dylib 0x00000002f80f2ae0 _ZN5chart9ChartView28impl_createDiagramAndContentERKNS_18CreateShapeParam2DERKN3com3sun4star3awt4SizeE + 4440 > 13 libchartcorelo.dylib 0x00000002f80f77ac _ZN5chart9ChartView14createShapes2DERKN3com3sun4star3awt4SizeE + 2728 > 14 libchartcorelo.dylib 0x00000002f80f58ec _ZN5chart9ChartView12createShapesEv + 692 > 15 libchartcorelo.dylib 0x00000002f80f4598 _ZN5chart9ChartView15impl_updateViewEb + 288 But the introduced use of `std::strong_order(first[0], second[0]) < 0` then triggered a false > lo/core/chart2/source/view/main/VDataSeries.cxx:105:61: error: NullToMemberPointer ValueDependentIsNotNull ZeroLiteral -> nullptr [loplugin:nullptr] > 105 | return std::strong_order(first[0], second[0]) < 0; > | ^ so needed some hack in loplugin:nullptr. And old versions of libc++, still used at least on Android, do not have any implementations of std::strong_order. So detect those cases in configure.ac (checking for std::strong_order for double, which is what is actually being used in the code) and fall back to operator <=> for now, even if that will not provide a strict weak ordering and will thus continue to violate the requirements of std::sort. And then our venerable clang-format 5.0.0 would have broken the token `<=>` into `<= >`, so exclude include/o3tl/compare.hxx from its mis-treatment. Change-Id: I7a64a630eb5f560dce59f3ff9d51ca3d1adc70be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163075 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
319 lines
7.8 KiB
C++
319 lines
7.8 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
|
|
#include <clang/AST/DeclBase.h>
|
|
#include <clang/AST/Decl.h>
|
|
#include <clang/AST/Type.h>
|
|
#include <clang/Basic/OperatorKinds.h>
|
|
|
|
#include "compat.hxx"
|
|
|
|
namespace loplugin {
|
|
|
|
class ContextCheck;
|
|
class TerminalCheck;
|
|
|
|
namespace detail {
|
|
|
|
inline ContextCheck checkRecordDecl(
|
|
clang::Decl const * decl, clang::TagTypeKind tag, llvm::StringRef id);
|
|
|
|
}
|
|
|
|
class DeclCheck;
|
|
|
|
class TypeCheck {
|
|
public:
|
|
explicit TypeCheck(clang::QualType type): type_(type) {}
|
|
|
|
explicit TypeCheck(clang::Type const * type): type_(type, 0) {}
|
|
|
|
explicit TypeCheck(clang::TypeDecl const * decl): type_(decl->getTypeForDecl(), 0) {}
|
|
|
|
explicit operator bool() const { return !type_.isNull(); }
|
|
|
|
TypeCheck NonConst() const;
|
|
|
|
TypeCheck NonConstVolatile() const;
|
|
|
|
TypeCheck Const() const;
|
|
|
|
TypeCheck Volatile() const;
|
|
|
|
TypeCheck ConstVolatile() const;
|
|
|
|
TypeCheck ConstNonVolatile() const;
|
|
|
|
TerminalCheck Void() const;
|
|
|
|
TerminalCheck Char() const;
|
|
|
|
TerminalCheck AnyBoolean() const;
|
|
|
|
TypeCheck Pointer() const;
|
|
|
|
TypeCheck MemberPointerOf() const;
|
|
|
|
TerminalCheck Enum() const;
|
|
|
|
TypeCheck LvalueReference() const;
|
|
|
|
TypeCheck RvalueReference() const;
|
|
|
|
inline ContextCheck Class(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck Struct(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck ClassOrStruct(llvm::StringRef id) const;
|
|
|
|
TypeCheck Typedef() const;
|
|
|
|
inline ContextCheck Typedef(llvm::StringRef id) const;
|
|
|
|
DeclCheck TemplateSpecializationClass() const;
|
|
|
|
TypeCheck NotSubstTemplateTypeParmType() const;
|
|
|
|
private:
|
|
TypeCheck() = default;
|
|
|
|
clang::QualType const type_{};
|
|
};
|
|
|
|
class DeclCheck {
|
|
friend TypeCheck;
|
|
|
|
public:
|
|
explicit DeclCheck(clang::Decl const * decl): decl_(decl) {}
|
|
|
|
explicit operator bool() const { return decl_ != nullptr; }
|
|
|
|
inline ContextCheck Class(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck Struct(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck ClassOrStruct(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck Union(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck Function(llvm::StringRef id) const;
|
|
|
|
ContextCheck Operator(clang::OverloadedOperatorKind op) const;
|
|
|
|
inline ContextCheck Var(llvm::StringRef id) const;
|
|
|
|
ContextCheck MemberFunction() const;
|
|
|
|
private:
|
|
DeclCheck() = default;
|
|
|
|
clang::Decl const * const decl_ = nullptr;
|
|
};
|
|
|
|
class ContextCheck {
|
|
public:
|
|
explicit ContextCheck(clang::DeclContext const * context = nullptr):
|
|
context_(context) {}
|
|
|
|
explicit operator bool() const { return context_ != nullptr; }
|
|
|
|
TerminalCheck GlobalNamespace() const;
|
|
|
|
inline ContextCheck Namespace(llvm::StringRef id) const;
|
|
|
|
TerminalCheck StdNamespace() const;
|
|
|
|
TerminalCheck StdOrNestedNamespace() const;
|
|
|
|
ContextCheck AnonymousNamespace() const;
|
|
|
|
inline ContextCheck Class(llvm::StringRef id) const;
|
|
|
|
inline ContextCheck Struct(llvm::StringRef id) const;
|
|
|
|
explicit ContextCheck(const clang::NamespaceDecl * decl ) : context_( decl ) {}
|
|
|
|
private:
|
|
clang::DeclContext const * lookThroughLinkageSpec() const;
|
|
|
|
clang::DeclContext const * const context_;
|
|
};
|
|
|
|
class TerminalCheck {
|
|
public:
|
|
explicit operator bool() const { return satisfied_; }
|
|
|
|
private:
|
|
friend ContextCheck;
|
|
friend TypeCheck;
|
|
|
|
explicit TerminalCheck(bool satisfied): satisfied_(satisfied) {}
|
|
|
|
bool const satisfied_;
|
|
};
|
|
|
|
|
|
typedef std::function<bool(clang::Decl const *)> DeclChecker;
|
|
// Returns true if the class has a base matching the checker, or, when checkSelf is true, if the
|
|
// class itself matches.
|
|
bool isDerivedFrom(const clang::CXXRecordDecl *decl, DeclChecker base, bool checkSelf = true);
|
|
|
|
|
|
namespace detail {
|
|
|
|
ContextCheck checkRecordDecl(
|
|
clang::Decl const * decl, clang::TagTypeKind tag, llvm::StringRef id)
|
|
{
|
|
auto r = llvm::dyn_cast_or_null<clang::RecordDecl>(decl);
|
|
if (r != nullptr && r->getTagKind() == tag) {
|
|
auto const i = r->getIdentifier();
|
|
if (i != nullptr && i->getName() == id) {
|
|
return ContextCheck(r->getDeclContext());
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
}
|
|
|
|
ContextCheck TypeCheck::Class(llvm::StringRef id)
|
|
const
|
|
{
|
|
if (!type_.isNull()) {
|
|
auto const t = type_->getAs<clang::RecordType>();
|
|
if (t != nullptr) {
|
|
return detail::checkRecordDecl(t->getDecl(), compat::TagTypeKind::Class, id);
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
ContextCheck TypeCheck::Struct(llvm::StringRef id) const
|
|
{
|
|
if (!type_.isNull()) {
|
|
auto const t = type_->getAs<clang::RecordType>();
|
|
if (t != nullptr) {
|
|
return detail::checkRecordDecl(t->getDecl(), compat::TagTypeKind::Struct, id);
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
ContextCheck TypeCheck::ClassOrStruct(llvm::StringRef id) const
|
|
{
|
|
auto const c1 = Class(id);
|
|
if (c1) {
|
|
return c1;
|
|
}
|
|
return Struct(id);
|
|
}
|
|
|
|
ContextCheck TypeCheck::Typedef(llvm::StringRef id) const
|
|
{
|
|
if (!type_.isNull()) {
|
|
if (auto const t = type_->getAs<clang::TypedefType>()) {
|
|
auto const d = t->getDecl();
|
|
auto const i = d->getIdentifier();
|
|
assert(i != nullptr);
|
|
if (i->getName() == id) {
|
|
return ContextCheck(d->getDeclContext());
|
|
}
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
ContextCheck DeclCheck::Class(llvm::StringRef id) const
|
|
{
|
|
return detail::checkRecordDecl(decl_, compat::TagTypeKind::Class, id);
|
|
}
|
|
|
|
ContextCheck DeclCheck::Struct(llvm::StringRef id) const
|
|
{
|
|
return detail::checkRecordDecl(decl_, compat::TagTypeKind::Struct, id);
|
|
}
|
|
|
|
ContextCheck DeclCheck::ClassOrStruct(llvm::StringRef id) const
|
|
{
|
|
auto const c1 = Class(id);
|
|
if (c1) {
|
|
return c1;
|
|
}
|
|
return Struct(id);
|
|
}
|
|
|
|
ContextCheck DeclCheck::Union(llvm::StringRef id) const
|
|
{
|
|
return detail::checkRecordDecl(decl_, compat::TagTypeKind::Union, id);
|
|
}
|
|
|
|
ContextCheck DeclCheck::Function(llvm::StringRef id) const
|
|
{
|
|
auto f = llvm::dyn_cast_or_null<clang::FunctionDecl>(decl_);
|
|
if (f != nullptr) {
|
|
auto const i = f->getIdentifier();
|
|
if (i != nullptr && i->getName() == id) {
|
|
return ContextCheck(f->getDeclContext());
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
ContextCheck DeclCheck::Var(llvm::StringRef id) const
|
|
{
|
|
auto f = llvm::dyn_cast_or_null<clang::VarDecl>(decl_);
|
|
if (f != nullptr) {
|
|
auto const i = f->getIdentifier();
|
|
if (i != nullptr && i->getName() == id) {
|
|
return ContextCheck(f->getDeclContext());
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
ContextCheck ContextCheck::Namespace(llvm::StringRef id) const
|
|
{
|
|
if (context_) {
|
|
auto n = llvm::dyn_cast<clang::NamespaceDecl>(lookThroughLinkageSpec());
|
|
if (n != nullptr) {
|
|
auto const i = n->getIdentifier();
|
|
if (i != nullptr && i->getName() == id) {
|
|
return ContextCheck(n->getParent());
|
|
}
|
|
}
|
|
}
|
|
return ContextCheck();
|
|
}
|
|
|
|
ContextCheck ContextCheck::Class(llvm::StringRef id) const
|
|
{
|
|
return detail::checkRecordDecl(
|
|
llvm::dyn_cast_or_null<clang::Decl>(context_), compat::TagTypeKind::Class, id);
|
|
}
|
|
|
|
ContextCheck ContextCheck::Struct(llvm::StringRef id) const
|
|
{
|
|
return detail::checkRecordDecl(
|
|
llvm::dyn_cast_or_null<clang::Decl>(context_), compat::TagTypeKind::Struct, id);
|
|
}
|
|
|
|
bool isExtraWarnUnusedType(clang::QualType type);
|
|
|
|
bool isOkToRemoveArithmeticCast(
|
|
clang::ASTContext & context, clang::QualType t1, clang::QualType t2,
|
|
const clang::Expr* subExpr);
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|