adb08e892b
Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all. This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin. The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it. Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
69 lines
2.5 KiB
C++
69 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
|
|
#include "tutorial1.hxx"
|
|
|
|
/*
|
|
This is a compile check.
|
|
|
|
Checks all return statements and warns if they return literal false (i.e. 'return false').
|
|
*/
|
|
|
|
namespace loplugin
|
|
{
|
|
|
|
// Ctor, nothing special, pass the argument(s).
|
|
Tutorial1::Tutorial1( const InstantiationData& data )
|
|
: FilteringPlugin( data )
|
|
{
|
|
}
|
|
|
|
// Perform the actual action.
|
|
void Tutorial1::run()
|
|
{
|
|
// Traverse the whole AST of the translation unit (i.e. examine the whole source file).
|
|
// The Clang AST helper class will call VisitReturnStmt for every return statement.
|
|
TraverseDecl( compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
// This function is called for every return statement.
|
|
// Returning true means to continue with examining the AST, false means to stop (just always return true).
|
|
bool Tutorial1::VisitReturnStmt( const ReturnStmt* returnstmt )
|
|
{
|
|
// Helper function from the LO base plugin class, call at the very beginning to ignore sources
|
|
// that should not be processed (e.g. system headers).
|
|
if( ignoreLocation( returnstmt ))
|
|
return true;
|
|
// Get the expression in the return statement (see ReturnStmt API docs).
|
|
const Expr* expression = returnstmt->getRetValue();
|
|
if( expression == NULL )
|
|
return true; // plain 'return;' without expression
|
|
// Check if the expression is a bool literal (Clang uses dyn_cast<> instead of dynamic_cast<>).
|
|
if( const CXXBoolLiteralExpr* boolliteral = dyn_cast< CXXBoolLiteralExpr >( expression ))
|
|
{ // It is.
|
|
if( boolliteral->getValue() == false ) // Is it 'return false;' ? (See CXXBoolLiteralExpr API docs)
|
|
{ // Ok, warn, use LO plugin helper function.
|
|
report( DiagnosticsEngine::Warning, // It's just a warning.
|
|
"returning false", // the message
|
|
boolliteral->getLocStart()) // and the exact position where the message should point
|
|
<< returnstmt->getSourceRange(); // and the full return statement to highlight (optional)
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
// Register the plugin action with the LO plugin handling.
|
|
static Plugin::Registration< Tutorial1 > tutorial1( "tutorial1" );
|
|
|
|
} // namespace
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|