adb08e892b
Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all. This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin. The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it. Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
96 lines
3.2 KiB
C++
96 lines
3.2 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
|
|
#include "tutorial2.hxx"
|
|
|
|
/*
|
|
This is a compile check.
|
|
|
|
Warns about if statements with a comparison followed by literal return false:
|
|
if( a == 1 )
|
|
return false;
|
|
*/
|
|
|
|
namespace loplugin
|
|
{
|
|
|
|
Tutorial2::Tutorial2( const InstantiationData& data )
|
|
: FilteringPlugin( data )
|
|
{
|
|
}
|
|
|
|
void Tutorial2::run()
|
|
{
|
|
// The Clang AST helper class will call VisitIfStmt for every if statement.
|
|
TraverseDecl( compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
// This function is called for every if statement.
|
|
bool Tutorial2::VisitIfStmt( const IfStmt* ifstmt )
|
|
{
|
|
if( ignoreLocation( ifstmt ))
|
|
return true;
|
|
// Check if the condition of the if statement is a binary operator.
|
|
if( const BinaryOperator* oper = dyn_cast< BinaryOperator >( ifstmt->getCond()))
|
|
{
|
|
// And if it's operator==.
|
|
if( oper->getOpcode() == BO_EQ )
|
|
{
|
|
// Now check if the sub-statement is 'return false'.
|
|
const Stmt* warn = NULL; // The return statement (for the warning message).
|
|
// Check if the sub-statement is directly 'return false;'.
|
|
if( isReturnFalse( ifstmt->getThen()))
|
|
warn = ifstmt->getThen();
|
|
// Check if the sub-statement is '{ return false; }'
|
|
else if( const CompoundStmt* compound = dyn_cast< CompoundStmt >( ifstmt->getThen()))
|
|
{
|
|
if( compound->size() == 1 ) // one statement
|
|
if( isReturnFalse( *compound->body_begin())) // check the one sub-statement
|
|
warn = *compound->body_begin();
|
|
}
|
|
if( warn != NULL ) // there is a return statement to warn about.
|
|
{
|
|
report( DiagnosticsEngine::Warning,
|
|
"returning false after if with equality comparison",
|
|
cast< ReturnStmt >( warn )->getRetValue()->getLocStart()) // the 'false' in the return
|
|
<< warn->getSourceRange();
|
|
// Also add a note showing the if statement.
|
|
report( DiagnosticsEngine::Note,
|
|
"the if statement is here",
|
|
ifstmt->getLocStart());
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool Tutorial2::isReturnFalse( const Stmt* stmt )
|
|
{
|
|
// Is it return statement?
|
|
if( const ReturnStmt* returnstmt = dyn_cast< ReturnStmt >( stmt ))
|
|
{
|
|
// dyn_cast_or_null<> can also be passed NULL, unlike dyn_cast<>
|
|
if( const CXXBoolLiteralExpr* boolliteral = dyn_cast_or_null< CXXBoolLiteralExpr >( returnstmt->getRetValue()))
|
|
{
|
|
if( boolliteral->getValue() == false )
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
// Register the plugin action with the LO plugin handling.
|
|
static Plugin::Registration< Tutorial2 > tutorial2( "tutorial2" );
|
|
|
|
} // namespace
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|