9c3c6a6b66
(in preparation of extending loplugin:redundantcast to more reinterpret_cast scenarios, which would have caused a false positive here). Required a tweak to loplugin:fakebool (as the relevant reinterpret_cast to silence some occurrences is no longer seen "inline" now), and the heuristics of loplugin:unused no longer worked (also because of the now-hidden reinterpret_cast'ing), but adding a maybe_unused attribute looks better than tweaking that plugin's heuristics even further. Change-Id: Iead1a9b31983918cf8f3b0e6c727c0081437c6d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134504 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
51 lines
1.2 KiB
C++
51 lines
1.2 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <sal/config.h>
|
|
|
|
#include <sal/types.h>
|
|
|
|
namespace {
|
|
|
|
struct S {
|
|
sal_Bool b; // expected-error {{FieldDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
|
|
};
|
|
|
|
struct S2 {
|
|
sal_Bool & b_;
|
|
// The following should arguably not warn, but currently does (and does find cases that actually
|
|
// can be cleaned up; if it ever produces false warnings for cases that cannot, we need to fix
|
|
// it):
|
|
S2(sal_Bool & b): // expected-error {{ParmVarDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
|
|
b_(b) {}
|
|
};
|
|
|
|
}
|
|
|
|
struct S3 {
|
|
sal_Bool b_;
|
|
void f() { S2 s(b_); }
|
|
};
|
|
|
|
namespace {
|
|
|
|
struct S4 {
|
|
sal_Bool b;
|
|
};
|
|
|
|
}
|
|
|
|
void f() {
|
|
sal_Bool b;
|
|
(void) &b;
|
|
(void) &S4::b;
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|