5ba447bdcd
simplify dynamic_cast followed by static_cast Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279 Reviewed-on: https://gerrit.libreoffice.org/44460 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
35 lines
1.0 KiB
C++
35 lines
1.0 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
struct ClassA
|
|
{
|
|
virtual ~ClassA() {}
|
|
};
|
|
|
|
struct ClassB : public ClassA
|
|
{
|
|
void foo() {}
|
|
};
|
|
|
|
void f1(ClassA* p1)
|
|
{
|
|
if (dynamic_cast<ClassB*>(p1)) // expected-note {{if here [loplugin:simplifydynamiccast]}}
|
|
{
|
|
static_cast<ClassB*>(p1)
|
|
->foo(); // expected-error@-1 {{simplify, use var in if [loplugin:simplifydynamiccast]}}
|
|
}
|
|
if (dynamic_cast<ClassB*>(p1) != nullptr)
|
|
{ // expected-note@-1 {{if here [loplugin:simplifydynamiccast]}}
|
|
static_cast<ClassB*>(p1)
|
|
->foo(); // expected-error@-1 {{simplify, use var in if [loplugin:simplifydynamiccast]}}
|
|
}
|
|
};
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|