Files
libreoffice/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
Stephan Bergmann f853ec317f Extend loplugin:external to warn about classes
...following up on 314f15bff0 "Extend
loplugin:external to warn about enums".

Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:

  filter/source/svg/svgexport.cxx
  sc/source/filter/excel/xelink.cxx
  sc/source/filter/excel/xilink.cxx
  svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx

All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage.  (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)

For friend declarations using elaborate type specifiers, like

  class C1 {};
  class C2 { friend class C1; };

* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")

* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".

Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace.  But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".

Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.

And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.

And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is.  GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>)  The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.

Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-22 12:57:32 +01:00

508 lines
12 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <ucbhelper/contentidentifier.hxx>
#include <com/sun/star/sdbc/SQLException.hpp>
#include <com/sun/star/uno/Reference.h>
#include <com/sun/star/beans/PropertyAttribute.hpp>
#include <ucbhelper/resultsetmetadata.hxx>
#include <cppuhelper/queryinterface.hxx>
#include "resultsetbase.hxx"
using namespace chelp;
using namespace com::sun::star;
ResultSetBase::ResultSetBase( const uno::Reference< uno::XComponentContext >& rxContext,
const uno::Reference< ucb::XContentProvider >& xProvider,
const uno::Sequence< beans::Property >& seq )
: m_xContext( rxContext ),
m_xProvider( xProvider ),
m_nRow( -1 ),
m_nWasNull( true ),
m_sProperty( seq )
{
}
ResultSetBase::~ResultSetBase()
{
}
// XInterface
void SAL_CALL
ResultSetBase::acquire()
throw()
{
OWeakObject::acquire();
}
void SAL_CALL
ResultSetBase::release()
throw()
{
OWeakObject::release();
}
uno::Any SAL_CALL
ResultSetBase::queryInterface( const uno::Type& rType )
{
uno::Any aRet = cppu::queryInterface( rType,
static_cast< lang::XComponent* >(this),
static_cast< sdbc::XRow* >(this),
static_cast< sdbc::XResultSet* >(this),
static_cast< sdbc::XResultSetMetaDataSupplier* >(this),
static_cast< beans::XPropertySet* >(this),
static_cast< ucb::XContentAccess* >(this) );
return aRet.hasValue() ? aRet : OWeakObject::queryInterface( rType );
}
// XComponent
void SAL_CALL
ResultSetBase::addEventListener(
const uno::Reference< lang::XEventListener >& Listener )
{
osl::MutexGuard aGuard( m_aMutex );
if ( ! m_pDisposeEventListeners )
m_pDisposeEventListeners.reset(
new comphelper::OInterfaceContainerHelper2( m_aMutex ));
m_pDisposeEventListeners->addInterface( Listener );
}
void SAL_CALL
ResultSetBase::removeEventListener(
const uno::Reference< lang::XEventListener >& Listener )
{
osl::MutexGuard aGuard( m_aMutex );
if ( m_pDisposeEventListeners )
m_pDisposeEventListeners->removeInterface( Listener );
}
void SAL_CALL
ResultSetBase::dispose()
{
osl::MutexGuard aGuard( m_aMutex );
lang::EventObject aEvt;
aEvt.Source = static_cast< lang::XComponent * >( this );
if ( m_pDisposeEventListeners && m_pDisposeEventListeners->getLength() )
{
m_pDisposeEventListeners->disposeAndClear( aEvt );
}
if( m_pRowCountListeners && m_pRowCountListeners->getLength() )
{
m_pRowCountListeners->disposeAndClear( aEvt );
}
if( m_pIsFinalListeners && m_pIsFinalListeners->getLength() )
{
m_pIsFinalListeners->disposeAndClear( aEvt );
}
}
// XResultSet
sal_Bool SAL_CALL
ResultSetBase::next()
{
m_nRow++;
return sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size();
}
sal_Bool SAL_CALL
ResultSetBase::isBeforeFirst()
{
return m_nRow == -1;
}
sal_Bool SAL_CALL
ResultSetBase::isAfterLast()
{
return sal::static_int_cast<sal_uInt32>( m_nRow ) >= m_aItems.size(); // Cannot happen, if m_aFolder.isOpen()
}
sal_Bool SAL_CALL
ResultSetBase::isFirst()
{
return m_nRow == 0;
}
sal_Bool SAL_CALL
ResultSetBase::isLast()
{
if( sal::static_int_cast<sal_uInt32>( m_nRow ) == m_aItems.size() - 1 )
return true;
else
return false;
}
void SAL_CALL
ResultSetBase::beforeFirst()
{
m_nRow = -1;
}
void SAL_CALL
ResultSetBase::afterLast()
{
m_nRow = m_aItems.size();
}
sal_Bool SAL_CALL
ResultSetBase::first()
{
m_nRow = -1;
return next();
}
sal_Bool SAL_CALL
ResultSetBase::last()
{
m_nRow = m_aItems.size() - 1;
return true;
}
sal_Int32 SAL_CALL
ResultSetBase::getRow()
{
// Test, whether behind last row
if( -1 == m_nRow || sal::static_int_cast<sal_uInt32>( m_nRow ) >= m_aItems.size() )
return 0;
else
return m_nRow+1;
}
sal_Bool SAL_CALL ResultSetBase::absolute( sal_Int32 row )
{
if( row >= 0 )
m_nRow = row - 1;
else
{
last();
m_nRow += ( row + 1 );
if( m_nRow < -1 )
m_nRow = -1;
}
return 0<= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size();
}
sal_Bool SAL_CALL
ResultSetBase::relative( sal_Int32 row )
{
if( isAfterLast() || isBeforeFirst() )
throw sdbc::SQLException();
if( row > 0 )
while( row-- )
next();
else if( row < 0 )
while( row++ && m_nRow > -1 )
previous();
return 0 <= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size();
}
sal_Bool SAL_CALL
ResultSetBase::previous()
{
if( sal::static_int_cast<sal_uInt32>( m_nRow ) > m_aItems.size() )
m_nRow = m_aItems.size(); // Correct Handling of afterLast
if( 0 <= m_nRow ) -- m_nRow;
return 0 <= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size();
}
void SAL_CALL
ResultSetBase::refreshRow()
{
}
sal_Bool SAL_CALL
ResultSetBase::rowUpdated()
{
return false;
}
sal_Bool SAL_CALL
ResultSetBase::rowInserted()
{
return false;
}
sal_Bool SAL_CALL
ResultSetBase::rowDeleted()
{
return false;
}
uno::Reference< uno::XInterface > SAL_CALL
ResultSetBase::getStatement()
{
return uno::Reference< uno::XInterface >();
}
// XCloseable
void SAL_CALL
ResultSetBase::close()
{
}
OUString SAL_CALL
ResultSetBase::queryContentIdentifierString()
{
if( 0 <= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size() )
return m_aPath[m_nRow];
else
return OUString();
}
uno::Reference< ucb::XContentIdentifier > SAL_CALL
ResultSetBase::queryContentIdentifier()
{
if( 0 <= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size() )
{
OUString url = queryContentIdentifierString();
if( ! m_aIdents[m_nRow].is() && !url.isEmpty() )
m_aIdents[m_nRow].set( new ::ucbhelper::ContentIdentifier( url ) );
return m_aIdents[m_nRow];
}
return uno::Reference< ucb::XContentIdentifier >();
}
uno::Reference< ucb::XContent > SAL_CALL
ResultSetBase::queryContent()
{
if( 0 <= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size() )
return m_xProvider->queryContent( queryContentIdentifier() );
else
return uno::Reference< ucb::XContent >();
}
namespace {
class XPropertySetInfoImpl
: public cppu::OWeakObject,
public beans::XPropertySetInfo
{
public:
explicit XPropertySetInfoImpl( const uno::Sequence< beans::Property >& aSeq )
: m_aSeq( aSeq )
{
}
void SAL_CALL acquire()
throw() override
{
OWeakObject::acquire();
}
void SAL_CALL release()
throw() override
{
OWeakObject::release();
}
uno::Any SAL_CALL queryInterface( const uno::Type& rType ) override
{
uno::Any aRet = cppu::queryInterface( rType,
static_cast< beans::XPropertySetInfo* >(this) );
return aRet.hasValue() ? aRet : OWeakObject::queryInterface( rType );
}
uno::Sequence< beans::Property > SAL_CALL getProperties() override
{
return m_aSeq;
}
beans::Property SAL_CALL getPropertyByName( const OUString& aName ) override
{
auto pProp = std::find_if(m_aSeq.begin(), m_aSeq.end(),
[&aName](const beans::Property& rProp) { return aName == rProp.Name; });
if (pProp != m_aSeq.end())
return *pProp;
throw beans::UnknownPropertyException(aName);
}
sal_Bool SAL_CALL hasPropertyByName( const OUString& Name ) override
{
return std::any_of(m_aSeq.begin(), m_aSeq.end(),
[&Name](const beans::Property& rProp) { return Name == rProp.Name; });
}
private:
uno::Sequence< beans::Property > m_aSeq;
};
}
// XPropertySet
uno::Reference< beans::XPropertySetInfo > SAL_CALL
ResultSetBase::getPropertySetInfo()
{
uno::Sequence< beans::Property > seq(2);
seq[0].Name = "RowCount";
seq[0].Handle = -1;
seq[0].Type = cppu::UnoType<sal_Int32>::get();
seq[0].Attributes = beans::PropertyAttribute::READONLY;
seq[1].Name = "IsRowCountFinal";
seq[1].Handle = -1;
seq[1].Type = cppu::UnoType<sal_Bool>::get();
seq[1].Attributes = beans::PropertyAttribute::READONLY;
//t
return uno::Reference< beans::XPropertySetInfo > ( new XPropertySetInfoImpl( seq ) );
}
void SAL_CALL ResultSetBase::setPropertyValue(
const OUString& aPropertyName, const uno::Any& )
{
if( aPropertyName == "IsRowCountFinal" ||
aPropertyName == "RowCount" )
return;
throw beans::UnknownPropertyException(aPropertyName);
}
uno::Any SAL_CALL ResultSetBase::getPropertyValue(
const OUString& PropertyName )
{
if( PropertyName == "IsRowCountFinal" )
{
return uno::Any(true);
}
else if ( PropertyName == "RowCount" )
{
sal_Int32 count = m_aItems.size();
return uno::Any(count);
}
else
throw beans::UnknownPropertyException(PropertyName);
}
void SAL_CALL ResultSetBase::addPropertyChangeListener(
const OUString& aPropertyName,
const uno::Reference< beans::XPropertyChangeListener >& xListener )
{
if( aPropertyName == "IsRowCountFinal" )
{
osl::MutexGuard aGuard( m_aMutex );
if ( ! m_pIsFinalListeners )
m_pIsFinalListeners.reset(
new comphelper::OInterfaceContainerHelper2( m_aMutex ));
m_pIsFinalListeners->addInterface( xListener );
}
else if ( aPropertyName == "RowCount" )
{
osl::MutexGuard aGuard( m_aMutex );
if ( ! m_pRowCountListeners )
m_pRowCountListeners.reset(
new comphelper::OInterfaceContainerHelper2( m_aMutex ));
m_pRowCountListeners->addInterface( xListener );
}
else
throw beans::UnknownPropertyException(aPropertyName);
}
void SAL_CALL ResultSetBase::removePropertyChangeListener(
const OUString& aPropertyName,
const uno::Reference< beans::XPropertyChangeListener >& aListener )
{
if( aPropertyName == "IsRowCountFinal" &&
m_pIsFinalListeners )
{
osl::MutexGuard aGuard( m_aMutex );
m_pIsFinalListeners->removeInterface( aListener );
}
else if ( aPropertyName == "RowCount" &&
m_pRowCountListeners )
{
osl::MutexGuard aGuard( m_aMutex );
m_pRowCountListeners->removeInterface( aListener );
}
else
throw beans::UnknownPropertyException(aPropertyName);
}
void SAL_CALL ResultSetBase::addVetoableChangeListener(
const OUString&,
const uno::Reference< beans::XVetoableChangeListener >& )
{}
void SAL_CALL ResultSetBase::removeVetoableChangeListener(
const OUString&,
const uno::Reference< beans::XVetoableChangeListener >& )
{}
// XResultSetMetaDataSupplier
uno::Reference< sdbc::XResultSetMetaData > SAL_CALL
ResultSetBase::getMetaData()
{
::ucbhelper::ResultSetMetaData* p =
new ::ucbhelper::ResultSetMetaData( m_xContext, m_sProperty );
return uno::Reference< sdbc::XResultSetMetaData >( p );
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */