ad9498f8b8
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
78 lines
2.5 KiB
C++
78 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#ifndef INCLUDED_DBACCESS_SOURCE_UI_INC_OPENDOCCONTROLS_HXX
|
|
#define INCLUDED_DBACCESS_SOURCE_UI_INC_OPENDOCCONTROLS_HXX
|
|
|
|
#include <vcl/button.hxx>
|
|
#include <vcl/lstbox.hxx>
|
|
#include <rtl/ustring.hxx>
|
|
#include <map>
|
|
|
|
namespace dbaui
|
|
{
|
|
|
|
// OpenDocumentButton
|
|
/** a button which can be used to open a document
|
|
|
|
The text of the button is the same as for the "Open" command in the application
|
|
UI. Additionally, the icon for this command is also displayed on the button.
|
|
*/
|
|
class OpenDocumentButton : public PushButton
|
|
{
|
|
private:
|
|
OUString m_sModule;
|
|
|
|
public:
|
|
OpenDocumentButton( vcl::Window* _pParent, const sal_Char* _pAsciiModuleName );
|
|
|
|
protected:
|
|
void impl_init( const sal_Char* _pAsciiModuleName );
|
|
};
|
|
|
|
// OpenDocumentListBox
|
|
class OpenDocumentListBox : public ListBox
|
|
{
|
|
private:
|
|
typedef ::std::pair< OUString, OUString > StringPair;
|
|
typedef ::std::map< sal_uInt16, StringPair > MapIndexToStringPair;
|
|
|
|
MapIndexToStringPair m_aURLs;
|
|
|
|
public:
|
|
OpenDocumentListBox( vcl::Window* _pParent, const sal_Char* _pAsciiModuleName );
|
|
|
|
OUString GetSelectedDocumentURL() const;
|
|
OUString GetSelectedDocumentFilter() const;
|
|
|
|
protected:
|
|
virtual void RequestHelp( const HelpEvent& _rHEvt ) SAL_OVERRIDE;
|
|
|
|
StringPair impl_getDocumentAtIndex( sal_uInt16 _nListIndex, bool _bSystemNotation = false ) const;
|
|
|
|
private:
|
|
void impl_init( const sal_Char* _pAsciiModuleName );
|
|
};
|
|
|
|
} // namespace dbaui
|
|
|
|
#endif // INCLUDED_DBACCESS_SOURCE_UI_INC_OPENDOCCONTROLS_HXX
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|