91b4e45316
look for possibly bogus implicit conversions to bool when passing
(normally pointer) args to bool params.
this plugin comes in the wake of a couple of bugs caused by refactoring,
where some of the call sites were not currently updated.
Of the changes, the following are real bugs:
desktop/../dp_persmap.cxx
StartInputFieldDlg
in sw/../fldmgr.cxx
which occurred as a result of
commit 39d719a80d
Date: Tue May 3 11:39:37 2016 +0200
tdf#99529 sw: don't pop up input field dialog before inserting field
CSerializationURLEncoded::encode_and_append in
forms/../serialization_urlencoded.cxx
XclExpCFImpl::XclExpCFImpl
in sc/../xecontent.cxx
I have no idea how to properly fix this, just made a guess.
SwDocTest::test64kPageDescs
in sw/qa/core/uwriter.cxx
which looks like a simple copy/paste error.
Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441
Reviewed-on: https://gerrit.libreoffice.org/48291
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
33 lines
1008 B
C++
33 lines
1008 B
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <sal/types.h>
|
|
#include <com/sun/star/uno/Sequence.hxx>
|
|
|
|
#define FALSE 0
|
|
|
|
void func_ptr(int*);
|
|
void func_bool(bool); // expected-note {{method here [loplugin:pointerbool]}}
|
|
void func_salbool(sal_Bool);
|
|
|
|
void test1(int* p1)
|
|
{
|
|
func_ptr(p1);
|
|
func_bool(
|
|
p1); // expected-error {{possibly unwanted implicit conversion when calling bool param [loplugin:pointerbool]}}
|
|
// no warning expected
|
|
func_bool(FALSE);
|
|
func_salbool(sal_False);
|
|
func_salbool(sal_True);
|
|
css::uno::Sequence<sal_Bool> aSeq;
|
|
func_bool(aSeq[0]);
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|