Files
libreoffice/xmloff/source/core/attrlist.cxx
Noel Grandin 12a7a3d57d Fix crashtest fdo77855.odt
regression from commit
    commit 9814c1f2ed
    use fastparser in SvXMLPropertySetContext subclasses

and add some asserts to find the problems earlier.

Change-Id: Ief64f813f2ef7ec005f682713dadb1be47cbcd15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101998
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-03 15:33:36 +02:00

229 lines
6.5 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <vector>
#include <o3tl/safeint.hxx>
#include <osl/diagnose.h>
#include <xmloff/xmltoken.hxx>
#include <cppuhelper/implbase.hxx>
#include <xmloff/attrlist.hxx>
using namespace ::com::sun::star;
using namespace ::xmloff::token;
namespace {
struct SvXMLTagAttribute_Impl
{
SvXMLTagAttribute_Impl( const OUString &rName,
const OUString &rValue )
: sName(rName),
sValue(rValue)
{
}
OUString sName;
OUString sValue;
};
}
struct SvXMLAttributeList_Impl
{
SvXMLAttributeList_Impl()
{
// performance improvement during adding
vecAttribute.reserve(20);
}
::std::vector<struct SvXMLTagAttribute_Impl> vecAttribute;
typedef ::std::vector<struct SvXMLTagAttribute_Impl>::size_type size_type;
};
sal_Int16 SAL_CALL SvXMLAttributeList::getLength()
{
return sal::static_int_cast< sal_Int16 >(m_pImpl->vecAttribute.size());
}
SvXMLAttributeList::SvXMLAttributeList( const SvXMLAttributeList &r ) :
cppu::WeakImplHelper<css::xml::sax::XAttributeList, css::util::XCloneable, css::lang::XUnoTunnel>(r),
m_pImpl( new SvXMLAttributeList_Impl( *r.m_pImpl ) )
{
}
SvXMLAttributeList::SvXMLAttributeList( const uno::Reference<
xml::sax::XAttributeList> & rAttrList )
: m_pImpl( new SvXMLAttributeList_Impl),
sType( GetXMLToken(XML_CDATA) )
{
SvXMLAttributeList* pImpl =
comphelper::getUnoTunnelImplementation<SvXMLAttributeList>( rAttrList );
if( pImpl )
*m_pImpl = *(pImpl->m_pImpl);
else
AppendAttributeList( rAttrList );
}
OUString SAL_CALL SvXMLAttributeList::getNameByIndex(sal_Int16 i)
{
return ( o3tl::make_unsigned( i ) < m_pImpl->vecAttribute.size() ) ? m_pImpl->vecAttribute[i].sName : OUString();
}
OUString SAL_CALL SvXMLAttributeList::getTypeByIndex(sal_Int16)
{
return sType;
}
OUString SAL_CALL SvXMLAttributeList::getValueByIndex(sal_Int16 i)
{
return ( o3tl::make_unsigned( i ) < m_pImpl->vecAttribute.size() ) ? m_pImpl->vecAttribute[i].sValue : OUString();
}
OUString SAL_CALL SvXMLAttributeList::getTypeByName( const OUString& )
{
return sType;
}
OUString SAL_CALL SvXMLAttributeList::getValueByName(const OUString& sName)
{
auto ii = std::find_if(m_pImpl->vecAttribute.begin(), m_pImpl->vecAttribute.end(),
[&sName](struct SvXMLTagAttribute_Impl& rAttr) { return rAttr.sName == sName; });
if (ii != m_pImpl->vecAttribute.end())
return (*ii).sValue;
return OUString();
}
uno::Reference< css::util::XCloneable > SvXMLAttributeList::createClone()
{
uno::Reference< css::util::XCloneable > r = new SvXMLAttributeList( *this );
return r;
}
SvXMLAttributeList::SvXMLAttributeList()
: m_pImpl( new SvXMLAttributeList_Impl ),
sType( GetXMLToken(XML_CDATA) )
{
}
SvXMLAttributeList::~SvXMLAttributeList()
{
}
void SvXMLAttributeList::AddAttribute( const OUString &sName ,
const OUString &sValue )
{
assert( !sName.isEmpty() && "empty attribute name is invalid");
assert( std::count(sName.getStr(), sName.getStr() + sName.getLength(), u':') <= 1 && "too many colons");
m_pImpl->vecAttribute.emplace_back( sName , sValue );
}
void SvXMLAttributeList::Clear()
{
m_pImpl->vecAttribute.clear();
OSL_ASSERT( ! getLength() );
}
void SvXMLAttributeList::RemoveAttribute( const OUString& sName )
{
auto ii = std::find_if(m_pImpl->vecAttribute.begin(), m_pImpl->vecAttribute.end(),
[&sName](struct SvXMLTagAttribute_Impl& rAttr) { return rAttr.sName == sName; });
if (ii != m_pImpl->vecAttribute.end())
m_pImpl->vecAttribute.erase( ii );
}
void SvXMLAttributeList::AppendAttributeList( const uno::Reference< css::xml::sax::XAttributeList > &r )
{
OSL_ASSERT( r.is() );
sal_Int16 nMax = r->getLength();
SvXMLAttributeList_Impl::size_type nTotalSize =
m_pImpl->vecAttribute.size() + nMax;
m_pImpl->vecAttribute.reserve( nTotalSize );
for( sal_Int16 i = 0 ; i < nMax ; ++i ) {
OUString sName = r->getNameByIndex( i );
assert( !sName.isEmpty() && "empty attribute name is invalid");
assert( std::count(sName.getStr(), sName.getStr() + sName.getLength(), u':') <= 1 && "too many colons");
m_pImpl->vecAttribute.emplace_back(sName, r->getValueByIndex( i ));
}
OSL_ASSERT( nTotalSize == static_cast<SvXMLAttributeList_Impl::size_type>(getLength()));
}
void SvXMLAttributeList::SetValueByIndex( sal_Int16 i,
const OUString& rValue )
{
if( o3tl::make_unsigned( i )
< m_pImpl->vecAttribute.size() )
{
m_pImpl->vecAttribute[i].sValue = rValue;
}
}
void SvXMLAttributeList::RemoveAttributeByIndex( sal_Int16 i )
{
if( o3tl::make_unsigned( i )
< m_pImpl->vecAttribute.size() )
m_pImpl->vecAttribute.erase( m_pImpl->vecAttribute.begin() + i );
}
void SvXMLAttributeList::RenameAttributeByIndex( sal_Int16 i,
const OUString& rNewName )
{
if( o3tl::make_unsigned( i )
< m_pImpl->vecAttribute.size() )
{
m_pImpl->vecAttribute[i].sName = rNewName;
}
}
sal_Int16 SvXMLAttributeList::GetIndexByName( const OUString& rName ) const
{
auto ii = std::find_if(m_pImpl->vecAttribute.begin(), m_pImpl->vecAttribute.end(),
[&rName](struct SvXMLTagAttribute_Impl& rAttr) { return rAttr.sName == rName; });
if (ii != m_pImpl->vecAttribute.end())
return static_cast<sal_Int16>(std::distance(m_pImpl->vecAttribute.begin(), ii));
return -1;
}
// XUnoTunnel & co
UNO3_GETIMPLEMENTATION_IMPL(SvXMLAttributeList)
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */