Files
libreoffice/xmloff/source/core/ProgressBarHelper.cxx
Stephan Bergmann 8b8ef8d633 Remove the xmloff::token::ResetTokens race condition
...where multiple parallel calls to xmloff::token::ResetTokens or
xmloff::token::GetXMLToken can see dangling pOUString pointers.  There is no
point in releasing this (bounded) amount of memory referenced from global
aTokenList, anyway.

There is still a race when parallel calls to xmloff::token::GetXMLToken write to
a pOUString pointer in parallel, but that's more harmless, and maybe calls to
GetXMLToken are synchronized by Solar Mutex?  Calls to ResetTokens (e.g., via
URP remote release request -> ~ScXMLExport -> ~SvXMLExport) were definitely
/not/ synchronized via any mutex.

The xmloff::token::Inc/DecRescheduleCount functions are now pointless and have
been removed, too.

Change-Id: I85905d4de1f042ed5c9a37589f942910d8ef80fd
2013-10-31 12:45:04 +01:00

111 lines
3.3 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <xmloff/ProgressBarHelper.hxx>
#include <tools/debug.hxx>
#include <xmloff/xmltoken.hxx>
#include <stdlib.h>
using namespace ::com::sun::star;
static const sal_Int32 nDefaultProgressBarRange = 1000000;
ProgressBarHelper::ProgressBarHelper(const ::com::sun::star::uno::Reference < ::com::sun::star::task::XStatusIndicator>& xTempStatusIndicator,
const sal_Bool bTempStrict)
: xStatusIndicator(xTempStatusIndicator)
, nRange(nDefaultProgressBarRange)
, nReference(100)
, nValue(0)
, bStrict(bTempStrict)
, bRepeat(sal_True)
#ifdef DBG_UTIL
, bFailure(sal_False)
#endif
{
}
ProgressBarHelper::~ProgressBarHelper()
{
}
sal_Int32 ProgressBarHelper::ChangeReference(sal_Int32 nNewReference)
{
if((nNewReference > 0) && (nNewReference != nReference))
{
if (nReference)
{
double fPercent(nNewReference / nReference);
double fValue(nValue * fPercent);
#if OSL_DEBUG_LEVEL > 0
// workaround for toolchain bug on solaris/x86 Sun C++ 5.5
// just call some function here
(void) abs(nValue);
#endif
nValue = static_cast< sal_Int32 >(fValue);
nReference = nNewReference;
}
else
{
nReference = nNewReference;
nValue = 0;
}
}
return nValue;
}
void ProgressBarHelper::SetValue(sal_Int32 nTempValue)
{
if (xStatusIndicator.is() && (nReference > 0))
{
if ((nTempValue >= nValue) && (!bStrict || (bStrict && (nTempValue <= nReference))))
{
// #91317# no progress bar with values > 100%
if (nTempValue > nReference)
{
if (!bRepeat)
nValue = nReference;
else
{
xStatusIndicator->reset();
nValue = 0;
}
}
else
nValue = nTempValue;
double fValue(nValue);
double fNewValue ((fValue * nRange) / nReference);
xStatusIndicator->setValue((sal_Int32)fNewValue);
// #95181# disabled, because we want to call setValue very often to enable a good reschedule
}
#ifdef DBG_UTIL
else if (!bFailure)
{
OSL_FAIL("tried to set a wrong value on the progressbar");
bFailure = sal_True;
}
#endif
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */