2caee0fac8
This was a good idea from mike kaganski as a consequence of https://gerrit.libreoffice.org/55359 Unfortunately, clang/llvm is not yet up to the job of doing floating point evaluation, I get tons of crashes all over the evaluate infrastruction inside clang, so this will need to wait until clang's code matures. So park it in store for now Change-Id: I5ba4de8323e462b4fd4db301e4d116a81fd56ed3 Reviewed-on: https://gerrit.libreoffice.org/59254 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
70 lines
2.4 KiB
C++
70 lines
2.4 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
static const float PI = 3.4;
|
|
struct Class1
|
|
{
|
|
float getFloat() const { return 1.5; }
|
|
int getInt() const { return 1; }
|
|
static constexpr float PI = 3.4;
|
|
static constexpr float E() { return 3.4; }
|
|
};
|
|
|
|
void func1(Class1 const& class1)
|
|
{
|
|
if (1
|
|
== PI) // expected-error {{comparing integer to float constant, can never be true [loplugin:intvsfloat]}}
|
|
return;
|
|
if (1
|
|
== class1
|
|
.PI) // expected-error {{comparing integer to float constant, can never be true [loplugin:intvsfloat]}}
|
|
return;
|
|
if (true
|
|
== class1
|
|
.PI) // expected-error {{comparing integer to float constant, can never be true [loplugin:intvsfloat]}}
|
|
return;
|
|
if (1 == class1.getInt()) // no warning expected
|
|
return;
|
|
if (1
|
|
== class1
|
|
.E()) // expected-error {{comparing integer to float constant, can never be true [loplugin:intvsfloat]}}
|
|
return;
|
|
if (true
|
|
== class1
|
|
.E()) // expected-error {{comparing integer to float constant, can never be true [loplugin:intvsfloat]}}
|
|
return;
|
|
if (1 == class1.getFloat()) // no warning expected
|
|
return;
|
|
}
|
|
|
|
void func2(Class1 const& class1)
|
|
{
|
|
int i0
|
|
= PI; // expected-error {{assigning constant float value to int truncates data [loplugin:intvsfloat]}}
|
|
(void)i0;
|
|
int i1
|
|
= class1
|
|
.PI; // expected-error {{assigning constant float value to int truncates data [loplugin:intvsfloat]}}
|
|
(void)i1;
|
|
int i2
|
|
= class1
|
|
.E(); // expected-error {{assigning constant float value to int truncates data [loplugin:intvsfloat]}}
|
|
(void)i2;
|
|
int i3 = class1.getFloat(); // no warning expected
|
|
(void)i3;
|
|
int i4 = class1.getInt(); // no warning expected
|
|
(void)i4;
|
|
bool b1
|
|
= class1
|
|
.E(); // expected-error {{assigning constant float value to int truncates data [loplugin:intvsfloat]}}
|
|
(void)b1;
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|