ff002524c1
There are some problems here, this should fix one of them: the getFilename function returns "<stdin>" for spelling locations, because the input to clang is sort of preprocessed via -frewrite-includes if icecream is used and the file is built on a remote host (whereas it's apparently not preprocessed if the file is compiled locally by icecream). Using getPresumedLoc() uses the #line directives in the preprocessed input, which avoids the problem but is more expensive, so try to use it only when necessary. The getFileEntry(getMainFileID())->getName() pattern will also result in "<stdin>", but fortunately icecream passes -main-file-name, which oddly enough isn't used by the SourceManager's spelling locations, but is available separately via CodeGenOptions. This builds everything successfully with clang version 6.0.0: ICECC_PREFERRED_HOST=myremote make check gb_SUPPRESS_TESTS=t Change-Id: Ic121511683e5302d7b9d85186c8b9c4a5443fa1b Reviewed-on: https://gerrit.libreoffice.org/54993 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
92 lines
2.7 KiB
C++
92 lines
2.7 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <memory>
|
|
#include <cassert>
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
#include <set>
|
|
#include "plugin.hxx"
|
|
|
|
/**
|
|
Find calls to "delete x" where x is a field on an object.
|
|
Should rather be using std::unique_ptr
|
|
*/
|
|
|
|
namespace {
|
|
|
|
class AutoMem:
|
|
public RecursiveASTVisitor<AutoMem>, public loplugin::Plugin
|
|
{
|
|
public:
|
|
explicit AutoMem(loplugin::InstantiationData const & data): Plugin(data), mbInsideDestructor(false) {}
|
|
|
|
virtual void run() override
|
|
{
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool TraverseCXXDestructorDecl(CXXDestructorDecl* );
|
|
bool VisitCXXDeleteExpr(const CXXDeleteExpr* );
|
|
private:
|
|
bool mbInsideDestructor;
|
|
};
|
|
|
|
bool AutoMem::TraverseCXXDestructorDecl(CXXDestructorDecl* expr)
|
|
{
|
|
mbInsideDestructor = true;
|
|
bool ret = RecursiveASTVisitor::TraverseCXXDestructorDecl(expr);
|
|
mbInsideDestructor = false;
|
|
return ret;
|
|
}
|
|
|
|
bool AutoMem::VisitCXXDeleteExpr(const CXXDeleteExpr* expr)
|
|
{
|
|
if (ignoreLocation( expr ))
|
|
return true;
|
|
StringRef aFileName = getFileNameOfSpellingLoc(compiler.getSourceManager().getSpellingLoc(expr->getLocStart()));
|
|
if (loplugin::hasPathnamePrefix(aFileName, SRCDIR "/include/salhelper/")
|
|
|| loplugin::hasPathnamePrefix(aFileName, SRCDIR "/include/osl/")
|
|
|| loplugin::hasPathnamePrefix(aFileName, SRCDIR "/salhelper/")
|
|
|| loplugin::hasPathnamePrefix(aFileName, SRCDIR "/store/")
|
|
|| loplugin::hasPathnamePrefix(aFileName, SRCDIR "/sal/"))
|
|
return true;
|
|
|
|
if (mbInsideDestructor)
|
|
return true;
|
|
|
|
const ImplicitCastExpr* pCastExpr = dyn_cast<ImplicitCastExpr>(expr->getArgument());
|
|
if (!pCastExpr)
|
|
return true;
|
|
const MemberExpr* pMemberExpr = dyn_cast<MemberExpr>(pCastExpr->getSubExpr());
|
|
if (!pMemberExpr)
|
|
return true;
|
|
// ignore union games
|
|
const FieldDecl* pFieldDecl = dyn_cast<FieldDecl>(pMemberExpr->getMemberDecl());
|
|
if (!pFieldDecl)
|
|
return true;
|
|
TagDecl const * td = dyn_cast<TagDecl>(pFieldDecl->getDeclContext());
|
|
if (td->isUnion())
|
|
return true;
|
|
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"calling delete on object field, rather use std::unique_ptr or std::scoped_ptr",
|
|
expr->getLocStart())
|
|
<< expr->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration< AutoMem > X("automem", false);
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|