ff002524c1
There are some problems here, this should fix one of them: the getFilename function returns "<stdin>" for spelling locations, because the input to clang is sort of preprocessed via -frewrite-includes if icecream is used and the file is built on a remote host (whereas it's apparently not preprocessed if the file is compiled locally by icecream). Using getPresumedLoc() uses the #line directives in the preprocessed input, which avoids the problem but is more expensive, so try to use it only when necessary. The getFileEntry(getMainFileID())->getName() pattern will also result in "<stdin>", but fortunately icecream passes -main-file-name, which oddly enough isn't used by the SourceManager's spelling locations, but is available separately via CodeGenOptions. This builds everything successfully with clang version 6.0.0: ICECC_PREFERRED_HOST=myremote make check gb_SUPPRESS_TESTS=t Change-Id: Ic121511683e5302d7b9d85186c8b9c4a5443fa1b Reviewed-on: https://gerrit.libreoffice.org/54993 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
79 lines
2.6 KiB
C++
79 lines
2.6 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <string>
|
|
|
|
#include "plugin.hxx"
|
|
|
|
// Having an extern prototype for a method in a module and not actually declaring that method is dodgy.
|
|
//
|
|
|
|
namespace {
|
|
|
|
class ExternAndNotDefined:
|
|
public RecursiveASTVisitor<ExternAndNotDefined>, public loplugin::Plugin
|
|
{
|
|
public:
|
|
explicit ExternAndNotDefined(loplugin::InstantiationData const & data): Plugin(data) {}
|
|
|
|
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
|
|
|
|
bool VisitFunctionDecl(const FunctionDecl * decl);
|
|
};
|
|
|
|
bool ExternAndNotDefined::VisitFunctionDecl(const FunctionDecl * functionDecl) {
|
|
if (ignoreLocation(functionDecl)) {
|
|
return true;
|
|
}
|
|
if (functionDecl->isDefined() || functionDecl->isPure()
|
|
|| (functionDecl->getLinkageAndVisibility().getLinkage()
|
|
!= ExternalLinkage)) {
|
|
return true;
|
|
}
|
|
//TODO, filtering out anything template for now:
|
|
if (functionDecl->isDependentContext()) {
|
|
return true;
|
|
}
|
|
CXXRecordDecl const * r = dyn_cast<CXXRecordDecl>(functionDecl->getDeclContext());
|
|
if (r != nullptr && r->getTemplateSpecializationKind() != TSK_Undeclared) {
|
|
return true;
|
|
}
|
|
// this is the bison/flex C API, it has to be defined this way
|
|
std::string functionName = functionDecl->getNameAsString();
|
|
if (functionName == "yyerror" || functionName == "YYWarning" || functionName == "yyparse" || functionName == "yylex") {
|
|
return true;
|
|
}
|
|
// see vcl/unx/gtk/app/gtksys.cxx, typename conflicts prevent using the right include
|
|
if (functionName == "gdk_x11_screen_get_screen_number") {
|
|
return true;
|
|
}
|
|
if (!compiler.getSourceManager().isInMainFile(functionDecl->getLocation()))
|
|
{
|
|
return true;
|
|
}
|
|
StringRef fileName { getFileNameOfSpellingLoc(functionDecl->getLocation()) };
|
|
// the filters use some kind of dynamic loading stunt
|
|
if (loplugin::hasPathnamePrefix(fileName, SRCDIR "/filter/qa/")) {
|
|
return true;
|
|
}
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"extern prototype in main file without definition",
|
|
functionDecl->getLocation())
|
|
<< functionDecl->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
|
|
loplugin::Plugin::Registration< ExternAndNotDefined > X("externandnotdefined");
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|