Files
libreoffice/reportdesign/source/ui/inc/DefaultInspection.hxx
Stephan Bergmann 6f4f5677ac No need to keep these whitelisted functions decorated with SAL_CALL
The only effect SAL_CALL effectively has on LO-internal code is to change non-
static member functions from __thiscall to __cdecl in MSVC (where all other
functions are __cdecl by default, anyway).  (For 3rd-party code, it could be
argued that SAL_CALL is useful on function declarations in the URE stable
interface other than non-static member functions, too, in case 3rd-party code
uses a compiler switch to change the default calling convention to something
other than __cdecl.  But loplugin:salcall exempts the URE stable interface,
anyway.)

One could argue that SAL_CALL, even if today it effectively only affects non-
static member functions in MSVC, could be extended in the future to affect more
functions on more platforms.  However, the current code would already not
support that.  For example, 3af500580b
"loplugin:salcall fix functions" changed FrameControl_createInstance in
UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even
though its address (in ctl_component_getFacrory, in the same file) is passed to
cppuhelper::createSingleFactory as an argument of type
cppu::ComponentInstantiation, which is a pointer to SAL_CALL function.

Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6
Reviewed-on: https://gerrit.libreoffice.org/46436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-14 13:03:06 +01:00

100 lines
4.8 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#ifndef INCLUDED_REPORTDESIGN_SOURCE_UI_INC_DEFAULTINSPECTION_HXX
#define INCLUDED_REPORTDESIGN_SOURCE_UI_INC_DEFAULTINSPECTION_HXX
#include <com/sun/star/inspection/XObjectInspectorModel.hpp>
#include <com/sun/star/lang/XServiceInfo.hpp>
#include <com/sun/star/uno/XComponentContext.hpp>
#include <com/sun/star/lang/XInitialization.hpp>
#include <cppuhelper/implbase3.hxx>
#include <memory>
namespace rptui
{
class OPropertyInfoService;
//= DefaultComponentInspectorModel
typedef ::cppu::WeakAggImplHelper3 < css::inspection::XObjectInspectorModel
, css::lang::XServiceInfo
, css::lang::XInitialization
> DefaultComponentInspectorModel_Base;
class DefaultComponentInspectorModel final : public DefaultComponentInspectorModel_Base
{
private:
::osl::Mutex m_aMutex;
css::uno::Reference< css::uno::XComponentContext > m_xContext;
css::uno::Reference< css::inspection::XObjectInspectorModel > m_xComponent; /// delegatee
bool m_bConstructed;
bool m_bHasHelpSection;
bool m_bIsReadOnly;
sal_Int32 m_nMinHelpTextLines;
sal_Int32 m_nMaxHelpTextLines;
DefaultComponentInspectorModel(const DefaultComponentInspectorModel&) = delete;
DefaultComponentInspectorModel& operator=(const DefaultComponentInspectorModel&) = delete;
virtual ~DefaultComponentInspectorModel() override;
// XServiceInfo
virtual OUString SAL_CALL getImplementationName( ) override;
virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) override;
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames( ) override;
// XObjectInspectorModel
virtual css::uno::Sequence< css::uno::Any > SAL_CALL getHandlerFactories() override;
virtual sal_Bool SAL_CALL getHasHelpSection() override;
virtual ::sal_Int32 SAL_CALL getMinHelpTextLines() override;
virtual ::sal_Int32 SAL_CALL getMaxHelpTextLines() override;
virtual sal_Bool SAL_CALL getIsReadOnly() override;
virtual void SAL_CALL setIsReadOnly( sal_Bool _isreadonly ) override;
virtual css::uno::Sequence< css::inspection::PropertyCategoryDescriptor > SAL_CALL describeCategories( ) override;
virtual ::sal_Int32 SAL_CALL getPropertyOrderIndex( const OUString& PropertyName ) override;
// XInitialization
virtual void SAL_CALL initialize( const css::uno::Sequence< css::uno::Any >& aArguments ) override;
// Service constructors
void createWithHelpSection( sal_Int32 _nMinHelpTextLines, sal_Int32 _nMaxHelpTextLines );
public:
// XServiceInfo - static versions
/// @throws css::uno::RuntimeException
static OUString getImplementationName_Static( );
/// @throws css::uno::RuntimeException
static css::uno::Sequence< OUString > getSupportedServiceNames_static( );
static css::uno::Reference< css::uno::XInterface >
create(const css::uno::Reference< css::uno::XComponentContext >&);
DefaultComponentInspectorModel( const css::uno::Reference< css::uno::XComponentContext >& _rxContext);
};
} // namespace rptui
#endif // INCLUDED_REPORTDESIGN_SOURCE_UI_INC_DEFAULTINSPECTION_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */