206b5b2661
...warning about (for now only) functions and variables with external linkage
that likely don't need it.
The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
returns 1, both moving just the struct S2 into an nunnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
as well as moving just the function f overload into an unnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }
would each change the program to return 0 instead.
Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
74 lines
2.8 KiB
C++
74 lines
2.8 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#include <com/sun/star/embed/EmbedStates.hpp>
|
|
#include <com/sun/star/embed/WrongStateException.hpp>
|
|
#include <com/sun/star/lang/DisposedException.hpp>
|
|
|
|
#include <commonembobj.hxx>
|
|
#include "embedobj.hxx"
|
|
|
|
|
|
using namespace ::com::sun::star;
|
|
|
|
static bool RectanglesEqual( const awt::Rectangle& aRect1, const awt::Rectangle& aRect2 )
|
|
{
|
|
return ( aRect1.X == aRect2.X
|
|
&& aRect1.Y == aRect2.Y
|
|
&& aRect1.Width == aRect2.Width
|
|
&& aRect1.Height == aRect2.Height );
|
|
}
|
|
|
|
void SAL_CALL OCommonEmbeddedObject::setObjectRectangles( const awt::Rectangle& aPosRect,
|
|
const awt::Rectangle& aClipRect )
|
|
{
|
|
::osl::MutexGuard aGuard( m_aMutex );
|
|
if ( m_bDisposed )
|
|
throw lang::DisposedException(); // TODO
|
|
|
|
if ( m_nObjectState != embed::EmbedStates::INPLACE_ACTIVE
|
|
&& m_nObjectState != embed::EmbedStates::UI_ACTIVE )
|
|
throw embed::WrongStateException( "The object is not activated inplace!",
|
|
static_cast< ::cppu::OWeakObject* >(this) );
|
|
|
|
awt::Rectangle aNewRectToShow = GetRectangleInterception( aPosRect, aClipRect );
|
|
awt::Rectangle aOldRectToShow = GetRectangleInterception( m_aOwnRectangle, m_aClipRectangle );
|
|
|
|
// the clip rectangle changes view only in case interception is also changed
|
|
if ( !RectanglesEqual( m_aOwnRectangle, aPosRect )
|
|
|| ( !RectanglesEqual( m_aClipRectangle, aPosRect ) && !RectanglesEqual( aOldRectToShow, aNewRectToShow ) ) )
|
|
m_xDocHolder->PlaceFrame( aNewRectToShow );
|
|
|
|
m_aOwnRectangle = aPosRect;
|
|
m_aClipRectangle = aClipRect;
|
|
}
|
|
|
|
void SAL_CALL OCommonEmbeddedObject::enableModeless( sal_Bool /*bEnable*/ )
|
|
{
|
|
// TODO: notify model that it can not use modal dialogs
|
|
}
|
|
|
|
void SAL_CALL OCommonEmbeddedObject::translateAccelerators(
|
|
const uno::Sequence< awt::KeyEvent >& /*aKeys*/ )
|
|
{
|
|
// TODO: UI activation related
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|